From nobody Mon Feb 9 02:15:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92917EB64DA for ; Mon, 26 Jun 2023 17:12:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230363AbjFZRMo (ORCPT ); Mon, 26 Jun 2023 13:12:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229664AbjFZRMm (ORCPT ); Mon, 26 Jun 2023 13:12:42 -0400 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2AD9610C0 for ; Mon, 26 Jun 2023 10:12:39 -0700 (PDT) Received: from loongson.cn (unknown [10.20.42.43]) by gateway (Coremail) with SMTP id _____8DxvscGx5lkm4MCAA--.3793S3; Tue, 27 Jun 2023 01:12:38 +0800 (CST) Received: from openarena.loongson.cn (unknown [10.20.42.43]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxxswGx5lkYhgKAA--.21854S2; Tue, 27 Jun 2023 01:12:38 +0800 (CST) From: Sui Jingfeng To: Tomi Valkeinen , David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/omap: Checking the mapping returned by vmap() Date: Tue, 27 Jun 2023 01:12:38 +0800 Message-Id: <20230626171238.667533-1-suijingfeng@loongson.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: AQAAf8BxxswGx5lkYhgKAA--.21854S2 X-CM-SenderInfo: xvxlyxpqjiv03j6o00pqjv00gofq/ X-Coremail-Antispam: 1Uk129KBj93XoWxJr1fKrW3GFy8Kw4xurWrCrX_yoW8uFy5pF s0ya4Y9rW8tFW2grsrZFn8Za45Ga1IkFWfWrW8t34fKr4FyrW7ZF98AFWqyr97WrWUArsI gw4kKF1rZFn0kwcCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUyEb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ Jr0_Gr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwI xGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480 Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7 IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k2 6cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxV AFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU1EksDUUUUU== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Because vmap() function could fail. Also don't let omap_gem_vaddr() function signature (declaration) dangling there, as it will only get defined when CONFIG_DRM_FBDEV_EMULATION=3Dy. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 10 ++++++++-- drivers/gpu/drm/omapdrm/omap_gem.h | 3 +++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm= /omap_fbdev.c index b7ccce0704a3..2c88aa1008d8 100644 --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c @@ -197,6 +197,11 @@ static int omap_fbdev_create(struct drm_fb_helper *hel= per, drm_fb_helper_fill_info(fbi, helper, sizes); =20 fbi->screen_buffer =3D omap_gem_vaddr(bo); + if (!fbi->screen_buffer) { + ret =3D -ENOMEM; + goto err_release_fbi; + } + fbi->screen_size =3D bo->size; fbi->fix.smem_start =3D dma_addr; fbi->fix.smem_len =3D bo->size; @@ -210,14 +215,15 @@ static int omap_fbdev_create(struct drm_fb_helper *he= lper, fbi->fix.ywrapstep =3D 1; } =20 - DBG("par=3D%p, %dx%d", fbi->par, fbi->var.xres, fbi->var.yres); DBG("allocated %dx%d fb", fb->width, fb->height); =20 return 0; =20 -fail: +err_release_fbi: + drm_fb_helper_release_info(helper); =20 +fail: if (ret) { if (fb) drm_framebuffer_remove(fb); diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/o= map_gem.h index 4d4488939f6b..7e8c41b72aae 100644 --- a/drivers/gpu/drm/omapdrm/omap_gem.h +++ b/drivers/gpu/drm/omapdrm/omap_gem.h @@ -48,7 +48,10 @@ struct drm_gem_object *omap_gem_new_dmabuf(struct drm_de= vice *dev, size_t size, struct sg_table *sgt); int omap_gem_new_handle(struct drm_device *dev, struct drm_file *file, union omap_gem_size gsize, u32 flags, u32 *handle); + +#ifdef CONFIG_DRM_FBDEV_EMULATION void *omap_gem_vaddr(struct drm_gem_object *obj); +#endif =20 /* Dumb Buffers Interface */ int omap_gem_dumb_map_offset(struct drm_file *file, struct drm_device *dev, --=20 2.25.1