From nobody Sat Feb 7 21:08:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2DDBEB64D7 for ; Fri, 23 Jun 2023 10:17:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231243AbjFWKRa (ORCPT ); Fri, 23 Jun 2023 06:17:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231316AbjFWKRR (ORCPT ); Fri, 23 Jun 2023 06:17:17 -0400 Received: from out-32.mta0.migadu.com (out-32.mta0.migadu.com [91.218.175.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3699D172D for ; Fri, 23 Jun 2023 03:17:05 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1687514910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qr4AdEHTYoG685b8wdwNQJqh58lsMzRbl2ELqoqnYBI=; b=S70026q2IZpnkxGa9L2vVHlHbIqeZLtj7NDD/D9SQI7G7Tlyz5UxodTgl/a/1XqOL3vBdE 9pVN1uud4BRdZSfLq54XxFbC0yNm0/EzpuD5nJLxGT02xA9NVBCuJLpQzib+Nqn3qMuouD yRlg0UhlRSB//HARQF/0Ta571pGYlL4= From: Sui Jingfeng To: Lucas Stach , Russell King , Christian Gmeiner , David Airlie , Daniel Vetter Cc: etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn, Sui Jingfeng Subject: [PATCH v1 1/8] drm/etnaviv: Using the size_t variable to store the number of pages Date: Fri, 23 Jun 2023 18:08:15 +0800 Message-Id: <20230623100822.274706-2-sui.jingfeng@linux.dev> In-Reply-To: <20230623100822.274706-1-sui.jingfeng@linux.dev> References: <20230623100822.274706-1-sui.jingfeng@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Sui Jingfeng Because the etnaviv_gem_new_private() function receives the size_t argument for the number of pages. And the number of pages should be unsigned. Note that Most 32-bit architectures use "unsigned int" size_t, and all 64-bit architectures use "unsigned long" size_t. So, let's keep the argument and parameter consistent. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/= etnaviv/etnaviv_gem_prime.c index 3524b5811682..b003481adc2b 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c @@ -114,7 +114,8 @@ struct drm_gem_object *etnaviv_gem_prime_import_sg_tabl= e(struct drm_device *dev, { struct etnaviv_gem_object *etnaviv_obj; size_t size =3D PAGE_ALIGN(attach->dmabuf->size); - int ret, npages; + size_t npages =3D size / PAGE_SIZE; + int ret; =20 ret =3D etnaviv_gem_new_private(dev, size, ETNA_BO_WC, &etnaviv_gem_prime_ops, &etnaviv_obj); @@ -123,8 +124,6 @@ struct drm_gem_object *etnaviv_gem_prime_import_sg_tabl= e(struct drm_device *dev, =20 lockdep_set_class(&etnaviv_obj->lock, &etnaviv_prime_lock_class); =20 - npages =3D size / PAGE_SIZE; - etnaviv_obj->sgt =3D sgt; etnaviv_obj->pages =3D kvmalloc_array(npages, sizeof(struct page *), GFP_= KERNEL); if (!etnaviv_obj->pages) { --=20 2.25.1