From nobody Sun Feb 8 17:42:47 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FAEDEB64DC for ; Wed, 21 Jun 2023 16:20:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229600AbjFUQUV (ORCPT ); Wed, 21 Jun 2023 12:20:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbjFUQUP (ORCPT ); Wed, 21 Jun 2023 12:20:15 -0400 Received: from imap5.colo.codethink.co.uk (imap5.colo.codethink.co.uk [78.40.148.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBE7EE41 for ; Wed, 21 Jun 2023 09:20:09 -0700 (PDT) Received: from [167.98.27.226] (helo=rainbowdash) by imap5.colo.codethink.co.uk with esmtpsa (Exim 4.94.2 #2 (Debian)) id 1qC0Yw-00CSap-Fg; Wed, 21 Jun 2023 17:20:07 +0100 Received: from ben by rainbowdash with local (Exim 4.96) (envelope-from ) id 1qC0Yx-001z4X-0O; Wed, 21 Jun 2023 17:20:07 +0100 From: Ben Dooks To: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, alexandre.belloni@bootlin.com Cc: Ben Dooks Subject: [RFC 2/5] i3c: add error print to show device failing during populate bus Date: Wed, 21 Jun 2023 17:20:02 +0100 Message-Id: <20230621162005.473049-3-ben.dooks@codethink.co.uk> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230621162005.473049-1-ben.dooks@codethink.co.uk> References: <20230621162005.473049-1-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The of_populate_i3c_bus() does not produce much helpful output when a device fails to add, so addd an explicit dev_err() showing the device node that failed and the error code it failed with. This should make finding bad device-tree entries easier. Signed-off-by: Ben Dooks --- drivers/i3c/master.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 559fc2781a81..6316f3fc914a 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -2125,6 +2125,8 @@ static int of_populate_i3c_bus(struct i3c_master_cont= roller *master) for_each_available_child_of_node(i3cbus_np, node) { ret =3D of_i3c_master_add_dev(master, node); if (ret) { + dev_err(dev, "%pOF: failed to add device (%d)\n", + node, ret); of_node_put(node); return ret; } --=20 2.40.1