From nobody Sun Feb 8 14:30:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F59DEB64D7 for ; Wed, 21 Jun 2023 03:59:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229843AbjFUD71 (ORCPT ); Tue, 20 Jun 2023 23:59:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229709AbjFUD70 (ORCPT ); Tue, 20 Jun 2023 23:59:26 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57CE0F1 for ; Tue, 20 Jun 2023 20:59:24 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Qm8rg3Gg2z1FDhw; Wed, 21 Jun 2023 11:59:15 +0800 (CST) Received: from huawei.com (10.175.104.170) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 21 Jun 2023 11:59:21 +0800 From: Miaohe Lin To: , , , CC: , , , , , , , Subject: [PATCH] sched/numa: fix possible uncapped numa_scan_period Date: Wed, 21 Jun 2023 11:58:47 +0800 Message-ID: <20230621035847.3349899-1-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.170] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The unit of task_scan_max() is ms while ns is expected. This will lead to task_scan_max() being ineffective. Fixes: 137844759843 ("sched/numa: Stagger NUMA balancing scan periods for n= ew threads") Signed-off-by: Miaohe Lin --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 3cc06cfca350..5e90e9658528 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3175,7 +3175,7 @@ void init_numa_balancing(unsigned long clone_flags, s= truct task_struct *p) if (mm) { unsigned int delay; =20 - delay =3D min_t(unsigned int, task_scan_max(current), + delay =3D min_t(unsigned int, task_scan_max(current) * NSEC_PER_MSEC, current->numa_scan_period * mm_users * NSEC_PER_MSEC); delay +=3D 2 * TICK_NSEC; p->node_stamp =3D delay; --=20 2.27.0