From nobody Tue Dec 16 16:55:42 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EB7DEB64D7 for ; Tue, 20 Jun 2023 10:39:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232181AbjFTKjl (ORCPT ); Tue, 20 Jun 2023 06:39:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231962AbjFTKje (ORCPT ); Tue, 20 Jun 2023 06:39:34 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F667E41 for ; Tue, 20 Jun 2023 03:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=U7fCOQZbJkzRS/ SUBlBnZh9gq2QKuIUDy7rdPxvWssY=; b=Gd4lSC1t8xeXhR+F/xeSwHMULeoibe ox4jbcvK4a0GGV3dQcPvnDLoChC06Ynb6GxgJEMM0dnpyHhfQnVUjFx67Jt+1+qL DaOfzJqkGGrvO2dvO6j+t5yi2m4qZXDKusQBqaVzv5y/dstRP0mnYe1cuVyYaIrz Pdhdyurrs5TM4= Received: (qmail 601049 invoked from network); 20 Jun 2023 12:39:25 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 20 Jun 2023 12:39:25 +0200 X-UD-Smtp-Session: l3s3148p1@Eq3VQ43+qoxehhtC From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Johan Hovold , Wolfram Sang , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org Subject: [RFC PATCH v2 1/3] gnss: ubx: use new helper to remove open coded regulator handling Date: Tue, 20 Jun 2023 12:39:06 +0200 Message-Id: <20230620103909.37582-2-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230620103909.37582-1-wsa+renesas@sang-engineering.com> References: <20230620103909.37582-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" v_bckp shall always be enabled as long as the device exists. We now have a regulator helper for that, use it. Signed-off-by: Wolfram Sang --- Changes since RFC v1: * rebased because of patches dropped drivers/gnss/ubx.c | 26 ++++---------------------- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/gnss/ubx.c b/drivers/gnss/ubx.c index c951be202ca2..9b76b101ba5e 100644 --- a/drivers/gnss/ubx.c +++ b/drivers/gnss/ubx.c @@ -17,7 +17,6 @@ #include "serial.h" =20 struct ubx_data { - struct regulator *v_bckp; struct regulator *vcc; }; =20 @@ -87,30 +86,16 @@ static int ubx_probe(struct serdev_device *serdev) goto err_free_gserial; } =20 - data->v_bckp =3D devm_regulator_get_optional(&serdev->dev, "v-bckp"); - if (IS_ERR(data->v_bckp)) { - ret =3D PTR_ERR(data->v_bckp); - if (ret =3D=3D -ENODEV) - data->v_bckp =3D NULL; - else - goto err_free_gserial; - } - - if (data->v_bckp) { - ret =3D regulator_enable(data->v_bckp); - if (ret) - goto err_free_gserial; - } + ret =3D devm_regulator_get_enable_optional(&serdev->dev, "v-bckp"); + if (ret < 0 && ret !=3D -ENODEV) + goto err_free_gserial; =20 ret =3D gnss_serial_register(gserial); if (ret) - goto err_disable_v_bckp; + goto err_free_gserial; =20 return 0; =20 -err_disable_v_bckp: - if (data->v_bckp) - regulator_disable(data->v_bckp); err_free_gserial: gnss_serial_free(gserial); =20 @@ -120,11 +105,8 @@ static int ubx_probe(struct serdev_device *serdev) static void ubx_remove(struct serdev_device *serdev) { struct gnss_serial *gserial =3D serdev_device_get_drvdata(serdev); - struct ubx_data *data =3D gnss_serial_get_drvdata(gserial); =20 gnss_serial_deregister(gserial); - if (data->v_bckp) - regulator_disable(data->v_bckp); gnss_serial_free(gserial); } =20 --=20 2.30.2