From nobody Tue Dec 16 08:50:55 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EB7DEB64D7 for ; Tue, 20 Jun 2023 10:39:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232181AbjFTKjl (ORCPT ); Tue, 20 Jun 2023 06:39:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231962AbjFTKje (ORCPT ); Tue, 20 Jun 2023 06:39:34 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F667E41 for ; Tue, 20 Jun 2023 03:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=U7fCOQZbJkzRS/ SUBlBnZh9gq2QKuIUDy7rdPxvWssY=; b=Gd4lSC1t8xeXhR+F/xeSwHMULeoibe ox4jbcvK4a0GGV3dQcPvnDLoChC06Ynb6GxgJEMM0dnpyHhfQnVUjFx67Jt+1+qL DaOfzJqkGGrvO2dvO6j+t5yi2m4qZXDKusQBqaVzv5y/dstRP0mnYe1cuVyYaIrz Pdhdyurrs5TM4= Received: (qmail 601049 invoked from network); 20 Jun 2023 12:39:25 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 20 Jun 2023 12:39:25 +0200 X-UD-Smtp-Session: l3s3148p1@Eq3VQ43+qoxehhtC From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Johan Hovold , Wolfram Sang , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org Subject: [RFC PATCH v2 1/3] gnss: ubx: use new helper to remove open coded regulator handling Date: Tue, 20 Jun 2023 12:39:06 +0200 Message-Id: <20230620103909.37582-2-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230620103909.37582-1-wsa+renesas@sang-engineering.com> References: <20230620103909.37582-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" v_bckp shall always be enabled as long as the device exists. We now have a regulator helper for that, use it. Signed-off-by: Wolfram Sang --- Changes since RFC v1: * rebased because of patches dropped drivers/gnss/ubx.c | 26 ++++---------------------- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/gnss/ubx.c b/drivers/gnss/ubx.c index c951be202ca2..9b76b101ba5e 100644 --- a/drivers/gnss/ubx.c +++ b/drivers/gnss/ubx.c @@ -17,7 +17,6 @@ #include "serial.h" =20 struct ubx_data { - struct regulator *v_bckp; struct regulator *vcc; }; =20 @@ -87,30 +86,16 @@ static int ubx_probe(struct serdev_device *serdev) goto err_free_gserial; } =20 - data->v_bckp =3D devm_regulator_get_optional(&serdev->dev, "v-bckp"); - if (IS_ERR(data->v_bckp)) { - ret =3D PTR_ERR(data->v_bckp); - if (ret =3D=3D -ENODEV) - data->v_bckp =3D NULL; - else - goto err_free_gserial; - } - - if (data->v_bckp) { - ret =3D regulator_enable(data->v_bckp); - if (ret) - goto err_free_gserial; - } + ret =3D devm_regulator_get_enable_optional(&serdev->dev, "v-bckp"); + if (ret < 0 && ret !=3D -ENODEV) + goto err_free_gserial; =20 ret =3D gnss_serial_register(gserial); if (ret) - goto err_disable_v_bckp; + goto err_free_gserial; =20 return 0; =20 -err_disable_v_bckp: - if (data->v_bckp) - regulator_disable(data->v_bckp); err_free_gserial: gnss_serial_free(gserial); =20 @@ -120,11 +105,8 @@ static int ubx_probe(struct serdev_device *serdev) static void ubx_remove(struct serdev_device *serdev) { struct gnss_serial *gserial =3D serdev_device_get_drvdata(serdev); - struct ubx_data *data =3D gnss_serial_get_drvdata(gserial); =20 gnss_serial_deregister(gserial); - if (data->v_bckp) - regulator_disable(data->v_bckp); gnss_serial_free(gserial); } =20 --=20 2.30.2 From nobody Tue Dec 16 08:50:55 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FDEFEB64D7 for ; Tue, 20 Jun 2023 10:39:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232208AbjFTKjo (ORCPT ); Tue, 20 Jun 2023 06:39:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232177AbjFTKjf (ORCPT ); Tue, 20 Jun 2023 06:39:35 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EE8210F8 for ; Tue, 20 Jun 2023 03:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=2BsJbCMG4/ENDD xROROqsb+IvXX19wdVnpIz1CwK0nE=; b=OqV+R8q+gfa60VfPGLstKbBoyp3OCH nTHQUQOdqCslu/jTAqqE2Y/vwRAsIgjR+HEzqeUuWatCdK7+qHDasbS1YouNHLW4 9nQxkOTgWZCtbXzhvomN0mwxZk0bOLuh2WdGGtpFG8+i0bYPqKxi5XmwPLlJxmU3 Urxw8OFF7x1C8= Received: (qmail 601086 invoked from network); 20 Jun 2023 12:39:26 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 20 Jun 2023 12:39:26 +0200 X-UD-Smtp-Session: l3s3148p1@nQjfQ43+uoxehhtC From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Johan Hovold , Wolfram Sang , linux-kernel@vger.kernel.org Subject: [RFC PATCH v2 2/3] gnss: ubx: add support for the reset gpio Date: Tue, 20 Jun 2023 12:39:07 +0200 Message-Id: <20230620103909.37582-3-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230620103909.37582-1-wsa+renesas@sang-engineering.com> References: <20230620103909.37582-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Tested with a Renesas KingFisher board. Because my GNSS device is hooked up via UART and I2C simultaneously, I could verify functionality by opening/closing the GNSS device using UART and see if the corresponding I2C device was visible on the bus. Signed-off-by: Wolfram Sang --- Changes since RFC v1: * rebased because of patches dropped * bail out correctly when requesting GPIO fails (Thanks, Dan!) drivers/gnss/ubx.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gnss/ubx.c b/drivers/gnss/ubx.c index 9b76b101ba5e..cb0612100644 100644 --- a/drivers/gnss/ubx.c +++ b/drivers/gnss/ubx.c @@ -7,6 +7,7 @@ =20 #include #include +#include #include #include #include @@ -18,6 +19,7 @@ =20 struct ubx_data { struct regulator *vcc; + struct gpio_desc *reset_gpio; }; =20 static int ubx_set_active(struct gnss_serial *gserial) @@ -29,6 +31,8 @@ static int ubx_set_active(struct gnss_serial *gserial) if (ret) return ret; =20 + gpiod_set_value_cansleep(data->reset_gpio, 0); + return 0; } =20 @@ -41,6 +45,8 @@ static int ubx_set_standby(struct gnss_serial *gserial) if (ret) return ret; =20 + gpiod_set_value_cansleep(data->reset_gpio, 1); + return 0; } =20 @@ -90,6 +96,13 @@ static int ubx_probe(struct serdev_device *serdev) if (ret < 0 && ret !=3D -ENODEV) goto err_free_gserial; =20 + /* Start with reset asserted (GPIO must be active low!) */ + data->reset_gpio =3D devm_gpiod_get_optional(&serdev->dev, "reset", GPIOD= _OUT_HIGH); + if (IS_ERR(data->reset_gpio)) { + ret =3D PTR_ERR(data->reset_gpio); + goto err_free_gserial; + } + ret =3D gnss_serial_register(gserial); if (ret) goto err_free_gserial; --=20 2.30.2 From nobody Tue Dec 16 08:50:55 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 613C8EB64DB for ; Tue, 20 Jun 2023 10:40:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232291AbjFTKjy (ORCPT ); Tue, 20 Jun 2023 06:39:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232196AbjFTKjj (ORCPT ); Tue, 20 Jun 2023 06:39:39 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8D9C10D0 for ; Tue, 20 Jun 2023 03:39:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=tQR0dWwr8w4Ycm Bt80qqUYFnqdWmFqmB5wVjdVTNQGI=; b=aX0RyTv49uKNK1StgC86X7o4GVifF5 L1mkoGXFqymtcBtohUJjjWCnnlZPBNgNnsRLpzdc10oWI5GQ2cri41QRyBQPGjmP k01F1OCQs90sV/YH9oKq+J1R7LC2UYulzv/Lqnt6h6MzXnm9ikbax6IyCldyG7SA sRo+apN62cWow= Received: (qmail 601116 invoked from network); 20 Jun 2023 12:39:27 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 20 Jun 2023 12:39:27 +0200 X-UD-Smtp-Session: l3s3148p1@QoLpQ43+vIxehhtC From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Johan Hovold , Wolfram Sang , Geert Uytterhoeven , Magnus Damm , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v2 3/3] arm64: dts: renesas: ulcb-kf: add node for GPS Date: Tue, 20 Jun 2023 12:39:08 +0200 Message-Id: <20230620103909.37582-4-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230620103909.37582-1-wsa+renesas@sang-engineering.com> References: <20230620103909.37582-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Wolfram Sang Add the node for the GPS receiver and its VCC supply. Signed-off-by: Wolfram Sang --- Changes since RFC v1: * rebased because of patches dropped and refactored * added static vcc-suplly @Geert: Not sure if we need so many fixed 3v3 regulators. Most of the other ones more or less directly derive from d_3v3. Or do you prefer it this way? arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts= /renesas/ulcb-kf.dtsi index e62f5359f64b..dd1ffc31c874 100644 --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi @@ -39,6 +39,13 @@ accel_3v3: regulator-acc-3v3 { regulator-max-microvolt =3D <3300000>; }; =20 + d_3v3: regulator-d-3v3 { + compatible =3D "regulator-fixed"; + regulator-name =3D "d-3v3"; + regulator-min-microvolt =3D <3300000>; + regulator-max-microvolt =3D <3300000>; + }; + hdmi_1v8: regulator-hdmi-1v8 { compatible =3D "regulator-fixed"; regulator-name =3D "hdmi-1v8"; @@ -434,6 +441,13 @@ &scif1 { pinctrl-names =3D "default"; =20 status =3D "okay"; + + gnss { + compatible =3D "u-blox,neo-m8"; + reset-gpios =3D <&gpio_exp_75 6 GPIO_ACTIVE_LOW>; + vcc-supply =3D <&d_3v3>; + current-speed =3D <9600>; + }; }; =20 &sdhi3 { --=20 2.30.2