From nobody Sun Feb 8 12:19:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF2DBEB64D7 for ; Tue, 20 Jun 2023 09:59:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231312AbjFTJ7r (ORCPT ); Tue, 20 Jun 2023 05:59:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231346AbjFTJ7E (ORCPT ); Tue, 20 Jun 2023 05:59:04 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2106.outbound.protection.outlook.com [40.107.255.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5E672D72 for ; Tue, 20 Jun 2023 02:55:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IF07+5hZI1v6S0JtX3VtqA47jwkOtaQAvUH9dMwNcdWvHtHS6P+8RSIZtvDzkcHR172hqklJjqd265CjPRb1bV4XOiuAu7BIGsX41sGQGNLJ4z86ckrQ5q/P1POiGAi0dhjFO9Y5BxhyYRgJBrCFrQ6k7D+XB/YmPuRGOnXPKyarCRPzYwbQvZwKdNNiJMiCf0XX2CO359logNYvtmRc1E8YM+7KUQmz8xcNEdj2Ml+ZN6auwi7iBW8tQzg7tE2YSLgTeIBfP58WLLlmhGGS7vNRBtH7TH2649RYONtAu9iIOVIDxZWthOA7s6varrypDTeszmU0oXTe3sDE+75p3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hKg+8M7pawnqQaYZJKPH6cP1gXnNb0G9L1GTB/NIvWY=; b=ahrpl9yFHzxvB/3t63uFZJVIe7MF3xJlxUVBuGYWvidnRkFd4xTbpH3swfSqy65EJA+zJFBTuqaiLFalicxcqQz02fcEdIsYCsCfLnL4zX5BfNmfeRlAN5vxV/K3HlPsYeYFLT/tJGEnrpbK4qUz3lE9BmIpevNpZzneC7fxwWU/9+SgFwX9T2B2udx+pg8boOF0DnT0YzmiC1GU2ZGCqrX/IZPRDmbZ2rUs6DdQlCwR/RrpFG6NRRjCU1T7yDGN5EwJxbCuRYPBmBm7w/VLBVSaLuCphRyeTgcDtF9n5SFQRMWHawrMosSnSav0nmGcPn48oYqOTMo19W/oOwD4RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hKg+8M7pawnqQaYZJKPH6cP1gXnNb0G9L1GTB/NIvWY=; b=gxZHQrVjmM+GTk5xjGykJSfxMRiUfjcdSqAOVgUIsEWhTqE7pFuDbQDbUv4X75SMcc01c2NgF1VtGdwmkc3gIT5xwl6GRdoLYHdM8MRJACvvbw5ye5Abe9xCaPa5tFBNsgvyxZJfaOz/B/zq/MeczvmSSA2bIUslj1pJNzQMffZF/kml7IlZZ3GL/ezrMmmMAJscZep/Ej0IUPX6UtOM6ZhijgjzHhOhoBsuG1xeaZrh2B5Px+crSjrQoWM9RJSDtcQ0IPUJJoju9Hol0HP9FaIf16YIseA0PcpfPJQV8e4UebdMJkovHOFL9CIZI5FdrIW1Rngq1hb1UVzdtkJQ0A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEYPR06MB6249.apcprd06.prod.outlook.com (2603:1096:101:de::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.36; Tue, 20 Jun 2023 09:55:52 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%4]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 09:55:52 +0000 From: Yangtao Li To: Jaegeuk Kim , Chao Yu Cc: Yangtao Li , Qi Han , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH v2] f2fs: compress: don't force buffered io when in COMPR_MODE_USER mode Date: Tue, 20 Jun 2023 17:55:39 +0800 Message-Id: <20230620095540.64109-1-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SGXP274CA0014.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b8::26) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEYPR06MB6249:EE_ X-MS-Office365-Filtering-Correlation-Id: dabb48b6-75a1-41a5-cf5a-08db71748831 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tbgb6JHUwkNruxoJwxC52Xzx+AcDsdRWAW9G1qm/aGKNR7vIIfApdJe0HxIh9If7dqYeRFcKkDFZjIxfanLtmYPQEXk8fu9VJUo7BXvWxCrHrCdcL/veACK84KclTy752/AfvnhxJshLwcNrh1lF+Uv5ze10cmVf0TqkgWv2oqNwI7NkMKl5jMA1JEyQsedwSazzA5eiyphtlwRPtlVDV+lKontYsebK5d6NVSBz5tFiFfciu9+QbjIdPwMujXmU77/rqE/2L9W/AcoewgVLxE91dgcjCjMTDMrFqqab3Ljr0xWeUQK3LIVCgGofw6VFL0P4elqwxh7QJmHt1Rkqgmr3SpcRLflYuz7zqp2gMIwqWn8ytA7s4z+9/vytvKOPQhMuw997r2+H0Q4jrJZrLVZVqHVijQ9+Gdl9EUCxVHo47/5YluVgBmS/nebovul270+n3UBrkx116EF6L/ewnly2F6nWr2J6OTiMhHNTNF4BV05hxFLwBnXfid5mHa877hqPn4mwWmhDImZOQJgkOOKxSEa77Gwl4VP7u9frAKpyEpVwfGV7MQ/arx2MuWYluufh7rpHPRgrf58hOrYxQVUyKwXjUh0NSAS+XpEUZQmpgng7vOBBzXYsZYI8+hmZ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(376002)(366004)(346002)(451199021)(83380400001)(6486002)(54906003)(6666004)(38100700002)(316002)(38350700002)(52116002)(66476007)(8676002)(8936002)(2616005)(36756003)(6506007)(1076003)(86362001)(26005)(4326008)(6512007)(186003)(40140700001)(41300700001)(5660300002)(66946007)(110136005)(66556008)(478600001)(2906002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?31gKd5CCxz2aEixEaP/h7PP/HC7cQNOR9wDg1BbTBytARdWjgEHjqFkJgvP5?= =?us-ascii?Q?MZmHGhQkDwDYla0Az84GYbvCo7wJmd7IBqf/xG1shaNiuv51Rxmc+Qh+31y4?= =?us-ascii?Q?GkXq6IskLX0vWolzY7Zgbvar7aZjNKS5eT7z503n0z+ujtRK4if+P9vrE0vs?= =?us-ascii?Q?hPUcRHK9lyJmkLsb1evnNHWFuHkDEypY/GAnZy1tQ1Zd5Tv9gAXjaM/OYuyQ?= =?us-ascii?Q?xjkvHAFqsu/ATqH+vwu2YuL0KvienlSRdeptz6ohiR9EEKNbMoPAqprPVuFx?= =?us-ascii?Q?HmjZNKRtBRjtxbfwZZNensL7RV1yX8DEzBHnoLJe2Nwr/xfUap43PdnSCET5?= =?us-ascii?Q?bw7LOVdrzMsUul1KptWcdFPvOqmmDgXef6SGL5F4jfPfpxhjKoHmLbdBbjnL?= =?us-ascii?Q?iIqoqjjEnXW/4RU+09U8yf7/KBsIuHcHQl837v3Appg8VTvCCOy2W37bFkWZ?= =?us-ascii?Q?G0EO/h9FUCPqA8KrWUngxlHgQcCVEyuTCuAp/vBGEdMiPmKDw5PCpcu2zTId?= =?us-ascii?Q?oKxz7Gwz4yItmbkXoZjZ2LAkkgRoGysOt7i2bqLzGeT9dYywPDrmVbO2XDRe?= =?us-ascii?Q?DcbzzjK7eImwWRQYV6ayI7VtCYWhKZY/AM0gsxfVR+I5PW9ChCCs1TEBPZoa?= =?us-ascii?Q?hb5ntVUSyrSZ4BTOO38wbw9KBZdbm9iYlMsaeKVplXj+tZrODFNuZHfZolar?= =?us-ascii?Q?bAawWKLhX8fsOELFZzvKe7hNm70thOYLSgrcQOfpgiQzxZx0dT/ZRblTbGlX?= =?us-ascii?Q?+lI46UseN29yFD9lMjh9kVX529D40FDzTm5FUqc9DVs6TsYlaoFUAOPeRsAT?= =?us-ascii?Q?TwRuDpbo18skNnjaucO/waIajSHF5AAhMePws8DoI4+EQdw7W01JeIB88k3V?= =?us-ascii?Q?OrzzixVEtljClEgDF/DrMnsThBKpGt9xqLk4nrkVZun1NAquzV5KDz0g+Zp3?= =?us-ascii?Q?Wzt00FvisVTDSQtDxDY07WHGGywAIoo9E9OuaH1DSiyUWAgbxPX8ypxRMHOQ?= =?us-ascii?Q?2BIT/MhcpOLtxUm19PgfP1Ys6svGAd3GSfjzq1YYEFMykKCmkCDlMhotFbHo?= =?us-ascii?Q?B4PHxu/D9Tzrz2u86lzL5goFi0xg49GuUh11Z/YUDEF5bwBiFmTkiKm2TGlK?= =?us-ascii?Q?7PLcFdoMdjRJgM1eo9pM1M9BDD6b/n5X2Sff3NoOcIIsNa4gfCbMBeiDKwmA?= =?us-ascii?Q?2NDE4voYizvrgMpQrhiv6UuJ8tgXdpnsCUZewoZ22/dj7W2fyS+zJIzuuAYv?= =?us-ascii?Q?9Epcu+ib/Xd86zHgOGwwZWE+1BAgaFjLaxqTKYd/5QHYdJE+5BTYAARoij0p?= =?us-ascii?Q?GdqEqGo2r3IIisQvKllUcWcE9Q/81bPecLtVzjDhaqPlykKiW2iJh8LBRM2r?= =?us-ascii?Q?frWcz8XJ40/7aYGRvjKTz3g93vaXwYW35RlZbFNriqjcd4RKspRO+zV2zlEJ?= =?us-ascii?Q?VtyNAAMfhb5S9QxLM6/dBPCrj98dcPIekN1F8xHympus/Ag9ubXBj+XY4tGF?= =?us-ascii?Q?MG+//olpGOi2wdZEnDGNMO03E1VbTB+EIJDXVr/uu+gx9JSXL/XyCAU3Umlh?= =?us-ascii?Q?WIFK4Mv4hdel6lbkrSv3Cwto2MFpIwJVZMr8CeKE?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: dabb48b6-75a1-41a5-cf5a-08db71748831 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 09:55:51.9832 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BDuTPtBeH1UZLBCzfOCv3DAK0+rP/ZQwh1lRXj5jfxojLL2zx6Iu6C+PVUpdwmzewUGlIDannqpabx8meP5fgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6249 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" It is observed that when in user compression mode (compress_extension=3D*), even though the file is not compressed, the file is still forced to use buffer io, which makes the AndroBench sequential read and write drop significantly. In fact, when the file is not compressed, we don't need to force it to buffer io. | w/o patch | w/ patch | seq read (MB/s) | 1320.068 | 3696.154 | seq write (MB/s) | 617.996 | 2978.478 | Fixes: 4c8ff7095bef ("f2fs: support data compression") Signed-off-by: Qi Han Signed-off-by: Yangtao Li --- fs/f2fs/f2fs.h | 14 ++++++++++++++ fs/f2fs/file.c | 5 ++++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 3f5b161dd743..9e960f1a1117 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -3170,6 +3170,20 @@ static inline int f2fs_compressed_file(struct inode = *inode) is_inode_flag_set(inode, FI_COMPRESSED_FILE); } =20 +static inline bool f2fs_is_compressed_file(struct inode *inode) +{ + int compress_mode =3D F2FS_OPTION(F2FS_I_SB(inode)).compress_mode; + + if (compress_mode =3D=3D COMPR_MODE_FS) + return f2fs_compressed_file(inode); + else if (atomic_read(&F2FS_I(inode)->i_compr_blocks) || + is_inode_flag_set(inode, FI_COMPRESS_RELEASED) || + is_inode_flag_set(inode, FI_ENABLE_COMPRESS)) + return true; + + return false; +} + static inline bool f2fs_need_compress_data(struct inode *inode) { int compress_mode =3D F2FS_OPTION(F2FS_I_SB(inode)).compress_mode; diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index f45d05c13ae5..75c9c3327bbd 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -822,7 +822,7 @@ static bool f2fs_force_buffered_io(struct inode *inode,= int rw) return true; if (fsverity_active(inode)) return true; - if (f2fs_compressed_file(inode)) + if (f2fs_is_compressed_file(inode)) return true; =20 /* disallow direct IO if any of devices has unaligned blksize */ @@ -4146,6 +4146,9 @@ static int f2fs_ioc_compress_file(struct file *filp) goto out; } =20 + /* avoid race case between aio and ioc_compress_file */ + inode_dio_wait(inode); + ret =3D filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); if (ret) goto out; --=20 2.39.0