From nobody Mon Feb 9 14:14:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8AECEB64D7 for ; Tue, 20 Jun 2023 09:48:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232464AbjFTJsX (ORCPT ); Tue, 20 Jun 2023 05:48:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232402AbjFTJsB (ORCPT ); Tue, 20 Jun 2023 05:48:01 -0400 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5B401185 for ; Tue, 20 Jun 2023 02:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=fMpVZ gPH13LrQj2/yL5QuaQCk1eUSXIciYTrYInC9Vk=; b=OzXo/M9STVDoO1tVerLvg q0rQABHDcUa+9BuqHqqudo/he1OA5RA5OWn4bwvUgGoqnT8CPJlS/kTQXVBiS+Yv aWkv27fjVEUoBYSBWydonC6LWQyTNMel4fCCUnc7QrkHwW9JHHNNf8LJjhUvpqyX jXXw2pFQRpqFOsMR7Lre20= Received: from openarena.loongson.cn (unknown [114.242.206.180]) by zwqz-smtp-mta-g4-0 (Coremail) with SMTP id _____wAXg3CldZFkB8yiAQ--.11241S10; Tue, 20 Jun 2023 17:47:19 +0800 (CST) From: Sui Jingfeng <18949883232@163.com> To: Lucas Stach , Russell King , Christian Gmeiner , David Airlie , Daniel Vetter Cc: linux-kernel@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Sui Jingfeng , Philipp Zabel , Bjorn Helgaas Subject: [PATCH v10 08/11] drm/etnaviv: Add a dedicated function to create the virtual master Date: Tue, 20 Jun 2023 17:47:13 +0800 Message-Id: <20230620094716.2231414-9-18949883232@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230620094716.2231414-1-18949883232@163.com> References: <20230620094716.2231414-1-18949883232@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wAXg3CldZFkB8yiAQ--.11241S10 X-Coremail-Antispam: 1Uf129KBjvJXoW7Cw1UWFyxJw13tw4rtrW7XFb_yoW8tF15pF 43GFyYkry8uFyUKw48JF15AFW5Ga1S934Svr9rAwnY9ws8AryrXryrtF1kAFnxJFWrCa1Y qw1jyryxuF45ZrJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j9VycUUUUU= X-Originating-IP: [114.242.206.180] X-CM-SenderInfo: jprymkizyyjjits6il2tof0z/1tbiEwiU0WE17eMXfgAAst Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Sui Jingfeng After introducing the etnaviv_of_first_available_node() helper, the creation of the virtual master platform device can also be simplified. So, switch to etnaviv_create_virtual_master() function. Cc: Lucas Stach Cc: Christian Gmeiner Cc: Philipp Zabel Cc: Bjorn Helgaas Cc: Daniel Vetter Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 43 ++++++++++++++++----------- 1 file changed, 26 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnavi= v/etnaviv_drv.c index d8e788aa16cb..47b2cdbb53e2 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c @@ -767,10 +767,32 @@ static void etnaviv_destroy_platform_device(struct pl= atform_device **ppdev) *ppdev =3D NULL; } =20 +static int etnaviv_create_virtual_master(void) +{ + struct platform_device **master =3D &etnaviv_platform_device; + struct device_node *np; + + /* + * If the DT contains at least one available GPU device, instantiate + * the DRM platform device. + */ + np =3D etnaviv_of_first_available_node(); + if (np) { + int ret; + + of_node_put(np); + + ret =3D etnaviv_create_platform_device("etnaviv", master); + if (ret) + return ret; + } + + return 0; +} + static int __init etnaviv_init(void) { int ret; - struct device_node *np; =20 etnaviv_validate_init(); =20 @@ -786,22 +808,9 @@ static int __init etnaviv_init(void) if (ret !=3D 0) goto unregister_platform_driver; =20 - /* - * If the DT contains at least one available GPU device, instantiate - * the DRM platform device. - */ - for_each_compatible_node(np, NULL, "vivante,gc") { - if (!of_device_is_available(np)) - continue; - of_node_put(np); - - ret =3D etnaviv_create_platform_device("etnaviv", - &etnaviv_platform_device); - if (ret) - goto unregister_platform_driver; - - break; - } + ret =3D etnaviv_create_virtual_master(); + if (ret) + goto unregister_platform_driver; =20 return ret; =20 --=20 2.25.1