From nobody Mon Feb 9 08:36:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0C14EB64DB for ; Tue, 20 Jun 2023 18:55:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230095AbjFTSzO (ORCPT ); Tue, 20 Jun 2023 14:55:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230195AbjFTSzG (ORCPT ); Tue, 20 Jun 2023 14:55:06 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5594C172B for ; Tue, 20 Jun 2023 11:55:03 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-4f87592ecaeso3088667e87.0 for ; Tue, 20 Jun 2023 11:55:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687287301; x=1689879301; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=K2584mY2CIIT99nEUdLfXKaqA6hVAl1xKCUH5FIpuMY=; b=pA3az+vlsg1FbU4r0H7GRSrMO1K/6APbS4mEww46QipnUF30dtExLhz1gYYX/8F5Rl OpUamyM3sKBleOa6+du24TuSsJysMv89q4m7VrlT+OiStX+h5DvMpuCXU0nk16gLZINW cqRcjhA3kHi28mQwnGrMSRls9xYwJKupH0zgcKZh7lO2P5WReXe4BdW7daYnY+0DWX2t jBLbdLGbJIf+/92EErAvaazbezajMfty0lSg60A1M3b1EiuCiCax0Lxvzlj/vUH87cjs JqroPLqRlXSezbV02SYBCqETLfoT+qZbe60EL9p1mjezyF+wirizL0AoMsK9wzWQLJuK XfCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687287301; x=1689879301; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K2584mY2CIIT99nEUdLfXKaqA6hVAl1xKCUH5FIpuMY=; b=AglHK4b4bFGx0/DxtwycfWrf9CQcikEQqyGhg6oZY3rmdVH3rxOIOE/C2I/xarybSa ZkRLa8fw+sgPYO+4sQ6SOMdVlwr6sWSn9JEpZB/hWgg7Afn1bF0sMzUToXdig8GTHAEv sR9t/9mJhFuI7NHu5pxXqdduFPuL87TPfQBJ77cMo1mutSGECVz7dKuo2WkUSCbfvwBt ZsrEqNdDn2ahpelCq5fWMHdpHsIO4ZM8dxx5dIvfn1xCu8qthvDXaogYg5ZnHqpJp8uP 4fRl7ldoW86xCvPNcT3LYF8cFcDuEWppB5hVqjFKU1djfkYOTJWZZ9N25qwu++B4RfJB RFuQ== X-Gm-Message-State: AC+VfDwcup2yD6jbyjxbpKvwO8bO2oXqXBHgM1lMp7ouGInDrTEKkcZK LNrlc2dp7x2dnRQecOs/X/DZ7A== X-Google-Smtp-Source: ACHHUZ5YK3+DQ+fqf/GvNiXAWn4RR3/C7kipu6rh0J8dUFQPAI7CLjjpQy+DjfJSw5r/M8xXXzHp7g== X-Received: by 2002:a19:d619:0:b0:4f4:bbfc:3615 with SMTP id n25-20020a19d619000000b004f4bbfc3615mr7200331lfg.68.1687287301516; Tue, 20 Jun 2023 11:55:01 -0700 (PDT) Received: from [192.168.1.101] (abxj193.neoplus.adsl.tpnet.pl. [83.9.3.193]) by smtp.gmail.com with ESMTPSA id v1-20020ac25921000000b004f867f8d157sm463899lfi.124.2023.06.20.11.55.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 11:55:01 -0700 (PDT) From: Konrad Dybcio Date: Tue, 20 Jun 2023 20:54:58 +0200 Subject: [PATCH 1/3] clk: qcom: gcc-sc8280xp: Add missing GDSC flags MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230620-topic-sc8280_gccgdsc-v1-1-0fd91a942bda@linaro.org> References: <20230620-topic-sc8280_gccgdsc-v1-0-0fd91a942bda@linaro.org> In-Reply-To: <20230620-topic-sc8280_gccgdsc-v1-0-0fd91a942bda@linaro.org> To: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1687287298; l=3934; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=zD4bAJffraIfwpzANPrCFCADlOJ036wDsQU07qiY6ho=; b=QeHHi6DuDgq2P9ODBKrUwVusAD4mrYFTqdvimc+cpr1Hb+Wy74AoiQrrbeeaKDiAHakNRCQr0 fWI+tRowT3cCeLWbIHV9X7jtAfUXn/EPu5u9EeENzqFp+5Pqxg/4WKS X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All GDSCs were missing the flags that describe how they should be treated, namely: - HW_CTRL - whether the hardware control mode is enabled - RETAIN_FF_ENABLE - whether to enable retention registers Add them as appropriate, according to the data from downstream. Fixes: d65d005f9a6c ("clk: qcom: add sc8280xp GCC driver") Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sc8280xp.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280x= p.c index 04a99dbaa57e..80bc741ee75a 100644 --- a/drivers/clk/qcom/gcc-sc8280xp.c +++ b/drivers/clk/qcom/gcc-sc8280xp.c @@ -6760,7 +6760,7 @@ static struct gdsc pcie_0_tunnel_gdsc =3D { .name =3D "pcie_0_tunnel_gdsc", }, .pwrsts =3D PWRSTS_OFF_ON, - .flags =3D VOTABLE, + .flags =3D VOTABLE | HW_CTRL | RETAIN_FF_ENABLE, }; =20 static struct gdsc pcie_1_tunnel_gdsc =3D { @@ -6771,7 +6771,7 @@ static struct gdsc pcie_1_tunnel_gdsc =3D { .name =3D "pcie_1_tunnel_gdsc", }, .pwrsts =3D PWRSTS_OFF_ON, - .flags =3D VOTABLE, + .flags =3D VOTABLE | HW_CTRL | RETAIN_FF_ENABLE, }; =20 /* @@ -6786,7 +6786,7 @@ static struct gdsc pcie_2a_gdsc =3D { .name =3D "pcie_2a_gdsc", }, .pwrsts =3D PWRSTS_OFF_ON, - .flags =3D VOTABLE | ALWAYS_ON, + .flags =3D VOTABLE | HW_CTRL | RETAIN_FF_ENABLE | ALWAYS_ON, }; =20 static struct gdsc pcie_2b_gdsc =3D { @@ -6797,7 +6797,7 @@ static struct gdsc pcie_2b_gdsc =3D { .name =3D "pcie_2b_gdsc", }, .pwrsts =3D PWRSTS_OFF_ON, - .flags =3D VOTABLE | ALWAYS_ON, + .flags =3D VOTABLE | HW_CTRL | RETAIN_FF_ENABLE | ALWAYS_ON, }; =20 static struct gdsc pcie_3a_gdsc =3D { @@ -6808,7 +6808,7 @@ static struct gdsc pcie_3a_gdsc =3D { .name =3D "pcie_3a_gdsc", }, .pwrsts =3D PWRSTS_OFF_ON, - .flags =3D VOTABLE | ALWAYS_ON, + .flags =3D VOTABLE | HW_CTRL | RETAIN_FF_ENABLE | ALWAYS_ON, }; =20 static struct gdsc pcie_3b_gdsc =3D { @@ -6819,7 +6819,7 @@ static struct gdsc pcie_3b_gdsc =3D { .name =3D "pcie_3b_gdsc", }, .pwrsts =3D PWRSTS_OFF_ON, - .flags =3D VOTABLE | ALWAYS_ON, + .flags =3D VOTABLE | HW_CTRL | RETAIN_FF_ENABLE | ALWAYS_ON, }; =20 static struct gdsc pcie_4_gdsc =3D { @@ -6830,7 +6830,7 @@ static struct gdsc pcie_4_gdsc =3D { .name =3D "pcie_4_gdsc", }, .pwrsts =3D PWRSTS_OFF_ON, - .flags =3D VOTABLE | ALWAYS_ON, + .flags =3D VOTABLE | HW_CTRL | RETAIN_FF_ENABLE | ALWAYS_ON, }; =20 static struct gdsc ufs_card_gdsc =3D { @@ -6839,6 +6839,7 @@ static struct gdsc ufs_card_gdsc =3D { .name =3D "ufs_card_gdsc", }, .pwrsts =3D PWRSTS_OFF_ON, + .flags =3D RETAIN_FF_ENABLE, }; =20 static struct gdsc ufs_phy_gdsc =3D { @@ -6847,6 +6848,7 @@ static struct gdsc ufs_phy_gdsc =3D { .name =3D "ufs_phy_gdsc", }, .pwrsts =3D PWRSTS_OFF_ON, + .flags =3D RETAIN_FF_ENABLE, }; =20 static struct gdsc usb30_mp_gdsc =3D { @@ -6855,6 +6857,7 @@ static struct gdsc usb30_mp_gdsc =3D { .name =3D "usb30_mp_gdsc", }, .pwrsts =3D PWRSTS_RET_ON, + .flags =3D RETAIN_FF_ENABLE, }; =20 static struct gdsc usb30_prim_gdsc =3D { @@ -6863,6 +6866,7 @@ static struct gdsc usb30_prim_gdsc =3D { .name =3D "usb30_prim_gdsc", }, .pwrsts =3D PWRSTS_RET_ON, + .flags =3D RETAIN_FF_ENABLE, }; =20 static struct gdsc usb30_sec_gdsc =3D { @@ -6871,6 +6875,7 @@ static struct gdsc usb30_sec_gdsc =3D { .name =3D "usb30_sec_gdsc", }, .pwrsts =3D PWRSTS_RET_ON, + .flags =3D RETAIN_FF_ENABLE, }; =20 static struct gdsc emac_0_gdsc =3D { @@ -6879,6 +6884,7 @@ static struct gdsc emac_0_gdsc =3D { .name =3D "emac_0_gdsc", }, .pwrsts =3D PWRSTS_OFF_ON, + .flags =3D HW_CTRL | RETAIN_FF_ENABLE, }; =20 static struct gdsc emac_1_gdsc =3D { @@ -6887,6 +6893,7 @@ static struct gdsc emac_1_gdsc =3D { .name =3D "emac_1_gdsc", }, .pwrsts =3D PWRSTS_OFF_ON, + .flags =3D HW_CTRL | RETAIN_FF_ENABLE, }; =20 static struct clk_regmap *gcc_sc8280xp_clocks[] =3D { --=20 2.41.0 From nobody Mon Feb 9 08:36:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA75EB64D7 for ; Tue, 20 Jun 2023 18:55:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229791AbjFTSzT (ORCPT ); Tue, 20 Jun 2023 14:55:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230210AbjFTSzH (ORCPT ); Tue, 20 Jun 2023 14:55:07 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AF7C1731 for ; Tue, 20 Jun 2023 11:55:04 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4f954d7309fso1051107e87.1 for ; Tue, 20 Jun 2023 11:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687287302; x=1689879302; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xwVfz2bEaJCer+jeAEjthcK+T4pqpqU1JsGzvN+M+jU=; b=vVS7AWD2Ro7EqTvhyl/8jS19LvItmOsclhWMkd5u+dM+swadAAaDmHXkFtB9n7IxPS 2dyKtlvdyQv6fh0qHMV1KUn7+dOCyskxVlmyNcNfds69QW6/sxqSEY03Og1xmq5gOxnQ imymHWim2uhKXw2/EJVeNhhI+dKKJCPR45yxmWaYPPlTdv8U90yxsZbkc9132q9QXyqj m2833vbC5CMBGFkCCD+la29WYDcyJ3S2geeCKJElbTxeXcIGzQ2xLAj7wBwXEXmQWwHV 0UBVk27jUVw+7YdTXCWxWzNtsb7+irUWFoBKw+RSWAIgsfnmnDLQkSNUF9I44lXXP0td Q0xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687287302; x=1689879302; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xwVfz2bEaJCer+jeAEjthcK+T4pqpqU1JsGzvN+M+jU=; b=azNEVLOAFVRDUIW+jpG5MXJKV6+Lf+lU7T2TBjcGG4qwSv7vVvbW9NIkaQFmyzV47N iE5Y/JahtknyM82qlmUvTPy5nFTLrLc4I4ilL2wuM09clYqooolxQuSE9aatHkuNDy34 EmTXvL4yM/JLNIeYbb46nkFeIE3RSgrBAwCj9wOYmduMhl4jWl/tXcFF7eEspB9hmkqc 9EQiwV4C0VL3VwwQSd30NDwnqaiYtvaaddv75vXSMmJeduGRAp5Lh5pMcB/Nvgs2L6pU tsJF6aOLfo5ciYmbmuaAxHVdRqyUxEiVXyLbmq7K+TwgT0hgi+F8HMEd2Ah02oXaGqeH Ik+A== X-Gm-Message-State: AC+VfDxgKMHp9lH0XqELQfBkg3pF8NTL/chBhtLwESlGcitwElGItJIA obw+mZyub2GlttRJ6nD38aJ00Q== X-Google-Smtp-Source: ACHHUZ5BIwH1hl1qgEejGBa4wEZU9T8FPhSnCLOnEDOVAKiZEzGrwXlDJNcqolVjs/D6KGrm2nSFvw== X-Received: by 2002:ac2:4e0a:0:b0:4f6:56ca:36fc with SMTP id e10-20020ac24e0a000000b004f656ca36fcmr6774364lfr.6.1687287302737; Tue, 20 Jun 2023 11:55:02 -0700 (PDT) Received: from [192.168.1.101] (abxj193.neoplus.adsl.tpnet.pl. [83.9.3.193]) by smtp.gmail.com with ESMTPSA id v1-20020ac25921000000b004f867f8d157sm463899lfi.124.2023.06.20.11.55.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 11:55:02 -0700 (PDT) From: Konrad Dybcio Date: Tue, 20 Jun 2023 20:54:59 +0200 Subject: [PATCH 2/3] dt-bindings: clock: qcom,gcc-sc8280xp: Add missing GDSCs MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230620-topic-sc8280_gccgdsc-v1-2-0fd91a942bda@linaro.org> References: <20230620-topic-sc8280_gccgdsc-v1-0-0fd91a942bda@linaro.org> In-Reply-To: <20230620-topic-sc8280_gccgdsc-v1-0-0fd91a942bda@linaro.org> To: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1687287298; l=1221; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=b3fOscs1Mn/FZl6XBM8E/StqOKB/3kR+0hvtGTWE+Sc=; b=rNBqt6XmLf0P7ecxaLthk40wXEGKyTzaMwyMBAMhvtphgvrZ7hu6snLFeHJ99EMu726CTI6k0 3FgLI+QykNZCH3l5T7GwuSNgrdyjZ8qAsHUzpHkalPCHeOSinLp/ziq X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are 10 more GDSCs that we've not been caring about, and by extension (and perhaps even more importantly), not putting to sleep. Add them. Fixes: a66a82f2a55e ("dt-bindings: clock: Add Qualcomm SC8280XP GCC binding= s") Signed-off-by: Konrad Dybcio Acked-by: Rob Herring --- include/dt-bindings/clock/qcom,gcc-sc8280xp.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/include/dt-bindings/clock/qcom,gcc-sc8280xp.h b/include/dt-bin= dings/clock/qcom,gcc-sc8280xp.h index 721105ea4fad..845491591784 100644 --- a/include/dt-bindings/clock/qcom,gcc-sc8280xp.h +++ b/include/dt-bindings/clock/qcom,gcc-sc8280xp.h @@ -494,5 +494,15 @@ #define USB30_SEC_GDSC 11 #define EMAC_0_GDSC 12 #define EMAC_1_GDSC 13 +#define USB4_1_GDSC 14 +#define USB4_GDSC 15 +#define HLOS1_VOTE_MMNOC_MMU_TBU_HF0_GDSC 16 +#define HLOS1_VOTE_MMNOC_MMU_TBU_HF1_GDSC 17 +#define HLOS1_VOTE_MMNOC_MMU_TBU_SF0_GDSC 18 +#define HLOS1_VOTE_MMNOC_MMU_TBU_SF1_GDSC 19 +#define HLOS1_VOTE_TURING_MMU_TBU0_GDSC 20 +#define HLOS1_VOTE_TURING_MMU_TBU1_GDSC 21 +#define HLOS1_VOTE_TURING_MMU_TBU2_GDSC 22 +#define HLOS1_VOTE_TURING_MMU_TBU3_GDSC 23 =20 #endif --=20 2.41.0 From nobody Mon Feb 9 08:36:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 761F8EB64D7 for ; Tue, 20 Jun 2023 18:55:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230236AbjFTSzX (ORCPT ); Tue, 20 Jun 2023 14:55:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230215AbjFTSzJ (ORCPT ); Tue, 20 Jun 2023 14:55:09 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1ED01706 for ; Tue, 20 Jun 2023 11:55:05 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-4f8777caaa1so2385572e87.3 for ; Tue, 20 Jun 2023 11:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687287304; x=1689879304; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aHWhWGxI+gIWrgxdsIEoKDAbK3764Y8ia34V6xPpSZ8=; b=Zdmxr2BWekZ+o27AOP9dolQpYQxC4bAFXbhwPHvW80URY06BETFu8tgVie4+dajRCW 5RupB34sETrjljyoIZfnmhYZfitgoYATq2Qly75rgyoCFPPNnJgdD0jXIX9DNrCEkJhj qOmt/kbkbYjr/pMCXJdEjkEK6YD4OeC6tPO82XkCz+Q+/R0/ImHFq3lVOFPd8p2J8IkF L7iJwOgFNutOC/m6wZ264XxHeJPje0mkFsOEFIq4c/baFYvzxnB3X7m1V4gFXTjFXipU axfdSbDlJ6ty8i3kigJ3SkBfGcaQ84eBNDVYQGY8B1B341fmQnhKEz+yantknIiv4Tg+ KEkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687287304; x=1689879304; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aHWhWGxI+gIWrgxdsIEoKDAbK3764Y8ia34V6xPpSZ8=; b=VL71lqVEUdvQLpTEKYwE6xLe5Yi1t4HtXktRer16C8VnhES7Oo3B8b2ob1U4+xQcxL 4ZeZKhGhiARUHpUcWy7mnIlltATBm/GkEX5NAGrX5envgHEB1E8Ge6L1CBnRAosTqGvr /GWf2vquliqtcghJDOfWY9B6q46KTJWaCP1+JI49I64c7wRlhnSGo+d6gDmj5FSuzVqu HsgYOsW5UdagjsdABr85kXSkqj7P+PN/9lX/AzawTcDcqnppy/WUjFBRebmEwujQPgLy +tcvHf7npkjmYEQt+1oNSKuMWPJLBuC0WZPMcvnX23VlP1JqdoPhmKu3Hqqf7Kx44coM pGsQ== X-Gm-Message-State: AC+VfDzWD3apV+U6seAC0ltI3xZ0ppJtlscf8N/PIhq9l6L8LWf8ZrZV Lfww9wmxJoecRPZBQ9CAS6yvfQ== X-Google-Smtp-Source: ACHHUZ40k2QvW5jpRPAY2cL/F543ANbvKXMi7c/pd3P5fsoECo1YdSpn8yxRE5uD4WZPeCzaJlGo7w== X-Received: by 2002:a19:7108:0:b0:4ef:f11c:f5b0 with SMTP id m8-20020a197108000000b004eff11cf5b0mr7396017lfc.54.1687287303979; Tue, 20 Jun 2023 11:55:03 -0700 (PDT) Received: from [192.168.1.101] (abxj193.neoplus.adsl.tpnet.pl. [83.9.3.193]) by smtp.gmail.com with ESMTPSA id v1-20020ac25921000000b004f867f8d157sm463899lfi.124.2023.06.20.11.55.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 11:55:03 -0700 (PDT) From: Konrad Dybcio Date: Tue, 20 Jun 2023 20:55:00 +0200 Subject: [PATCH 3/3] clk: qcom: gcc-sc8280xp: Add missing GDSCs MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230620-topic-sc8280_gccgdsc-v1-3-0fd91a942bda@linaro.org> References: <20230620-topic-sc8280_gccgdsc-v1-0-0fd91a942bda@linaro.org> In-Reply-To: <20230620-topic-sc8280_gccgdsc-v1-0-0fd91a942bda@linaro.org> To: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1687287298; l=3796; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=UpWmAPr/HPOctqmlcpw284qW29dCVKn9J2MOK2Err1E=; b=nyJGHDOyzmKntivEByH56F5Fz8sy1mETEgpXQOJMHvkopLccQhqqmFH/x/YiLcfPIjOp4MVY+ u4pddd3PmNtD4EwvjxjxPIky+dcWF9oJLblEq7tHI51K7Uwc6lRE5it X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are 10 more GDSCs that we've not been caring about, and by extension (and perhaps even more importantly), not putting to sleep. Add them. Fixes: d65d005f9a6c ("clk: qcom: add sc8280xp GCC driver") Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sc8280xp.c | 100 ++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 100 insertions(+) diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280x= p.c index 80bc741ee75a..910d4f08af89 100644 --- a/drivers/clk/qcom/gcc-sc8280xp.c +++ b/drivers/clk/qcom/gcc-sc8280xp.c @@ -6896,6 +6896,96 @@ static struct gdsc emac_1_gdsc =3D { .flags =3D HW_CTRL | RETAIN_FF_ENABLE, }; =20 +static struct gdsc usb4_1_gdsc =3D { + .gdscr =3D 0xb8004, + .pd =3D { + .name =3D "usb4_1_gdsc", + }, + .pwrsts =3D PWRSTS_OFF_ON, + .flags =3D HW_CTRL | RETAIN_FF_ENABLE, +}; + +static struct gdsc usb4_gdsc =3D { + .gdscr =3D 0x2a004, + .pd =3D { + .name =3D "usb4_gdsc", + }, + .pwrsts =3D PWRSTS_OFF_ON, + .flags =3D HW_CTRL | RETAIN_FF_ENABLE, +}; + +static struct gdsc hlos1_vote_mmnoc_mmu_tbu_hf0_gdsc =3D { + .gdscr =3D 0x7d050, + .pd =3D { + .name =3D "hlos1_vote_mmnoc_mmu_tbu_hf0_gdsc", + }, + .pwrsts =3D PWRSTS_OFF_ON, + .flags =3D VOTABLE, +}; + +static struct gdsc hlos1_vote_mmnoc_mmu_tbu_hf1_gdsc =3D { + .gdscr =3D 0x7d058, + .pd =3D { + .name =3D "hlos1_vote_mmnoc_mmu_tbu_hf1_gdsc", + }, + .pwrsts =3D PWRSTS_OFF_ON, + .flags =3D VOTABLE, +}; + +static struct gdsc hlos1_vote_mmnoc_mmu_tbu_sf0_gdsc =3D { + .gdscr =3D 0x7d054, + .pd =3D { + .name =3D "hlos1_vote_mmnoc_mmu_tbu_sf0_gdsc", + }, + .pwrsts =3D PWRSTS_OFF_ON, + .flags =3D VOTABLE, +}; + +static struct gdsc hlos1_vote_mmnoc_mmu_tbu_sf1_gdsc =3D { + .gdscr =3D 0x7d06c, + .pd =3D { + .name =3D "hlos1_vote_mmnoc_mmu_tbu_sf1_gdsc", + }, + .pwrsts =3D PWRSTS_OFF_ON, + .flags =3D VOTABLE, +}; + +static struct gdsc hlos1_vote_turing_mmu_tbu0_gdsc =3D { + .gdscr =3D 0x7d05c, + .pd =3D { + .name =3D "hlos1_vote_turing_mmu_tbu0_gdsc", + }, + .pwrsts =3D PWRSTS_OFF_ON, + .flags =3D VOTABLE, +}; + +static struct gdsc hlos1_vote_turing_mmu_tbu1_gdsc =3D { + .gdscr =3D 0x7d060, + .pd =3D { + .name =3D "hlos1_vote_turing_mmu_tbu1_gdsc", + }, + .pwrsts =3D PWRSTS_OFF_ON, + .flags =3D VOTABLE, +}; + +static struct gdsc hlos1_vote_turing_mmu_tbu2_gdsc =3D { + .gdscr =3D 0x7d0a0, + .pd =3D { + .name =3D "hlos1_vote_turing_mmu_tbu2_gdsc", + }, + .pwrsts =3D PWRSTS_OFF_ON, + .flags =3D VOTABLE, +}; + +static struct gdsc hlos1_vote_turing_mmu_tbu3_gdsc =3D { + .gdscr =3D 0x7d0a4, + .pd =3D { + .name =3D "hlos1_vote_turing_mmu_tbu3_gdsc", + }, + .pwrsts =3D PWRSTS_OFF_ON, + .flags =3D VOTABLE, +}; + static struct clk_regmap *gcc_sc8280xp_clocks[] =3D { [GCC_AGGRE_NOC_PCIE0_TUNNEL_AXI_CLK] =3D &gcc_aggre_noc_pcie0_tunnel_axi_= clk.clkr, [GCC_AGGRE_NOC_PCIE1_TUNNEL_AXI_CLK] =3D &gcc_aggre_noc_pcie1_tunnel_axi_= clk.clkr, @@ -7376,6 +7466,16 @@ static struct gdsc *gcc_sc8280xp_gdscs[] =3D { [USB30_SEC_GDSC] =3D &usb30_sec_gdsc, [EMAC_0_GDSC] =3D &emac_0_gdsc, [EMAC_1_GDSC] =3D &emac_1_gdsc, + [USB4_1_GDSC] =3D &usb4_1_gdsc, + [USB4_GDSC] =3D &usb4_gdsc, + [HLOS1_VOTE_MMNOC_MMU_TBU_HF0_GDSC] =3D &hlos1_vote_mmnoc_mmu_tbu_hf0_gds= c, + [HLOS1_VOTE_MMNOC_MMU_TBU_HF1_GDSC] =3D &hlos1_vote_mmnoc_mmu_tbu_hf1_gds= c, + [HLOS1_VOTE_MMNOC_MMU_TBU_SF0_GDSC] =3D &hlos1_vote_mmnoc_mmu_tbu_sf0_gds= c, + [HLOS1_VOTE_MMNOC_MMU_TBU_SF1_GDSC] =3D &hlos1_vote_mmnoc_mmu_tbu_sf1_gds= c, + [HLOS1_VOTE_TURING_MMU_TBU0_GDSC] =3D &hlos1_vote_turing_mmu_tbu0_gdsc, + [HLOS1_VOTE_TURING_MMU_TBU1_GDSC] =3D &hlos1_vote_turing_mmu_tbu1_gdsc, + [HLOS1_VOTE_TURING_MMU_TBU2_GDSC] =3D &hlos1_vote_turing_mmu_tbu2_gdsc, + [HLOS1_VOTE_TURING_MMU_TBU3_GDSC] =3D &hlos1_vote_turing_mmu_tbu3_gdsc, }; =20 static const struct clk_rcg_dfs_data gcc_dfs_clocks[] =3D { --=20 2.41.0