From nobody Sun Feb 8 15:01:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4A32EB64D9 for ; Mon, 19 Jun 2023 18:04:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232019AbjFSSEA (ORCPT ); Mon, 19 Jun 2023 14:04:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjFSSD6 (ORCPT ); Mon, 19 Jun 2023 14:03:58 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DD9712A for ; Mon, 19 Jun 2023 11:03:57 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-98377c5d53eso529702066b.0 for ; Mon, 19 Jun 2023 11:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1687197836; x=1689789836; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R3jx2b9Mk6wTwyAJZvyHLpveP2xgctvjKCyGVRIC4vU=; b=sB25lAs9M9T5ef+SSdN+RFXG3CFcWIZZFsFJzWjnOhiNWn185mvbqvNfaY2O/P1hd8 lDlqHEwGOga+ykrUJD7BeLs46uudS3TXlaJ5fKVgWN7IstFmQlY8ggFEPoAEbkzApcEP UkHlegN2faNzCaN76HOVFIh1JtMiuSO/q1P4v1+jg/uRUUfZ/Sy7mvA4AMR788gPyLOG P4Rwk5YOtl9y6TRU0Ib9G498Hqkm91nbY3hUIPpIN/T4RxNoRn0ah3ZZw1snX3BRYo05 lKWZpdcQbJtgvGnbBrupwWNQJmiCRX96y6RnqwjQ73khWrYnwG6+kzKHmYjl2aR9dwuX RhNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687197836; x=1689789836; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R3jx2b9Mk6wTwyAJZvyHLpveP2xgctvjKCyGVRIC4vU=; b=Q+Ql+N1JpVxSBuni+IeVJ9LqvTRvg9RRNv2MrCOAKqyYE0+MLhoFM8yHcZQLD1araf zXbstQTqfT77efmoEzQH7smfa70FsACoJ/I1GJekxo4c4UTe4kYcfHsIzgvWZ3f8THzG iCrN8zmKr/gU9tF/jYv/UvUcnujbfz76iDM9Qaa435ML0bSOgX1yJ1EMsbUaC4ChBYeu FPN4Bc67ybTtQqXtLDJ5f9jSLTE6/K860bDch0YGGQxoB2G5XjB5ZZYvPULFR5Zl49Lu Ew8/5JLBGvuahJkrdepdEWLxIztDMR3LO0Bu583IMCGbhvBziP5x24NBe57MLnH8yTk8 Hz4w== X-Gm-Message-State: AC+VfDxE2+uMqQX94PgiWKpaj0cw0JfvUNP4QtvGk2wfzvxBnaiIrEqb tKL3rZZqZ3ux3Q6Zc4IusJE= X-Google-Smtp-Source: ACHHUZ4kDUuvTG8QrUb8lvlWMeevD5EvadoImRGj69UFl7+uh2sxzqE9PJ4vU4H9MA37Nm9RTrlAfw== X-Received: by 2002:a17:907:2da6:b0:988:f93:32e8 with SMTP id gt38-20020a1709072da600b009880f9332e8mr6314843ejc.26.1687197835771; Mon, 19 Jun 2023 11:03:55 -0700 (PDT) Received: from localhost.localdomain ([2a02:810a:9640:26a8:dcda:2154:7873:34]) by smtp.gmail.com with ESMTPSA id kk10-20020a170907766a00b00988a6421831sm20913ejc.93.2023.06.19.11.03.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 19 Jun 2023 11:03:55 -0700 (PDT) From: Franziska Naepelt X-Google-Original-From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: eperi1024@gmail.com, franziska.naepelt@gmail.com, gregkh@linuxfoundation.org, hdegoede@redhat.com, johannes.berg@intel.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, quic_vjakkam@quicinc.com, tegongkang@gmail.com Subject: [PATCH 1/5] staging: rtl8723bs: Fix indentation issues Date: Mon, 19 Jun 2023 20:03:51 +0200 Message-Id: <20230619180351.18925-1-franziska.naepelt@gmail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230619175703.18826-1-franziska.naepelt@gmail.com> References: <20230619175703.18826-1-franziska.naepelt@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch indentation issues: - WARNING: suspect code indent for conditional statements (32, 48) - WARNING: suspect code indent for conditional statements (24, 24) - ERROR: code indent should use tabs where possible Signed-off-by: Franziska Naepelt --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 84a9f4dd8f95..1afd1a93bcee 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -581,7 +581,7 @@ static int rtw_cfg80211_ap_set_encryption(struct net_de= vice *dev, struct ieee_pa =20 psecuritypriv->dot118021XGrpPrivacy =3D _WEP40_; if (param->u.crypt.key_len =3D=3D 13) - psecuritypriv->dot118021XGrpPrivacy =3D _WEP104_; + psecuritypriv->dot118021XGrpPrivacy =3D _WEP104_; =20 } else if (strcmp(param->u.crypt.alg, "TKIP") =3D=3D 0) { psecuritypriv->dot118021XGrpPrivacy =3D _TKIP_; @@ -1305,7 +1305,7 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy } else if (request->n_channels <=3D 4) { for (j =3D request->n_channels - 1; j >=3D 0; j--) for (i =3D 0; i < survey_times; i++) - memcpy(&ch[j*survey_times+i], &ch[j], sizeof(struct rtw_ieee80211_chann= el)); + memcpy(&ch[j*survey_times+i], &ch[j], sizeof(struct rtw_ieee80211_chan= nel)); _status =3D rtw_sitesurvey_cmd(padapter, ssid, RTW_SSID_SCAN_AMOUNT, ch,= survey_times * request->n_channels); } else { _status =3D rtw_sitesurvey_cmd(padapter, ssid, RTW_SSID_SCAN_AMOUNT, NUL= L, 0); @@ -2810,7 +2810,7 @@ int rtw_wdev_alloc(struct adapter *padapter, struct d= evice *dev) wdev->netdev =3D pnetdev; =20 wdev->iftype =3D NL80211_IFTYPE_STATION; /* will be init in rtw_hal_init= () */ - /* Must sync with _rtw_init_mlme_= priv() */ + /* Must sync with _rtw_init_mlme_priv() */ /* pmlmepriv->fw_state =3D WIFI_STATION_STATE */ padapter->rtw_wdev =3D wdev; pnetdev->ieee80211_ptr =3D wdev; --=20 2.39.2 (Apple Git-143) From nobody Sun Feb 8 15:01:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5911EB64DA for ; Mon, 19 Jun 2023 18:08:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232217AbjFSSIE (ORCPT ); Mon, 19 Jun 2023 14:08:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232196AbjFSSIA (ORCPT ); Mon, 19 Jun 2023 14:08:00 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A2EF128 for ; Mon, 19 Jun 2023 11:07:59 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-970028cfb6cso613017366b.1 for ; Mon, 19 Jun 2023 11:07:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1687198077; x=1689790077; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+3xnjd0eY8aQSj0QUgbvMXe0x5b/buzAezpR6BW9YoA=; b=pKM/o4HN/dcO0Z/xHwNdbeQebyVtN3To8gAF20wPUGE/45rNM19+hyyFXiyEgoy/2I 8Eup5urzdmcL2kouRqaVAlhjIU+UIVzE4FsLLbbe21AOCLzFSOTEMCcL3ET59Weei9VF 53mK5v2q/d4qiKL9u2XlgDJEU/MufzxMCKdvm4tGL3/lHFiYtCJ53LbY01i2LcDqqDeO pAuEB7EC6otKXxQe6su1jHFCTv1fv5JQFnBNU5DH409qcMxn2ULfRLUoUb/ClzBxXkA+ WSSStkzc4Ea1wdJfo9iM72sTf0EMdKVFKDJPOcsPZ2xkLMDtJn5czfyBllnAFUH9+wSu zP9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687198077; x=1689790077; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+3xnjd0eY8aQSj0QUgbvMXe0x5b/buzAezpR6BW9YoA=; b=DD8FGHbksC3yDm5SarXpfxJ5TG1zAF/a6C63VKvT5WpnPvrT4ytiOtfHICf9cZatVI +iCW6VfWkfXVSlO/s3XvWFHwq3cfwXerkjb8fekb0/ta78xjuVnkXgpMRtcajAffblVZ x8ic6O1ToDp52G1ew8WM21ZMVaICDnuuqeuh86lFP5vdHKMtvW1uxLjLqDpHsNFXqiyh ZB6n8Fwo+pJK+iqM13lFWt7j39f0khZeFBfLgH+3cgDEzEEpP2PAtje/o1DiMkIrhqLb TOSuhVDsoyUwtuTg4OHN2hBbDXajvrliVCw2vV8rawkYp1Cv4scH9T1evAFNhpvDzK+P NNzw== X-Gm-Message-State: AC+VfDx53EydPcCBeIWP4kMPQu4TZyfhqFZRRENMWR/KWI2avQ5LneYo I3olb/lwmgTSDBOIqUrpPpA= X-Google-Smtp-Source: ACHHUZ714AGjCPDgBlyZ8eBV3aeRatY715HnXU4wYJ++p4cqyBk07bFYYj+cF5Ki80va9RKWROfQQA== X-Received: by 2002:a17:907:86ab:b0:987:792:34e5 with SMTP id qa43-20020a17090786ab00b00987079234e5mr6985114ejc.23.1687198077390; Mon, 19 Jun 2023 11:07:57 -0700 (PDT) Received: from localhost.localdomain ([2a02:810a:9640:26a8:dcda:2154:7873:34]) by smtp.gmail.com with ESMTPSA id hk12-20020a170906c9cc00b009659ad1072fsm22076ejb.113.2023.06.19.11.07.56 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 19 Jun 2023 11:07:57 -0700 (PDT) From: Franziska Naepelt X-Google-Original-From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: eperi1024@gmail.com, franziska.naepelt@gmail.com, gregkh@linuxfoundation.org, hdegoede@redhat.com, johannes.berg@intel.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, quic_vjakkam@quicinc.com, tegongkang@gmail.com Subject: [PATCH 2/5] staging: rtl8723bs: Fix space issues Date: Mon, 19 Jun 2023 20:07:53 +0200 Message-Id: <20230619180753.18998-1-franziska.naepelt@gmail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230619175703.18826-1-franziska.naepelt@gmail.com> References: <20230619175703.18826-1-franziska.naepelt@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch space issues: - CHECK: spaces preferred around that '*' (ctx:VxV) - CHECK: spaces preferred around that '+' (ctx:VxV) - CHECK: spaces preferred around that '-' (ctx:VxV) - CHECK: spaces preferred around that '|' (ctx:VxV) - CHECK: No space is necessary after a cast - WARNING: please, no spaces at the start of a line Signed-off-by: Franziska Naepelt --- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 77 +++++++++---------- 1 file changed, 38 insertions(+), 39 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 1afd1a93bcee..abda4e0f0bf5 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -95,14 +95,14 @@ static struct ieee80211_channel rtw_2ghz_channels[] =3D= { static void rtw_2g_channels_init(struct ieee80211_channel *channels) { memcpy((void *)channels, (void *)rtw_2ghz_channels, - sizeof(struct ieee80211_channel)*RTW_2G_CHANNELS_NUM + sizeof(struct ieee80211_channel) * RTW_2G_CHANNELS_NUM ); } =20 static void rtw_2g_rates_init(struct ieee80211_rate *rates) { memcpy(rates, rtw_g_rates, - sizeof(struct ieee80211_rate)*RTW_G_RATES_NUM + sizeof(struct ieee80211_rate) * RTW_G_RATES_NUM ); } =20 @@ -126,8 +126,8 @@ static struct ieee80211_supported_band *rtw_spt_band_al= loc( if (!spt_band) goto exit; =20 - spt_band->channels =3D (struct ieee80211_channel *)(((u8 *)spt_band)+size= of(struct ieee80211_supported_band)); - spt_band->bitrates =3D (struct ieee80211_rate *)(((u8 *)spt_band->channel= s)+sizeof(struct ieee80211_channel)*n_channels); + spt_band->channels =3D (struct ieee80211_channel *)(((u8 *)spt_band) + si= zeof(struct ieee80211_supported_band)); + spt_band->bitrates =3D (struct ieee80211_rate *)(((u8 *)spt_band->channel= s) + sizeof(struct ieee80211_channel) * n_channels); spt_band->band =3D band; spt_band->n_channels =3D n_channels; spt_band->n_bitrates =3D n_bitrates; @@ -247,10 +247,10 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct a= dapter *padapter, struct wl u32 wpsielen =3D 0; u8 *wpsie =3D NULL; =20 - wpsie =3D rtw_get_wps_ie(pnetwork->network.ies+_FIXED_IE_LENGTH_, pnetwo= rk->network.ie_length-_FIXED_IE_LENGTH_, NULL, &wpsielen); + wpsie =3D rtw_get_wps_ie(pnetwork->network.ies + _FIXED_IE_LENGTH_, pnet= work->network.ie_length - _FIXED_IE_LENGTH_, NULL, &wpsielen); =20 if (wpsie && wpsielen > 0) - psr =3D rtw_get_wps_attr_content(wpsie, wpsielen, WPS_ATTR_SELECTED_RE= GISTRAR, (u8 *)(&sr), NULL); + psr =3D rtw_get_wps_attr_content(wpsie, wpsielen, WPS_ATTR_SELECTED_REG= ISTRAR, (u8 *)(&sr), NULL); =20 if (sr !=3D 0) { /* it means under processing WPS */ @@ -266,7 +266,6 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl } /* spin_unlock_bh(&pwdev_priv->scan_req_lock); */ =20 - channel =3D pnetwork->network.configuration.ds_config; freq =3D rtw_ieee80211_channel_to_frequency(channel, NL80211_BAND_2GHZ); =20 @@ -277,9 +276,9 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl /* We've set wiphy's signal_type as CFG80211_SIGNAL_TYPE_MBM: signal stre= ngth in mBm (100*dBm) */ if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true && is_same_network(&pmlmepriv->cur_network.network, &pnetwork->network, 0))= { - notify_signal =3D 100*translate_percentage_to_dbm(padapter->recvpriv.sig= nal_strength);/* dbm */ + notify_signal =3D 100 * translate_percentage_to_dbm(padapter->recvpriv.s= ignal_strength);/* dbm */ } else { - notify_signal =3D 100*translate_percentage_to_dbm(pnetwork->network.phy_= info.signal_strength);/* dbm */ + notify_signal =3D 100 * translate_percentage_to_dbm(pnetwork->network.ph= y_info.signal_strength);/* dbm */ } =20 buf =3D kzalloc(MAX_BSSINFO_LEN, GFP_ATOMIC); @@ -452,20 +451,20 @@ void rtw_cfg80211_indicate_connect(struct adapter *pa= dapter) roam_info.links[0].channel =3D notify_channel; roam_info.links[0].bssid =3D cur_network->network.mac_address; roam_info.req_ie =3D - pmlmepriv->assoc_req+sizeof(struct ieee80211_hdr_3addr)+2; + pmlmepriv->assoc_req + sizeof(struct ieee80211_hdr_3addr) + 2; roam_info.req_ie_len =3D - pmlmepriv->assoc_req_len-sizeof(struct ieee80211_hdr_3addr)-2; + pmlmepriv->assoc_req_len - sizeof(struct ieee80211_hdr_3addr) - 2; roam_info.resp_ie =3D - pmlmepriv->assoc_rsp+sizeof(struct ieee80211_hdr_3addr)+6; + pmlmepriv->assoc_rsp + sizeof(struct ieee80211_hdr_3addr) + 6; roam_info.resp_ie_len =3D - pmlmepriv->assoc_rsp_len-sizeof(struct ieee80211_hdr_3addr)-6; + pmlmepriv->assoc_rsp_len - sizeof(struct ieee80211_hdr_3addr) - 6; cfg80211_roamed(padapter->pnetdev, &roam_info, GFP_ATOMIC); } else { cfg80211_connect_result(padapter->pnetdev, cur_network->network.mac_addr= ess - , pmlmepriv->assoc_req+sizeof(struct ieee80211_hdr_3addr)+2 - , pmlmepriv->assoc_req_len-sizeof(struct ieee80211_hdr_3addr)-2 - , pmlmepriv->assoc_rsp+sizeof(struct ieee80211_hdr_3addr)+6 - , pmlmepriv->assoc_rsp_len-sizeof(struct ieee80211_hdr_3addr)-6 + , pmlmepriv->assoc_req + sizeof(struct ieee80211_hdr_3addr) + 2 + , pmlmepriv->assoc_req_len - sizeof(struct ieee80211_hdr_3addr) - 2 + , pmlmepriv->assoc_rsp + sizeof(struct ieee80211_hdr_3addr) + 6 + , pmlmepriv->assoc_rsp_len - sizeof(struct ieee80211_hdr_3addr) - 6 , WLAN_STATUS_SUCCESS, GFP_ATOMIC); } } @@ -720,7 +719,7 @@ static int rtw_cfg80211_set_encryption(struct net_devic= e *dev, struct ieee_param param->u.crypt.err =3D 0; param->u.crypt.alg[IEEE_CRYPT_ALG_NAME_LEN - 1] =3D '\0'; =20 - if (param_len < (u32) ((u8 *) param->u.crypt.key - (u8 *) param) + param-= >u.crypt.key_len) { + if (param_len < (u32)((u8 *)param->u.crypt.key - (u8 *)param) + param->u.= crypt.key_len) { ret =3D -EINVAL; goto exit; } @@ -1035,10 +1034,10 @@ static int cfg80211_rtw_get_station(struct wiphy *w= iphy, } =20 /* for Ad-Hoc/AP mode */ - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) - || check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) - || check_fwstate(pmlmepriv, WIFI_AP_STATE)) - && check_fwstate(pmlmepriv, _FW_LINKED)) { + if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) || + check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) || + check_fwstate(pmlmepriv, WIFI_AP_STATE)) && + check_fwstate(pmlmepriv, _FW_LINKED)) { /* TODO: should acquire station info... */ } =20 @@ -1237,7 +1236,7 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy spin_unlock_bh(&pwdev_priv->scan_req_lock); =20 if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { - if (check_fwstate(pmlmepriv, WIFI_UNDER_WPS|_FW_UNDER_SURVEY|_FW_UNDER_L= INKING) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_UNDER_WPS | _FW_UNDER_SURVEY | _FW_UND= ER_LINKING) =3D=3D true) { need_indicate_scan_done =3D true; goto check_need_indicate_scan_done; } @@ -1291,7 +1290,7 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy } =20 /* parsing channels, n_channels */ - memset(ch, 0, sizeof(struct rtw_ieee80211_channel)*RTW_CHANNEL_SCAN_AMOUN= T); + memset(ch, 0, sizeof(struct rtw_ieee80211_channel) * RTW_CHANNEL_SCAN_AMO= UNT); for (i =3D 0; i < request->n_channels && i < RTW_CHANNEL_SCAN_AMOUNT; i++= ) { ch[i].hw_value =3D request->channels[i]->hw_value; ch[i].flags =3D request->channels[i]->flags; @@ -1305,7 +1304,7 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy } else if (request->n_channels <=3D 4) { for (j =3D request->n_channels - 1; j >=3D 0; j--) for (i =3D 0; i < survey_times; i++) - memcpy(&ch[j*survey_times+i], &ch[j], sizeof(struct rtw_ieee80211_chan= nel)); + memcpy(&ch[j * survey_times + i], &ch[j], sizeof(struct rtw_ieee80211_= channel)); _status =3D rtw_sitesurvey_cmd(padapter, ssid, RTW_SSID_SCAN_AMOUNT, ch,= survey_times * request->n_channels); } else { _status =3D rtw_sitesurvey_cmd(padapter, ssid, RTW_SSID_SCAN_AMOUNT, NUL= L, 0); @@ -1461,7 +1460,7 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *pa= dapter, u8 *pie, size_t iel goto exit; } =20 - if (ielen > MAX_WPA_IE_LEN+MAX_WPS_IE_LEN+MAX_P2P_IE_LEN) { + if (ielen > MAX_WPA_IE_LEN + MAX_WPS_IE_LEN + MAX_P2P_IE_LEN) { ret =3D -EINVAL; goto exit; } @@ -1481,19 +1480,19 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *= padapter, u8 *pie, size_t iel =20 pwpa =3D rtw_get_wpa_ie(buf, &wpa_ielen, ielen); if (pwpa && wpa_ielen > 0) { - if (rtw_parse_wpa_ie(pwpa, wpa_ielen+2, &group_cipher, &pairwise_cipher,= NULL) =3D=3D _SUCCESS) { + if (rtw_parse_wpa_ie(pwpa, wpa_ielen + 2, &group_cipher, &pairwise_ciphe= r, NULL) =3D=3D _SUCCESS) { padapter->securitypriv.dot11AuthAlgrthm =3D dot11AuthAlgrthm_8021X; padapter->securitypriv.ndisauthtype =3D Ndis802_11AuthModeWPAPSK; - memcpy(padapter->securitypriv.supplicant_ie, &pwpa[0], wpa_ielen+2); + memcpy(padapter->securitypriv.supplicant_ie, &pwpa[0], wpa_ielen + 2); } } =20 pwpa2 =3D rtw_get_wpa2_ie(buf, &wpa2_ielen, ielen); if (pwpa2 && wpa2_ielen > 0) { - if (rtw_parse_wpa2_ie(pwpa2, wpa2_ielen+2, &group_cipher, &pairwise_ciph= er, NULL) =3D=3D _SUCCESS) { + if (rtw_parse_wpa2_ie(pwpa2, wpa2_ielen + 2, &group_cipher, &pairwise_ci= pher, NULL) =3D=3D _SUCCESS) { padapter->securitypriv.dot11AuthAlgrthm =3D dot11AuthAlgrthm_8021X; padapter->securitypriv.ndisauthtype =3D Ndis802_11AuthModeWPA2PSK; - memcpy(padapter->securitypriv.supplicant_ie, &pwpa2[0], wpa2_ielen+2); + memcpy(padapter->securitypriv.supplicant_ie, &pwpa2[0], wpa2_ielen + 2); } } =20 @@ -1892,7 +1891,7 @@ static int cfg80211_rtw_set_pmksa(struct wiphy *wiphy, =20 memcpy(psecuritypriv->PMKIDList[index].PMKID, (u8 *)pmksa->pmkid, WLAN_= PMKID_LEN); psecuritypriv->PMKIDList[index].bUsed =3D true; - psecuritypriv->PMKIDIndex =3D index+1; + psecuritypriv->PMKIDIndex =3D index + 1; blInserted =3D true; break; } @@ -2094,8 +2093,8 @@ static netdev_tx_t rtw_cfg80211_monitor_if_xmit_entry= (struct sk_buff *skb, struc _rtw_xmit_entry(skb, padapter->pnetdev); return NETDEV_TX_OK; =20 - } else if ((frame_control & (IEEE80211_FCTL_FTYPE|IEEE80211_FCTL_STYPE)) = =3D=3D - (IEEE80211_FTYPE_MGMT|IEEE80211_STYPE_ACTION)) { + } else if ((frame_control & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE)= ) =3D=3D + (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION)) { /* only for action frames */ struct xmit_frame *pmgntframe; struct pkt_attrib *pattrib; @@ -2209,7 +2208,7 @@ static int rtw_cfg80211_add_monitor_if(struct adapter= *padapter, char *name, str goto out; =20 *ndev =3D pwdev_priv->pmon_ndev =3D mon_ndev; - memcpy(pwdev_priv->ifname_mon, name, IFNAMSIZ+1); + memcpy(pwdev_priv->ifname_mon, name, IFNAMSIZ + 1); =20 out: if (ret && mon_wdev) { @@ -2303,14 +2302,14 @@ static int rtw_add_beacon(struct adapter *adapter, = const u8 *head, size_t head_l if (head_len < 24) return -EINVAL; =20 - pbuf =3D rtw_zmalloc(head_len+tail_len); + pbuf =3D rtw_zmalloc(head_len + tail_len); if (!pbuf) return -ENOMEM; =20 - memcpy(pbuf, (void *)head+24, head_len-24);/* 24 =3Dbeacon header len. */ - memcpy(pbuf+head_len-24, (void *)tail, tail_len); + memcpy(pbuf, (void *)head + 24, head_len - 24);/* 24 =3Dbeacon header le= n. */ + memcpy(pbuf + head_len - 24, (void *)tail, tail_len); =20 - len =3D head_len+tail_len-24; + len =3D head_len + tail_len - 24; =20 /* check wps ie if inclued */ rtw_get_wps_ie(pbuf + _FIXED_IE_LENGTH_, len - _FIXED_IE_LENGTH_, NULL, &= wps_ielen); @@ -2600,7 +2599,7 @@ static int cfg80211_rtw_mgmt_tx(struct wiphy *wiphy, pwdev_priv =3D adapter_wdev_data(padapter); =20 /* cookie generation */ - *cookie =3D (unsigned long) buf; + *cookie =3D (unsigned long)buf; =20 /* indicate ack before issue frame to avoid racing with rsp frame */ rtw_cfg80211_mgmt_tx_status(padapter, *cookie, buf, len, ack, GFP_KERNEL); --=20 2.39.2 (Apple Git-143) From nobody Sun Feb 8 15:01:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82A6BEB64D9 for ; Mon, 19 Jun 2023 18:12:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230155AbjFSSMi (ORCPT ); Mon, 19 Jun 2023 14:12:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbjFSSMg (ORCPT ); Mon, 19 Jun 2023 14:12:36 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ABB612A for ; Mon, 19 Jun 2023 11:12:35 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-51a3f911135so4369185a12.2 for ; Mon, 19 Jun 2023 11:12:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1687198353; x=1689790353; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5+9yzantCwRm4FcYrNICqbhK8i/swOUSMka8dPN5+64=; b=CeGYnMzigtPR/nqfkfnU4ejWwYkY8x92hJCLspMad9X9dfeqH/MpjHAOdux37fyKd3 pAQjdRBqvmVczLZ8iaw0Eo/niR3UhEeSNWzcLyt6w2ciBx27/yZMscMDfQR36tOGXxC3 LC909lVEdZ53y22JQb3IiTpSFoK+oLbJmcEU8I2d/rpxwk3oPCp7LhTtrtQYqzHOxDMt ULDl12qyOixveL0w0OMLWuF7lfU9lNP1KmDv9ATD9vhlsDVNRBRGaL2xJlqpLWSvhgrP BK3yGV6tqY83NNYDQbBBNcN067ndTX3YyAkNwasRuQp7Fj8AyQuHwU1aHXNn0ux/7alX N+Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687198353; x=1689790353; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5+9yzantCwRm4FcYrNICqbhK8i/swOUSMka8dPN5+64=; b=cyGqa6TLssFB3ubA8aqTdWNMMAKE8pi4BLUI9S57pPK1vTO1RJop3ouuRR1nbUPspy 9J1bA5s3aEE0RXfzxN8p+zNK1lP0g9qV+1qhiISGZXqnfNsH3BXRtvgqOm0s2xu4MpPU ak/ghxiE9bnFfzXwuV0lbjrVK4khPJHJAad4WXMwnPyeBAqhWIl6AVhYi4LguHwtcLiU DLxV0KZLOB8MHCPV5EtXPHhxl8izTNF1Zt2MhkAND5M7a0S8jLXiskWnGKHlB/c0xd56 zEBpU12MDpfnYDXlGQ9YlV3TZHSj8AvPjV/EZkS9mzP8BCekwvmdCOQa+Lp91qIR1NBV TpVg== X-Gm-Message-State: AC+VfDzjnXfdSKr9/cLBPCr5u0+AyPDaEFywciN1wJ/y2l/eDwXppHB/ wTyPml74Z3W2yMpgv556YfbaWsctaIguqA== X-Google-Smtp-Source: ACHHUZ6IEh/9j6fKs7xILtT7GKtRkvBhhp02lyKwWifu/78E8OJlga48C9TCvaocwOqN6Hu7bnM1TA== X-Received: by 2002:a17:906:4793:b0:96f:2315:29fe with SMTP id cw19-20020a170906479300b0096f231529femr9809250ejc.0.1687198353486; Mon, 19 Jun 2023 11:12:33 -0700 (PDT) Received: from localhost.localdomain ([2a02:810a:9640:26a8:dcda:2154:7873:34]) by smtp.gmail.com with ESMTPSA id lf4-20020a170906ae4400b0098822e05eddsm27361ejb.100.2023.06.19.11.12.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 19 Jun 2023 11:12:33 -0700 (PDT) From: Franziska Naepelt X-Google-Original-From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: eperi1024@gmail.com, franziska.naepelt@gmail.com, gregkh@linuxfoundation.org, hdegoede@redhat.com, johannes.berg@intel.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, quic_vjakkam@quicinc.com, tegongkang@gmail.com Subject: [PATCH 3/5] staging: rtl8723bs: Fix block comment issue Date: Mon, 19 Jun 2023 20:12:30 +0200 Message-Id: <20230619181230.19070-1-franziska.naepelt@gmail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230619175703.18826-1-franziska.naepelt@gmail.com> References: <20230619175703.18826-1-franziska.naepelt@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch block comment issue: - WARNING: Block comments use * on subsequent lines Signed-off-by: Franziska Naepelt --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index abda4e0f0bf5..b65b5372bbcb 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -328,11 +328,11 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct a= dapter *padapter, struct wl } =20 /* - Check the given bss is valid by kernel API cfg80211_get_bss() - @padapter : the given adapter - - return true if bss is valid, false for not found. -*/ + * Check the given bss is valid by kernel API cfg80211_get_bss() + * @padapter : the given adapter + * + * return true if bss is valid, false for not found. + */ int rtw_cfg80211_check_bss(struct adapter *padapter) { struct wlan_bssid_ex *pnetwork =3D &(padapter->mlmeextpriv.mlmext_info.n= etwork); --=20 2.39.2 (Apple Git-143) From nobody Sun Feb 8 15:01:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D864BEB64DA for ; Mon, 19 Jun 2023 18:12:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231910AbjFSSM6 (ORCPT ); Mon, 19 Jun 2023 14:12:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230220AbjFSSMz (ORCPT ); Mon, 19 Jun 2023 14:12:55 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33484E4D for ; Mon, 19 Jun 2023 11:12:51 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2b477e9d396so20681051fa.3 for ; Mon, 19 Jun 2023 11:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1687198369; x=1689790369; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TIC5OCFcaIkjdFrGg7yRkrVHCEbc8gY+YZsP4CSqvYo=; b=ITBI6X7O1B7uVPBo1qZL9XL8wH1m13Yiky5kXxOenoO/CgG/dnsi8xG62i10AOXfjV t+GHqEwdPu6wAQFl0M+uW8Cx6ZF23OLITC+M9Py2Vsgxn2xSQBdf3R033lAvwUqJPDbB x83buwldezJtOnZqn2kniYEHGFVgBvxJgrRNbtVikxgrHMO4r8F5UZwUEmxegrrVyvax /j9PY066uydHE6IEOQKEwrIVfupU9gSs/NSWel9Bbc3U5K4zYCrE3tJ5KK/5CLYdMC7q ZhdkDFB6udxhvIdZ5K+oS1pqAEWoH5myyPTeOyngLbjAIxM1BkfMtg5pGizLD4UYlU7T Bbog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687198369; x=1689790369; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TIC5OCFcaIkjdFrGg7yRkrVHCEbc8gY+YZsP4CSqvYo=; b=EBGxumMskUIRuxbESJ7w3jaNKOw+g+tDKw7eDcSH4k30rCz60mScH9YqkZcCbOgt0g YHcOFgxPg0iiTkHrdjZMVYnL+JPUn/jB68vMTX4A8yuDQJ7pGwgg13mRtbqo+bfRVKbK HIOv7zwuWah9ObZzzGN6teLKmefi3AXx4qSrmJBvWVuxdKf2G30qoy2Q8444G54Vf2hX EtCROEy5RlPrXn++M4zTCAY9FiQaA9FI+8lqLfi9xb5cNEzId/HwWWuIGi5taw5kb/DN sqcTqD2YXvOmqDbUy8Ymwz06foL/i7KBDSl4qIWD68zkJtQMmIqu0r2TDu4g6Sa8dRKg ohEg== X-Gm-Message-State: AC+VfDwe32Igiy4PMMeO3ibudBE6iuTNdJAw8CU0u3kI4G+lvu6UUQdh 0QtJJLoJM55IbQFerga3zIo= X-Google-Smtp-Source: ACHHUZ5V6Vxl9OK+64fr+JSP6NjRiiNQA6EFQRF7Zx04UgAsCfx4RHDrcn5ulpgSvbFFV1sRJ6nTxw== X-Received: by 2002:a2e:9147:0:b0:2b4:62ad:3c33 with SMTP id q7-20020a2e9147000000b002b462ad3c33mr4845895ljg.25.1687198369278; Mon, 19 Jun 2023 11:12:49 -0700 (PDT) Received: from localhost.localdomain ([2a02:810a:9640:26a8:dcda:2154:7873:34]) by smtp.gmail.com with ESMTPSA id h11-20020a170906828b00b00965a4350411sm41021ejx.9.2023.06.19.11.12.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 19 Jun 2023 11:12:48 -0700 (PDT) From: Franziska Naepelt X-Google-Original-From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: eperi1024@gmail.com, franziska.naepelt@gmail.com, gregkh@linuxfoundation.org, hdegoede@redhat.com, johannes.berg@intel.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, quic_vjakkam@quicinc.com, tegongkang@gmail.com Subject: [PATCH 4/5] staging: rtl8723bs: Fix blank line issues Date: Mon, 19 Jun 2023 20:12:46 +0200 Message-Id: <20230619181246.19112-1-franziska.naepelt@gmail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230619175703.18826-1-franziska.naepelt@gmail.com> References: <20230619175703.18826-1-franziska.naepelt@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch blank line issues: - CHECK: Please don't use multiple blank lines - CHECK: Blank lines aren't necessary before a close brace '}' - CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: Franziska Naepelt --- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 46 ------------------- 1 file changed, 46 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index b65b5372bbcb..c00a377258d8 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -304,7 +304,6 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl memcpy(pwlanhdr->addr2, pnetwork->network.mac_address, ETH_ALEN); memcpy(pwlanhdr->addr3, pnetwork->network.mac_address, ETH_ALEN); =20 - pbuf +=3D sizeof(struct ieee80211_hdr_3addr); len =3D sizeof(struct ieee80211_hdr_3addr); =20 @@ -324,7 +323,6 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl =20 exit: return bss; - } =20 /* @@ -373,7 +371,6 @@ void rtw_cfg80211_ibss_indicate_connect(struct adapter = *padapter) struct wlan_network *scanned =3D pmlmepriv->cur_network_scanned; =20 if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true) { - memcpy(&cur_network->network, pnetwork, sizeof(struct wlan_bssid_ex)); rtw_cfg80211_inform_bss(padapter, cur_network); } else { @@ -494,7 +491,6 @@ void rtw_cfg80211_indicate_disconnect(struct adapter *p= adapter) } } =20 - static int rtw_cfg80211_ap_set_encryption(struct net_device *dev, struct i= eee_param *param, u32 param_len) { int ret =3D 0; @@ -568,7 +564,6 @@ static int rtw_cfg80211_ap_set_encryption(struct net_de= vice *dev, struct ieee_pa rtw_ap_set_wep_key(padapter, param->u.crypt.key, wep_key_len, wep_key_id= x, 1); =20 goto exit; - } =20 /* group key */ @@ -615,11 +610,9 @@ static int rtw_cfg80211_ap_set_encryption(struct net_d= evice *dev, struct ieee_pa pbcmc_sta->ieee8021x_blocked =3D false; pbcmc_sta->dot118021XPrivacy =3D psecuritypriv->dot118021XGrpPrivacy;/= * rx will use bmc_sta's dot118021XPrivacy */ } - } =20 goto exit; - } =20 if (psecuritypriv->dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_8021X && psta= ) { /* psk/802_1x */ @@ -642,7 +635,6 @@ static int rtw_cfg80211_ap_set_encryption(struct net_de= vice *dev, struct ieee_pa psecuritypriv->busetkipkey =3D true; =20 } else if (strcmp(param->u.crypt.alg, "CCMP") =3D=3D 0) { - psta->dot118021XPrivacy =3D _AES_; } else { psta->dot118021XPrivacy =3D _NO_PRIVACY_; @@ -694,17 +686,13 @@ static int rtw_cfg80211_ap_set_encryption(struct net_= device *dev, struct ieee_pa pbcmc_sta->ieee8021x_blocked =3D false; pbcmc_sta->dot118021XPrivacy =3D psecuritypriv->dot118021XGrpPrivacy;= /* rx will use bmc_sta's dot118021XPrivacy */ } - } - } - } =20 exit: =20 return ret; - } =20 static int rtw_cfg80211_set_encryption(struct net_device *dev, struct ieee= _param *param, u32 param_len) @@ -788,7 +776,6 @@ static int rtw_cfg80211_set_encryption(struct net_devic= e *dev, struct ieee_param if (strcmp(param->u.crypt.alg, "none") !=3D 0) psta->ieee8021x_blocked =3D false; =20 - if ((padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypt= ion2Enabled) || (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypti= on3Enabled)) { psta->dot118021XPrivacy =3D padapter->securitypriv.dot11PrivacyAlgrth= m; @@ -899,7 +886,6 @@ static int cfg80211_rtw_add_key(struct wiphy *wiphy, st= ruct net_device *ndev, =20 strncpy((char *)param->u.crypt.alg, alg_name, IEEE_CRYPT_ALG_NAME_LEN); =20 - if (!mac_addr || is_broadcast_ether_addr(mac_addr)) param->u.crypt.set_tx =3D 0; /* for wpa/wpa2 group key */ else @@ -931,7 +917,6 @@ static int cfg80211_rtw_add_key(struct wiphy *wiphy, st= ruct net_device *ndev, kfree(param); =20 return ret; - } =20 static int cfg80211_rtw_get_key(struct wiphy *wiphy, struct net_device *nd= ev, @@ -982,7 +967,6 @@ static int cfg80211_rtw_set_default_key(struct wiphy *w= iphy, } =20 return 0; - } =20 static int cfg80211_rtw_get_station(struct wiphy *wiphy, @@ -1167,7 +1151,6 @@ void rtw_cfg80211_surveydone_event_callback(struct ad= apter *padapter) /* ev =3Dtranslate_scan(padapter, a, pnetwork, ev, stop); */ rtw_cfg80211_inform_bss(padapter, pnetwork); } - } =20 spin_unlock_bh(&(pmlmepriv->scanned_queue.lock)); @@ -1199,7 +1182,6 @@ static int rtw_cfg80211_set_probe_req_wpsp2pie(struct= adapter *padapter, char *b } =20 return ret; - } =20 static int cfg80211_rtw_scan(struct wiphy *wiphy @@ -1311,7 +1293,6 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy } spin_unlock_bh(&pmlmepriv->lock); =20 - if (_status =3D=3D false) ret =3D -1; =20 @@ -1326,7 +1307,6 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy =20 exit: return ret; - } =20 static int cfg80211_rtw_set_wiphy_params(struct wiphy *wiphy, u32 changed) @@ -1341,12 +1321,10 @@ static int rtw_cfg80211_set_wpa_version(struct secu= rity_priv *psecuritypriv, u32 return 0; } =20 - if (wpa_version & (NL80211_WPA_VERSION_1 | NL80211_WPA_VERSION_2)) psecuritypriv->ndisauthtype =3D Ndis802_11AuthModeWPAPSK; =20 return 0; - } =20 static int rtw_cfg80211_set_auth_type(struct security_priv *psecuritypriv, @@ -1372,7 +1350,6 @@ static int rtw_cfg80211_set_auth_type(struct security= _priv *psecuritypriv, =20 psecuritypriv->ndisencryptstatus =3D Ndis802_11Encryption1Enabled; =20 - break; default: psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_Open; @@ -1380,7 +1357,6 @@ static int rtw_cfg80211_set_auth_type(struct security= _priv *psecuritypriv, } =20 return 0; - } =20 static int rtw_cfg80211_set_cipher(struct security_priv *psecuritypriv, u3= 2 cipher, bool ucast) @@ -1390,7 +1366,6 @@ static int rtw_cfg80211_set_cipher(struct security_pr= iv *psecuritypriv, u32 ciph u32 *profile_cipher =3D ucast ? &psecuritypriv->dot11PrivacyAlgrthm : &psecuritypriv->dot118021XGrpPrivacy; =20 - if (!cipher) { *profile_cipher =3D _NO_PRIVACY_; psecuritypriv->ndisencryptstatus =3D ndisencryptstatus; @@ -1602,7 +1577,6 @@ static int cfg80211_rtw_join_ibss(struct wiphy *wiphy= , struct net_device *ndev, } =20 if (params->ssid_len > IW_ESSID_MAX_SIZE) { - ret =3D -E2BIG; goto exit; } @@ -1670,7 +1644,6 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, = struct net_device *ndev, =20 padapter->mlmepriv.not_indic_disco =3D true; =20 - if (adapter_wdev_data(padapter)->block =3D=3D true) { ret =3D -EBUSY; goto exit; @@ -1693,7 +1666,6 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, = struct net_device *ndev, } =20 if (sme->ssid_len > IW_ESSID_MAX_SIZE) { - ret =3D -E2BIG; goto exit; } @@ -1888,7 +1860,6 @@ static int cfg80211_rtw_set_pmksa(struct wiphy *wiphy, /* overwrite PMKID */ for (index =3D 0 ; index < NUM_PMKID_CACHE; index++) { if (!memcmp(psecuritypriv->PMKIDList[index].Bssid, (u8 *)pmksa->bssid, E= TH_ALEN)) { - memcpy(psecuritypriv->PMKIDList[index].PMKID, (u8 *)pmksa->pmkid, WLAN_= PMKID_LEN); psecuritypriv->PMKIDList[index].bUsed =3D true; psecuritypriv->PMKIDIndex =3D index + 1; @@ -1898,7 +1869,6 @@ static int cfg80211_rtw_set_pmksa(struct wiphy *wiphy, } =20 if (!blInserted) { - memcpy(psecuritypriv->PMKIDList[psecuritypriv->PMKIDIndex].Bssid, (u8 *)= pmksa->bssid, ETH_ALEN); memcpy(psecuritypriv->PMKIDList[psecuritypriv->PMKIDIndex].PMKID, (u8 *)= pmksa->pmkid, WLAN_PMKID_LEN); =20 @@ -2134,11 +2104,9 @@ static netdev_tx_t rtw_cfg80211_monitor_if_xmit_entr= y(struct sk_buff *skb, struc pattrib->seqnum =3D pmlmeext->mgnt_seq; pmlmeext->mgnt_seq++; =20 - pattrib->last_txcmdsz =3D pattrib->pktlen; =20 dump_mgntframe(padapter, pmgntframe); - } =20 fail: @@ -2146,11 +2114,8 @@ static netdev_tx_t rtw_cfg80211_monitor_if_xmit_entr= y(struct sk_buff *skb, struc dev_kfree_skb_any(skb); =20 return NETDEV_TX_OK; - } =20 - - static const struct net_device_ops rtw_cfg80211_monitor_if_ops =3D { .ndo_start_xmit =3D rtw_cfg80211_monitor_if_xmit_entry, }; @@ -2323,7 +2288,6 @@ static int rtw_add_beacon(struct adapter *adapter, co= nst u8 *head, size_t head_l else ret =3D -EINVAL; =20 - kfree(pbuf); =20 return ret; @@ -2403,7 +2367,6 @@ static int cfg80211_rtw_del_station(struct wiphy *wip= hy, struct net_device *ndev return -EINVAL; } =20 - spin_lock_bh(&pstapriv->asoc_list_lock); =20 phead =3D &pstapriv->asoc_list; @@ -2422,9 +2385,7 @@ static int cfg80211_rtw_del_station(struct wiphy *wip= hy, struct net_device *ndev =20 break; } - } - } =20 spin_unlock_bh(&pstapriv->asoc_list_lock); @@ -2432,7 +2393,6 @@ static int cfg80211_rtw_del_station(struct wiphy *wip= hy, struct net_device *ndev associated_clients_update(padapter, updated); =20 return ret; - } =20 static int cfg80211_rtw_change_station(struct wiphy *wiphy, struct net_dev= ice *ndev, @@ -2464,7 +2424,6 @@ static struct sta_info *rtw_sta_info_get_by_idx(const= int idx, struct sta_priv * static int cfg80211_rtw_dump_station(struct wiphy *wiphy, struct net_devic= e *ndev, int idx, u8 *mac, struct station_info *sinfo) { - int ret =3D 0; struct adapter *padapter =3D rtw_netdev_priv(ndev); struct sta_info *psta =3D NULL; @@ -2567,7 +2526,6 @@ static int _cfg80211_rtw_mgmt_tx(struct adapter *pada= pter, u8 tx_ch, const u8 *b exit: =20 return ret; - } =20 static int cfg80211_rtw_mgmt_tx(struct wiphy *wiphy, @@ -2639,7 +2597,6 @@ static int cfg80211_rtw_mgmt_tx(struct wiphy *wiphy, =20 static void rtw_cfg80211_init_ht_capab(struct ieee80211_sta_ht_cap *ht_cap= , enum nl80211_band band) { - #define MAX_BIT_RATE_40MHZ_MCS15 300 /* Mbps */ #define MAX_BIT_RATE_40MHZ_MCS7 150 /* Mbps */ =20 @@ -2691,12 +2648,10 @@ void rtw_cfg80211_init_wiphy(struct adapter *padapt= er) =20 /* copy mac_addr to wiphy */ memcpy(wiphy->perm_addr, padapter->eeprompriv.mac_addr, ETH_ALEN); - } =20 static void rtw_cfg80211_preinit_wiphy(struct adapter *padapter, struct wi= phy *wiphy) { - wiphy->signal_type =3D CFG80211_SIGNAL_TYPE_MBM; =20 wiphy->max_scan_ssids =3D RTW_SSID_SCAN_AMOUNT; @@ -2843,7 +2798,6 @@ int rtw_wdev_alloc(struct adapter *padapter, struct d= evice *dev) wiphy_free(wiphy); exit: return ret; - } =20 void rtw_wdev_free(struct wireless_dev *wdev) --=20 2.39.2 (Apple Git-143) From nobody Sun Feb 8 15:01:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EADDEB64D9 for ; Mon, 19 Jun 2023 18:13:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232271AbjFSSNJ (ORCPT ); Mon, 19 Jun 2023 14:13:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232111AbjFSSNF (ORCPT ); Mon, 19 Jun 2023 14:13:05 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C67A1B0 for ; Mon, 19 Jun 2023 11:13:02 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-9887ebe16d0so235918766b.2 for ; Mon, 19 Jun 2023 11:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1687198380; x=1689790380; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k3lPC1NaG28i6896h3scqLwd/Pl9ZFzYUuPdAO/i3WU=; b=REouLqfcG5RmtqcrUPyseUPu3OEdrtRxbrg8YZAsp5AQW69nUfAtDDDj3sFCm7kVhr wwrj8CP68bwOtVBp3BnlUXl5gwDdLN/WsWLigk3e5kEYoKQUkgk20ECM4CawgVaWwVQl /0VKfixyOIEZbZw7a+l0qZvJpmpOF+x97uQtoBe85owCoGe+2PuHhbRymx25DIYDj2lX j13DdfYczEOGZp8N36RzmVPlW38OHZvouiXg+xVxB3txdXQrEWHgLhLatr9uNG1L0jDv BhQ3dOq3Bsxtasxhu8+bcl56H9MUZC8dSisBfHH3j5xVst6Wz+aHjafAp9nhDDaSQGXE amSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687198380; x=1689790380; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k3lPC1NaG28i6896h3scqLwd/Pl9ZFzYUuPdAO/i3WU=; b=X3nIswCorWhQZMSOoObQ2GWgqcJLbS47KeSi4/gWy1MceUkrIgK9dPSlzRjLA2vmP9 xCc/grKGQpTjdx9f/zJu4iMXAggVVbO9TuCG/L9CfEBgb17UYAJqL1JIkEfCwjcgpSMM nAJkcDszpkwsSbNMJaZfLaby0j3D8kjjtK4W9qbSZygOfgshyI++opPCcib+OozL45An RD5d1cqM6qGQ8P4Ltfi5Ak5Y4jTNv8xMXZVdXoTHHmRRIlJ1KOwYFYIiKnc8uD9SpQwZ Bvmoc8orgv7lsB7LKFoIRS2ZQQc21SJq18kCTdF+YamDr00abUUCwWqjeDKCVcOU7jwD PAJQ== X-Gm-Message-State: AC+VfDyBXaMraii4VPKNQnDzufXuCmqh4g3W71Pk5oXPQKzSPdAZUtcC yqMiAUh5pQHLAuVTp/HxDlw= X-Google-Smtp-Source: ACHHUZ5+bsTW94X154hZMIJPIV5jfq+bsCsgyITU/b4qM8u02y+nWwrEcxZ17RzZ/LNTQYYQ+yBBlw== X-Received: by 2002:a17:907:3fa3:b0:94e:116:8581 with SMTP id hr35-20020a1709073fa300b0094e01168581mr10957330ejc.5.1687198380447; Mon, 19 Jun 2023 11:13:00 -0700 (PDT) Received: from localhost.localdomain ([2a02:810a:9640:26a8:dcda:2154:7873:34]) by smtp.gmail.com with ESMTPSA id qu13-20020a170907110d00b00988781076e2sm30992ejb.78.2023.06.19.11.12.59 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 19 Jun 2023 11:13:00 -0700 (PDT) From: Franziska Naepelt X-Google-Original-From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: eperi1024@gmail.com, franziska.naepelt@gmail.com, gregkh@linuxfoundation.org, hdegoede@redhat.com, johannes.berg@intel.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, quic_vjakkam@quicinc.com, tegongkang@gmail.com Subject: [PATCH 5/5] staging: rtl8723bs: Fix alignment open parenthesis Date: Mon, 19 Jun 2023 20:12:58 +0200 Message-Id: <20230619181258.19152-1-franziska.naepelt@gmail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230619175703.18826-1-franziska.naepelt@gmail.com> References: <20230619175703.18826-1-franziska.naepelt@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch issues: - CHECK: Alignment should match open parenthesis Signed-off-by: Franziska Naepelt --- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 91 ++++++++++--------- 1 file changed, 49 insertions(+), 42 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index c00a377258d8..292cba045023 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -95,14 +95,14 @@ static struct ieee80211_channel rtw_2ghz_channels[] =3D= { static void rtw_2g_channels_init(struct ieee80211_channel *channels) { memcpy((void *)channels, (void *)rtw_2ghz_channels, - sizeof(struct ieee80211_channel) * RTW_2G_CHANNELS_NUM + sizeof(struct ieee80211_channel) * RTW_2G_CHANNELS_NUM ); } =20 static void rtw_2g_rates_init(struct ieee80211_rate *rates) { memcpy(rates, rtw_g_rates, - sizeof(struct ieee80211_rate) * RTW_G_RATES_NUM + sizeof(struct ieee80211_rate) * RTW_G_RATES_NUM ); } =20 @@ -275,7 +275,7 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl =20 /* We've set wiphy's signal_type as CFG80211_SIGNAL_TYPE_MBM: signal stre= ngth in mBm (100*dBm) */ if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true && - is_same_network(&pmlmepriv->cur_network.network, &pnetwork->network, 0))= { + is_same_network(&pmlmepriv->cur_network.network, &pnetwork->network, = 0)) { notify_signal =3D 100 * translate_percentage_to_dbm(padapter->recvpriv.s= ignal_strength);/* dbm */ } else { notify_signal =3D 100 * translate_percentage_to_dbm(pnetwork->network.ph= y_info.signal_strength);/* dbm */ @@ -313,7 +313,7 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl *((__le64 *)pbuf) =3D cpu_to_le64(notify_timestamp); =20 bss =3D cfg80211_inform_bss_frame(wiphy, notify_channel, (struct ieee8021= 1_mgmt *)buf, - len, notify_signal, GFP_ATOMIC); + len, notify_signal, GFP_ATOMIC); =20 if (unlikely(!bss)) goto exit; @@ -345,9 +345,9 @@ int rtw_cfg80211_check_bss(struct adapter *padapter) =20 notify_channel =3D ieee80211_get_channel(padapter->rtw_wdev->wiphy, freq); bss =3D cfg80211_get_bss(padapter->rtw_wdev->wiphy, notify_channel, - pnetwork->mac_address, pnetwork->ssid.ssid, - pnetwork->ssid.ssid_length, - IEEE80211_BSS_TYPE_ANY, IEEE80211_PRIVACY_ANY); + pnetwork->mac_address, pnetwork->ssid.ssid, + pnetwork->ssid.ssid_length, + IEEE80211_BSS_TYPE_ANY, IEEE80211_PRIVACY_ANY); =20 cfg80211_put_bss(padapter->rtw_wdev->wiphy, bss); =20 @@ -486,7 +486,7 @@ void rtw_cfg80211_indicate_disconnect(struct adapter *p= adapter) NULL, 0, true, GFP_ATOMIC); } else { cfg80211_connect_result(padapter->pnetdev, NULL, NULL, 0, NULL, 0, - WLAN_STATUS_UNSPECIFIED_FAILURE, GFP_ATOMIC/*GFP_KERNEL*/); + WLAN_STATUS_UNSPECIFIED_FAILURE, GFP_ATOMIC/*GFP_KERNEL*/); } } } @@ -777,7 +777,7 @@ static int rtw_cfg80211_set_encryption(struct net_devic= e *dev, struct ieee_param psta->ieee8021x_blocked =3D false; =20 if ((padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypt= ion2Enabled) || - (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypti= on3Enabled)) { + (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encryp= tion3Enabled)) { psta->dot118021XPrivacy =3D padapter->securitypriv.dot11PrivacyAlgrth= m; } =20 @@ -826,7 +826,7 @@ static int rtw_cfg80211_set_encryption(struct net_devic= e *dev, struct ieee_param pbcmc_sta->ieee8021x_blocked =3D false; =20 if ((padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypt= ion2Enabled) || - (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypti= on3Enabled)) { + (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encryp= tion3Enabled)) { pbcmc_sta->dot118021XPrivacy =3D padapter->securitypriv.dot11PrivacyA= lgrthm; } } @@ -944,9 +944,9 @@ static int cfg80211_rtw_del_key(struct wiphy *wiphy, st= ruct net_device *ndev, } =20 static int cfg80211_rtw_set_default_key(struct wiphy *wiphy, - struct net_device *ndev, int link_id, u8 key_index - , bool unicast, bool multicast - ) + struct net_device *ndev, int link_id, + u8 key_index, bool unicast, + bool multicast) { struct adapter *padapter =3D rtw_netdev_priv(ndev); struct security_priv *psecuritypriv =3D &padapter->securitypriv; @@ -1121,9 +1121,10 @@ void rtw_cfg80211_unlink_bss(struct adapter *padapte= r, struct wlan_network *pnet struct wlan_bssid_ex *select_network =3D &pnetwork->network; =20 bss =3D cfg80211_get_bss(wiphy, NULL/*notify_channel*/, - select_network->mac_address, select_network->ssid.ssid, - select_network->ssid.ssid_length, IEEE80211_BSS_TYPE_ANY, - IEEE80211_PRIVACY_ANY); + select_network->mac_address, + select_network->ssid.ssid, + select_network->ssid.ssid_length, + IEEE80211_BSS_TYPE_ANY, IEEE80211_PRIVACY_ANY); =20 if (bss) { cfg80211_unlink_bss(wiphy, bss); @@ -1328,7 +1329,7 @@ static int rtw_cfg80211_set_wpa_version(struct securi= ty_priv *psecuritypriv, u32 } =20 static int rtw_cfg80211_set_auth_type(struct security_priv *psecuritypriv, - enum nl80211_auth_type sme_auth_type) + enum nl80211_auth_type sme_auth_type) { switch (sme_auth_type) { case NL80211_AUTHTYPE_AUTOMATIC: @@ -1633,7 +1634,7 @@ static int cfg80211_rtw_leave_ibss(struct wiphy *wiph= y, struct net_device *ndev) } =20 static int cfg80211_rtw_connect(struct wiphy *wiphy, struct net_device *nd= ev, - struct cfg80211_connect_params *sme) + struct cfg80211_connect_params *sme) { int ret =3D 0; enum ndis_802_11_authentication_mode authmode; @@ -1708,7 +1709,7 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, = struct net_device *ndev, =20 /* For WEP Shared auth */ if ((psecuritypriv->dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_Shared || - psecuritypriv->dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_Auto) && sme-= >key) { + psecuritypriv->dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_Auto) && sme= ->key) { u32 wep_key_idx, wep_key_len, wep_total_len; struct ndis_802_11_wep *pwep =3D NULL; =20 @@ -1806,15 +1807,14 @@ static int cfg80211_rtw_disconnect(struct wiphy *wi= phy, struct net_device *ndev, } =20 static int cfg80211_rtw_set_txpower(struct wiphy *wiphy, - struct wireless_dev *wdev, - enum nl80211_tx_power_setting type, int mbm) + struct wireless_dev *wdev, + enum nl80211_tx_power_setting type, int mbm) { return 0; } =20 static int cfg80211_rtw_get_txpower(struct wiphy *wiphy, - struct wireless_dev *wdev, - int *dbm) + struct wireless_dev *wdev, int *dbm) { *dbm =3D (12); =20 @@ -2227,7 +2227,7 @@ static struct wireless_dev * } =20 static int cfg80211_rtw_del_virtual_intf(struct wiphy *wiphy, - struct wireless_dev *wdev + struct wireless_dev *wdev ) { struct net_device *ndev =3D wdev_to_ndev(wdev); @@ -2294,13 +2294,14 @@ static int rtw_add_beacon(struct adapter *adapter, = const u8 *head, size_t head_l } =20 static int cfg80211_rtw_start_ap(struct wiphy *wiphy, struct net_device *n= dev, - struct cfg80211_ap_settings *settings) + struct cfg80211_ap_settings *settings) { int ret =3D 0; struct adapter *adapter =3D rtw_netdev_priv(ndev); =20 - ret =3D rtw_add_beacon(adapter, settings->beacon.head, settings->beacon.h= ead_len, - settings->beacon.tail, settings->beacon.tail_len); + ret =3D rtw_add_beacon(adapter, settings->beacon.head, + settings->beacon.head_len, settings->beacon.tail, + settings->beacon.tail_len); =20 adapter->mlmeextpriv.mlmext_info.hidden_ssid_mode =3D settings->hidden_ss= id; =20 @@ -2317,8 +2318,9 @@ static int cfg80211_rtw_start_ap(struct wiphy *wiphy,= struct net_device *ndev, return ret; } =20 -static int cfg80211_rtw_change_beacon(struct wiphy *wiphy, struct net_devi= ce *ndev, - struct cfg80211_beacon_data *info) +static int cfg80211_rtw_change_beacon(struct wiphy *wiphy, + struct net_device *ndev, + struct cfg80211_beacon_data *info) { struct adapter *adapter =3D rtw_netdev_priv(ndev); =20 @@ -2331,9 +2333,10 @@ static int cfg80211_rtw_stop_ap(struct wiphy *wiphy,= struct net_device *ndev, return 0; } =20 -static int cfg80211_rtw_add_station(struct wiphy *wiphy, struct net_device= *ndev, - const u8 *mac, - struct station_parameters *params) +static int cfg80211_rtw_add_station(struct wiphy *wiphy, + struct net_device *ndev, + const u8 *mac, + struct station_parameters *params) { return 0; } @@ -2395,8 +2398,10 @@ static int cfg80211_rtw_del_station(struct wiphy *wi= phy, struct net_device *ndev return ret; } =20 -static int cfg80211_rtw_change_station(struct wiphy *wiphy, struct net_dev= ice *ndev, - const u8 *mac, struct station_parameters *params) +static int cfg80211_rtw_change_station(struct wiphy *wiphy, + struct net_device *ndev, + const u8 *mac, + struct station_parameters *params) { return 0; } @@ -2421,8 +2426,10 @@ static struct sta_info *rtw_sta_info_get_by_idx(cons= t int idx, struct sta_priv * return psta; } =20 -static int cfg80211_rtw_dump_station(struct wiphy *wiphy, struct net_devic= e *ndev, - int idx, u8 *mac, struct station_info *sinfo) +static int cfg80211_rtw_dump_station(struct wiphy *wiphy, + struct net_device *ndev, + int idx, u8 *mac, + struct station_info *sinfo) { int ret =3D 0; struct adapter *padapter =3D rtw_netdev_priv(ndev); @@ -2444,8 +2451,9 @@ static int cfg80211_rtw_dump_station(struct wiphy *wi= phy, struct net_device *nde return ret; } =20 -static int cfg80211_rtw_change_bss(struct wiphy *wiphy, struct net_device = *ndev, - struct bss_parameters *params) +static int cfg80211_rtw_change_bss(struct wiphy *wiphy, + struct net_device *ndev, + struct bss_parameters *params) { return 0; } @@ -2528,10 +2536,9 @@ static int _cfg80211_rtw_mgmt_tx(struct adapter *pad= apter, u8 tx_ch, const u8 *b return ret; } =20 -static int cfg80211_rtw_mgmt_tx(struct wiphy *wiphy, - struct wireless_dev *wdev, - struct cfg80211_mgmt_tx_params *params, - u64 *cookie) +static int cfg80211_rtw_mgmt_tx(struct wiphy *wiphy, struct wireless_dev *= wdev, + struct cfg80211_mgmt_tx_params *params, + u64 *cookie) { struct net_device *ndev =3D wdev_to_ndev(wdev); struct ieee80211_channel *chan =3D params->chan; --=20 2.39.2 (Apple Git-143)