From nobody Sun Feb 8 16:06:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF508EB64DA for ; Mon, 19 Jun 2023 13:07:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231874AbjFSNHB (ORCPT ); Mon, 19 Jun 2023 09:07:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231768AbjFSNGZ (ORCPT ); Mon, 19 Jun 2023 09:06:25 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAD1B1706 for ; Mon, 19 Jun 2023 06:05:14 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-543ae6ce8d1so2818129a12.2 for ; Mon, 19 Jun 2023 06:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1687179909; x=1689771909; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XbDj0tuIsqmd9Jb0jvnKqTFsbroelomAP4JxfiYyGMc=; b=UA8q5LtBb0Ykh3MFbdGnfMFxTLoX6PI5I+bsDyEpHus9uTAEWP2yotngxINlDm3Dai 3YiYw+uTYqOMlR+98nC7buF9L6dLMJJ2p5v6+CrjpvFnkzP4vSq2/lfRGGSkgB13awG/ ehipcwsazCyFrhWw0vE/vjdkponpzHJ1JraXQLaShlRvGwMX0/tX5GrX5Ry8CNlY68Sj ka5N5zANVdqW+vGGUWiFIGzH1rZZKPxxGWTIBq3BrFDiXuL1eYUKLnWUwnVUXSgvChQq M6GBny0MHWbHYsnohmZfLj2MnkgepVQAYLHrrlooxS2jbH5m1n6EI4jIGWomLvJ4C3yp llAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687179909; x=1689771909; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XbDj0tuIsqmd9Jb0jvnKqTFsbroelomAP4JxfiYyGMc=; b=cnTwef5GLrXoeJLRW3OlAGC+Lhp2/+EiWmmdtz23j4CKPEc7oUyPEFrzgB+NEe9Lbt SZlez6FN/Dz2mtq455/oVwkL7EbzEyUVyfJLWlPle3Hk87fRql5hug2y5RpAn77WDzzZ 5B7qn3vcZuuqiT5F2Dqd9Y+nXs2DkxEySaFIZLM70sQygA5FcwGDpUeD/26CV0A+qi// t5mzxQy61/vCU+5LbL3ngfR+w9rqNAKcQp0SzrpRUnaSzePRs53OzUGueGW2nChnfvXa rOYU5bFtPhZLcP6QwNPp3Jxtsf0ndfFfot4lOEjU7hYDcnWspdWFOZ7uYcy1L3VFWbwx 2CwA== X-Gm-Message-State: AC+VfDzlDMFuX907GHec4u3QRkkfSxlWnRxGkV4UYLv2x/eiIXW46+ll h1xWlTHX5OsD7+ygV26TdH3W0viuGNd0Q44syk7z9Drd X-Google-Smtp-Source: ACHHUZ61V3ZMnYG41ClCRZ+rfd2TfsBGK3nyq4MLTfcXQzlnSEZTBbraxSM5XwAVEsYRCan4M+gbYA== X-Received: by 2002:a17:902:ea8a:b0:1aa:d545:462e with SMTP id x10-20020a170902ea8a00b001aad545462emr9637270plb.13.1687179909415; Mon, 19 Jun 2023 06:05:09 -0700 (PDT) Received: from ubuntu-hf2.default.svc.cluster.local ([101.127.248.173]) by smtp.gmail.com with ESMTPSA id l13-20020a170903120d00b001b53953f306sm5236052plh.178.2023.06.19.06.05.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 06:05:09 -0700 (PDT) From: Haifeng Xu To: mhocko@suse.com Cc: akpm@linux-foundation.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, roman.gushchin@linux.dev, shakeelb@google.com, Haifeng Xu Subject: [PATCH v2] mm/memcontrol: do not tweak node in mem_cgroup_init() Date: Mon, 19 Jun 2023 13:04:42 +0000 Message-Id: <20230619130442.2487-1-haifeng.xu@shopee.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" mem_cgroup_init() request for allocations from each possible node, and it's used to be a problem because NODE_DATA is not allocated for offline node. Things have already changed since commit 09f49dca570a9 ("mm: handle uninitialized numa nodes gracefully"), so it's unnecessary to check for !node_online nodes here. How to test? qemu-system-x86_64 \ -kernel vmlinux \ -initrd full.rootfs.cpio.gz \ -append "console=3DttyS0,115200 root=3D/dev/ram0 nokaslr earlyprintk=3Dse= rial oops=3Dpanic panic_on_warn" \ -drive format=3Dqcow2,file=3Dvm_disk.qcow2,media=3Ddisk,if=3Dide \ -enable-kvm \ -cpu host \ -m 8G,slots=3D2,maxmem=3D16G \ -smp cores=3D4,threads=3D1,sockets=3D2 \ -object memory-backend-ram,id=3Dmem0,size=3D4G \ -object memory-backend-ram,id=3Dmem1,size=3D4G \ -numa node,memdev=3Dmem0,cpus=3D0-3,nodeid=3D0 \ -numa node,memdev=3Dmem1,cpus=3D4-7,nodeid=3D1 \ -numa node,nodeid=3D2 \ -net nic,model=3Dvirtio,macaddr=3D52:54:00:12:34:58 \ -net user \ -nographic \ -rtc base=3Dlocaltime \ -gdb tcp::6000 Guest state when booting: [ 0.048881] NUMA: Node 0 [mem 0x00000000-0x0009ffff] + [mem 0x00100000-0= xbfffffff] -> [mem 0x00000000-0xbfffffff] [ 0.050489] NUMA: Node 0 [mem 0x00000000-0xbfffffff] + [mem 0x100000000-= 0x13fffffff] -> [mem 0x00000000-0x13fffffff] [ 0.052173] NODE_DATA(0) allocated [mem 0x13fffc000-0x13fffffff] [ 0.053164] NODE_DATA(1) allocated [mem 0x23fffa000-0x23fffdfff] [ 0.054187] Zone ranges: [ 0.054587] DMA [mem 0x0000000000001000-0x0000000000ffffff] [ 0.055551] DMA32 [mem 0x0000000001000000-0x00000000ffffffff] [ 0.056515] Normal [mem 0x0000000100000000-0x000000023fffffff] [ 0.057484] Movable zone start for each node [ 0.058149] Early memory node ranges [ 0.058705] node 0: [mem 0x0000000000001000-0x000000000009efff] [ 0.059679] node 0: [mem 0x0000000000100000-0x00000000bffdffff] [ 0.060659] node 0: [mem 0x0000000100000000-0x000000013fffffff] [ 0.061649] node 1: [mem 0x0000000140000000-0x000000023fffffff] [ 0.062638] Initmem setup node 0 [mem 0x0000000000001000-0x000000013ffff= fff] [ 0.063745] Initmem setup node 1 [mem 0x0000000140000000-0x000000023ffff= fff] [ 0.064855] DMA zone: 158 reserved pages exceeds freesize 0 [ 0.065746] Initializing node 2 as memoryless [ 0.066437] Initmem setup node 2 as memoryless [ 0.067132] DMA zone: 158 reserved pages exceeds freesize 0 [ 0.068037] On node 0, zone DMA: 1 pages in unavailable ranges [ 0.068265] On node 0, zone DMA: 97 pages in unavailable ranges [ 0.124755] On node 0, zone Normal: 32 pages in unavailable ranges cat /sys/devices/system/node/online 0-1 cat /sys/devices/system/node/possible 0-2 Signed-off-by: Haifeng Xu Acked-by: Michal Hocko --- v2: - extend changelog by test steps --- mm/memcontrol.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 4b27e245a055..c73c5fb33f65 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -7421,8 +7421,7 @@ static int __init mem_cgroup_init(void) for_each_node(node) { struct mem_cgroup_tree_per_node *rtpn; =20 - rtpn =3D kzalloc_node(sizeof(*rtpn), GFP_KERNEL, - node_online(node) ? node : NUMA_NO_NODE); + rtpn =3D kzalloc_node(sizeof(*rtpn), GFP_KERNEL, node); =20 rtpn->rb_root =3D RB_ROOT; rtpn->rb_rightmost =3D NULL; --=20 2.25.1