From nobody Tue Feb 10 05:25:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC707EB64DB for ; Mon, 19 Jun 2023 11:40:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231785AbjFSLk2 (ORCPT ); Mon, 19 Jun 2023 07:40:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230206AbjFSLkX (ORCPT ); Mon, 19 Jun 2023 07:40:23 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5202116; Mon, 19 Jun 2023 04:40:22 -0700 (PDT) Received: from desky.lan (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 804AA547; Mon, 19 Jun 2023 13:39:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1687174787; bh=90PzYNLWixBUyL3/eSoLzMJaEMkB7Asvs7U2pXzyuG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=phYHN58NjLoPC7rE3G6gJEGQ+sU6Wa43jPuNqLWTryrFoUChmnBdgD5tzzeqBJB7s NiwS68bgvwDG512H7SWZt73m5c6hyOcjccm0UBOaZTyCEUlhRV9d+TChi383BHH+5V H9M7PhnUSd6VLxQ22lDgISLEqAmIPgqZC+i4BaiY= From: Tomi Valkeinen To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Sakari Ailus , Laurent Pinchart , Jacopo Mondi , Jai Luthra , Vaishnav Achath Cc: Tomi Valkeinen Subject: [PATCH v4 1/4] media: ti: cal: Clean up mbus formats uses Date: Mon, 19 Jun 2023 14:40:04 +0300 Message-Id: <20230619114007.297393-2-tomi.valkeinen@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230619114007.297393-1-tomi.valkeinen@ideasonboard.com> References: <20230619114007.297393-1-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Clean up the CAL drivers uses of mbus formats: - Switch all YUV formats from 2X8 formats to 1X16, as those are what should be used for CSI-2 bus. - Drop 24 and 32 bit formats, as the driver doesn't support them (see cal_ctx_pix_proc_config()). - Switch RGB565_2X8_LE to RGB565_1X16 (for the same reason as for the YUV formats) and drop RGB565_2X8_BE as it cannot be supported with CSI-2. Signed-off-by: Tomi Valkeinen Reviewed-by: Jacopo Mondi --- drivers/media/platform/ti/cal/cal-camerarx.c | 2 +- drivers/media/platform/ti/cal/cal-video.c | 2 +- drivers/media/platform/ti/cal/cal.c | 36 ++++---------------- 3 files changed, 8 insertions(+), 32 deletions(-) diff --git a/drivers/media/platform/ti/cal/cal-camerarx.c b/drivers/media/p= latform/ti/cal/cal-camerarx.c index 16ae52879a79..267089b0fea0 100644 --- a/drivers/media/platform/ti/cal/cal-camerarx.c +++ b/drivers/media/platform/ti/cal/cal-camerarx.c @@ -817,7 +817,7 @@ static int cal_camerarx_sd_init_cfg(struct v4l2_subdev = *sd, .format =3D { .width =3D 640, .height =3D 480, - .code =3D MEDIA_BUS_FMT_UYVY8_2X8, + .code =3D MEDIA_BUS_FMT_UYVY8_1X16, .field =3D V4L2_FIELD_NONE, .colorspace =3D V4L2_COLORSPACE_SRGB, .ycbcr_enc =3D V4L2_YCBCR_ENC_601, diff --git a/drivers/media/platform/ti/cal/cal-video.c b/drivers/media/plat= form/ti/cal/cal-video.c index ca906a9e4222..ed92e23d4b16 100644 --- a/drivers/media/platform/ti/cal/cal-video.c +++ b/drivers/media/platform/ti/cal/cal-video.c @@ -894,7 +894,7 @@ static int cal_ctx_v4l2_init_mc_format(struct cal_ctx *= ctx) const struct cal_format_info *fmtinfo; struct v4l2_pix_format *pix_fmt =3D &ctx->v_fmt.fmt.pix; =20 - fmtinfo =3D cal_format_by_code(MEDIA_BUS_FMT_UYVY8_2X8); + fmtinfo =3D cal_format_by_code(MEDIA_BUS_FMT_UYVY8_1X16); if (!fmtinfo) return -EINVAL; =20 diff --git a/drivers/media/platform/ti/cal/cal.c b/drivers/media/platform/t= i/cal/cal.c index 9c5105223d6b..18d86f6ae809 100644 --- a/drivers/media/platform/ti/cal/cal.c +++ b/drivers/media/platform/ti/cal/cal.c @@ -61,48 +61,24 @@ MODULE_PARM_DESC(mc_api, "activates the MC API"); const struct cal_format_info cal_formats[] =3D { { .fourcc =3D V4L2_PIX_FMT_YUYV, - .code =3D MEDIA_BUS_FMT_YUYV8_2X8, + .code =3D MEDIA_BUS_FMT_YUYV8_1X16, .bpp =3D 16, }, { .fourcc =3D V4L2_PIX_FMT_UYVY, - .code =3D MEDIA_BUS_FMT_UYVY8_2X8, + .code =3D MEDIA_BUS_FMT_UYVY8_1X16, .bpp =3D 16, }, { .fourcc =3D V4L2_PIX_FMT_YVYU, - .code =3D MEDIA_BUS_FMT_YVYU8_2X8, + .code =3D MEDIA_BUS_FMT_YVYU8_1X16, .bpp =3D 16, }, { .fourcc =3D V4L2_PIX_FMT_VYUY, - .code =3D MEDIA_BUS_FMT_VYUY8_2X8, + .code =3D MEDIA_BUS_FMT_VYUY8_1X16, .bpp =3D 16, }, { - .fourcc =3D V4L2_PIX_FMT_RGB565, /* gggbbbbb rrrrrggg */ - .code =3D MEDIA_BUS_FMT_RGB565_2X8_LE, + .fourcc =3D V4L2_PIX_FMT_RGB565, + .code =3D MEDIA_BUS_FMT_RGB565_1X16, .bpp =3D 16, - }, { - .fourcc =3D V4L2_PIX_FMT_RGB565X, /* rrrrrggg gggbbbbb */ - .code =3D MEDIA_BUS_FMT_RGB565_2X8_BE, - .bpp =3D 16, - }, { - .fourcc =3D V4L2_PIX_FMT_RGB555, /* gggbbbbb arrrrrgg */ - .code =3D MEDIA_BUS_FMT_RGB555_2X8_PADHI_LE, - .bpp =3D 16, - }, { - .fourcc =3D V4L2_PIX_FMT_RGB555X, /* arrrrrgg gggbbbbb */ - .code =3D MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE, - .bpp =3D 16, - }, { - .fourcc =3D V4L2_PIX_FMT_RGB24, /* rgb */ - .code =3D MEDIA_BUS_FMT_RGB888_2X12_LE, - .bpp =3D 24, - }, { - .fourcc =3D V4L2_PIX_FMT_BGR24, /* bgr */ - .code =3D MEDIA_BUS_FMT_RGB888_2X12_BE, - .bpp =3D 24, - }, { - .fourcc =3D V4L2_PIX_FMT_RGB32, /* argb */ - .code =3D MEDIA_BUS_FMT_ARGB8888_1X32, - .bpp =3D 32, }, { .fourcc =3D V4L2_PIX_FMT_SBGGR8, .code =3D MEDIA_BUS_FMT_SBGGR8_1X8, --=20 2.34.1