From nobody Sun Feb 8 10:44:12 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78254EB64DC for ; Sat, 17 Jun 2023 22:23:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232531AbjFQWXU (ORCPT ); Sat, 17 Jun 2023 18:23:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231571AbjFQWXO (ORCPT ); Sat, 17 Jun 2023 18:23:14 -0400 Received: from s.wrqvtbkv.outbound-mail.sendgrid.net (s.wrqvtbkv.outbound-mail.sendgrid.net [149.72.123.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3907110F5 for ; Sat, 17 Jun 2023 15:23:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=from:subject:in-reply-to:references:mime-version:to:cc: content-transfer-encoding:content-type:cc:content-type:from:subject:to; s=s1; bh=knW5hfOdRlNb6ad4KcvWMFXEOrQEnk5DYqTPo5HmSZE=; b=Lcs4O2j3t0Zya8gHh1y5Xz1vPnnl19E8vEuvH6W8bEEnX+iTrflGvDeo1iZzMttdvVL+ 98xgNX3tnCR8MrbFidbigyG/aE4uhdKJDEp0YEq++j+djJJlE/DWVKJ4NczNF+N/3DFhyw VtLIdf3jFLfBo4Uzv6ppFPZdBJBEDPq1fsZAcxAu66me8wCPAxwun24TTtffKiNE8jqg39 amqDdIg9yeNRgixtwQ45aS3cCHoKVNRmlGPfRK65vQ6RswoMdT5lVyUIVkstnKvLcAXpkB //k+G6QHah1WTLcZ0Z1XQL6P2OivTVqscp00Gi5avguR1rdChqWbf+40lYB4AvQg== Received: by filterdrecv-66949dbc98-dbt7m with SMTP id filterdrecv-66949dbc98-dbt7m-1-648E3250-7 2023-06-17 22:23:12.210230445 +0000 UTC m=+3278605.771189366 Received: from bionic.localdomain (unknown) by geopod-ismtpd-1 (SG) with ESMTP id 4XYLAl6XSH2KsNiMfk1_gA Sat, 17 Jun 2023 22:23:12.024 +0000 (UTC) From: Jonas Karlman Subject: [PATCH v3 1/2] drm/fourcc: Add NV20 and NV30 YUV formats Date: Sat, 17 Jun 2023 22:23:12 +0000 (UTC) Message-Id: <20230617222307.3145714-2-jonas@kwiboo.se> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230617222307.3145714-1-jonas@kwiboo.se> References: <20230617222307.3145714-1-jonas@kwiboo.se> MIME-Version: 1.0 X-SG-EID: =?us-ascii?Q?TdbjyGynYnRZWhH+7lKUQJL+ZxmxpowvO2O9SQF5CwCVrYgcwUXgU5DKUU3QxA?= =?us-ascii?Q?fZekEeQsTe+RrMu3cja6a0h=2FnEEJCFmPMWB71Ft?= =?us-ascii?Q?+V7t0A=2FzSB2WM2Yr+B+lLlEGl35eOZtuuZWJsdu?= =?us-ascii?Q?F1uSpyKMXxuqrraykNbNcSNPUH9XsC2mI9giyEV?= =?us-ascii?Q?wwlTRHnBnJKPviaxCHD6r2mBMSuvhCMrD307Un6?= =?us-ascii?Q?P5ZoC9nGUVA+oa=2FvsmzKMnhOYMLpH5Akpemi1V?= To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Sandy Huang , Heiko Stuebner Cc: dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jonas Karlman X-Entity-ID: P7KYpSJvGCELWjBME/J5tg== Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" DRM_FORMAT_NV20 and DRM_FORMAT_NV30 formats is the 2x1 and non-subsampled variant of NV15, a 10-bit 2-plane YUV format that has no padding between components. Instead, luminance and chrominance samples are grouped into 4s so that each group is packed into an integer number of bytes: YYYY =3D UVUV =3D 4 * 10 bits =3D 40 bits =3D 5 bytes The '20' and '30' suffix refers to the optimum effective bits per pixel which is achieved when the total number of luminance samples is a multiple of 4. V2: Added NV30 format Signed-off-by: Jonas Karlman Reviewed-by: Sandy Huang --- drivers/gpu/drm/drm_fourcc.c | 8 ++++++++ include/uapi/drm/drm_fourcc.h | 2 ++ 2 files changed, 10 insertions(+) diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c index 0f17dfa8702b..193cf8ed7912 100644 --- a/drivers/gpu/drm/drm_fourcc.c +++ b/drivers/gpu/drm/drm_fourcc.c @@ -299,6 +299,14 @@ const struct drm_format_info *__drm_format_info(u32 fo= rmat) .num_planes =3D 2, .char_per_block =3D { 5, 5, 0 }, .block_w =3D { 4, 2, 0 }, .block_h =3D { 1, 1, 0 }, .hsub =3D 2, .vsub =3D 2, .is_yuv =3D true }, + { .format =3D DRM_FORMAT_NV20, .depth =3D 0, + .num_planes =3D 2, .char_per_block =3D { 5, 5, 0 }, + .block_w =3D { 4, 2, 0 }, .block_h =3D { 1, 1, 0 }, .hsub =3D 2, + .vsub =3D 1, .is_yuv =3D true }, + { .format =3D DRM_FORMAT_NV30, .depth =3D 0, + .num_planes =3D 2, .char_per_block =3D { 5, 5, 0 }, + .block_w =3D { 4, 2, 0 }, .block_h =3D { 1, 1, 0 }, .hsub =3D 1, + .vsub =3D 1, .is_yuv =3D true }, { .format =3D DRM_FORMAT_Q410, .depth =3D 0, .num_planes =3D 3, .char_per_block =3D { 2, 2, 2 }, .block_w =3D { 1, 1, 1 }, .block_h =3D { 1, 1, 1 }, .hsub =3D 1, diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index 8db7fd3f743e..3151f1fc7ebb 100644 --- a/include/uapi/drm/drm_fourcc.h +++ b/include/uapi/drm/drm_fourcc.h @@ -323,6 +323,8 @@ extern "C" { * index 1 =3D Cr:Cb plane, [39:0] Cr1:Cb1:Cr0:Cb0 little endian */ #define DRM_FORMAT_NV15 fourcc_code('N', 'V', '1', '5') /* 2x2 subsampled= Cr:Cb plane */ +#define DRM_FORMAT_NV20 fourcc_code('N', 'V', '2', '0') /* 2x1 subsampled= Cr:Cb plane */ +#define DRM_FORMAT_NV30 fourcc_code('N', 'V', '3', '0') /* non-subsampled= Cr:Cb plane */ =20 /* * 2 plane YCbCr MSB aligned --=20 2.40.1 From nobody Sun Feb 8 10:44:12 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F273EB64DA for ; Sat, 17 Jun 2023 22:23:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232757AbjFQWXW (ORCPT ); Sat, 17 Jun 2023 18:23:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232065AbjFQWXQ (ORCPT ); Sat, 17 Jun 2023 18:23:16 -0400 Received: from s.wrqvtzvf.outbound-mail.sendgrid.net (s.wrqvtzvf.outbound-mail.sendgrid.net [149.72.126.143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0452B10E0 for ; Sat, 17 Jun 2023 15:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=from:subject:in-reply-to:references:mime-version:to:cc: content-transfer-encoding:content-type:cc:content-type:from:subject:to; s=s1; bh=In9jXU/Xmc90ShXMfHKgvGxvsps9jJbDF/D42oeosxM=; b=f5OSXAF0iGtb4udg0YVYucbfwZeIk6ReJVzTnE562VDQ2IQXiN9oPimZEWkzNRcg3YlU Kf89B0WsEGLy0RUAON+z96YFuNcGPDvrjePeGGqtPJhAMw01K7Rl5hkbU9xpOHi1JjrCuD 7M7ozbb8t/n2AsdjdlrIqR4aiZbxmo90xZfdC/5xg6A1Gix/mcHH2NYlTHWoP8LtNAdu2+ +TFTuX8MlWvODEz2OIsKyTc5J8GVVDGjkGcPAlmFmVc9Yfvaan38YDVMl32fn1GGyw3BpL RxyqaiTmZcUP8pB74lWkRjhToBxyAmU3xhE0bKEayoy767hXv3F41wC7zfmBPIRQ== Received: by filterdrecv-canary-78ff49ff78-6jdhb with SMTP id filterdrecv-canary-78ff49ff78-6jdhb-1-648E3251-31 2023-06-17 22:23:13.974305074 +0000 UTC m=+3278615.968239283 Received: from bionic.localdomain (unknown) by geopod-ismtpd-1 (SG) with ESMTP id V8aP4NOAQ_-U3xk-8FFjJg Sat, 17 Jun 2023 22:23:13.695 +0000 (UTC) From: Jonas Karlman Subject: [PATCH v3 2/2] drm/rockchip: vop: Add NV15, NV20 and NV30 support Date: Sat, 17 Jun 2023 22:23:14 +0000 (UTC) Message-Id: <20230617222307.3145714-3-jonas@kwiboo.se> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230617222307.3145714-1-jonas@kwiboo.se> References: <20230617222307.3145714-1-jonas@kwiboo.se> MIME-Version: 1.0 X-SG-EID: =?us-ascii?Q?TdbjyGynYnRZWhH+7lKUQJL+ZxmxpowvO2O9SQF5CwCVrYgcwUXgU5DKUU3QxA?= =?us-ascii?Q?fZekEeQsTe+RrMu3cja6a0h6i1hv+OZJVIZNLFe?= =?us-ascii?Q?BUB6rZ5yOxRN6V3ryls9aLxT7Au4q7aBvoO6NbC?= =?us-ascii?Q?14xqEU0E9j+eD0WG1hBLHyO=2FHHqrQE5ekiIn5oF?= =?us-ascii?Q?j0dcRQSbJ0hiYk0NIK70+hOLoL53gAKvWUJvV99?= =?us-ascii?Q?EKEwEhUkcJe=2FS669FDfJMJM6qBIYw5PsONIvvv4?= =?us-ascii?Q?6ZXzqsUNTOBR7aMSWy1tA=3D=3D?= To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Sandy Huang , Heiko Stuebner Cc: dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jonas Karlman X-Entity-ID: P7KYpSJvGCELWjBME/J5tg== Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add support for displaying 10-bit 4:2:0 and 4:2:2 formats produced by the Rockchip Video Decoder on RK322X, RK3288, RK3328, RK3368 and RK3399. Also add support for 10-bit 4:4:4 format while at it. V2: Added NV30 support Signed-off-by: Jonas Karlman Reviewed-by: Sandy Huang --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 29 +++++++++++++++++-- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 + drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 32 +++++++++++++++++---- 3 files changed, 54 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/= rockchip/rockchip_drm_vop.c index 60b23636a3fe..3984265a6d8f 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -273,6 +273,18 @@ static bool has_uv_swapped(uint32_t format) } } =20 +static bool is_fmt_10(uint32_t format) +{ + switch (format) { + case DRM_FORMAT_NV15: + case DRM_FORMAT_NV20: + case DRM_FORMAT_NV30: + return true; + default: + return false; + } +} + static enum vop_data_format vop_convert_format(uint32_t format) { switch (format) { @@ -288,12 +300,15 @@ static enum vop_data_format vop_convert_format(uint32= _t format) case DRM_FORMAT_BGR565: return VOP_FMT_RGB565; case DRM_FORMAT_NV12: + case DRM_FORMAT_NV15: case DRM_FORMAT_NV21: return VOP_FMT_YUV420SP; case DRM_FORMAT_NV16: + case DRM_FORMAT_NV20: case DRM_FORMAT_NV61: return VOP_FMT_YUV422SP; case DRM_FORMAT_NV24: + case DRM_FORMAT_NV30: case DRM_FORMAT_NV42: return VOP_FMT_YUV444SP; default: @@ -944,7 +959,12 @@ static void vop_plane_atomic_update(struct drm_plane *= plane, dsp_sty =3D dest->y1 + crtc->mode.vtotal - crtc->mode.vsync_start; dsp_st =3D dsp_sty << 16 | (dsp_stx & 0xffff); =20 - offset =3D (src->x1 >> 16) * fb->format->cpp[0]; + if (fb->format->block_w[0]) + offset =3D (src->x1 >> 16) * fb->format->char_per_block[0] / + fb->format->block_w[0]; + else + offset =3D (src->x1 >> 16) * fb->format->cpp[0]; + offset +=3D (src->y1 >> 16) * fb->pitches[0]; dma_addr =3D rk_obj->dma_addr + offset + fb->offsets[0]; =20 @@ -970,6 +990,7 @@ static void vop_plane_atomic_update(struct drm_plane *p= lane, } =20 VOP_WIN_SET(vop, win, format, format); + VOP_WIN_SET(vop, win, fmt_10, is_fmt_10(fb->format->format)); VOP_WIN_SET(vop, win, yrgb_vir, DIV_ROUND_UP(fb->pitches[0], 4)); VOP_WIN_SET(vop, win, yrgb_mst, dma_addr); VOP_WIN_YUV2YUV_SET(vop, win_yuv2yuv, y2r_en, is_yuv); @@ -986,7 +1007,11 @@ static void vop_plane_atomic_update(struct drm_plane = *plane, uv_obj =3D fb->obj[1]; rk_uv_obj =3D to_rockchip_obj(uv_obj); =20 - offset =3D (src->x1 >> 16) * bpp / hsub; + if (fb->format->block_w[1]) + offset =3D (src->x1 >> 16) * bpp / + fb->format->block_w[1] / hsub; + else + offset =3D (src->x1 >> 16) * bpp / hsub; offset +=3D (src->y1 >> 16) * fb->pitches[1] / vsub; =20 dma_addr =3D rk_uv_obj->dma_addr + offset + fb->offsets[1]; diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h b/drivers/gpu/drm/= rockchip/rockchip_drm_vop.h index 5f56e0597df8..4b2daefeb8c1 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.h @@ -186,6 +186,7 @@ struct vop_win_phy { struct vop_reg enable; struct vop_reg gate; struct vop_reg format; + struct vop_reg fmt_10; struct vop_reg rb_swap; struct vop_reg uv_swap; struct vop_reg act_info; diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/= rockchip/rockchip_vop_reg.c index 20ac7811c5eb..7f72dcac6f0e 100644 --- a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c +++ b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c @@ -53,6 +53,23 @@ static const uint32_t formats_win_full[] =3D { DRM_FORMAT_NV42, }; =20 +static const uint32_t formats_win_full_10[] =3D { + DRM_FORMAT_XRGB8888, + DRM_FORMAT_ARGB8888, + DRM_FORMAT_XBGR8888, + DRM_FORMAT_ABGR8888, + DRM_FORMAT_RGB888, + DRM_FORMAT_BGR888, + DRM_FORMAT_RGB565, + DRM_FORMAT_BGR565, + DRM_FORMAT_NV12, + DRM_FORMAT_NV16, + DRM_FORMAT_NV24, + DRM_FORMAT_NV15, + DRM_FORMAT_NV20, + DRM_FORMAT_NV30, +}; + static const uint64_t format_modifiers_win_full[] =3D { DRM_FORMAT_MOD_LINEAR, DRM_FORMAT_MOD_INVALID, @@ -627,11 +644,12 @@ static const struct vop_scl_regs rk3288_win_full_scl = =3D { =20 static const struct vop_win_phy rk3288_win01_data =3D { .scl =3D &rk3288_win_full_scl, - .data_formats =3D formats_win_full, - .nformats =3D ARRAY_SIZE(formats_win_full), + .data_formats =3D formats_win_full_10, + .nformats =3D ARRAY_SIZE(formats_win_full_10), .format_modifiers =3D format_modifiers_win_full, .enable =3D VOP_REG(RK3288_WIN0_CTRL0, 0x1, 0), .format =3D VOP_REG(RK3288_WIN0_CTRL0, 0x7, 1), + .fmt_10 =3D VOP_REG(RK3288_WIN0_CTRL0, 0x1, 4), .rb_swap =3D VOP_REG(RK3288_WIN0_CTRL0, 0x1, 12), .uv_swap =3D VOP_REG(RK3288_WIN0_CTRL0, 0x1, 15), .act_info =3D VOP_REG(RK3288_WIN0_ACT_INFO, 0x1fff1fff, 0), @@ -768,11 +786,12 @@ static const struct vop_intr rk3368_vop_intr =3D { =20 static const struct vop_win_phy rk3368_win01_data =3D { .scl =3D &rk3288_win_full_scl, - .data_formats =3D formats_win_full, - .nformats =3D ARRAY_SIZE(formats_win_full), + .data_formats =3D formats_win_full_10, + .nformats =3D ARRAY_SIZE(formats_win_full_10), .format_modifiers =3D format_modifiers_win_full, .enable =3D VOP_REG(RK3368_WIN0_CTRL0, 0x1, 0), .format =3D VOP_REG(RK3368_WIN0_CTRL0, 0x7, 1), + .fmt_10 =3D VOP_REG(RK3368_WIN0_CTRL0, 0x1, 4), .rb_swap =3D VOP_REG(RK3368_WIN0_CTRL0, 0x1, 12), .uv_swap =3D VOP_REG(RK3368_WIN0_CTRL0, 0x1, 15), .x_mir_en =3D VOP_REG(RK3368_WIN0_CTRL0, 0x1, 21), @@ -938,11 +957,12 @@ static const struct vop_win_yuv2yuv_data rk3399_vop_b= ig_win_yuv2yuv_data[] =3D { =20 static const struct vop_win_phy rk3399_win01_data =3D { .scl =3D &rk3288_win_full_scl, - .data_formats =3D formats_win_full, - .nformats =3D ARRAY_SIZE(formats_win_full), + .data_formats =3D formats_win_full_10, + .nformats =3D ARRAY_SIZE(formats_win_full_10), .format_modifiers =3D format_modifiers_win_full_afbc, .enable =3D VOP_REG(RK3288_WIN0_CTRL0, 0x1, 0), .format =3D VOP_REG(RK3288_WIN0_CTRL0, 0x7, 1), + .fmt_10 =3D VOP_REG(RK3288_WIN0_CTRL0, 0x1, 4), .rb_swap =3D VOP_REG(RK3288_WIN0_CTRL0, 0x1, 12), .uv_swap =3D VOP_REG(RK3288_WIN0_CTRL0, 0x1, 15), .x_mir_en =3D VOP_REG(RK3288_WIN0_CTRL0, 0x1, 21), --=20 2.40.1