From nobody Sun Feb 8 13:10:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23558EB64D9 for ; Sat, 17 Jun 2023 08:20:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346285AbjFQIUA (ORCPT ); Sat, 17 Jun 2023 04:20:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230313AbjFQIT6 (ORCPT ); Sat, 17 Jun 2023 04:19:58 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D976173A for ; Sat, 17 Jun 2023 01:19:57 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QjpqF1rqjz18MBy; Sat, 17 Jun 2023 16:19:53 +0800 (CST) Received: from huawei.com (10.175.104.170) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sat, 17 Jun 2023 16:19:54 +0800 From: Miaohe Lin To: , , , CC: , , , , , , , Subject: [PATCH] sched/topology: remove unneeded do while loop in cpu_attach_domain() Date: Sat, 17 Jun 2023 16:19:26 +0800 Message-ID: <20230617081926.2035113-1-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.170] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" When sg !=3D sd->groups, the do while loop would cause deadloop here. But that won't occur because sg is always equal to sd->groups now. Remove this unneeded do while loop. Signed-off-by: Miaohe Lin Reviewed-by: Chen Yu --- kernel/sched/topology.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index ca4472281c28..9010c93c3fdb 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -750,10 +750,7 @@ cpu_attach_domain(struct sched_domain *sd, struct root= _domain *rd, int cpu) * domain for convenience. Clear such flags since * the child is being destroyed. */ - do { - sg->flags =3D 0; - } while (sg !=3D sd->groups); - + sg->flags =3D 0; sd->child =3D NULL; } } --=20 2.27.0