From nobody Wed Feb 11 01:28:34 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0551AEB64D7 for ; Fri, 16 Jun 2023 15:45:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346083AbjFPPp2 (ORCPT ); Fri, 16 Jun 2023 11:45:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230060AbjFPPpS (ORCPT ); Fri, 16 Jun 2023 11:45:18 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57B852D43 for ; Fri, 16 Jun 2023 08:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686930270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VH0KKJcNZdhv+KXmN/7rOQUAjwGdBm7kB0o87VP7404=; b=P3zX3fEHGJ3X/ysFi3XkSD0JInrFQ0b+PHoMXbNcyjBGdTDxwhj9f5BnNYQb832qSC0d0E fIV3e4clMy2okSfuqgSlGcNIO9HyDOUsFD8nemAHBng/W70tImMztrLq5dTLbS9BhWT+6b Nqc7WqPBsaL5K/1CvPcLuxcF382IM14= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-343-LeEI9tWSNP622ir7Js4HvA-1; Fri, 16 Jun 2023 11:44:29 -0400 X-MC-Unique: LeEI9tWSNP622ir7Js4HvA-1 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-5704970148dso11892247b3.3 for ; Fri, 16 Jun 2023 08:44:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686930269; x=1689522269; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VH0KKJcNZdhv+KXmN/7rOQUAjwGdBm7kB0o87VP7404=; b=LKb3fWXQCVpBev79x+NTWjdh4lq4G588RY2PHnIvc+/zkH4GoCPja51+tMwS0SciyW UFF/TMsZfgG7uOpdgq+gWZ+7KWxV6L+nXtonGNkQcAvfSAHiZUUQmGvDIn1oV2Xz5WKP +B1tpHkUmM7QJebWYycMg13VTBrp0NNKGK8l7aTdky5NCB5DZirDwXI2c7Bq2A3AFRAT J7htZC9ijoiOc4+tIAV8fW85TlMMeuOCfNzgswQVdmqT2ZPLkEoqZRSQWAVyYyLPKj3r kEqbhXyA4h5UKESiEUxt3EC6WSUUMN4DrCkcg0FjQKt865fuwXSjEoYJhmd1Lus/GkPZ O4jw== X-Gm-Message-State: AC+VfDzHprApSrJ7mq197H+lWa6H/lP4Y25S/xvQZ8DLr5IeD8MZ0Pnu aOKzf/tjYi6hHVN9e1ixOFF//giYyqItDnLBJYLwI8DHcI7M9zHn3ApEFKGLj6ovqsfWaRen/8t X9yWK6R6HPjlCztYaZXeXDR0= X-Received: by 2002:a0d:dd51:0:b0:55a:40d3:4d6f with SMTP id g78-20020a0ddd51000000b0055a40d34d6fmr2041398ywe.26.1686930268704; Fri, 16 Jun 2023 08:44:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4YmvzX8Pu7iXe05Cv5jOEtdUapmFb2kkN3FGxTBj+wnhTKLl6VJZpH/PtDWGmB5qttha/53Q== X-Received: by 2002:a0d:dd51:0:b0:55a:40d3:4d6f with SMTP id g78-20020a0ddd51000000b0055a40d34d6fmr2041389ywe.26.1686930268386; Fri, 16 Jun 2023 08:44:28 -0700 (PDT) Received: from klayman.redhat.com (net-2-34-28-201.cust.vodafonedsl.it. [2.34.28.201]) by smtp.gmail.com with ESMTPSA id 27-20020a05620a079b00b007607ecd58ecsm4436931qka.59.2023.06.16.08.44.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jun 2023 08:44:28 -0700 (PDT) From: Marco Pagani To: Moritz Fischer , Wu Hao , Xu Yilun , Tom Rix Cc: Marco Pagani , linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org Subject: [PATCH v7 1/4] fpga: add an initial KUnit suite for the FPGA Manager Date: Fri, 16 Jun 2023 17:44:02 +0200 Message-Id: <20230616154405.220502-2-marpagan@redhat.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230616154405.220502-1-marpagan@redhat.com> References: <20230616154405.220502-1-marpagan@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The suite tests the basic behaviors of the FPGA Manager including programming using a single contiguous buffer and a scatter gather table. Signed-off-by: Marco Pagani --- drivers/fpga/tests/fpga-mgr-test.c | 302 +++++++++++++++++++++++++++++ 1 file changed, 302 insertions(+) create mode 100644 drivers/fpga/tests/fpga-mgr-test.c diff --git a/drivers/fpga/tests/fpga-mgr-test.c b/drivers/fpga/tests/fpga-m= gr-test.c new file mode 100644 index 000000000000..70e897dad3b6 --- /dev/null +++ b/drivers/fpga/tests/fpga-mgr-test.c @@ -0,0 +1,302 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * KUnit test for the FPGA Manager + * + * Copyright (C) 2023 Red Hat, Inc. + * + * Author: Marco Pagani + */ + +#include +#include +#include +#include +#include +#include + +#define HEADER_FILL 'H' +#define IMAGE_FILL 'P' +#define IMAGE_BLOCK 1024 + +#define HEADER_SIZE IMAGE_BLOCK +#define IMAGE_SIZE (IMAGE_BLOCK * 4) + +struct mgr_stats { + bool header_match; + bool image_match; + u32 seq_num; + u32 op_parse_header_seq; + u32 op_write_init_seq; + u32 op_write_seq; + u32 op_write_sg_seq; + u32 op_write_complete_seq; + enum fpga_mgr_states op_parse_header_state; + enum fpga_mgr_states op_write_init_state; + enum fpga_mgr_states op_write_state; + enum fpga_mgr_states op_write_sg_state; + enum fpga_mgr_states op_write_complete_state; +}; + +struct mgr_ctx { + struct fpga_image_info *img_info; + struct fpga_manager *mgr; + struct platform_device *pdev; + struct mgr_stats stats; +}; + +/** + * init_test_buffer() - Allocate and initialize a test image in a buffer. + * @test: KUnit test context object. + * @count: image size in bytes. + * + * Return: pointer to the newly allocated image. + */ +static char *init_test_buffer(struct kunit *test, size_t count) +{ + char *buf; + size_t i; + + buf =3D kunit_kzalloc(test, count, GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, buf); + + for (i =3D 0; i < count; i++) + buf[i] =3D i < HEADER_SIZE ? HEADER_FILL : IMAGE_FILL; + + return buf; +} + +static int op_parse_header(struct fpga_manager *mgr, struct fpga_image_inf= o *info, + const char *buf, size_t count) +{ + struct mgr_stats *stats =3D mgr->priv; + size_t i; + + /* Set header_size and data_size for later */ + info->header_size =3D HEADER_SIZE; + info->data_size =3D info->count - HEADER_SIZE; + + stats->header_match =3D true; + + /* Check header */ + for (i =3D 0; i < info->header_size; i++) + if (buf[i] !=3D HEADER_FILL) + stats->header_match =3D false; + + stats->op_parse_header_state =3D mgr->state; + stats->op_parse_header_seq =3D stats->seq_num++; + + return 0; +} + +static int op_write_init(struct fpga_manager *mgr, struct fpga_image_info = *info, + const char *buf, size_t count) +{ + struct mgr_stats *stats =3D mgr->priv; + + stats->op_write_init_state =3D mgr->state; + stats->op_write_init_seq =3D stats->seq_num++; + + return 0; +} + +static int op_write(struct fpga_manager *mgr, const char *buf, size_t coun= t) +{ + struct mgr_stats *stats =3D mgr->priv; + size_t i; + + /* Check image */ + stats->image_match =3D true; + for (i =3D 0; i < count; i++) + if (buf[i] !=3D IMAGE_FILL) + stats->image_match =3D false; + + stats->op_write_state =3D mgr->state; + stats->op_write_seq =3D stats->seq_num++; + + return 0; +} + +static int op_write_sg(struct fpga_manager *mgr, struct sg_table *sgt) +{ + struct mgr_stats *stats =3D mgr->priv; + struct scatterlist *sg; + char *img; + unsigned int si, i, j =3D 0; + + stats->image_match =3D true; + + /* Check image (write_sg will still get whole image in sg_table) */ + for_each_sgtable_sg(sgt, sg, si) { + img =3D sg_virt(sg); + for (i =3D 0; i < sg->length; i++) { + if (i + j > HEADER_SIZE && img[i] !=3D IMAGE_FILL) + stats->image_match =3D false; + } + j +=3D i; + } + + stats->op_write_sg_state =3D mgr->state; + stats->op_write_sg_seq =3D stats->seq_num++; + + return 0; +} + +static int op_write_complete(struct fpga_manager *mgr, struct fpga_image_i= nfo *info) +{ + struct mgr_stats *stats =3D mgr->priv; + + stats->op_write_complete_state =3D mgr->state; + stats->op_write_complete_seq =3D stats->seq_num++; + + return 0; +} + +/* + * Fake Manager that implements all ops required to check the programming + * sequence using a single contiguous buffer and a scatter gather table. + */ +static const struct fpga_manager_ops fake_mgr_ops =3D { + .skip_header =3D true, + .parse_header =3D op_parse_header, + .write_init =3D op_write_init, + .write =3D op_write, + .write_sg =3D op_write_sg, + .write_complete =3D op_write_complete, +}; + +static void fpga_mgr_test_get(struct kunit *test) +{ + struct mgr_ctx *ctx =3D test->priv; + struct fpga_manager *mgr; + + mgr =3D fpga_mgr_get(&ctx->pdev->dev); + KUNIT_EXPECT_PTR_EQ(test, mgr, ctx->mgr); + + fpga_mgr_put(ctx->mgr); +} + +static void fpga_mgr_test_lock(struct kunit *test) +{ + struct mgr_ctx *ctx =3D test->priv; + int ret; + + ret =3D fpga_mgr_lock(ctx->mgr); + KUNIT_EXPECT_EQ(test, ret, 0); + + ret =3D fpga_mgr_lock(ctx->mgr); + KUNIT_EXPECT_EQ(test, ret, -EBUSY); + + fpga_mgr_unlock(ctx->mgr); +} + +/* Check the programming sequence using an image in a buffer */ +static void fpga_mgr_test_img_load_buf(struct kunit *test) +{ + struct mgr_ctx *ctx =3D test->priv; + char *img_buf; + int ret; + + img_buf =3D init_test_buffer(test, IMAGE_SIZE); + + ctx->img_info->count =3D IMAGE_SIZE; + ctx->img_info->buf =3D img_buf; + + ret =3D fpga_mgr_load(ctx->mgr, ctx->img_info); + KUNIT_EXPECT_EQ(test, ret, 0); + + KUNIT_EXPECT_TRUE(test, ctx->stats.header_match); + KUNIT_EXPECT_TRUE(test, ctx->stats.image_match); + + KUNIT_EXPECT_EQ(test, ctx->stats.op_parse_header_state, FPGA_MGR_STATE_PA= RSE_HEADER); + KUNIT_EXPECT_EQ(test, ctx->stats.op_write_init_state, FPGA_MGR_STATE_WRIT= E_INIT); + KUNIT_EXPECT_EQ(test, ctx->stats.op_write_state, FPGA_MGR_STATE_WRITE); + KUNIT_EXPECT_EQ(test, ctx->stats.op_write_complete_state, FPGA_MGR_STATE_= WRITE_COMPLETE); + + KUNIT_EXPECT_EQ(test, ctx->stats.op_write_init_seq, ctx->stats.op_parse_h= eader_seq + 1); + KUNIT_EXPECT_EQ(test, ctx->stats.op_write_seq, ctx->stats.op_parse_header= _seq + 2); + KUNIT_EXPECT_EQ(test, ctx->stats.op_write_complete_seq, ctx->stats.op_par= se_header_seq + 3); +} + +/* Check the programming sequence using an image in a scatter gather table= */ +static void fpga_mgr_test_img_load_sgt(struct kunit *test) +{ + struct mgr_ctx *ctx =3D test->priv; + struct sg_table *sgt; + char *img_buf; + int ret; + + img_buf =3D init_test_buffer(test, IMAGE_SIZE); + + sgt =3D kunit_kzalloc(test, sizeof(*sgt), GFP_KERNEL); + ret =3D sg_alloc_table(sgt, 1, GFP_KERNEL); + KUNIT_ASSERT_EQ(test, ret, 0); + sg_init_one(sgt->sgl, img_buf, IMAGE_SIZE); + + ctx->img_info->sgt =3D sgt; + + ret =3D fpga_mgr_load(ctx->mgr, ctx->img_info); + KUNIT_EXPECT_EQ(test, ret, 0); + + KUNIT_EXPECT_TRUE(test, ctx->stats.header_match); + KUNIT_EXPECT_TRUE(test, ctx->stats.image_match); + + KUNIT_EXPECT_EQ(test, ctx->stats.op_parse_header_state, FPGA_MGR_STATE_PA= RSE_HEADER); + KUNIT_EXPECT_EQ(test, ctx->stats.op_write_init_state, FPGA_MGR_STATE_WRIT= E_INIT); + KUNIT_EXPECT_EQ(test, ctx->stats.op_write_sg_state, FPGA_MGR_STATE_WRITE); + KUNIT_EXPECT_EQ(test, ctx->stats.op_write_complete_state, FPGA_MGR_STATE_= WRITE_COMPLETE); + + KUNIT_EXPECT_EQ(test, ctx->stats.op_write_init_seq, ctx->stats.op_parse_h= eader_seq + 1); + KUNIT_EXPECT_EQ(test, ctx->stats.op_write_sg_seq, ctx->stats.op_parse_hea= der_seq + 2); + KUNIT_EXPECT_EQ(test, ctx->stats.op_write_complete_seq, ctx->stats.op_par= se_header_seq + 3); + + sg_free_table(ctx->img_info->sgt); +} + +static int fpga_mgr_test_init(struct kunit *test) +{ + struct mgr_ctx *ctx; + + ctx =3D kunit_kzalloc(test, sizeof(*ctx), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); + + ctx->pdev =3D platform_device_register_simple("mgr_pdev", PLATFORM_DEVID_= AUTO, NULL, 0); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx->pdev); + + ctx->mgr =3D devm_fpga_mgr_register(&ctx->pdev->dev, "Fake FPGA Manager",= &fake_mgr_ops, + &ctx->stats); + KUNIT_ASSERT_FALSE(test, IS_ERR_OR_NULL(ctx->mgr)); + + ctx->img_info =3D fpga_image_info_alloc(&ctx->pdev->dev); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx->img_info); + + test->priv =3D ctx; + + return 0; +} + +static void fpga_mgr_test_exit(struct kunit *test) +{ + struct mgr_ctx *ctx =3D test->priv; + + fpga_image_info_free(ctx->img_info); + platform_device_unregister(ctx->pdev); +} + +static struct kunit_case fpga_mgr_test_cases[] =3D { + KUNIT_CASE(fpga_mgr_test_get), + KUNIT_CASE(fpga_mgr_test_lock), + KUNIT_CASE(fpga_mgr_test_img_load_buf), + KUNIT_CASE(fpga_mgr_test_img_load_sgt), + {} +}; + +static struct kunit_suite fpga_mgr_suite =3D { + .name =3D "fpga_mgr", + .init =3D fpga_mgr_test_init, + .exit =3D fpga_mgr_test_exit, + .test_cases =3D fpga_mgr_test_cases, +}; + +kunit_test_suite(fpga_mgr_suite); + +MODULE_LICENSE("GPL"); --=20 2.40.1