From nobody Fri Sep 20 16:35:44 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CD67EB64DA for ; Fri, 16 Jun 2023 02:53:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240505AbjFPCxm (ORCPT ); Thu, 15 Jun 2023 22:53:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237804AbjFPCxg (ORCPT ); Thu, 15 Jun 2023 22:53:36 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FB3A2953; Thu, 15 Jun 2023 19:53:35 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2b448cf5d83so1787481fa.1; Thu, 15 Jun 2023 19:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686884013; x=1689476013; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5teyYXVySChYV/2XSD9vMPokSMgSc3gjTsNzsa7EAFM=; b=GNGMlYrDetZ6ICqbhwc+puCCyE0c6rBFCkQ8b2eeddMC1qIzcXriAtlIDfPp1ocvIQ Y85D0wSVo17OGLjrALMWSfJ7CC84T3mXIEpEOqin4Ce6pvn+sj9Eh6aXApRESdK5nO1T M0Uzch3MQyKSoV0y+PuLiq1vvpZlmwV3RInYVeJX7xu0kHE6bJkcBm4EIAGUfLE4fcl+ Azz9yUjzTf4HOjqUJoF+0yCu17FhRfHghSHqbLXk+htf8e022ymnlP+PCDnDwI5kiqow uHsr0hCZ56YmvWc1UwNKGktZcBsdqep4u3a1dzgu4FndnRaYK6Vql5XOwRj5p1j2G+62 AURw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686884013; x=1689476013; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5teyYXVySChYV/2XSD9vMPokSMgSc3gjTsNzsa7EAFM=; b=Bjn7/jt/sue6spbkYfBj24PrJXhPjv5tb1UXeNn9SBLvzkmexwVybop/2ZEhsEzIih yf9Rk53ya4yDADstexC8XjJFsToarBGeieFnPa0mWmCIiYBkILCm0GHyJmR+zkC7zdPz oGoMV1kO0W9SP5Jw3WJC9m+1W/OBTnDPyAj7IHZI+Bc2JmVm7usyU3MgLCd0GBxZy1lE HEFWUaiI3ts+VAUqcPjylduzu7y6uCJv5dqFaufaafilTrQhKTWazUQ4V4N3/dX8Bb+x 73i9sKQzRNfYlGsaNT4/Kw4hbiC30nKLZvch3tn6BoX9IHQ00i2gcuM0CLTygKqN+6n6 6Wcw== X-Gm-Message-State: AC+VfDzOYiI7urAXztARuQv1bU3FfW86IoOQHPpAaLeM4J7KswYt9+IN vH5Kgf8kiVM1HLbSM4xMg4U= X-Google-Smtp-Source: ACHHUZ7w7yvq7i3gLLPqn0YvdI3QsxCnRzgWFtRNSlech3ZCz7VcklyDsOE1xOmGCpIss6027QOEnQ== X-Received: by 2002:a2e:98d6:0:b0:2af:3141:a52b with SMTP id s22-20020a2e98d6000000b002af3141a52bmr710339ljj.22.1686884013304; Thu, 15 Jun 2023 19:53:33 -0700 (PDT) Received: from arinc9-Xeront.. (athedsl-404045.home.otenet.gr. [79.131.130.75]) by smtp.gmail.com with ESMTPSA id v15-20020a1cf70f000000b003f8d770e935sm890328wmh.0.2023.06.15.19.53.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jun 2023 19:53:32 -0700 (PDT) From: arinc9.unal@gmail.com X-Google-Original-From: arinc.unal@arinc9.com To: =?UTF-8?q?Ar=C4=B1n=C3=A7=20=C3=9CNAL?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King Cc: Landen Chao , Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH net v5 1/6] net: dsa: mt7530: set all CPU ports in MT7531_CPU_PMAP Date: Fri, 16 Jun 2023 05:53:22 +0300 Message-Id: <20230616025327.12652-2-arinc.unal@arinc9.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616025327.12652-1-arinc.unal@arinc9.com> References: <20230616025327.12652-1-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ar=C4=B1n=C3=A7 =C3=9CNAL MT7531_CPU_PMAP represents the destination port mask for trapped-to-CPU frames (further restricted by PCR_MATRIX). Currently the driver sets the first CPU port as the single port in this bit mask, which works fine regardless of whether the device tree defines port 5, 6 or 5+6 as CPU ports. This is because the logic coincides with DSA's logic of picking the first CPU port as the CPU port that all user ports are affine to, by default. An upcoming change would like to influence DSA's selection of the default CPU port to no longer be the first one, and in that case, this logic needs adaptation. Since there is no observed leakage or duplication of frames if all CPU ports are defined in this bit mask, simply include them all. Suggested-by: Russell King (Oracle) Suggested-by: Vladimir Oltean Signed-off-by: Ar=C4=B1n=C3=A7 =C3=9CNAL Reviewed-by: Russell King (Oracle) Reviewed-by: Vladimir Oltean --- drivers/net/dsa/mt7530.c | 15 ++++++++------- drivers/net/dsa/mt7530.h | 1 + 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 9bc54e1348cb..0a5237793209 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -1010,6 +1010,13 @@ mt753x_cpu_port_enable(struct dsa_switch *ds, int po= rt) if (priv->id =3D=3D ID_MT7621) mt7530_rmw(priv, MT7530_MFC, CPU_MASK, CPU_EN | CPU_PORT(port)); =20 + /* Add the CPU port to the CPU port bitmap for MT7531 and the switch on + * the MT7988 SoC. Trapped frames will be trapped to the CPU port that + * is affine to the inbound user port. + */ + if (priv->id =3D=3D ID_MT7531 || priv->id =3D=3D ID_MT7988) + mt7530_set(priv, MT7531_CFC, MT7531_CPU_PMAP(BIT(port))); + /* CPU port gets connected to all user ports of * the switch. */ @@ -2352,15 +2359,9 @@ static int mt7531_setup_common(struct dsa_switch *ds) { struct mt7530_priv *priv =3D ds->priv; - struct dsa_port *cpu_dp; int ret, i; =20 - /* BPDU to CPU port */ - dsa_switch_for_each_cpu_port(cpu_dp, ds) { - mt7530_rmw(priv, MT7531_CFC, MT7531_CPU_PMAP_MASK, - BIT(cpu_dp->index)); - break; - } + /* Trap BPDUs to the CPU port(s) */ mt7530_rmw(priv, MT753X_BPC, MT753X_BPDU_PORT_FW_MASK, MT753X_BPDU_CPU_ONLY); =20 diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h index 5084f48a8869..e590cf43f3ae 100644 --- a/drivers/net/dsa/mt7530.h +++ b/drivers/net/dsa/mt7530.h @@ -54,6 +54,7 @@ enum mt753x_id { #define MT7531_MIRROR_PORT_GET(x) (((x) >> 16) & MIRROR_MASK) #define MT7531_MIRROR_PORT_SET(x) (((x) & MIRROR_MASK) << 16) #define MT7531_CPU_PMAP_MASK GENMASK(7, 0) +#define MT7531_CPU_PMAP(x) FIELD_PREP(MT7531_CPU_PMAP_MASK, x) =20 #define MT753X_MIRROR_REG(id) ((((id) =3D=3D ID_MT7531) || ((id) =3D=3D I= D_MT7988)) ? \ MT7531_CFC : MT7530_MFC) --=20 2.39.2 From nobody Fri Sep 20 16:35:44 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9D40EB64DA for ; Fri, 16 Jun 2023 02:53:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241103AbjFPCxp (ORCPT ); Thu, 15 Jun 2023 22:53:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239840AbjFPCxi (ORCPT ); Thu, 15 Jun 2023 22:53:38 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C29B2954; Thu, 15 Jun 2023 19:53:37 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-4f004cc54f4so170115e87.3; Thu, 15 Jun 2023 19:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686884015; x=1689476015; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JH9rgnoje5CiNXWobY3ZLpf7/bXY7kCTB8+Con2/+OA=; b=nbAUKxqkROBMD6br9cgrAZn8uavT1rxIO62rQiLnqdRERiQ41WRJ1ZoRrz+JwNhpWO COQeiWJ17QHdyIBU+7Kl4Uy3mNsxqZ1+ySu1e05uA31KPc/5XLADq7OKx4c/IBD7dxxn PINZKSsz14Hvfa0J+1MPAteXtXocCojlIAg12dKW6an3DInGDCeBcBNIum/rSrBaS0vt +P67NDJ6avMMTxEtLw7VGE5IH+6Z8pGYAnVlB8ItIzZUVwclykbcQgJM/iZQ9awFRMt9 yBWMZSuf6pSQ30YQtqNusfmSSu8pA7HCpyoQx6IhyTuOuwQ7hLfX5l5xL1PD7xOF7+mo lEjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686884015; x=1689476015; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JH9rgnoje5CiNXWobY3ZLpf7/bXY7kCTB8+Con2/+OA=; b=Gw7YThxGSFFJ3koxMVPL+J3KUxC2Ob+5DBP4hzJrG9DmuQy29creyike0+IRIkhPxw yKNiOiKzcK9eCtoaiJXeROp7S2pzdNoQxkL5rnKgOSsMWGze0j2V2kx4d1JwGbXfqq91 X/mECSx5tbyJPr7uygN/PK8wn8oA/quGU/SkPDiTNXsJdNjwvHiZhUr294l3qfCq6xCI cFEidTH2KoVlPLrbrxhLxe9Fdh06BB7c90HlmOCulRvhuU8piWEIHYIdZ/Yur/Dquwnp ad4ZMbIgHgAUJfkh/Bx3QqHRue+FZvrnVoBgUfve3qulIaHmCb7H6mB3Tgz0yhJJxnE+ BMPQ== X-Gm-Message-State: AC+VfDwGrMMAou8M1GCqRGyNHBr68CTyvXpRdbTiX3wnP+ICmNjXyc9r M43N8K8Xx0c3FGTn92+yDuU= X-Google-Smtp-Source: ACHHUZ7vBZhrlqunY+9yGIC8576odQqD9NlYAC3uEM3FtxIRkY8j4u0HkMS7Zd9Ziv7asuFwukz1Hw== X-Received: by 2002:a19:8c4a:0:b0:4f3:8f3a:f98d with SMTP id i10-20020a198c4a000000b004f38f3af98dmr257461lfj.45.1686884015414; Thu, 15 Jun 2023 19:53:35 -0700 (PDT) Received: from arinc9-Xeront.. (athedsl-404045.home.otenet.gr. [79.131.130.75]) by smtp.gmail.com with ESMTPSA id v15-20020a1cf70f000000b003f8d770e935sm890328wmh.0.2023.06.15.19.53.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jun 2023 19:53:35 -0700 (PDT) From: arinc9.unal@gmail.com X-Google-Original-From: arinc.unal@arinc9.com To: =?UTF-8?q?Ar=C4=B1n=C3=A7=20=C3=9CNAL?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King Cc: Landen Chao , Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH net v5 2/6] net: dsa: mt7530: fix trapping frames on non-MT7621 SoC MT7530 switch Date: Fri, 16 Jun 2023 05:53:23 +0300 Message-Id: <20230616025327.12652-3-arinc.unal@arinc9.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616025327.12652-1-arinc.unal@arinc9.com> References: <20230616025327.12652-1-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ar=C4=B1n=C3=A7 =C3=9CNAL The check for setting the CPU_PORT bits must include the non-MT7621 SoC MT7530 switch variants to trap frames. Expand the check to include them. Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 sw= itch") Signed-off-by: Ar=C4=B1n=C3=A7 =C3=9CNAL Reviewed-by: Vladimir Oltean --- drivers/net/dsa/mt7530.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 0a5237793209..e9fbe7ae6c2c 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -1007,7 +1007,7 @@ mt753x_cpu_port_enable(struct dsa_switch *ds, int por= t) UNU_FFP(BIT(port))); =20 /* Set CPU port number */ - if (priv->id =3D=3D ID_MT7621) + if (priv->id =3D=3D ID_MT7530 || priv->id =3D=3D ID_MT7621) mt7530_rmw(priv, MT7530_MFC, CPU_MASK, CPU_EN | CPU_PORT(port)); =20 /* Add the CPU port to the CPU port bitmap for MT7531 and the switch on --=20 2.39.2 From nobody Fri Sep 20 16:35:44 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ACF6EB64D9 for ; Fri, 16 Jun 2023 02:53:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241241AbjFPCxt (ORCPT ); Thu, 15 Jun 2023 22:53:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240318AbjFPCxk (ORCPT ); Thu, 15 Jun 2023 22:53:40 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71366297C; Thu, 15 Jun 2023 19:53:39 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4f7677a94d1so175893e87.0; Thu, 15 Jun 2023 19:53:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686884018; x=1689476018; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PeQcyVvQd35gvg0Q5bl83ripKoD4zdxyC5dpHXUCgQ8=; b=edhIdPAtNhERnXnhjZiBeAyokijKoqw5wFSRniTKNbImMzwboh6sAlKJtp6krKiLqD +Zq56xq+MUxNSCKY9olSWo4ITNXyaglKL5uAE/1orLonCMJ/RFboUZu9Lk/EwUUTQ45y sfsPSu5hkUn/7/EEXol48gnALTuRaxRIwq74vfvwQfDOLf4Trrmds4WjqmGXXgPJ/Jry 2gCoV1U3y7o/7wRwOvapFJVwFuZs9DrYoPfQPrQhRumjEpaR7fqvnWm8R5Xh+oxQleJt NXc6aLT10cyMrgG2G9AyOCxLqfQvxWWWrHOmTh5+EFbSxTTMJHhMS859SJRZWVRePNA8 OyFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686884018; x=1689476018; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PeQcyVvQd35gvg0Q5bl83ripKoD4zdxyC5dpHXUCgQ8=; b=gCVqeYlJ5sjXApucCCAH/CVYMRv/ZK7eqUwjHyWI1KhAXtIT+m7+vv/lg24mPbgtuo zOE4r+cqnguxwfs2OLbAYNtcaNy1GGLzQUviOkyXd+rlArlz1LtEvzVps00p1Z1IFJtl JbexuhTRQ139seUl3IBzK1ZDRR1MnRwt3uvM4V2OxRVzDYULZYid78Gr1VrVWE6fL1SD Jn/LcykWwnbOEA9iFEqrjfnfLfeW6/SNUqszujRqxe1KRUaAHh01cu9ZfEBBGBlnq18/ KXC7e2FurjDlDVNjVIjBAFTo/0eG8EnGdnBZor8becfWYgtWd8NjI/RoveQeIYB5Laa3 1frA== X-Gm-Message-State: AC+VfDyOCFsvP8bg5rfQg+3waPpSaaLra7+aBYqePYm/n98fq9UmZV10 zWjWSeQ2u/ARjzqfQP57Rn0= X-Google-Smtp-Source: ACHHUZ67TVTk9qXe6h1Ou3Utuf+4Q6WQCIv/PcEdfrfjhSpFBZKtVFo4DFESiS/5EHeQtQMd4rRa5Q== X-Received: by 2002:a05:6512:3288:b0:4f0:1e7d:f897 with SMTP id p8-20020a056512328800b004f01e7df897mr347357lfe.17.1686884017644; Thu, 15 Jun 2023 19:53:37 -0700 (PDT) Received: from arinc9-Xeront.. (athedsl-404045.home.otenet.gr. [79.131.130.75]) by smtp.gmail.com with ESMTPSA id v15-20020a1cf70f000000b003f8d770e935sm890328wmh.0.2023.06.15.19.53.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jun 2023 19:53:37 -0700 (PDT) From: arinc9.unal@gmail.com X-Google-Original-From: arinc.unal@arinc9.com To: =?UTF-8?q?Ar=C4=B1n=C3=A7=20=C3=9CNAL?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King Cc: Landen Chao , Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH net v5 3/6] net: dsa: mt7530: fix handling of BPDUs on MT7530 switch Date: Fri, 16 Jun 2023 05:53:24 +0300 Message-Id: <20230616025327.12652-4-arinc.unal@arinc9.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616025327.12652-1-arinc.unal@arinc9.com> References: <20230616025327.12652-1-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ar=C4=B1n=C3=A7 =C3=9CNAL BPDUs are link-local frames, therefore they must be trapped to the CPU port. Currently, the MT7530 switch treats BPDUs as regular multicast frames, therefore flooding them to user ports. To fix this, set BPDUs to be trapped to the CPU port. Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 sw= itch") Signed-off-by: Ar=C4=B1n=C3=A7 =C3=9CNAL --- drivers/net/dsa/mt7530.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index e9fbe7ae6c2c..7b72cf3a0e30 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -2262,6 +2262,10 @@ mt7530_setup(struct dsa_switch *ds) =20 priv->p6_interface =3D PHY_INTERFACE_MODE_NA; =20 + /* Trap BPDUs to the CPU port */ + mt7530_rmw(priv, MT753X_BPC, MT753X_BPDU_PORT_FW_MASK, + MT753X_BPDU_CPU_ONLY); + /* Enable and reset MIB counters */ mt7530_mib_reset(ds); =20 --=20 2.39.2 From nobody Fri Sep 20 16:35:44 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A6B0EB64D9 for ; Fri, 16 Jun 2023 02:53:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241258AbjFPCxw (ORCPT ); Thu, 15 Jun 2023 22:53:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241167AbjFPCxn (ORCPT ); Thu, 15 Jun 2023 22:53:43 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C99802D54; Thu, 15 Jun 2023 19:53:41 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3f8d2bfec9bso1628625e9.0; Thu, 15 Jun 2023 19:53:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686884020; x=1689476020; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t/TXTWeJTVoXuAKTeh8f1IhTxUfSJa+l8YgArHUf0S4=; b=ThPTTwZndntg5GQFV1BoU+8HZFGwk9ozDDKBt84BM3Zf9xiXy0jyMkhwsyRQpz0DhE tpiD4K+P93HcI9o/lqPEtJvg5dLWSXSvon3k2Gv9Fa0LKG2MzO7vTiAyJ4O++Mfz2fQK i+wnGIVtewWpUOoI/5W6ukcsc19fvEX9lsnUx249uxV8rFTGKoY7ApxORhwgwUvvxVfg CPkov//tFDmBmGjXs/hw3h3akvFI/dqxHTDNZArBQtw32DWJxwiq2nyqjTwSNoj7KV+G R71ON85rCzlKLz7zp+pyD/Hi8D2FUNiH8ajKGOkQA6g5MeEcWqPGp8qpKWYC/LgoL/d/ QIWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686884020; x=1689476020; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t/TXTWeJTVoXuAKTeh8f1IhTxUfSJa+l8YgArHUf0S4=; b=I0y0toAV2CmEKerLUGXA2ALYzn6Bex8HyuCl0dIWNQff5HPvZigJpZ9QItKdwzhsHT sGniJkU55+wkvHdn59Bs9jQUbBF+wjLvGBym6kUebBMvBDaEemmy2E41APbTUZVNSgcR 3CIlxX4twwP0EcnoMeR1idJqI+S2NjolzsO8nUM3U9eH4jVdRIllGxjKspjxZzrzWsab xVZ0n6g14Dj8lE9E+eMe/WLAup+knl9LNllrZQahxocFV5YE5QtjGdE96Yshn70iHMYr 74kQJxT8HJTvwIKP4ogyP4j3scBAqUEZHQVjye+HUFWmzysQAihye2Tp95VYPrgVd+47 TRpw== X-Gm-Message-State: AC+VfDx04KnnPlZXvfY9dVwmQhlC3XI/T0TbvykcrucOZFI+Oe7K7jSZ RUQeHK3GLhDJSLoF9psJQh4= X-Google-Smtp-Source: ACHHUZ5m3yWS67ui0qIRpldwzOdvU3TkY97rT5RE0eglqoIcnhnwT5+gmeL631Pgtun6ClqmYTYI6w== X-Received: by 2002:a05:600c:214d:b0:3f7:2a38:34b9 with SMTP id v13-20020a05600c214d00b003f72a3834b9mr591288wml.23.1686884019658; Thu, 15 Jun 2023 19:53:39 -0700 (PDT) Received: from arinc9-Xeront.. (athedsl-404045.home.otenet.gr. [79.131.130.75]) by smtp.gmail.com with ESMTPSA id v15-20020a1cf70f000000b003f8d770e935sm890328wmh.0.2023.06.15.19.53.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jun 2023 19:53:39 -0700 (PDT) From: arinc9.unal@gmail.com X-Google-Original-From: arinc.unal@arinc9.com To: =?UTF-8?q?Ar=C4=B1n=C3=A7=20=C3=9CNAL?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King Cc: Landen Chao , Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH net v5 4/6] net: dsa: mt7530: fix handling of LLDP frames Date: Fri, 16 Jun 2023 05:53:25 +0300 Message-Id: <20230616025327.12652-5-arinc.unal@arinc9.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616025327.12652-1-arinc.unal@arinc9.com> References: <20230616025327.12652-1-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ar=C4=B1n=C3=A7 =C3=9CNAL LLDP frames are link-local frames, therefore they must be trapped to the CPU port. Currently, the MT753X switches treat LLDP frames as regular multicast frames, therefore flooding them to user ports. To fix this, set LLDP frames to be trapped to the CPU port(s). Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 sw= itch") Signed-off-by: Ar=C4=B1n=C3=A7 =C3=9CNAL --- drivers/net/dsa/mt7530.c | 8 ++++++++ drivers/net/dsa/mt7530.h | 5 +++++ 2 files changed, 13 insertions(+) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 7b72cf3a0e30..c85876fd9107 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -2266,6 +2266,10 @@ mt7530_setup(struct dsa_switch *ds) mt7530_rmw(priv, MT753X_BPC, MT753X_BPDU_PORT_FW_MASK, MT753X_BPDU_CPU_ONLY); =20 + /* Trap LLDP frames with :0E MAC DA to the CPU port */ + mt7530_rmw(priv, MT753X_RGAC2, MT753X_R0E_PORT_FW_MASK, + MT753X_R0E_PORT_FW(MT753X_BPDU_CPU_ONLY)); + /* Enable and reset MIB counters */ mt7530_mib_reset(ds); =20 @@ -2369,6 +2373,10 @@ mt7531_setup_common(struct dsa_switch *ds) mt7530_rmw(priv, MT753X_BPC, MT753X_BPDU_PORT_FW_MASK, MT753X_BPDU_CPU_ONLY); =20 + /* Trap LLDP frames with :0E MAC DA to the CPU port(s) */ + mt7530_rmw(priv, MT753X_RGAC2, MT753X_R0E_PORT_FW_MASK, + MT753X_R0E_PORT_FW(MT753X_BPDU_CPU_ONLY)); + /* Enable and reset MIB counters */ mt7530_mib_reset(ds); =20 diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h index e590cf43f3ae..08045b035e6a 100644 --- a/drivers/net/dsa/mt7530.h +++ b/drivers/net/dsa/mt7530.h @@ -67,6 +67,11 @@ enum mt753x_id { #define MT753X_BPC 0x24 #define MT753X_BPDU_PORT_FW_MASK GENMASK(2, 0) =20 +/* Register for :03 and :0E MAC DA frame control */ +#define MT753X_RGAC2 0x2c +#define MT753X_R0E_PORT_FW_MASK GENMASK(18, 16) +#define MT753X_R0E_PORT_FW(x) FIELD_PREP(MT753X_R0E_PORT_FW_MASK, x) + enum mt753x_bpdu_port_fw { MT753X_BPDU_FOLLOW_MFC, MT753X_BPDU_CPU_EXCLUDE =3D 4, --=20 2.39.2 From nobody Fri Sep 20 16:35:44 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55BB9EB64DA for ; Fri, 16 Jun 2023 02:53:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241305AbjFPCx6 (ORCPT ); Thu, 15 Jun 2023 22:53:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241184AbjFPCxq (ORCPT ); Thu, 15 Jun 2023 22:53:46 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4DEF2D40; Thu, 15 Jun 2023 19:53:43 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2b448cf5d83so1788371fa.1; Thu, 15 Jun 2023 19:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686884022; x=1689476022; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LO090aGKfjAdyiyyfSeSG2ozaZLnIRNfAQZhwpNuUNw=; b=ITChrslju8jBHdCFGMTnZneuxkNEPIhlMv0UPmOUk90hhQ9TABR/+Ec28t8s+N5Eef /5PwPvi1FwbhLdocKB73t8OkWirFTsevPasV48m4UEA3ylnHDYrgrXanBNzF21BQhp23 j55RMeGOqiVrJ3VS3Ccfxc3iy7A1XZxp4jZ9DhD5QIwWaSrjK1Jnesu6Fceycmo1Sx4F Od7SY/XRkjVRaoMozR0ktoQRUAd5ZDhUpxusVM8zxI+PVzj82Dz/HARSx8252cl/hAwH pNCXUW3PxYnytEtW+Mu8H3wIDswoRxZ6TKPVpv8dOnF87gIJhsZAsubeqoRILazSfDFI b82Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686884022; x=1689476022; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LO090aGKfjAdyiyyfSeSG2ozaZLnIRNfAQZhwpNuUNw=; b=Rst3gf4nRfQopTqwBFJrfdoEDGFWLwla1ngtLYy76m6SoSd+3O2ZGGYOcaZG7xds0z juuEijO8VdOaa5tcCdY53g61t8kGb0UP+K6oMtuFcNdl/gZOWJ168Jn4ri0Kge9wLxfo 1BcjT8zHF153+mFAodu6208s/GOAojdNxX3eNeei+alTnZJFIhS0FCkoudhcgynXtmXE TckFM9ttb9nqorHa4E37pxU2jEehUKKHujHGv3d2jfuvIXK78wvkDUicDjsNH4AhPtOB Y+vUclQzEVXP24jA7EX24UY4Jkfe3uRAlkHVQFJcHN4uYTRbWxelBSJlkG/0hxTVn17K sHdg== X-Gm-Message-State: AC+VfDwCAals0bcY8uY6K6wsuAqs877Lc2ylLETCHCwAYM7qQOgcs0vm fnCAPNV+DvCuX1s1bPBMc/c= X-Google-Smtp-Source: ACHHUZ6Z7LilC+FcI/MnaRBoH32zrQ8wAQ+OWysUuzaicYbLxLEUP0x/CxGDTkpy+8kQ1fK7v8+Jfw== X-Received: by 2002:a2e:8859:0:b0:2b4:48c5:5261 with SMTP id z25-20020a2e8859000000b002b448c55261mr724604ljj.35.1686884021643; Thu, 15 Jun 2023 19:53:41 -0700 (PDT) Received: from arinc9-Xeront.. (athedsl-404045.home.otenet.gr. [79.131.130.75]) by smtp.gmail.com with ESMTPSA id v15-20020a1cf70f000000b003f8d770e935sm890328wmh.0.2023.06.15.19.53.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jun 2023 19:53:41 -0700 (PDT) From: arinc9.unal@gmail.com X-Google-Original-From: arinc.unal@arinc9.com To: =?UTF-8?q?Ar=C4=B1n=C3=A7=20=C3=9CNAL?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King Cc: Landen Chao , Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH net v5 5/6] net: dsa: introduce preferred_default_local_cpu_port and use on MT7530 Date: Fri, 16 Jun 2023 05:53:26 +0300 Message-Id: <20230616025327.12652-6-arinc.unal@arinc9.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616025327.12652-1-arinc.unal@arinc9.com> References: <20230616025327.12652-1-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vladimir Oltean Since the introduction of the OF bindings, DSA has always had a policy that in case multiple CPU ports are present in the device tree, the numerically smallest one is always chosen. The MT7530 switch family, except the switch on the MT7988 SoC, has 2 CPU ports, 5 and 6, where port 6 is preferable on the MT7531BE switch because it has higher bandwidth. The MT7530 driver developers had 3 options: - to modify DSA when the MT7531 switch support was introduced, such as to prefer the better port - to declare both CPU ports in device trees as CPU ports, and live with the sub-optimal performance resulting from not preferring the better port - to declare just port 6 in the device tree as a CPU port Of course they chose the path of least resistance (3rd option), kicking the can down the road. The hardware description in the device tree is supposed to be stable - developers are not supposed to adopt the strategy of piecemeal hardware description, where the device tree is updated in lockstep with the features that the kernel currently supports. Now, as a result of the fact that they did that, any attempts to modify the device tree and describe both CPU ports as CPU ports would make DSA change its default selection from port 6 to 5, effectively resulting in a performance degradation visible to users with the MT7531BE switch as can be seen below. Without preferring port 6: [ ID][Role] Interval Transfer Bitrate Retr [ 5][TX-C] 0.00-20.00 sec 374 MBytes 157 Mbits/sec 734 sender [ 5][TX-C] 0.00-20.00 sec 373 MBytes 156 Mbits/sec receiver [ 7][RX-C] 0.00-20.00 sec 1.81 GBytes 778 Mbits/sec 0 sender [ 7][RX-C] 0.00-20.00 sec 1.81 GBytes 777 Mbits/sec receiver With preferring port 6: [ ID][Role] Interval Transfer Bitrate Retr [ 5][TX-C] 0.00-20.00 sec 1.99 GBytes 856 Mbits/sec 273 sender [ 5][TX-C] 0.00-20.00 sec 1.99 GBytes 855 Mbits/sec receiver [ 7][RX-C] 0.00-20.00 sec 1.72 GBytes 737 Mbits/sec 15 sender [ 7][RX-C] 0.00-20.00 sec 1.71 GBytes 736 Mbits/sec receiver Using one port for WAN and the other ports for LAN is a very popular use case which is what this test emulates. As such, this change proposes that we retroactively modify stable kernels (which don't support the modification of the CPU port assignments, so as to let user space fix the problem and restore the throughput) to keep the mt7530 driver preferring port 6 even with device trees where the hardware is more fully described. Fixes: c288575f7810 ("net: dsa: mt7530: Add the support of MT7531 switch") Signed-off-by: Vladimir Oltean Signed-off-by: Ar=C4=B1n=C3=A7 =C3=9CNAL --- drivers/net/dsa/mt7530.c | 15 +++++++++++++++ include/net/dsa.h | 8 ++++++++ net/dsa/dsa.c | 24 +++++++++++++++++++++++- 3 files changed, 46 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index c85876fd9107..3f84bcb79b3a 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -399,6 +399,20 @@ static void mt7530_pll_setup(struct mt7530_priv *priv) core_set(priv, CORE_TRGMII_GSW_CLK_CG, REG_GSWCK_EN); } =20 +/* If port 6 is available as a CPU port, always prefer that as the default, + * otherwise don't care. + */ +static struct dsa_port * +mt753x_preferred_default_local_cpu_port(struct dsa_switch *ds) +{ + struct dsa_port *cpu_dp =3D dsa_to_port(ds, 6); + + if (dsa_port_is_cpu(cpu_dp)) + return cpu_dp; + + return NULL; +} + /* Setup port 6 interface mode and TRGMII TX circuit */ static int mt7530_pad_clk_setup(struct dsa_switch *ds, phy_interface_t interface) @@ -3098,6 +3112,7 @@ static int mt7988_setup(struct dsa_switch *ds) const struct dsa_switch_ops mt7530_switch_ops =3D { .get_tag_protocol =3D mtk_get_tag_protocol, .setup =3D mt753x_setup, + .preferred_default_local_cpu_port =3D mt753x_preferred_default_local_cpu_= port, .get_strings =3D mt7530_get_strings, .get_ethtool_stats =3D mt7530_get_ethtool_stats, .get_sset_count =3D mt7530_get_sset_count, diff --git a/include/net/dsa.h b/include/net/dsa.h index 8903053fa5aa..ab0f0a5b0860 100644 --- a/include/net/dsa.h +++ b/include/net/dsa.h @@ -958,6 +958,14 @@ struct dsa_switch_ops { struct phy_device *phy); void (*port_disable)(struct dsa_switch *ds, int port); =20 + /* + * Compatibility between device trees defining multiple CPU ports and + * drivers which are not OK to use by default the numerically smallest + * CPU port of a switch for its local ports. This can return NULL, + * meaning "don't know/don't care". + */ + struct dsa_port *(*preferred_default_local_cpu_port)(struct dsa_switch *d= s); + /* * Port's MAC EEE settings */ diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index ab1afe67fd18..1afed89e03c0 100644 --- a/net/dsa/dsa.c +++ b/net/dsa/dsa.c @@ -403,6 +403,24 @@ static int dsa_tree_setup_default_cpu(struct dsa_switc= h_tree *dst) return 0; } =20 +static struct dsa_port * +dsa_switch_preferred_default_local_cpu_port(struct dsa_switch *ds) +{ + struct dsa_port *cpu_dp; + + if (!ds->ops->preferred_default_local_cpu_port) + return NULL; + + cpu_dp =3D ds->ops->preferred_default_local_cpu_port(ds); + if (!cpu_dp) + return NULL; + + if (WARN_ON(!dsa_port_is_cpu(cpu_dp) || cpu_dp->ds !=3D ds)) + return NULL; + + return cpu_dp; +} + /* Perform initial assignment of CPU ports to user ports and DSA links in = the * fabric, giving preference to CPU ports local to each switch. Default to * using the first CPU port in the switch tree if the port does not have a= CPU @@ -410,12 +428,16 @@ static int dsa_tree_setup_default_cpu(struct dsa_swit= ch_tree *dst) */ static int dsa_tree_setup_cpu_ports(struct dsa_switch_tree *dst) { - struct dsa_port *cpu_dp, *dp; + struct dsa_port *preferred_cpu_dp, *cpu_dp, *dp; =20 list_for_each_entry(cpu_dp, &dst->ports, list) { if (!dsa_port_is_cpu(cpu_dp)) continue; =20 + preferred_cpu_dp =3D dsa_switch_preferred_default_local_cpu_port(cpu_dp-= >ds); + if (preferred_cpu_dp && preferred_cpu_dp !=3D cpu_dp) + continue; + /* Prefer a local CPU port */ dsa_switch_for_each_port(dp, cpu_dp->ds) { /* Prefer the first local CPU port found */ --=20 2.39.2 From nobody Fri Sep 20 16:35:44 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1012EB64D9 for ; Fri, 16 Jun 2023 02:54:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241451AbjFPCyC (ORCPT ); Thu, 15 Jun 2023 22:54:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240087AbjFPCxr (ORCPT ); Thu, 15 Jun 2023 22:53:47 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 728652D5E; Thu, 15 Jun 2023 19:53:45 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-3f8d5262dc8so2172205e9.0; Thu, 15 Jun 2023 19:53:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686884024; x=1689476024; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AIVXF0NWT+mxXgpNldoq9Ep8Ze5GWaI0IQCYTwDNGis=; b=TH8+LNShLJl+lN5lR3SXIDRE6PtqXnSRNJweWN236P/MIEYjkQOt20OHZTs3m/gqdE zGyNyeyEJdBx+dDNx5guLPyWxxlKbcQrK1dGm0+PRkP8vzVZw0VR7U/siln+azfbtHPU k93f+NVbO2n6Ef4quOJ7b/4G42caGRJ8M0l1r+m2XLHiEIMAilxsHB2VBBCWgSjsAv+J JoShn7VsdcB0zX9lG+rpOb42TpOo2PyDg8xI9398Pw/0HZsklD6MIoo3T/YdEK6YwnkO iFKCeCEe3kJHnVKxPkYWlJLdwtg+3HJhzQbeW4Kv0g16bWumcpwS8EEU7sq6Sm2Lq7lu sqIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686884024; x=1689476024; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AIVXF0NWT+mxXgpNldoq9Ep8Ze5GWaI0IQCYTwDNGis=; b=N0tB3VB246iK866MCD/wVuTcy8BQL0iMHtrLfEZgcqeQytDw2qPHxzh6fGG07rycvG z3x+jQMoNYh/2e+wG1JktvXm4i2CwDpTkfZryNH+Ye2Bv+H2h7vPva3DL4N4L6Iohddq wm8Kt1sffY3myA1RXKtWHbc9Mc/nwPxHJ2M5ys5O9tS71njJTZE37T1iSzRNLn2F9u3g psavJgjhEK4Bj6zivWRj7DnUlFEw/CRs9opxva7NLRhWAnDDsyG4f/B/oHP6xNJw1vV/ 9xOYDnuvUWxlJyRmZlf5Fw9egiddFK8EtIKyiOKB+5hdYdwteD4bZiVCkGJ1J2E6ul2b c6IQ== X-Gm-Message-State: AC+VfDzrBX0Myi8ExcrZi2rii4dm7IjdlpsoR+3L7oSDi0LPf+Nrm/iH z58QnMhfDtT2hH47w4paBKM= X-Google-Smtp-Source: ACHHUZ5eszUdRCoqVl0XnO8o0Flzro58U4rSrS2wesjQ3rQNHV27XtmHlB1V/EdEpBfOJF4FMCoUPQ== X-Received: by 2002:a05:600c:3657:b0:3f6:8ba:6ea2 with SMTP id y23-20020a05600c365700b003f608ba6ea2mr410986wmq.15.1686884023787; Thu, 15 Jun 2023 19:53:43 -0700 (PDT) Received: from arinc9-Xeront.. (athedsl-404045.home.otenet.gr. [79.131.130.75]) by smtp.gmail.com with ESMTPSA id v15-20020a1cf70f000000b003f8d770e935sm890328wmh.0.2023.06.15.19.53.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jun 2023 19:53:43 -0700 (PDT) From: arinc9.unal@gmail.com X-Google-Original-From: arinc.unal@arinc9.com To: =?UTF-8?q?Ar=C4=B1n=C3=A7=20=C3=9CNAL?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King Cc: Landen Chao , Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH net v5 6/6] MAINTAINERS: add me as maintainer of MEDIATEK SWITCH DRIVER Date: Fri, 16 Jun 2023 05:53:27 +0300 Message-Id: <20230616025327.12652-7-arinc.unal@arinc9.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616025327.12652-1-arinc.unal@arinc9.com> References: <20230616025327.12652-1-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ar=C4=B1n=C3=A7 =C3=9CNAL Add me as a maintainer of the MediaTek MT7530 DSA subdriver. List maintainers in alphabetical order by first name. Signed-off-by: Ar=C4=B1n=C3=A7 =C3=9CNAL Reviewed-by: Vladimir Oltean --- MAINTAINERS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index a73e5a98503a..c58d7fbb40ed 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13259,10 +13259,11 @@ F: drivers/memory/mtk-smi.c F: include/soc/mediatek/smi.h =20 MEDIATEK SWITCH DRIVER -M: Sean Wang +M: Ar=C4=B1n=C3=A7 =C3=9CNAL +M: Daniel Golle M: Landen Chao M: DENG Qingfang -M: Daniel Golle +M: Sean Wang L: netdev@vger.kernel.org S: Maintained F: drivers/net/dsa/mt7530-mdio.c --=20 2.39.2