From nobody Sun Feb 8 17:37:50 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30AB8EB64D9 for ; Thu, 15 Jun 2023 16:17:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233738AbjFOQRM (ORCPT ); Thu, 15 Jun 2023 12:17:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233686AbjFOQRH (ORCPT ); Thu, 15 Jun 2023 12:17:07 -0400 X-Greylist: delayed 532 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 15 Jun 2023 09:17:04 PDT Received: from mail.holtmann.org (coyote.holtmann.net [212.227.132.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CAB77ED for ; Thu, 15 Jun 2023 09:17:04 -0700 (PDT) Received: from fedora.. (p5b3d25f5.dip0.t-ipconnect.de [91.61.37.245]) by mail.holtmann.org (Postfix) with ESMTPSA id 4A1AACECD7; Thu, 15 Jun 2023 18:08:10 +0200 (CEST) From: Marcel Holtmann To: linux-cachefs@redhat.com, linux-kernel@vger.kernel.org Cc: dhowells@redhat.com, arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH] cachefiles: allocate static minor for /dev/cachefiles Date: Thu, 15 Jun 2023 18:08:06 +0200 Message-Id: <20230615160806.94000-1-marcel@holtmann.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The cachefiles misc character device uses MISC_DYNAMIC_MINOR and thus doesn't support module auto-loading. Assign a static minor number for it and provide appropriate module aliases for it. This is enough for kmod to create the /dev/cachefiles device node on startup and facility module auto-loading. Signed-off-by: Marcel Holtmann --- Documentation/admin-guide/devices.txt | 3 ++- fs/cachefiles/main.c | 4 +++- include/linux/miscdevice.h | 1 + 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Documentation/admin-guide/devices.txt b/Documentation/admin-gu= ide/devices.txt index 06c525e01ea5..21b2dda10006 100644 --- a/Documentation/admin-guide/devices.txt +++ b/Documentation/admin-guide/devices.txt @@ -376,8 +376,9 @@ 240 =3D /dev/userio Serio driver testing device 241 =3D /dev/vhost-vsock Host kernel driver for virtio vsock 242 =3D /dev/rfkill Turning off radio transmissions (rfkill) + 243 =3D /dev/cachefiles Filesystem caching on files =20 - 243-254 Reserved for local use + 244-254 Reserved for local use 255 Reserved for MISC_DYNAMIC_MINOR =20 11 char Raw keyboard device (Linux/SPARC only) diff --git a/fs/cachefiles/main.c b/fs/cachefiles/main.c index 3f369c6f816d..eead7b5016a7 100644 --- a/fs/cachefiles/main.c +++ b/fs/cachefiles/main.c @@ -30,11 +30,13 @@ MODULE_PARM_DESC(cachefiles_debug, "CacheFiles debuggin= g mask"); MODULE_DESCRIPTION("Mounted-filesystem based cache"); MODULE_AUTHOR("Red Hat, Inc."); MODULE_LICENSE("GPL"); +MODULE_ALIAS("devname:cachefiles"); +MODULE_ALIAS_MISCDEV(CACHEFILES_MINOR); =20 struct kmem_cache *cachefiles_object_jar; =20 static struct miscdevice cachefiles_dev =3D { - .minor =3D MISC_DYNAMIC_MINOR, + .minor =3D CACHEFILES_MINOR, .name =3D "cachefiles", .fops =3D &cachefiles_daemon_fops, }; diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h index c0fea6ca5076..d7f989f593b0 100644 --- a/include/linux/miscdevice.h +++ b/include/linux/miscdevice.h @@ -71,6 +71,7 @@ #define USERIO_MINOR 240 #define VHOST_VSOCK_MINOR 241 #define RFKILL_MINOR 242 +#define CACHEFILES_MINOR 243 #define MISC_DYNAMIC_MINOR 255 =20 struct device; --=20 2.40.1