From nobody Mon Feb 9 12:24:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF240EB64DB for ; Thu, 15 Jun 2023 10:54:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343716AbjFOKyY (ORCPT ); Thu, 15 Jun 2023 06:54:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343725AbjFOKyQ (ORCPT ); Thu, 15 Jun 2023 06:54:16 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBA6F269A; Thu, 15 Jun 2023 03:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1686826455; x=1718362455; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fkwNJa0lrqgcBoAYQJldjJ8QWkitSk0hghnyQyG2tqs=; b=hT9Nt/YdvKF7OJU2kBX7ebjgrYQwFzQ0wi1fgS3SgxQxMwQ/yEW7wwwD Etyc26BUl87d/CTiLDR4yZ8QuRV4nbiCCHlsqLuVRR92Px0Of3+QQfrGx hdL4vTbJ12QOqQUEvMtJ/e9Dmm4l2vB4+0o7lvfwaBP4sB7iagqV+Ry9f Bqm8UovqRIhRYWmjuMU2EvZQg7lTJCzg5zqb0Lcd9M3X0rcLw8txbxG7Z jYf4M1UfTsx3+slTNX8ZUp5KitcIbClV6Jpe1tPtPjSDrQm0errGO1qCx wp3VJbQImV8olCph7USS4eP/be9i927bAUkFXgj47+Oorok2DdT4OYj+6 g==; X-IronPort-AV: E=Sophos;i="6.00,244,1681196400"; d="scan'208";a="218006816" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 15 Jun 2023 03:54:15 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 15 Jun 2023 03:54:06 -0700 Received: from m18063-ThinkPad-T460p.mchp-main.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Thu, 15 Jun 2023 03:54:02 -0700 From: Claudiu Beznea To: , , , , , , , , CC: , , , Claudiu Beznea Subject: [PATCH 3/3] pinctrl: at91-pio4: check return value of devm_kasprintf() Date: Thu, 15 Jun 2023 13:53:33 +0300 Message-ID: <20230615105333.585304-4-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230615105333.585304-1-claudiu.beznea@microchip.com> References: <20230615105333.585304-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" devm_kasprintf() returns a pointer to dynamically allocated memory. Pointer could be NULL in case allocation fails. Check pointer validity. Identified with coccinelle (kmerr.cocci script). Fixes: 776180848b57 ("pinctrl: introduce driver for Atmel PIO4 controller") Depends-on: 1c4e5c470a56 ("pinctrl: at91: use devm_kasprintf() to avoid pot= ential leaks") Depends-on: 5a8f9cf269e8 ("pinctrl: at91-pio4: use proper format specifier = for unsigned int") Signed-off-by: Claudiu Beznea Reviewed-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-at91-pio4.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-= at91-pio4.c index e40487be2038..fc7d7155bb8d 100644 --- a/drivers/pinctrl/pinctrl-at91-pio4.c +++ b/drivers/pinctrl/pinctrl-at91-pio4.c @@ -1146,6 +1146,8 @@ static int atmel_pinctrl_probe(struct platform_device= *pdev) /* Pin naming convention: P(bank_name)(bank_pin_number). */ pin_desc[i].name =3D devm_kasprintf(&pdev->dev, GFP_KERNEL, "P%c%u", bank + 'A', line); + if (!pin_desc[i].name) + return -ENOMEM; =20 group->name =3D group_names[i] =3D pin_desc[i].name; group->pin =3D pin_desc[i].number; --=20 2.34.1