From nobody Tue Feb 10 01:19:46 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A043EB64DC for ; Thu, 15 Jun 2023 10:54:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343639AbjFOKyF (ORCPT ); Thu, 15 Jun 2023 06:54:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343540AbjFOKyC (ORCPT ); Thu, 15 Jun 2023 06:54:02 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28D9A2135; Thu, 15 Jun 2023 03:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1686826441; x=1718362441; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3v+xI5WPh077/j0cQYGy7LYrHkohpui4PXNg4lHsRLY=; b=o7P8br4gAIyeK5YDjN6hpuU9ARopmlcu1LKKeUayl1DOCV5Ri6Vlz0Nz /JXYeD/V9dptzhq5rqgZ++mW4irLNpmi0GQKQyJS1hfv2ps7f5caE4VqK 2fz3aDb/6Up4zPKGmkSS1/o11j5CJZ6YyvmYLhARLEHS5gUE+FkEz4c1D 6DcG4CQmKlJA3OpUfrndeND3I2wQN0+/0+zpUwAlI0TKhsFuxRak7Fb8V UXAIgyur2ihUNKDw+udeDe6Xf6Z9nv2fUBR3ohBTGTFMUVZ9e+2CBP9SC tFQGcjQlidwP3G5xLV2NSXp0fWvbZsztBzYhAq3EC1LF104HmD1+ZSG3l g==; X-IronPort-AV: E=Sophos;i="6.00,244,1681196400"; d="scan'208";a="218006713" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 15 Jun 2023 03:54:01 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 15 Jun 2023 03:54:01 -0700 Received: from m18063-ThinkPad-T460p.mchp-main.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Thu, 15 Jun 2023 03:53:57 -0700 From: Claudiu Beznea To: , , , , , , , , CC: , , , Claudiu Beznea Subject: [PATCH 2/3] pinctrl: microchip-sgpio: check return value of devm_kasprintf() Date: Thu, 15 Jun 2023 13:53:32 +0300 Message-ID: <20230615105333.585304-3-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230615105333.585304-1-claudiu.beznea@microchip.com> References: <20230615105333.585304-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" devm_kasprintf() returns a pointer to dynamically allocated memory. Pointer could be NULL in case allocation fails. Check pointer validity. Identified with coccinelle (kmerr.cocci script). Fixes: 7e5ea974e61c ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver = for Microsemi Serial GPIO") Signed-off-by: Claudiu Beznea Reviewed-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-microchip-sgpio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pi= nctrl-microchip-sgpio.c index 4794602316e7..666d8b7cdbad 100644 --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c @@ -818,6 +818,9 @@ static int microchip_sgpio_register_bank(struct device = *dev, pctl_desc->name =3D devm_kasprintf(dev, GFP_KERNEL, "%s-%sput", dev_name(dev), bank->is_input ? "in" : "out"); + if (!pctl_desc->name) + return -ENOMEM; + pctl_desc->pctlops =3D &sgpio_pctl_ops; pctl_desc->pmxops =3D &sgpio_pmx_ops; pctl_desc->confops =3D &sgpio_confops; --=20 2.34.1