From nobody Sat Feb 7 20:39:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F280EB64D9 for ; Wed, 14 Jun 2023 16:30:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233803AbjFNQaZ (ORCPT ); Wed, 14 Jun 2023 12:30:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233835AbjFNQaQ (ORCPT ); Wed, 14 Jun 2023 12:30:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D197212D for ; Wed, 14 Jun 2023 09:30:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B285863CA5 for ; Wed, 14 Jun 2023 16:30:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CEACC433CA; Wed, 14 Jun 2023 16:30:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686760214; bh=IqJAuDAh+oPrQmuQFsWP4nPEM1N5IZtP0C9lgOkmGBw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XsBi+9UiefrdfNEDmXoLkyXbN7qPPv+SucqyXQs4pDYMmmmIWL0EsOMMg+EDz9yeS mbSUh3W7xrrGHzP26miKczUGDJblmQ0PL220Z50/jMVfeni8fNh9uVp76Re2R+yfQ7 Kuoj/u8gVIeJGlDndbwOXTbP7GCjfP3LLpFFnuURyYYk5gawtHpbFJsPs+KSykOyny 2ruIkH4prN+JlvXGi/PmWm6V2qml1tWQFFVoO2lLoAD9/0UVfbYfxEdx5podKpc/4i 3rcGV+gtapTOKOQyRvNDMXbF1zlk2B0TpVtZd8+c+LcKi9vOTQXa+8vnkc6hv2IJh6 5jXxy5ewtTX0g== From: Jisheng Zhang To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: [PATCH 1/3] net: stmmac: don't clear network statistics in .ndo_open() Date: Thu, 15 Jun 2023 00:18:45 +0800 Message-Id: <20230614161847.4071-2-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230614161847.4071-1-jszhang@kernel.org> References: <20230614161847.4071-1-jszhang@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" FWICT, the common style in other network drivers: the network statistics are not cleared since initialization, follow the common style for stmmac. Signed-off-by: Jisheng Zhang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/ne= t/ethernet/stmicro/stmmac/stmmac_main.c index 0fca81507a77..951e037d0a80 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -3823,10 +3823,6 @@ static int __stmmac_open(struct net_device *dev, } } =20 - /* Extra statistics */ - memset(&priv->xstats, 0, sizeof(struct stmmac_extra_stats)); - priv->xstats.threshold =3D tc; - priv->rx_copybreak =3D STMMAC_RX_COPYBREAK; =20 buf_sz =3D dma_conf->dma_buf_sz; @@ -7307,6 +7303,8 @@ int stmmac_dvr_probe(struct device *device, #endif priv->msg_enable =3D netif_msg_init(debug, default_msg_level); =20 + priv->xstats.threshold =3D tc; + /* Initialize RSS */ rxq =3D priv->plat->rx_queues_to_use; netdev_rss_key_fill(priv->rss.key, sizeof(priv->rss.key)); --=20 2.40.1