From nobody Sun Feb 8 04:34:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09474C001B3 for ; Tue, 20 Jun 2023 08:28:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231925AbjFTI2c (ORCPT ); Tue, 20 Jun 2023 04:28:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231909AbjFTI2a (ORCPT ); Tue, 20 Jun 2023 04:28:30 -0400 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDC17130; Tue, 20 Jun 2023 01:28:25 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 35K8SIHg131019; Tue, 20 Jun 2023 03:28:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1687249698; bh=suCPQPrzzGFfP4KenDy/T5byFv935u0r7FkdI3FxBb8=; h=From:Date:Subject:References:In-Reply-To:To:CC; b=Ak0WeTnAy3ZxPjUz74Z60HqtjFXrMaLEDaQ8yMLB6QwaeO8JQhddUzqkVVudnbBuU AHg41gN8gHjdHJwyjGRbbvuz2bgA8FAkOxsfxj/MkvcUN5HxWYCB76dlZx29ZwiatA pXIm9xxtb7DDnxbgCA18vm43v8BnQs/IuXBEjXL4= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 35K8SIjQ022384 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 20 Jun 2023 03:28:18 -0500 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 20 Jun 2023 03:28:18 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 20 Jun 2023 03:28:18 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 35K8SHdC065731; Tue, 20 Jun 2023 03:28:18 -0500 From: Kamlesh Gurudasani Date: Tue, 20 Jun 2023 13:56:59 +0530 Subject: [PATCH v4 1/2] dt-bindings: crypto: ti,sa2ul: make power-domains conditional MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20230614-sa3ul-v4-1-7c969f626796@ti.com> References: <20230614-sa3ul-v4-0-7c969f626796@ti.com> In-Reply-To: <20230614-sa3ul-v4-0-7c969f626796@ti.com> To: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jayesh Choudhary CC: , , , Kamlesh Gurudasani , Conor Dooley X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1687249695; l=1420; i=kamlesh@ti.com; s=20230614; h=from:subject:message-id; bh=9fFLiJzU0nj0ThkjDNPisO+/050gLX2S2toEaa+3810=; b=hZIGO2szRT25GerYQmO4Jq6Qssaj4zGAijghN1ci5tJLrgsDoC+CK2vJXXAhhaIwiyLeWR7JA UwgCauj2rEjCN9MIWQxyV3LWcvWYP0BkPaTnG3VTQbCoNRXS+hDc9SS X-Developer-Key: i=kamlesh@ti.com; a=ed25519; pk=db9XKPVWDGJVqj2jDqgnPQd6uQf3GZ3oaQa4bq1odGo= X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Devices specific to compatible ti,am62-sa3ul don't have control over power of SA3UL from main domain. "power-domains" property in crypto node tries to access the SA3UL power, for which it gets NACK and hence, driver doesn't probe properly for those particular devices. Make "power-domains" property as false for devices with compatible ti,am62-sa3ul. Fixes: 2ce9a7299bf6 ("dt-bindings: crypto: Add TI SA2UL crypto accelerator = documentation") Reviewed-by: Conor Dooley Signed-off-by: Kamlesh Gurudasani --- Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Docum= entation/devicetree/bindings/crypto/ti,sa2ul.yaml index 77ec8bc70bf7..f0ef7685550a 100644 --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml @@ -66,10 +66,22 @@ patternProperties: required: - compatible - reg - - power-domains - dmas - dma-names =20 +allOf: + - if: + properties: + compatible: + contains: + const: ti,am62-sa3ul + then: + properties: + power-domains: false + else: + required: + - power-domains + additionalProperties: false =20 examples: --=20 2.34.1 From nobody Sun Feb 8 04:34:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2291DEB64D7 for ; Tue, 20 Jun 2023 08:28:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231920AbjFTI2e (ORCPT ); Tue, 20 Jun 2023 04:28:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231911AbjFTI2a (ORCPT ); Tue, 20 Jun 2023 04:28:30 -0400 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDD91132; Tue, 20 Jun 2023 01:28:25 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 35K8SKWq131024; Tue, 20 Jun 2023 03:28:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1687249700; bh=mKtCUPgaud8pjCzNSvAn4kZizjOxNjiafARqukJWj+8=; h=From:Date:Subject:References:In-Reply-To:To:CC; b=h2EEn6uY2RoBnI1oT1TfviGf+MRBU2R/DzBpna36nkXQua/s2JSW/UF9SfyHwsWlh wM9RAmXTrVsT0eQKLfEDsUsatvgnUx2NxyiAoRapOt5hVBmeMBrOhjLo256FqLvWlj GPpTg1v+JllHNViI3c70QpfT6i53aljGm9JnA/0E= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 35K8SKmR005164 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 20 Jun 2023 03:28:20 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 20 Jun 2023 03:28:19 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 20 Jun 2023 03:28:19 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 35K8SJdb010857; Tue, 20 Jun 2023 03:28:19 -0500 From: Kamlesh Gurudasani Date: Tue, 20 Jun 2023 13:57:00 +0530 Subject: [PATCH v4 2/2] arm64: dts: ti: k3-am62-main: Remove power-domains from crypto node MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20230614-sa3ul-v4-2-7c969f626796@ti.com> References: <20230614-sa3ul-v4-0-7c969f626796@ti.com> In-Reply-To: <20230614-sa3ul-v4-0-7c969f626796@ti.com> To: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jayesh Choudhary CC: , , , Kamlesh Gurudasani X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1687249695; l=1080; i=kamlesh@ti.com; s=20230614; h=from:subject:message-id; bh=twkydDeRPS5AYQfyYZRmDOCh79DoQ65SqFyXWQK4qeQ=; b=PWS4JU8LX+bhAAPFR2oK0F1v7ZN3UN+EkLVNzavYEs9wBVqkaZD+O6BX9A1jRo1BCrfQjx2zn X82SXIz/6mwBnv60B1UpApxJUTiCHxk5s3EZDNqnn+qtb0+4pJRT1SV X-Developer-Key: i=kamlesh@ti.com; a=ed25519; pk=db9XKPVWDGJVqj2jDqgnPQd6uQf3GZ3oaQa4bq1odGo= X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Only SYSFW has control of SA3UL power. From SYSFW 08.04.00.002, for security reasons, device ID for power management of SA3UL has been removed. "power-domains" property in crypto node tries to access the SA3UL, for which it gets NACK and hence, SA3UL driver doesn't probe properly. Fixes: 8af893654c02 ("arm64: dts: ti: k3-am62-main: Enable crypto accelerat= or") Signed-off-by: Kamlesh Gurudasani --- arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts= /ti/k3-am62-main.dtsi index b3e4857bbbe4..18a6e9ffaf58 100644 --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi @@ -174,7 +174,6 @@ k3_reset: reset-controller { crypto: crypto@40900000 { compatible =3D "ti,am62-sa3ul"; reg =3D <0x00 0x40900000 0x00 0x1200>; - power-domains =3D <&k3_pds 70 TI_SCI_PD_SHARED>; #address-cells =3D <2>; #size-cells =3D <2>; ranges =3D <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>; --=20 2.34.1