From nobody Sun Dec 14 11:35:36 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE0CDC7EE2E for ; Tue, 13 Jun 2023 12:32:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242360AbjFMMc4 (ORCPT ); Tue, 13 Jun 2023 08:32:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241892AbjFMMcq (ORCPT ); Tue, 13 Jun 2023 08:32:46 -0400 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90E7C173C for ; Tue, 13 Jun 2023 05:32:43 -0700 (PDT) Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id DD0E63F26B for ; Tue, 13 Jun 2023 12:32:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1686659561; bh=hHaMBfP8cTjp0xc0R7xoilj8XNV0BDQ4DKwZIDqU/Oo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GBAb3pFAeuXCZAyNX2befsU6lgbifD7P55UGxeV1ailuebAahd6knjUOp2OiMklZH RW26yCFSea3jGV+ng+xULuXRqxOQoHDrGxZ9cgbHOEG2fex8RGweeALGTeG4XZSWci 6jqzE/yFNqoPhfbgMx0Vs0m9cUUXsEKfSJ8SKy0R6j+OWjN4hEHrYa6KdEJAkgoDfe pHmukk92w3DvTA0qD2zYl3m+mcKvL1ffR6etWa/1KeuyNCQr3UvaGNXEIQssD41JO4 fGVFJAeeXkfyO+wPWy2bjOqDRlF8323C8kXRWJfmrOAPAQgiTii4V/R7Hkgmdr3U9h ItlO7nWAazxBQ== Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-39aa9617c6bso3379953b6e.1 for ; Tue, 13 Jun 2023 05:32:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686659558; x=1689251558; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hHaMBfP8cTjp0xc0R7xoilj8XNV0BDQ4DKwZIDqU/Oo=; b=IPbmuiXEnPx4igko8m2t+2VmK1U8UL4kZlKkkxTmZ3z3NZ6TXzURxkb5ny3QvpCeGa wCJs8jbZUmVjK1Mi1ucj8PV2gb/612ajpMCnqZ0rcjE3CUOgy1MF+/UsChY5w3VG/C0q kjhcry29zIDiPvXp2N4hJ7/yTOcqV4h4jWI5q9Cd8ODfvDntKqiLPQptAsI3NPLm8ZcG 40BwSXhU1QiaflOPpkRtjdYjHzPPVkEV/wz4aSJqfR5X5sEo3XzuZi41qJ5kgZxV1xxS vO9vocLSfeZQKYLisDYyTLIgcHJLHG2rcbV3NOioYA17vjZl09Qrz0HiFgkixsn1/8Fe Jz9g== X-Gm-Message-State: AC+VfDz5WnD+al/CWbewLx6XDJVzYnRYdkXWAqukdV8QJVWTBQxiXxRX 5EDF9p+gYGHjeeZRUkxkbfvrpQPc9FXL9ob8MsuTWXd0ApatCjdoHE/+Ys1jnMA/D/naWr3vaJF pn8jo4yN1KvVb8+rpJPlzzSmOqEkcEHwJDbgSqPZMFxVJb4lSZQ== X-Received: by 2002:a05:6808:9a6:b0:39a:be43:6f13 with SMTP id e6-20020a05680809a600b0039abe436f13mr7138069oig.43.1686659558524; Tue, 13 Jun 2023 05:32:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4RfknMhI+ej6W4l7lYiCx6ttQnGKf4kPAEtDH1QaZaaEH5xHKVB655Rt8z4qsy4Iy99d7DmA== X-Received: by 2002:a05:6808:9a6:b0:39a:be43:6f13 with SMTP id e6-20020a05680809a600b0039abe436f13mr7138046oig.43.1686659558292; Tue, 13 Jun 2023 05:32:38 -0700 (PDT) Received: from magali.. ([2804:14c:bbe3:4606:ac1a:e505:990c:70e9]) by smtp.gmail.com with ESMTPSA id z26-20020a056808049a00b0039c532c9ae1sm4838116oid.55.2023.06.13.05.32.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 05:32:37 -0700 (PDT) From: Magali Lemes To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, shuah@kernel.org, vfedorenko@novek.ru, tianjia.zhang@linux.alibaba.com Cc: andrei.gherzan@canonical.com, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 2/4] selftests: net: tls: check if FIPS mode is enabled Date: Tue, 13 Jun 2023 09:32:20 -0300 Message-Id: <20230613123222.631897-3-magali.lemes@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230613123222.631897-1-magali.lemes@canonical.com> References: <20230613123222.631897-1-magali.lemes@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" TLS selftests use the ChaCha20-Poly1305 and SM4 algorithms, which are not FIPS compliant. When fips=3D1, this set of tests fails. Add a check and only run these tests if not in FIPS mode. Fixes: 4f336e88a870 ("selftests/tls: add CHACHA20-POLY1305 to tls selftests= ") Fixes: e506342a03c7 ("selftests/tls: add SM4 GCM/CCM to tls selftests") Reviewed-by: Jakub Kicinski Signed-off-by: Magali Lemes --- Changes in v4: - Add R-b tag. - Remove extra newline. =20 Changes in v3: - No need to initialize static variable to zero. - Skip tests during test setup only. - Use the constructor attribute to set fips_enabled before entering main(). =20 Changes in v2: - Put fips_non_compliant into the variants. - Turn fips_enabled into a static global variable. - Read /proc/sys/crypto/fips_enabled only once at main(). tools/testing/selftests/net/tls.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/ne= t/tls.c index e699548d4247..ff36844d14b4 100644 --- a/tools/testing/selftests/net/tls.c +++ b/tools/testing/selftests/net/tls.c @@ -25,6 +25,8 @@ #define TLS_PAYLOAD_MAX_LEN 16384 #define SOL_TLS 282 =20 +static int fips_enabled; + struct tls_crypto_info_keys { union { struct tls12_crypto_info_aes_gcm_128 aes128; @@ -235,7 +237,7 @@ FIXTURE_VARIANT(tls) { uint16_t tls_version; uint16_t cipher_type; - bool nopad; + bool nopad, fips_non_compliant; }; =20 FIXTURE_VARIANT_ADD(tls, 12_aes_gcm) @@ -254,24 +256,28 @@ FIXTURE_VARIANT_ADD(tls, 12_chacha) { .tls_version =3D TLS_1_2_VERSION, .cipher_type =3D TLS_CIPHER_CHACHA20_POLY1305, + .fips_non_compliant =3D true, }; =20 FIXTURE_VARIANT_ADD(tls, 13_chacha) { .tls_version =3D TLS_1_3_VERSION, .cipher_type =3D TLS_CIPHER_CHACHA20_POLY1305, + .fips_non_compliant =3D true, }; =20 FIXTURE_VARIANT_ADD(tls, 13_sm4_gcm) { .tls_version =3D TLS_1_3_VERSION, .cipher_type =3D TLS_CIPHER_SM4_GCM, + .fips_non_compliant =3D true, }; =20 FIXTURE_VARIANT_ADD(tls, 13_sm4_ccm) { .tls_version =3D TLS_1_3_VERSION, .cipher_type =3D TLS_CIPHER_SM4_CCM, + .fips_non_compliant =3D true, }; =20 FIXTURE_VARIANT_ADD(tls, 12_aes_ccm) @@ -311,6 +317,9 @@ FIXTURE_SETUP(tls) int one =3D 1; int ret; =20 + if (fips_enabled && variant->fips_non_compliant) + SKIP(return, "Unsupported cipher in FIPS mode"); + tls_crypto_info_init(variant->tls_version, variant->cipher_type, &tls12); =20 @@ -1865,4 +1874,17 @@ TEST(prequeue) { close(cfd); } =20 +static void __attribute__((constructor)) fips_check(void) { + int res; + FILE *f; + + f =3D fopen("/proc/sys/crypto/fips_enabled", "r"); + if (f) { + res =3D fscanf(f, "%d", &fips_enabled); + if (res !=3D 1) + ksft_print_msg("ERROR: Couldn't read /proc/sys/crypto/fips_enabled\n"); + fclose(f); + } +} + TEST_HARNESS_MAIN --=20 2.34.1