From nobody Mon Feb 9 04:28:46 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AC53C7EE2E for ; Tue, 13 Jun 2023 01:12:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238708AbjFMBMJ (ORCPT ); Mon, 12 Jun 2023 21:12:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238109AbjFMBMH (ORCPT ); Mon, 12 Jun 2023 21:12:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A599101; Mon, 12 Jun 2023 18:12:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F404863079; Tue, 13 Jun 2023 01:12:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CE91C433EF; Tue, 13 Jun 2023 01:12:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686618722; bh=s2B8jsyrAMp70vnL8t+VU1TAoQczCjHuMAecRCqHfbs=; h=From:To:Cc:Subject:Date:From; b=MDtbZq/YIgU4w5Mjy34aMseasppY5x6FJ2bJ3b/DNb3cmDYOXij8PSXRLNTtAlTPz oA06kJovpjEY4Ob3igRKSNBni3AWzrLC0k79X9basD0M9Uqc3bJK1kxUgbBMskamkC 55sRnsgbYtCaOORxmCLwiP1+sbm3MNkSQYyyZKHWyqE4lL6Z2Zp0xPTlvkNw0sbKoS vP3WutOLeUdWFjxLFXYXuXHD4EMmlnO6uGfmapFQQirR/wS4No1G+FtTsFL7bnxdIO kcn4m0RWFdtuKa9L7yiNYU8/DxpxwKB7MqpUObwanJPxa9oEoSEInekRzPg3mYBwiK fSlhp9xn9aaKA== From: Stephen Boyd To: Michael Turquette , Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, Maxime Ripard , kernel test robot Subject: [PATCH] ASoC: tlv320aic32x4: pll: Remove impossible condition in clk_aic32x4_pll_determine_rate() Date: Mon, 12 Jun 2023 18:12:00 -0700 Message-ID: <20230613011201.1166753-1-sboyd@kernel.org> X-Mailer: git-send-email 2.41.0.162.gfafddb0af9-goog MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Smatch warns: sound/soc/codecs/tlv320aic32x4-clk.c:219 clk_aic32x4_pll_determine_rate() w= arn: unsigned 'rate' is never less than zero. Cc: Maxime Ripard Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306101217.08CRVGcK-lkp@int= el.com/ Fixes: 25d43ec352ea ("ASoC: tlv320aic32x4: pll: Switch to determine_rate") Signed-off-by: Stephen Boyd Reviewed-by: Maxime Ripard --- sound/soc/codecs/tlv320aic32x4-clk.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/tlv320aic32x4-clk.c b/sound/soc/codecs/tlv320= aic32x4-clk.c index a7ec501b4c69..c116e82f712d 100644 --- a/sound/soc/codecs/tlv320aic32x4-clk.c +++ b/sound/soc/codecs/tlv320aic32x4-clk.c @@ -208,18 +208,14 @@ static int clk_aic32x4_pll_determine_rate(struct clk_= hw *hw, struct clk_rate_request *req) { struct clk_aic32x4_pll_muldiv settings; - unsigned long rate; int ret; =20 ret =3D clk_aic32x4_pll_calc_muldiv(&settings, req->rate, req->best_paren= t_rate); if (ret < 0) return -EINVAL; =20 - rate =3D clk_aic32x4_pll_calc_rate(&settings, req->best_parent_rate); - if (rate < 0) - return rate; + req->rate =3D clk_aic32x4_pll_calc_rate(&settings, req->best_parent_rate); =20 - req->rate =3D rate; return 0; } =20 --=20 https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/ https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git