From nobody Sat Feb 7 18:15:33 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4FC8EB64D7 for ; Tue, 13 Jun 2023 20:18:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237542AbjFMUSJ (ORCPT ); Tue, 13 Jun 2023 16:18:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236859AbjFMUSE (ORCPT ); Tue, 13 Jun 2023 16:18:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEB34A7 for ; Tue, 13 Jun 2023 13:18:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 225C463AA3 for ; Tue, 13 Jun 2023 20:18:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DFBBC433F2; Tue, 13 Jun 2023 20:18:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686687481; bh=VbxQM5rd9J1wfcJAjyGtGXRhnFYFWNB67/3Yu6cd5n0=; h=From:Date:Subject:References:In-Reply-To:To:From; b=O3RaT0cBLGNEsghEbmdNOiPflmBHxVUup3aXF12DDoUdgFMsai6zWeZMsOmE8Ygua hW6rEjUzwjkZCwn3dqj4DOUZ1XowH7wYEBAVg/jlk1OCI+fiA8W+N2Lntk1Dob6FzM ty5/DoSsVoGVEouMqiul5oDfou3Q4ibY1SyJdyA359U9rHBQ6fPa6qOrPgf43PJwfU AF00iBMLZLY5xnPNq0rnVKsy0WK55JBPWwhgrkVeghGvCD7P6Ga7eXytGmPg9sfNrZ sibc+lkLv7CYTrKzrxQPf5cXOezXLoVHSq5d4T2+bVPcY7YeuTv7XFq7/OO1UzT0IQ Iat18DOBcsoUA== From: Mark Brown Date: Tue, 13 Jun 2023 21:17:42 +0100 Subject: [PATCH 1/3] regmap: Add test that writes to write only registers are prevented MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230613-regmap-kunit-read-write-v1-1-2db337c52827@kernel.org> References: <20230613-regmap-kunit-read-write-v1-0-2db337c52827@kernel.org> In-Reply-To: <20230613-regmap-kunit-read-write-v1-0-2db337c52827@kernel.org> To: linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.13-dev-c6835 X-Developer-Signature: v=1; a=openpgp-sha256; l=2588; i=broonie@kernel.org; h=from:subject:message-id; bh=VbxQM5rd9J1wfcJAjyGtGXRhnFYFWNB67/3Yu6cd5n0=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBkiM71k5/z/PsKtne40l8ZSIrWf0Kq1vEaCQAKb1ak xfu3J6uJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZIjO9QAKCRAk1otyXVSH0LFSB/ 4iu0f4qqsIhrOuvGt6DUhUAKTmra/A+1DL+Fit6e8ZD1P/ceTBCnh1U8juy5erurEdLtR61Rs3RzPT yvULzzyZmYQRs1zaNLSYuXgkWVIdQr7TZXbB1BeDKSap9iMy93r5NR3YCGpVnf8oWon3alB8gdvCRl d/RT6VCW+fI8U0U4NKAELKknuUFN+nPhy19JUwW9xCZP9q1CuhWTABcaUg3Scm7KBNUeglL8W2BHuZ aBUtjo+AFat/rNCpeTVZivTJSLNooJvHypK+DcvH4rOPZGIari6v+henpikkr2U+mcjaTV4We3TTUc s6NI4AGr4qOaW1Tsw4SY5OqVpsZXHU X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We should have error checking that verifies that writes to write only registers are suppressed, verify that this happens as it should. Signed-off-by: Mark Brown --- drivers/base/regmap/regmap-kunit.c | 41 ++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 41 insertions(+) diff --git a/drivers/base/regmap/regmap-kunit.c b/drivers/base/regmap/regma= p-kunit.c index 4ec5cbfc0ca0..f5c175022a47 100644 --- a/drivers/base/regmap/regmap-kunit.c +++ b/drivers/base/regmap/regmap-kunit.c @@ -92,6 +92,11 @@ static struct regmap *gen_regmap(struct regmap_config *c= onfig, return ret; } =20 +static bool reg_5_false(struct device *context, unsigned int reg) +{ + return reg !=3D 5; +} + static void basic_read_write(struct kunit *test) { struct regcache_types *t =3D (struct regcache_types *)test->param_value; @@ -191,6 +196,41 @@ static void bulk_read(struct kunit *test) regmap_exit(map); } =20 +static void write_readonly(struct kunit *test) +{ + struct regcache_types *t =3D (struct regcache_types *)test->param_value; + struct regmap *map; + struct regmap_config config; + struct regmap_ram_data *data; + unsigned int val; + int i; + + config =3D test_regmap_config; + config.cache_type =3D t->type; + config.num_reg_defaults =3D BLOCK_TEST_SIZE; + config.writeable_reg =3D reg_5_false; + + map =3D gen_regmap(&config, &data); + KUNIT_ASSERT_FALSE(test, IS_ERR(map)); + if (IS_ERR(map)) + return; + + get_random_bytes(&val, sizeof(val)); + + for (i =3D 0; i < BLOCK_TEST_SIZE; i++) + data->written[i] =3D false; + + /* Change the value of all registers, readonly should fail */ + for (i =3D 0; i < BLOCK_TEST_SIZE; i++) + KUNIT_EXPECT_EQ(test, i !=3D 5, regmap_write(map, i, val) =3D=3D 0); + + /* Did that match what we see on the device? */ + for (i =3D 0; i < BLOCK_TEST_SIZE; i++) + KUNIT_EXPECT_EQ(test, i !=3D 5, data->written[i]); + + regmap_exit(map); +} + static void reg_defaults(struct kunit *test) { struct regcache_types *t =3D (struct regcache_types *)test->param_value; @@ -1037,6 +1077,7 @@ static struct kunit_case regmap_test_cases[] =3D { KUNIT_CASE_PARAM(basic_read_write, regcache_types_gen_params), KUNIT_CASE_PARAM(bulk_write, regcache_types_gen_params), KUNIT_CASE_PARAM(bulk_read, regcache_types_gen_params), + KUNIT_CASE_PARAM(write_readonly, regcache_types_gen_params), KUNIT_CASE_PARAM(reg_defaults, regcache_types_gen_params), KUNIT_CASE_PARAM(reg_defaults_read_dev, regcache_types_gen_params), KUNIT_CASE_PARAM(register_patch, regcache_types_gen_params), --=20 2.30.2 From nobody Sat Feb 7 18:15:33 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8511EB64D8 for ; Tue, 13 Jun 2023 20:18:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238628AbjFMUSN (ORCPT ); Tue, 13 Jun 2023 16:18:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234319AbjFMUSF (ORCPT ); Tue, 13 Jun 2023 16:18:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F7681980 for ; Tue, 13 Jun 2023 13:18:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1C63D63AA4 for ; Tue, 13 Jun 2023 20:18:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06020C433D9; Tue, 13 Jun 2023 20:18:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686687482; bh=WhDf+kiOS5aGuKfQUW/eJ+QBuABHGrCyRWVCjRn2dDA=; h=From:Date:Subject:References:In-Reply-To:To:From; b=WEpeg+qLFzsDtXVmweut5W1DguWjehSf3IVBlfEEC5VI5yCC+12DC1OIMLJpvzugu zQ+QOjBvRt/sL5P0xUXmAfCficmth4XFEJIAc1yTakGgc/VlndgTtyHrZMPxwrFOGx ch268kG7bRClsE+yKzXGKOIvz9NEvo2XD6wYAzr5/Pj/a5HVo7egDKLgjpsLuiCuU+ a3NLWdZQ+13qk3LkpNzbWXn7W7Vqha1lMp1b3ODLIynZtC685EtQ9pJuvYQPXchTWQ OoJCZONoESW4VeXShMOPGzJJdyFYL6nxpe1OMw+7soeW56HdkXZk1Q6/MLweeJvVPA uKuZmZF2kV9xA== From: Mark Brown Date: Tue, 13 Jun 2023 21:17:43 +0100 Subject: [PATCH 2/3] regmap: Add a test case for write only registers MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230613-regmap-kunit-read-write-v1-2-2db337c52827@kernel.org> References: <20230613-regmap-kunit-read-write-v1-0-2db337c52827@kernel.org> In-Reply-To: <20230613-regmap-kunit-read-write-v1-0-2db337c52827@kernel.org> To: linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.13-dev-c6835 X-Developer-Signature: v=1; a=openpgp-sha256; l=2087; i=broonie@kernel.org; h=from:subject:message-id; bh=WhDf+kiOS5aGuKfQUW/eJ+QBuABHGrCyRWVCjRn2dDA=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBkiM72N5yZTsPaXZCipx/1IPP5jFg2fekvhIb4EhIi TUR/LEqJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZIjO9gAKCRAk1otyXVSH0P9WB/ 93dMF8vQ5978ILOWs6dF215F8uwWjXb1gympEWm8GVV7VLqkzHMMZ+gJqcyWLKvCOkBLTEH9+oLSYV 8ANTje7h6yLATbj7puUUSFpSX+wTb4Qr29lW+EbDUBjZlglV6LeyhjJpS0JqU367KQtuMCOmKjzeUG GhR8eVyfVGRVnd3L8T6gqWoS8usrjqd+fAMlUlTE404zEp9kAxXp7zKJ+rPE8b3ivuO77w7rKAwNb+ WXf8oWy0d5EgBvOVvONVP2ZED5Hl9CQJ5JTUgAOStgZzrQByCFuZo++lcQrmnVuoP13ii76zuqSgPE YQtBkGy6TOOzZHRVZNegc7EguYulL/ X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Validate that attempts to read from write only registers fail and don't somehow trigger spurious hardware accesses. Signed-off-by: Mark Brown --- drivers/base/regmap/regmap-kunit.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/drivers/base/regmap/regmap-kunit.c b/drivers/base/regmap/regma= p-kunit.c index f5c175022a47..a1a1a9ce2e13 100644 --- a/drivers/base/regmap/regmap-kunit.c +++ b/drivers/base/regmap/regmap-kunit.c @@ -231,6 +231,37 @@ static void write_readonly(struct kunit *test) regmap_exit(map); } =20 +static void read_writeonly(struct kunit *test) +{ + struct regcache_types *t =3D (struct regcache_types *)test->param_value; + struct regmap *map; + struct regmap_config config; + struct regmap_ram_data *data; + unsigned int val; + int i; + + config =3D test_regmap_config; + config.cache_type =3D t->type; + config.readable_reg =3D reg_5_false; + + map =3D gen_regmap(&config, &data); + KUNIT_ASSERT_FALSE(test, IS_ERR(map)); + if (IS_ERR(map)) + return; + + for (i =3D 0; i < BLOCK_TEST_SIZE; i++) + data->read[i] =3D false; + + /* Try to read all the registers, the writeonly one should fail */ + for (i =3D 0; i < BLOCK_TEST_SIZE; i++) + KUNIT_EXPECT_EQ(test, i !=3D 5, regmap_read(map, i, &val) =3D=3D 0); + + /* Did we trigger a hardware access? */ + KUNIT_EXPECT_FALSE(test, data->read[5]); + + regmap_exit(map); +} + static void reg_defaults(struct kunit *test) { struct regcache_types *t =3D (struct regcache_types *)test->param_value; @@ -1078,6 +1109,7 @@ static struct kunit_case regmap_test_cases[] =3D { KUNIT_CASE_PARAM(bulk_write, regcache_types_gen_params), KUNIT_CASE_PARAM(bulk_read, regcache_types_gen_params), KUNIT_CASE_PARAM(write_readonly, regcache_types_gen_params), + KUNIT_CASE_PARAM(read_writeonly, regcache_types_gen_params), KUNIT_CASE_PARAM(reg_defaults, regcache_types_gen_params), KUNIT_CASE_PARAM(reg_defaults_read_dev, regcache_types_gen_params), KUNIT_CASE_PARAM(register_patch, regcache_types_gen_params), --=20 2.30.2 From nobody Sat Feb 7 18:15:33 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DBFBEB64D8 for ; Tue, 13 Jun 2023 20:18:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238982AbjFMUSR (ORCPT ); Tue, 13 Jun 2023 16:18:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235642AbjFMUSG (ORCPT ); Tue, 13 Jun 2023 16:18:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49EF61BC3 for ; Tue, 13 Jun 2023 13:18:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0DE7863AAA for ; Tue, 13 Jun 2023 20:18:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1359C433F0; Tue, 13 Jun 2023 20:18:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686687483; bh=HlCWEB0TkEMXgL7Np/AcOk7D/BltZYu6dtcLIzNuEH8=; h=From:Date:Subject:References:In-Reply-To:To:From; b=W2Wh8raVaRTIke7QaMgKW7bb/TlwBeupOGPXV/sst1O/Fjm0NsrY2ECkzyGFhVj3q aYy2xUjYidhYiH7CHSfsSpzygHfGwOPYU/X6RT0jdMFlJrrI6E26oh5Ts+THO2/Z8h icBIxMeG/dz5f6/1uvqzUCCnKmKcv8A18Bd0rZCBAKPHvDULTt125fB9hCsqVIurUj aDJ15UzDb2Y5gSkFVORxn7u2B64SaSKw/uFCnqsZL5Aa2/uqIbQL8f4kbEse5ODqsN JGcmSq+6zdvSdfGHzvPtEUz2XPjXijGxVCFQaKvYNdNfmZDxT2eyJNvj25hJ/lLqW0 DtznZ1ZiWuNsQ== From: Mark Brown Date: Tue, 13 Jun 2023 21:17:44 +0100 Subject: [PATCH 3/3] regmap: Add test to make sure we don't sync to read only registers MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230613-regmap-kunit-read-write-v1-3-2db337c52827@kernel.org> References: <20230613-regmap-kunit-read-write-v1-0-2db337c52827@kernel.org> In-Reply-To: <20230613-regmap-kunit-read-write-v1-0-2db337c52827@kernel.org> To: linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.13-dev-c6835 X-Developer-Signature: v=1; a=openpgp-sha256; l=2433; i=broonie@kernel.org; h=from:subject:message-id; bh=HlCWEB0TkEMXgL7Np/AcOk7D/BltZYu6dtcLIzNuEH8=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBkiM73rne9moWjQQWpOFaUabAmBps1dMoW4LJ/Aprh 5A+gDZ+JATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZIjO9wAKCRAk1otyXVSH0EKaB/ 9AygOvQGpuQY6j90FmJVeAy7sfgIMqlOHvl/lg5R3X+gvmWiAuANDXJohhJxr1Gti8iuiBHHx9gvWW +2YDu2Hlgp/RVoFM/ER68PharDYmySsBnrfNDE1djHtM7iss9G6ShaqoV6+CXqVTOXfq4zTp/bHCWq YY+S2uhuKgIc8Y0JmUMynnjh4KRZHOTw+NSS8aX9e36kbNXMPwugQQs+rjShjJCdYKWH2pr+uQcYgv HrNaUN96HHcL1Qlb2OeCLe6vs85DbehaPSSrUj62eEkqcah3P+Wlbl2wwYwoA20hHQzWa1hiCzol1U cA2oL9t6tyGLOyUREW7z02g+CxwSTE X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ensure that a read only value in the register cache does not result in a write during regcache_sync(). Signed-off-by: Mark Brown --- drivers/base/regmap/regmap-kunit.c | 42 ++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 42 insertions(+) diff --git a/drivers/base/regmap/regmap-kunit.c b/drivers/base/regmap/regma= p-kunit.c index a1a1a9ce2e13..6f444ac0ec49 100644 --- a/drivers/base/regmap/regmap-kunit.c +++ b/drivers/base/regmap/regmap-kunit.c @@ -680,6 +680,47 @@ static void cache_sync_defaults(struct kunit *test) regmap_exit(map); } =20 +static void cache_sync_readonly(struct kunit *test) +{ + struct regcache_types *t =3D (struct regcache_types *)test->param_value; + struct regmap *map; + struct regmap_config config; + struct regmap_ram_data *data; + unsigned int val; + int i; + + config =3D test_regmap_config; + config.cache_type =3D t->type; + config.writeable_reg =3D reg_5_false; + + map =3D gen_regmap(&config, &data); + KUNIT_ASSERT_FALSE(test, IS_ERR(map)); + if (IS_ERR(map)) + return; + + /* Read all registers to fill the cache */ + for (i =3D 0; i < BLOCK_TEST_SIZE; i++) + KUNIT_EXPECT_EQ(test, 0, regmap_read(map, i, &val)); + + /* Change the value of all registers, readonly should fail */ + get_random_bytes(&val, sizeof(val)); + regcache_cache_only(map, true); + for (i =3D 0; i < BLOCK_TEST_SIZE; i++) + KUNIT_EXPECT_EQ(test, i !=3D 5, regmap_write(map, i, val) =3D=3D 0); + regcache_cache_only(map, false); + + /* Resync */ + for (i =3D 0; i < BLOCK_TEST_SIZE; i++) + data->written[i] =3D false; + KUNIT_EXPECT_EQ(test, 0, regcache_sync(map)); + + /* Did that match what we see on the device? */ + for (i =3D 0; i < BLOCK_TEST_SIZE; i++) + KUNIT_EXPECT_EQ(test, i !=3D 5, data->written[i]); + + regmap_exit(map); +} + static void cache_sync_patch(struct kunit *test) { struct regcache_types *t =3D (struct regcache_types *)test->param_value; @@ -1119,6 +1160,7 @@ static struct kunit_case regmap_test_cases[] =3D { KUNIT_CASE_PARAM(cache_bypass, real_cache_types_gen_params), KUNIT_CASE_PARAM(cache_sync, real_cache_types_gen_params), KUNIT_CASE_PARAM(cache_sync_defaults, real_cache_types_gen_params), + KUNIT_CASE_PARAM(cache_sync_readonly, real_cache_types_gen_params), KUNIT_CASE_PARAM(cache_sync_patch, real_cache_types_gen_params), KUNIT_CASE_PARAM(cache_drop, sparse_cache_types_gen_params), =20 --=20 2.30.2