From nobody Mon Feb 9 14:14:34 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A861CC7EE43 for ; Mon, 12 Jun 2023 19:26:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237357AbjFLT0S (ORCPT ); Mon, 12 Jun 2023 15:26:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237521AbjFLT0H (ORCPT ); Mon, 12 Jun 2023 15:26:07 -0400 Received: from 189.cn (ptr.189.cn [183.61.185.102]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 31A6910D9; Mon, 12 Jun 2023 12:26:04 -0700 (PDT) HMM_SOURCE_IP: 10.64.8.41:42778.1249123675 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-114.242.206.180 (unknown [10.64.8.41]) by 189.cn (HERMES) with SMTP id 311461002B2; Tue, 13 Jun 2023 03:25:59 +0800 (CST) Received: from ([114.242.206.180]) by gateway-151646-dep-75648544bd-xwndj with ESMTP id 6d29b3ab2b714ff0869e711772a8b3e0 for alexander.deucher@amd.com; Tue, 13 Jun 2023 03:26:04 CST X-Transaction-ID: 6d29b3ab2b714ff0869e711772a8b3e0 X-Real-From: 15330273260@189.cn X-Receive-IP: 114.242.206.180 X-MEDUSA-Status: 0 Sender: 15330273260@189.cn From: Sui Jingfeng <15330273260@189.cn> To: Alex Deucher , Christian Konig , Pan Xinhui , David Airlie , Daniel Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Ben Skeggs , Karol Herbst , Lyude Paul , Bjorn Helgaas , Alex Williamson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Hawking Zhang , Mario Limonciello , Lijo Lazar , YiPeng Chai , Andrey Grodzovsky , Somalapuram Amaranath , Bokun Zhang , Ville Syrjala , Li Yi , Sui Jingfeng , Jason Gunthorpe , Kevin Tian , Cornelia Huck , Yishai Hadas , Abhishek Sahu , Yi Liu Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, loongson-kernel@lists.loongnix.cn Subject: [PATCH v6 2/8] PCI/VGA: Deal only with VGA class devices Date: Tue, 13 Jun 2023 03:25:44 +0800 Message-Id: <20230612192550.197053-3-15330273260@189.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230612192550.197053-1-15330273260@189.cn> References: <20230612192550.197053-1-15330273260@189.cn> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Sui Jingfeng Deal only with the VGA devcie(pdev->class =3D=3D 0x0300), so replace the pci_get_subsys() function with pci_get_class(). Filter the non-PCI display device(pdev->class !=3D 0x0300) out. There no need to process the non-displ= ay PCI device. Signed-off-by: Sui Jingfeng Reviewed-by: Mario Limonciello --- drivers/pci/vgaarb.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c index c1bc6c983932..22a505e877dc 100644 --- a/drivers/pci/vgaarb.c +++ b/drivers/pci/vgaarb.c @@ -754,10 +754,6 @@ static bool vga_arbiter_add_pci_device(struct pci_dev = *pdev) struct pci_dev *bridge; u16 cmd; =20 - /* Only deal with VGA class devices */ - if ((pdev->class >> 8) !=3D PCI_CLASS_DISPLAY_VGA) - return false; - /* Allocate structure */ vgadev =3D kzalloc(sizeof(struct vga_device), GFP_KERNEL); if (vgadev =3D=3D NULL) { @@ -1500,7 +1496,9 @@ static int pci_notify(struct notifier_block *nb, unsi= gned long action, struct pci_dev *pdev =3D to_pci_dev(dev); bool notify =3D false; =20 - vgaarb_dbg(dev, "%s\n", __func__); + /* Only deal with VGA class devices */ + if (pdev->class !=3D PCI_CLASS_DISPLAY_VGA << 8) + return 0; =20 /* For now we're only intereted in devices added and removed. I didn't * test this thing here, so someone needs to double check for the @@ -1510,6 +1508,8 @@ static int pci_notify(struct notifier_block *nb, unsi= gned long action, else if (action =3D=3D BUS_NOTIFY_DEL_DEVICE) notify =3D vga_arbiter_del_pci_device(pdev); =20 + vgaarb_dbg(dev, "%s: action =3D %lu\n", __func__, action); + if (notify) vga_arbiter_notify_clients(); return 0; @@ -1534,8 +1534,8 @@ static struct miscdevice vga_arb_device =3D { =20 static int __init vga_arb_device_init(void) { + struct pci_dev *pdev =3D NULL; int rc; - struct pci_dev *pdev; =20 rc =3D misc_register(&vga_arb_device); if (rc < 0) @@ -1545,11 +1545,13 @@ static int __init vga_arb_device_init(void) =20 /* We add all PCI devices satisfying VGA class in the arbiter by * default */ - pdev =3D NULL; - while ((pdev =3D - pci_get_subsys(PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, - PCI_ANY_ID, pdev)) !=3D NULL) + while (1) { + pdev =3D pci_get_class(PCI_CLASS_DISPLAY_VGA << 8, pdev); + if (!pdev) + break; + vga_arbiter_add_pci_device(pdev); + } =20 pr_info("loaded\n"); return rc; --=20 2.25.1