From nobody Fri Dec 19 17:54:53 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89DD9C7EE23 for ; Mon, 12 Jun 2023 12:51:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233952AbjFLMvm (ORCPT ); Mon, 12 Jun 2023 08:51:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235641AbjFLMva (ORCPT ); Mon, 12 Jun 2023 08:51:30 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 422CFE52 for ; Mon, 12 Jun 2023 05:51:25 -0700 (PDT) Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id EEF113F11D for ; Mon, 12 Jun 2023 12:51:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1686574283; bh=53EQLqkSYcnfUW7tWTa0tl0p5nwMGKAhLFezoflGDnw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=EOHfr2fmYdIdE3jYWn1PTwt6Po9QbvFpY435RNRK5eeHyxd4LaKMl1q+KVsq59IGH gaqSqO9uILCb47gK4YY7b8EBl8eTm9WUs8BtLNbsAgQcXdOrpcykHQGLLHJPtd3t+G EkRFMvSKHUhGLNbZwdBkoqTiQQLS6U6cfGgqx9Plw8blI6P8NoQbvzRfJ8CAaJyPpS e3glmZmS7484FyejDbDYDAKvExNwZR3KWGVBk9cqECkMu3QnlRfznpfPnGesoukpRT xxhyizkRrDRidT/xSUlNKx9cL0jTxzj6XobIziWle84PCmhf4WBrGZL1DNdfdt8dI3 XxNPN7JncYx/Q== Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-6b2bf00f660so2803891a34.3 for ; Mon, 12 Jun 2023 05:51:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686574283; x=1689166283; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=53EQLqkSYcnfUW7tWTa0tl0p5nwMGKAhLFezoflGDnw=; b=Z1IOFjs23MQ6mZi6lWGxMykg9ngW+P4+nrgXcDc+3TIeknUH/FCCxBSWcDGN2sUjSS Sr46BnJqJh5JnxVfLmDASt2SfXfDpZRjGdfz7O5V5ZtbALRfmeYVilce7K+myym3PzIO vHor688PHAdyQSVTr2nVBPThsrcA1xWxKv6sS1j3rJwQ7hA1VlaxCnprouBcOMMuxwbw PSPDX15WPCWf5niyWjSxrgIhkvToWhegym1jFjaqjJN9wrOpqfp8itkrnr0KbTP61LqW +s0ExUhodcwDp1CaFE3vJvpi4D+A4v2PgdraxYegLh9JnA4BqHxXtMMWYiFKHNJCGgym 3LRg== X-Gm-Message-State: AC+VfDwszTJ2FnGYCzva/Q6FJGF8ns1hqXjEdBOih9BWasLtRcyJyXbY Zwc/0Y/fzev3FLPNgvJhe+uKGspej7ghxo1rSSseF40I8fRATLu3J/QSlUoWOA/koMQwBh1Pi6P x6paLVz+KLkWhd0ep0iYgMBjDyUysT2vN40fJ6ldtiw== X-Received: by 2002:a05:6870:8785:b0:1a6:88c4:5815 with SMTP id r5-20020a056870878500b001a688c45815mr2399842oam.57.1686574282896; Mon, 12 Jun 2023 05:51:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7d6CuEdbi4X+dikuOxYc7owlwRtCAJacFJFzXKOQlEcvp7Jz/z6S00gZUboMLR6TJ52c8YVQ== X-Received: by 2002:a05:6870:8785:b0:1a6:88c4:5815 with SMTP id r5-20020a056870878500b001a688c45815mr2399831oam.57.1686574282715; Mon, 12 Jun 2023 05:51:22 -0700 (PDT) Received: from magali.. ([2804:14c:bbe3:4606:d612:b95d:6bdc:8f6d]) by smtp.gmail.com with ESMTPSA id j22-20020a4ad196000000b00529cc3986c8sm3157193oor.40.2023.06.12.05.51.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 05:51:22 -0700 (PDT) From: Magali Lemes To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, shuah@kernel.org, vfedorenko@novek.ru, tianjia.zhang@linux.alibaba.com Cc: andrei.gherzan@canonical.com, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/4] selftests: net: tls: check if FIPS mode is enabled Date: Mon, 12 Jun 2023 09:51:05 -0300 Message-Id: <20230612125107.73795-3-magali.lemes@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230612125107.73795-1-magali.lemes@canonical.com> References: <20230612125107.73795-1-magali.lemes@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" TLS selftests use the ChaCha20-Poly1305 and SM4 algorithms, which are not FIPS compliant. When fips=3D1, this set of tests fails. Add a check and only run these tests if not in FIPS mode. Fixes: 4f336e88a870 ("selftests/tls: add CHACHA20-POLY1305 to tls selftests= ") Fixes: e506342a03c7 ("selftests/tls: add SM4 GCM/CCM to tls selftests") Signed-off-by: Magali Lemes Reviewed-by: Jakub Kicinski --- Changes in v3: - No need to initialize static variable to zero. - Skip tests during test setup only. - Use the constructor attribute to set fips_enabled before entering main(). =20 Changes in v2: - Put fips_non_compliant into the variants. - Turn fips_enabled into a static global variable. - Read /proc/sys/crypto/fips_enabled only once at main(). tools/testing/selftests/net/tls.c | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/ne= t/tls.c index e699548d4247..e4efe80d55e9 100644 --- a/tools/testing/selftests/net/tls.c +++ b/tools/testing/selftests/net/tls.c @@ -25,6 +25,8 @@ #define TLS_PAYLOAD_MAX_LEN 16384 #define SOL_TLS 282 =20 +static int fips_enabled; + struct tls_crypto_info_keys { union { struct tls12_crypto_info_aes_gcm_128 aes128; @@ -235,7 +237,7 @@ FIXTURE_VARIANT(tls) { uint16_t tls_version; uint16_t cipher_type; - bool nopad; + bool nopad, fips_non_compliant; }; =20 FIXTURE_VARIANT_ADD(tls, 12_aes_gcm) @@ -254,24 +256,28 @@ FIXTURE_VARIANT_ADD(tls, 12_chacha) { .tls_version =3D TLS_1_2_VERSION, .cipher_type =3D TLS_CIPHER_CHACHA20_POLY1305, + .fips_non_compliant =3D true, }; =20 FIXTURE_VARIANT_ADD(tls, 13_chacha) { .tls_version =3D TLS_1_3_VERSION, .cipher_type =3D TLS_CIPHER_CHACHA20_POLY1305, + .fips_non_compliant =3D true, }; =20 FIXTURE_VARIANT_ADD(tls, 13_sm4_gcm) { .tls_version =3D TLS_1_3_VERSION, .cipher_type =3D TLS_CIPHER_SM4_GCM, + .fips_non_compliant =3D true, }; =20 FIXTURE_VARIANT_ADD(tls, 13_sm4_ccm) { .tls_version =3D TLS_1_3_VERSION, .cipher_type =3D TLS_CIPHER_SM4_CCM, + .fips_non_compliant =3D true, }; =20 FIXTURE_VARIANT_ADD(tls, 12_aes_ccm) @@ -311,6 +317,9 @@ FIXTURE_SETUP(tls) int one =3D 1; int ret; =20 + if (fips_enabled && variant->fips_non_compliant) + SKIP(return, "Unsupported cipher in FIPS mode"); + tls_crypto_info_init(variant->tls_version, variant->cipher_type, &tls12); =20 @@ -406,6 +415,7 @@ static void chunked_sendfile(struct __test_metadata *_m= etadata, =20 TEST_F(tls, multi_chunk_sendfile) { + chunked_sendfile(_metadata, self, 4096, 4096); chunked_sendfile(_metadata, self, 4096, 0); chunked_sendfile(_metadata, self, 4096, 1); @@ -1865,4 +1875,17 @@ TEST(prequeue) { close(cfd); } =20 +static void __attribute__((constructor)) fips_check(void) { + int res; + FILE *f; + + f =3D fopen("/proc/sys/crypto/fips_enabled", "r"); + if (f) { + res =3D fscanf(f, "%d", &fips_enabled); + if (res !=3D 1) + ksft_print_msg("ERROR: Couldn't read /proc/sys/crypto/fips_enabled\n"); + fclose(f); + } +} + TEST_HARNESS_MAIN --=20 2.34.1