From nobody Sun Feb 8 02:21:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2BDFC77B7A for ; Thu, 8 Jun 2023 01:38:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232101AbjFHBio (ORCPT ); Wed, 7 Jun 2023 21:38:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbjFHBim (ORCPT ); Wed, 7 Jun 2023 21:38:42 -0400 Received: from mail.nfschina.com (unknown [42.101.60.195]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 21ED01FF3 for ; Wed, 7 Jun 2023 18:38:40 -0700 (PDT) Received: from localhost.localdomain (unknown [219.141.250.2]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id C0E5C1801128C4; Thu, 8 Jun 2023 09:38:37 +0800 (CST) X-MD-Sfrom: zeming@nfschina.com X-MD-SrcIP: 219.141.250.2 From: Li zeming To: jstultz@google.com, tglx@linutronix.de, sboyd@kernel.org Cc: linux-kernel@vger.kernel.org, Li zeming Subject: [PATCH] time: alarmtimer: Optimization function return value Date: Sat, 10 Jun 2023 02:09:55 +0800 Message-Id: <20230609180955.4357-1-zeming@nfschina.com> X-Mailer: git-send-email 2.18.2 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Replace -1 return values with -EPERM. Signed-off-by: Li zeming --- kernel/time/alarmtimer.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c index 82b28ab0f328..e918d556dd51 100644 --- a/kernel/time/alarmtimer.c +++ b/kernel/time/alarmtimer.c @@ -92,9 +92,9 @@ static int alarmtimer_rtc_add_device(struct device *dev) return -EBUSY; =20 if (!test_bit(RTC_FEATURE_ALARM, rtc->features)) - return -1; + return -EPERM; if (!device_may_wakeup(rtc->dev.parent)) - return -1; + return -EPERM; =20 pdev =3D platform_device_register_data(dev, "alarmtimer", PLATFORM_DEVID_AUTO, NULL, 0); @@ -104,7 +104,7 @@ static int alarmtimer_rtc_add_device(struct device *dev) spin_lock_irqsave(&rtcdev_lock, flags); if (!IS_ERR(pdev) && !rtcdev) { if (!try_module_get(rtc->owner)) { - ret =3D -1; + ret =3D -EPERM; goto unlock; } =20 @@ -113,7 +113,7 @@ static int alarmtimer_rtc_add_device(struct device *dev) get_device(dev); pdev =3D NULL; } else { - ret =3D -1; + ret =3D -EPERM; } unlock: spin_unlock_irqrestore(&rtcdev_lock, flags); --=20 2.18.2