From nobody Fri Sep 20 18:46:57 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03A0DC83005 for ; Fri, 9 Jun 2023 08:32:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240110AbjFIIcN (ORCPT ); Fri, 9 Jun 2023 04:32:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240846AbjFIIbR (ORCPT ); Fri, 9 Jun 2023 04:31:17 -0400 Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C4F31FEC for ; Fri, 9 Jun 2023 01:30:40 -0700 (PDT) Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-33e53672aa6so6594935ab.1 for ; Fri, 09 Jun 2023 01:30:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1686299437; x=1688891437; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6mun1nGQ80ZyVZjdi0M4IzGfNqFd85FTe1SFditmWTE=; b=CocMFGYDJ28ZQWX5/Zb+FWOJDAAQ8XIC34Mc06ztwspA6x7UOg9DlOAYTqPm8CZpHw dIi8y8dHV2bbmb3Mh+rDMd7prp+hWGQ1XdDLsMOx6QuXcgGyiFLn5LnJq+3ZptBy6g2D 5BhgwyaKRjPBGEcMy9y/35wR02MRZ9JHVlYjY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686299437; x=1688891437; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6mun1nGQ80ZyVZjdi0M4IzGfNqFd85FTe1SFditmWTE=; b=OB4UTh13JeReapjgbz68oA0PI7ldALxEbeBhZrpLtTgO/G+k9scgRNM5UvNnsR9XNh 8+XZP82Q56+HiP5f4KxkZFadZmgwLYG5a5Q+vQkR+qr0YdPQoqiqHY5A6fzXIJk4d6k+ xHw/trFik7f9ajsF/+eC2fwPiNht3w1jPDbDONw0/TuqFPeO0KzjheRQQO26UB+on45e c4apFKjRDEyv25w1T5amx94D7zM6QxNOwK6bUI10XFJ4hA4CR0sCN3/4Fr5f1qyhzZUF YF9clOBy/sBC9UloOhYLtuCEvtqaE1gzRD2/KYU2pn/v36FJCqdJQlWEDbqV8/hybqOp qLdw== X-Gm-Message-State: AC+VfDz7c0aVFE31FpEBScteMcyGMKZzkbV/52RinlAILc+hQEBkLc/j AOy6pvZh/rRQVHVNtbePu94lUQ== X-Google-Smtp-Source: ACHHUZ4xGILPF6LRehHfcnbwmynkR+03VjZMBahqygYIt5vljilPzTSm4E0iZ0dYLkUzfyQF4wBwuA== X-Received: by 2002:a05:6e02:4cf:b0:335:fef6:6b76 with SMTP id f15-20020a056e0204cf00b00335fef66b76mr1159316ils.6.1686299437720; Fri, 09 Jun 2023 01:30:37 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:c2ea:d8e4:1fe8:21f0]) by smtp.gmail.com with ESMTPSA id 23-20020aa79157000000b0063b806b111csm2184327pfi.169.2023.06.09.01.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jun 2023 01:30:37 -0700 (PDT) From: Chen-Yu Tsai To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Brown , Liam Girdwood , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/9] regulator: dt-bindings: mt6358: Merge ldo_vcn33_* regulators Date: Fri, 9 Jun 2023 16:29:58 +0800 Message-ID: <20230609083009.2822259-2-wenst@chromium.org> X-Mailer: git-send-email 2.41.0.162.gfafddb0af9-goog In-Reply-To: <20230609083009.2822259-1-wenst@chromium.org> References: <20230609083009.2822259-1-wenst@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The ldo_vcn33_bt and ldo_vcn33_wifi regulators are actually the same regulator, having the same voltage setting and output pin. There are simply two enable bits that are ORed together to enable the regulator. Having two regulators representing the same output pin is misleading from a design matching standpoint, and also error-prone in driver implementations. Merge the two as ldo_vcn33. Neither vcn33 regulators are referenced in upstream device trees. As far as hardware designs go, none of the Chromebooks using MT8183 w/ MT6358 use this output. Signed-off-by: Chen-Yu Tsai Acked-by: Krzysztof Kozlowski Reviewed-by: Matthias Brugger --- .../bindings/regulator/mt6358-regulator.txt | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/Documentation/devicetree/bindings/regulator/mt6358-regulator.t= xt b/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt index 7034cdca54e0..b22b956d1cbe 100644 --- a/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt +++ b/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt @@ -15,8 +15,7 @@ LDO: ldo_vcamd, ldo_vcn18, ldo_vfe28, ldo_vsram_proc11, ldo_vcn28, ldo_vsram_= others, ldo_vsram_others_sshub, ldo_vsram_gpu, ldo_vxo22, ldo_vefuse, ldo_vaux18, ldo_vmch, ldo_vbif28, ldo_vsram_proc12, ldo_vcama1, ldo_vemc, ldo_vio28,= ldo_va12, - ldo_vrf18, ldo_vcn33_bt, ldo_vcn33_wifi, ldo_vcama2, ldo_vmc, ldo_vldo28= , ldo_vaud28, - ldo_vsim2 + ldo_vrf18, ldo_vcn33, ldo_vcama2, ldo_vmc, ldo_vldo28, ldo_vaud28, ldo_v= sim2 =20 Example: =20 @@ -305,15 +304,8 @@ Example: regulator-enable-ramp-delay =3D <120>; }; =20 - mt6358_vcn33_bt_reg: ldo_vcn33_bt { - regulator-name =3D "vcn33_bt"; - regulator-min-microvolt =3D <3300000>; - regulator-max-microvolt =3D <3500000>; - regulator-enable-ramp-delay =3D <270>; - }; - - mt6358_vcn33_wifi_reg: ldo_vcn33_wifi { - regulator-name =3D "vcn33_wifi"; + mt6358_vcn33_reg: ldo_vcn33 { + regulator-name =3D "vcn33"; regulator-min-microvolt =3D <3300000>; regulator-max-microvolt =3D <3500000>; regulator-enable-ramp-delay =3D <270>; --=20 2.41.0.162.gfafddb0af9-goog