From nobody Sun Feb 8 18:39:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF665C7EE43 for ; Wed, 7 Jun 2023 08:21:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239284AbjFGIVY (ORCPT ); Wed, 7 Jun 2023 04:21:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239098AbjFGIVG (ORCPT ); Wed, 7 Jun 2023 04:21:06 -0400 Received: from smtpbg153.qq.com (smtpbg153.qq.com [13.245.218.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C60851FDC; Wed, 7 Jun 2023 01:20:52 -0700 (PDT) X-QQ-mid: bizesmtp81t1686126015tij1hqko Received: from wxdbg.localdomain.com ( [122.235.137.64]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 07 Jun 2023 16:20:06 +0800 (CST) X-QQ-SSF: 01400000000000J0Z000000A0000000 X-QQ-FEAT: +ynUkgUhZJlWz8h9pkBblPfRUT02IjaMSbr4acK3xfZ6D3K7hFxp/p1AGukcB twgiMIpKrFXolURkQR1vr51Zd9RxTg8ZuBnaSDm8iHlBl2RWNYAMaR350cG1JVezHidLoEX ZIrT8u7K1YybOuoUpMfCA8UGUPBQPmOYOnaNRheQ6xKboqrdmJ8B0i9tqXpKA86mE69XEWQ CbdZhy3Fb2SiAq8sBTRoGDo3YWI/ng/sWYvtLyPw7ae5PEkfri+DMfx5uRa6QkWPiZTM2AK 6UV6zrqzGBRICvX0XNxubrWESmBTu79LaDXHIbCIoNMYxvyDqL2y8s/DrxevhTGYntkFW+e KG4QAOntDaxCGDjcaQSYV9zPkE30/FR8LRuMYRCJB5T3g1D2KxeBQkcL+Xk5Q== X-QQ-GoodBg: 2 X-BIZMAIL-ID: 16544725819709452032 From: Jiawen Wu To: linus.walleij@linaro.org, brgl@bgdev.pl, shreeya.patel@collabora.com, andy.shevchenko@gmail.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jiawen Wu Subject: [PATCH v2] gpiolib: Fix GPIO chip IRQ initialization restriction Date: Wed, 7 Jun 2023 16:18:03 +0800 Message-Id: <20230607081803.778223-1-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In case of gpio-regmap, IRQ chip is added by regmap-irq and associated with GPIO chip by gpiochip_irqchip_add_domain(). The initialization flag was not added in gpiochip_irqchip_add_domain(), causing gpiochip_to_irq() to return -EPROBE_DEFER. Fixes: 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members before = initialization") Signed-off-by: Jiawen Wu Reviewed-by: Andy Shevchenko Reviewed-by: Linus Walleij Reviewed-by: Michael Walle Tested-by: Michael Walle # on kontron-sl28 --- v1 -> v2: - add compiler barrier --- drivers/gpio/gpiolib.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index a7220e04a93e..9ecf93cbd801 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1792,6 +1792,14 @@ int gpiochip_irqchip_add_domain(struct gpio_chip *gc, gc->to_irq =3D gpiochip_to_irq; gc->irq.domain =3D domain; =20 + /* + * Using barrier() here to prevent compiler from reordering + * gc->irq.initialized before adding irqdomain. + */ + barrier(); + + gc->irq.initialized =3D true; + return 0; } EXPORT_SYMBOL_GPL(gpiochip_irqchip_add_domain); --=20 2.27.0