From nobody Sat Feb 7 23:23:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 998E1C7EE24 for ; Tue, 6 Jun 2023 17:40:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238437AbjFFRkW (ORCPT ); Tue, 6 Jun 2023 13:40:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238712AbjFFRjz (ORCPT ); Tue, 6 Jun 2023 13:39:55 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 471F210F8 for ; Tue, 6 Jun 2023 10:39:53 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6537d2a8c20so3015572b3a.2 for ; Tue, 06 Jun 2023 10:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686073192; x=1688665192; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FC01jxOBSLY7ZKXPg/UOaGu8vDRxRyeIgOBpQX22Jyc=; b=CAbk5mQi2P1KsDiLqmuh5rlEyijisBivA760hzTefSWQWlpw7TJLIzVvN5RklboRtr 14WgBjG8JrA44rskY7oEjPRK+eM720JDUaRgRt/RHP1BfaikiT8inDBh8px4ddQV7PHV 1FTrHIHe8fZ6jEvpRMymIi0PuyUvITmn4VgPfRYcYhqcn8H9/cDqPBOqAUuC7nZmtDXv 7IV48/6OP5xb9YYNkDdmfpTuHeEnAIPtcHxLWkSHAoDuAweACUKWYIfA8MdYTysegZR9 DiIzTKvdjwbzK9qpMp1ZUm1MwVspB91+FcsCnX3iYNDvOy17uBwn9Xu4H2NS+KVWsbqg oTgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686073192; x=1688665192; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FC01jxOBSLY7ZKXPg/UOaGu8vDRxRyeIgOBpQX22Jyc=; b=l30zxAZuPogR7hULSlRMZHS/p55j24cJTITMV7g6lGfd1RVP2ic/LmrgbznuhiaKhW 4wCvmKinP6GJYWSmo0S35qEhhMVgnTAVRSobdTALvs3B3FrJYpuxnJftvj7QR/Br3l1R 24FRUKmVn+UVkH9NrALmcy975Wrjq119SH00LL78vdYFGQ/OAav+43ZlxzLyqRaQk6jZ qg0Kbv3O8eYcir5Bj+XcUUpIoDtwuDS7HCEtrFbDXWJgeOgg7W2IB8lAnaTH5mg0qVfe F1YJRNJTJG+1WF0Ib9aayfPVBFskT60gkjJaAEpbpddaibJL9C2OOqfZYnE10R1H/hDU zwqA== X-Gm-Message-State: AC+VfDzBYAIczCyiO7hDWM/hvclu/QM3pzKUNnRi5pRRfZaxlQ1UTrkq nM9gjL/PapmSnoNadC+RjPucp8T0IH0= X-Google-Smtp-Source: ACHHUZ67KIg/Mm9NMPhjTlayFjlenoLJPI4NEBi4xLY/i14s1DBOxzAioMCWtn7d/RPKGoOH81NjfQ== X-Received: by 2002:a05:6a20:3d93:b0:10c:34af:a469 with SMTP id s19-20020a056a203d9300b0010c34afa469mr425310pzi.16.1686073192178; Tue, 06 Jun 2023 10:39:52 -0700 (PDT) Received: from daehojeong-desktop.mtv.corp.google.com ([2620:15c:211:201:72aa:6329:65da:3ad3]) by smtp.gmail.com with ESMTPSA id l6-20020a170902d34600b001ae7fad1598sm8818368plk.29.2023.06.06.10.39.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 10:39:51 -0700 (PDT) From: Daeho Jeong To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com Cc: Daeho Jeong Subject: [PATCH] f2fs-tools: fix wrong write pointer check for non-zoned areas Date: Tue, 6 Jun 2023 10:39:48 -0700 Message-ID: <20230606173948.3390215-1-daeho43@gmail.com> X-Mailer: git-send-email 2.41.0.rc0.172.g3f132b7071-goog MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Daeho Jeong Do not check F2FS_ZONED_HM for the whole device. We need to do this for each area of devices. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu --- fsck/mount.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fsck/mount.c b/fsck/mount.c index 851a62b..0ebbfcf 100644 --- a/fsck/mount.c +++ b/fsck/mount.c @@ -2868,9 +2868,6 @@ static bool write_pointer_at_zone_start(struct f2fs_s= b_info *sbi, int log_sectors_per_block =3D sbi->log_blocksize - SECTOR_SHIFT; int ret, j; =20 - if (c.zoned_model !=3D F2FS_ZONED_HM) - return true; - for (j =3D 0; j < MAX_DEVICES; j++) { if (!c.devices[j].path) break; @@ -2882,6 +2879,9 @@ static bool write_pointer_at_zone_start(struct f2fs_s= b_info *sbi, if (j >=3D MAX_DEVICES) return false; =20 + if (c.devices[j].zoned_model !=3D F2FS_ZONED_HM) + return true; + sector =3D (block - c.devices[j].start_blkaddr) << log_sectors_per_block; ret =3D f2fs_report_zone(j, sector, &blkz); if (ret) --=20 2.41.0.rc0.172.g3f132b7071-goog