From nobody Tue Feb 10 22:15:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC880C77B73 for ; Tue, 6 Jun 2023 07:32:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234931AbjFFHcR (ORCPT ); Tue, 6 Jun 2023 03:32:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236148AbjFFHcN (ORCPT ); Tue, 6 Jun 2023 03:32:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D446E11A; Tue, 6 Jun 2023 00:32:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 68DEC62CB9; Tue, 6 Jun 2023 07:32:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2644FC433EF; Tue, 6 Jun 2023 07:32:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686036731; bh=Ak0j0Hr5s4dVlzG32KaXySxXdetfo8cIUB4kqJq07T4=; h=From:To:Cc:Subject:Date:From; b=L1KDGLqVhGh+sVvUI3ToDKAxdVULNnFXTvV3964C9ha3o5I1TeW1XCjyfgMd8J3ws pxhfQRkKWRdwUnAR+kC2KXathXAHPKwvuX/WwwLQPHv9eqNloTqKJVQABzITZSIUFN MGGa1LK4qUzA9RDzUVpGr8W9YIgF33mOgLtxwfT4y68r/YryJ6d3v8u2Xk9qag/1up 8Boecj0X0M4nZXMxMqF+jYcXOcFsUFAHs1zW67Yxhg3pBFmA4tEgbg/D4SdhwAJO8c 3JuH0kEblnlLPo5mQ30719Xryv0/vqp/UEynYcnttSDDCY7jPRy6t//Q6wp+sjqg/i qZGutlyXFpO9w== From: Chao Yu To: Theodore Ts'o , Andreas Dilger Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Yu Subject: [PATCH] ext4: fix to check return value of freeze_bdev() in ext4_shutdown() Date: Tue, 6 Jun 2023 15:32:03 +0800 Message-Id: <20230606073203.1310389-1-chao@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" freeze_bdev() can fail due to a lot of reasons, it needs to check its reason before later process. Fixes: 783d94854499 ("ext4: add EXT4_IOC_GOINGDOWN ioctl") Signed-off-by: Chao Yu --- fs/ext4/ioctl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index f9a430152063..55be1b8a6360 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -797,6 +797,7 @@ static int ext4_shutdown(struct super_block *sb, unsign= ed long arg) { struct ext4_sb_info *sbi =3D EXT4_SB(sb); __u32 flags; + int ret; =20 if (!capable(CAP_SYS_ADMIN)) return -EPERM; @@ -815,7 +816,9 @@ static int ext4_shutdown(struct super_block *sb, unsign= ed long arg) =20 switch (flags) { case EXT4_GOING_FLAGS_DEFAULT: - freeze_bdev(sb->s_bdev); + ret =3D freeze_bdev(sb->s_bdev); + if (ret) + return ret; set_bit(EXT4_FLAGS_SHUTDOWN, &sbi->s_ext4_flags); thaw_bdev(sb->s_bdev); break; --=20 2.40.1