arch/x86/events/amd/ibs.c | 3 +++ 1 file changed, 3 insertions(+)
The AMD IBS PMU doesn't handle branch stacks, so it should not accept
events with brstack.
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
arch/x86/events/amd/ibs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c
index 371014802191..607a692ba8ce 100644
--- a/arch/x86/events/amd/ibs.c
+++ b/arch/x86/events/amd/ibs.c
@@ -265,6 +265,9 @@ static int perf_ibs_init(struct perf_event *event)
if (config & ~perf_ibs->config_mask)
return -EINVAL;
+ if (has_branch_stack(event))
+ return -EOPNOTSUPP;
+
if (hwc->sample_period) {
if (config & perf_ibs->cnt_mask)
/* raw max_cnt may not be set */
--
2.41.0.rc2.161.g9c6817b8e7-goog
On 03-Jun-23 1:15 AM, Namhyung Kim wrote: > The AMD IBS PMU doesn't handle branch stacks, so it should not accept > events with brstack. > > Cc: Ravi Bangoria <ravi.bangoria@amd.com> > Signed-off-by: Namhyung Kim <namhyung@kernel.org> Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com> Thanks!
Em Tue, Jun 06, 2023 at 10:08:43AM +0530, Ravi Bangoria escreveu: > On 03-Jun-23 1:15 AM, Namhyung Kim wrote: > > The AMD IBS PMU doesn't handle branch stacks, so it should not accept > > events with brstack. > > > > Cc: Ravi Bangoria <ravi.bangoria@amd.com> > > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > > Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com> It seems this patch was not merged, can you please check? - Arnaldo
On 23-Nov-23 8:15 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Jun 06, 2023 at 10:08:43AM +0530, Ravi Bangoria escreveu: >> On 03-Jun-23 1:15 AM, Namhyung Kim wrote: >>> The AMD IBS PMU doesn't handle branch stacks, so it should not accept >>> events with brstack. >>> >>> Cc: Ravi Bangoria <ravi.bangoria@amd.com> >>> Signed-off-by: Namhyung Kim <namhyung@kernel.org> >> >> Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com> > > It seems this patch was not merged, can you please check? Right. And it does not apply cleanly on peterz/queue.git/perf/core, since surrounding code has changed. Thanks, Ravi
Em Fri, Nov 24, 2023 at 09:30:37AM +0530, Ravi Bangoria escreveu: > On 23-Nov-23 8:15 PM, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jun 06, 2023 at 10:08:43AM +0530, Ravi Bangoria escreveu: > >> On 03-Jun-23 1:15 AM, Namhyung Kim wrote: > >>> The AMD IBS PMU doesn't handle branch stacks, so it should not accept > >>> events with brstack. > >>> > >>> Cc: Ravi Bangoria <ravi.bangoria@amd.com> > >>> Signed-off-by: Namhyung Kim <namhyung@kernel.org> > >> > >> Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com> > > > > It seems this patch was not merged, can you please check? > > Right. And it does not apply cleanly on peterz/queue.git/perf/core, since > surrounding code has changed. Can you please refresh it if PeterZ has nothing against? - Arnaldo
On 27-Nov-23 8:02 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, Nov 24, 2023 at 09:30:37AM +0530, Ravi Bangoria escreveu: >> On 23-Nov-23 8:15 PM, Arnaldo Carvalho de Melo wrote: >>> Em Tue, Jun 06, 2023 at 10:08:43AM +0530, Ravi Bangoria escreveu: >>>> On 03-Jun-23 1:15 AM, Namhyung Kim wrote: >>>>> The AMD IBS PMU doesn't handle branch stacks, so it should not accept >>>>> events with brstack. >>>>> >>>>> Cc: Ravi Bangoria <ravi.bangoria@amd.com> >>>>> Signed-off-by: Namhyung Kim <namhyung@kernel.org> >>>> >>>> Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com> >>> >>> It seems this patch was not merged, can you please check? >> >> Right. And it does not apply cleanly on peterz/queue.git/perf/core, since >> surrounding code has changed. > > Can you please refresh it if PeterZ has nothing against? Posted v2: https://lore.kernel.org/r/20231130062246.290-1-ravi.bangoria@amd.com Thanks.
Em Thu, Nov 30, 2023 at 11:58:15AM +0530, Ravi Bangoria escreveu: > On 27-Nov-23 8:02 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Nov 24, 2023 at 09:30:37AM +0530, Ravi Bangoria escreveu: > >> On 23-Nov-23 8:15 PM, Arnaldo Carvalho de Melo wrote: > >>> Em Tue, Jun 06, 2023 at 10:08:43AM +0530, Ravi Bangoria escreveu: > >>>> On 03-Jun-23 1:15 AM, Namhyung Kim wrote: > >>>>> The AMD IBS PMU doesn't handle branch stacks, so it should not accept > >>>>> events with brstack. > >>>>> Signed-off-by: Namhyung Kim <namhyung@kernel.org> > >>>> Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com> > >>> It seems this patch was not merged, can you please check? > >> Right. And it does not apply cleanly on peterz/queue.git/perf/core, since > >> surrounding code has changed. > > Can you please refresh it if PeterZ has nothing against? > Posted v2: https://lore.kernel.org/r/20231130062246.290-1-ravi.bangoria@amd.com Peter, can you please consider this one? Thanks a lot! - Arnaldo
On Thu, Nov 30, 2023 at 5:03 AM Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > > Em Thu, Nov 30, 2023 at 11:58:15AM +0530, Ravi Bangoria escreveu: > > On 27-Nov-23 8:02 PM, Arnaldo Carvalho de Melo wrote: > > > Em Fri, Nov 24, 2023 at 09:30:37AM +0530, Ravi Bangoria escreveu: > > >> On 23-Nov-23 8:15 PM, Arnaldo Carvalho de Melo wrote: > > >>> Em Tue, Jun 06, 2023 at 10:08:43AM +0530, Ravi Bangoria escreveu: > > >>>> On 03-Jun-23 1:15 AM, Namhyung Kim wrote: > > >>>>> The AMD IBS PMU doesn't handle branch stacks, so it should not accept > > >>>>> events with brstack. > > > >>>>> Signed-off-by: Namhyung Kim <namhyung@kernel.org> > > >>>> Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com> > > > >>> It seems this patch was not merged, can you please check? > > > >> Right. And it does not apply cleanly on peterz/queue.git/perf/core, since > > >> surrounding code has changed. > > > > Can you please refresh it if PeterZ has nothing against? > > > Posted v2: https://lore.kernel.org/r/20231130062246.290-1-ravi.bangoria@amd.com > > Peter, can you please consider this one? The v2 is already in the tip tree. Thanks Ravi for doing this! Namhyung
Em Fri, Dec 01, 2023 at 12:23:16PM -0800, Namhyung Kim escreveu: > On Thu, Nov 30, 2023 at 5:03 AM Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > > Em Thu, Nov 30, 2023 at 11:58:15AM +0530, Ravi Bangoria escreveu: > > > On 27-Nov-23 8:02 PM, Arnaldo Carvalho de Melo wrote: > > > > Em Fri, Nov 24, 2023 at 09:30:37AM +0530, Ravi Bangoria escreveu: > > > >> On 23-Nov-23 8:15 PM, Arnaldo Carvalho de Melo wrote: > > > >>> Em Tue, Jun 06, 2023 at 10:08:43AM +0530, Ravi Bangoria escreveu: > > > >>>> On 03-Jun-23 1:15 AM, Namhyung Kim wrote: > > > >>>>> The AMD IBS PMU doesn't handle branch stacks, so it should not accept > > > >>>>> events with brstack. > > > > > >>>>> Signed-off-by: Namhyung Kim <namhyung@kernel.org> > > > >>>> Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com> > > > > > >>> It seems this patch was not merged, can you please check? > > > > > >> Right. And it does not apply cleanly on peterz/queue.git/perf/core, since > > > >> surrounding code has changed. > > > > Can you please refresh it if PeterZ has nothing against? > > > Posted v2: https://lore.kernel.org/r/20231130062246.290-1-ravi.bangoria@amd.com > > Peter, can you please consider this one? > The v2 is already in the tip tree. Thanks Ravi for doing this! Yeap, I just checked and Ingo merged it, thanks everybody! - Arnaldo
Em Fri, Dec 01, 2023 at 12:23:16PM -0800, Namhyung Kim escreveu: > On Thu, Nov 30, 2023 at 5:03 AM Arnaldo Carvalho de Melo > <acme@kernel.org> wrote: > > > > Em Thu, Nov 30, 2023 at 11:58:15AM +0530, Ravi Bangoria escreveu: > > > On 27-Nov-23 8:02 PM, Arnaldo Carvalho de Melo wrote: > > > > Em Fri, Nov 24, 2023 at 09:30:37AM +0530, Ravi Bangoria escreveu: > > > >> On 23-Nov-23 8:15 PM, Arnaldo Carvalho de Melo wrote: > > > >>> Em Tue, Jun 06, 2023 at 10:08:43AM +0530, Ravi Bangoria escreveu: > > > >>>> On 03-Jun-23 1:15 AM, Namhyung Kim wrote: > > > >>>>> The AMD IBS PMU doesn't handle branch stacks, so it should not accept > > > >>>>> events with brstack. > > > > > >>>>> Signed-off-by: Namhyung Kim <namhyung@kernel.org> > > > >>>> Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com> > > > > > >>> It seems this patch was not merged, can you please check? > > > > > >> Right. And it does not apply cleanly on peterz/queue.git/perf/core, since > > > >> surrounding code has changed. > > > > > > Can you please refresh it if PeterZ has nothing against? > > > > > Posted v2: https://lore.kernel.org/r/20231130062246.290-1-ravi.bangoria@amd.com > > > > Peter, can you please consider this one? > > The v2 is already in the tip tree. Thanks Ravi for doing this! > Namhyung yay! - Arnaldo
© 2016 - 2024 Red Hat, Inc.