From nobody Sun Feb 8 13:32:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1398C7EE2A for ; Fri, 2 Jun 2023 02:09:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233562AbjFBCJu (ORCPT ); Thu, 1 Jun 2023 22:09:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230492AbjFBCJs (ORCPT ); Thu, 1 Jun 2023 22:09:48 -0400 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A1E313E for ; Thu, 1 Jun 2023 19:09:45 -0700 (PDT) Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id E74593F12E for ; Fri, 2 Jun 2023 02:09:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1685671782; bh=HGFWY1748xWHBeuQ3h2WYaCQqPEsRJy9T6c8zRERFxM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=HZOWl/p8dEH+aXZ8g5Fi6R9VlSY5H0TqnCIBVeCadsIlbKMkX07q9CLEZawjrq6iS Q5YBKPJYgKz5pZDVE4CNkoO/LTXZ0ZDH2CiLgP6ugwoYwYXMQ2L7HT5Hn/+5epTClc GqgaGHEk1HLlel9c7J70Fx4VOOrFV7SZSr9qfLmOyW92A5DnLuPA0Pop3B5wu7U5DV PD+FyKJ+FFIsXdWGH0YXxQeD9epWkoLggUbA/oHXasmkJ00nTLcZCZTowkA+B6BuJD WF/Yfc9gqnUsj1rOrMp97OSSJtOrs3ake3xiIQ114MMKgZUckPiJfSBYBHZPalNU/9 5OnBK8CuY+iNQ== Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1b04bc1f3cbso7190925ad.2 for ; Thu, 01 Jun 2023 19:09:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685671781; x=1688263781; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HGFWY1748xWHBeuQ3h2WYaCQqPEsRJy9T6c8zRERFxM=; b=d9YB+O3WZ/3yCLgWNX6YYXkfwpemjo5+WCRGWihAB09fOM+YFl7tDzzmg4dXVXfJ0t 76eOPzDXiLNcT0t8tUZFCnSM8X35a/BYftDQKR/PTAJGS9pp11poCi8DGlUEnmaINpfd sFgHboxplRg8GqgDgXni9qLWXtC5O5azB1SthHnvgrsueaOGPF2Cg19seL8jwcr8HcRp xAwOxiR2K3lAZ3P4TmHIKhfQaWP49ZnCgg1rFqFEedp4IylW3JtxvZSfUVbHL+wekAQY eSXlhhL+LGlc7DNYd33/a/s9ass9VmRHFS8YKmMJRlRVum1LI3vwSKM/cgX+Nq+ye7tD w2eg== X-Gm-Message-State: AC+VfDzCDlt22xSMisz52nUYiXW68r8FBTrZc5dsNzEnhYJNdNJ/RBqE x6y3jdc0XVo8FHqrmc+OW/zsSMyZM+Tu4zMWI5yRuv0dC3BtFUhSSXL6AKUXNfi2y5xOau9S/P/ +kWbh1HTuQw0RnIVJpaEvcPGQ7/9gJ2Q2xLTokdBTb/XFktWPKQ== X-Received: by 2002:a17:902:d503:b0:1b1:a2c3:29c0 with SMTP id b3-20020a170902d50300b001b1a2c329c0mr882203plg.24.1685671781282; Thu, 01 Jun 2023 19:09:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ714BmOv9fruEm5Qgzxep6fJULya1ekyW4/JETSKvADOJrqtiqDHlU+NnOPyVOY75zkhlAelA== X-Received: by 2002:a17:902:d503:b0:1b1:a2c3:29c0 with SMTP id b3-20020a170902d50300b001b1a2c329c0mr882194plg.24.1685671780984; Thu, 01 Jun 2023 19:09:40 -0700 (PDT) Received: from chengendu.. (111-248-148-133.dynamic-ip.hinet.net. [111.248.148.133]) by smtp.gmail.com with ESMTPSA id u11-20020a170902e80b00b001acacff3a70sm64391plg.125.2023.06.01.19.09.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 19:09:40 -0700 (PDT) From: Chengen Du To: trond.myklebust@hammerspace.com Cc: anna@kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Chengen Du Subject: [PATCH v2 RESEND] NFS: Add mount option 'fasc' Date: Fri, 2 Jun 2023 10:09:35 +0800 Message-Id: <20230602020935.43367-1-chengen.du@canonical.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In certain instances, users or applications switch to other privileged users by executing commands like 'su' to carry out operations on NFS- mounted folders. However, when this happens, the login time for the privileged user is reset, and any NFS ACCESS operations must be resent, which can result in a decrease in performance. In specific production environments where the access cache can be trusted due to stable group membership, there's no need to verify the cache stall situation. To maintain the initial behavior and performance, a new mount option called 'fasc' has been introduced. This option triggers the mechanism of clearing the file access cache upon login. Signed-off-by: Chengen Du --- fs/nfs/dir.c | 21 ++++++++++++--------- fs/nfs/fs_context.c | 5 +++++ fs/nfs/super.c | 1 + include/linux/nfs_fs_sb.h | 1 + 4 files changed, 19 insertions(+), 9 deletions(-) diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 8f3112e71a6a..cefdb23d4cd7 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -2951,12 +2951,14 @@ static struct nfs_access_entry *nfs_access_search_r= btree(struct inode *inode, co return NULL; } =20 -static u64 nfs_access_login_time(const struct task_struct *task, - const struct cred *cred) +static inline +bool nfs_check_access_stale(const struct task_struct *task, + const struct cred *cred, + const struct nfs_access_entry *cache) { const struct task_struct *parent; const struct cred *pcred; - u64 ret; + u64 login_time; =20 rcu_read_lock(); for (;;) { @@ -2966,15 +2968,15 @@ static u64 nfs_access_login_time(const struct task_= struct *task, break; task =3D parent; } - ret =3D task->start_time; + login_time =3D task->start_time; rcu_read_unlock(); - return ret; + + return ((s64)(login_time - cache->timestamp) > 0); } =20 static int nfs_access_get_cached_locked(struct inode *inode, const struct = cred *cred, u32 *mask, bool may_block) { struct nfs_inode *nfsi =3D NFS_I(inode); - u64 login_time =3D nfs_access_login_time(current, cred); struct nfs_access_entry *cache; bool retry =3D true; int err; @@ -3003,7 +3005,8 @@ static int nfs_access_get_cached_locked(struct inode = *inode, const struct cred * retry =3D false; } err =3D -ENOENT; - if ((s64)(login_time - cache->timestamp) > 0) + if ((NFS_SERVER(inode)->flags & NFS_MOUNT_FASC) && + nfs_check_access_stale(current, cred, cache)) goto out; *mask =3D cache->mask; list_move_tail(&cache->lru, &nfsi->access_cache_entry_lru); @@ -3023,7 +3026,6 @@ static int nfs_access_get_cached_rcu(struct inode *in= ode, const struct cred *cre * but do it without locking. */ struct nfs_inode *nfsi =3D NFS_I(inode); - u64 login_time =3D nfs_access_login_time(current, cred); struct nfs_access_entry *cache; int err =3D -ECHILD; struct list_head *lh; @@ -3038,7 +3040,8 @@ static int nfs_access_get_cached_rcu(struct inode *in= ode, const struct cred *cre cache =3D NULL; if (cache =3D=3D NULL) goto out; - if ((s64)(login_time - cache->timestamp) > 0) + if ((NFS_SERVER(inode)->flags & NFS_MOUNT_FASC) && + nfs_check_access_stale(current, cred, cache)) goto out; if (nfs_check_cache_invalid(inode, NFS_INO_INVALID_ACCESS)) goto out; diff --git a/fs/nfs/fs_context.c b/fs/nfs/fs_context.c index 9bcd53d5c7d4..0a14bd67efc1 100644 --- a/fs/nfs/fs_context.c +++ b/fs/nfs/fs_context.c @@ -88,6 +88,7 @@ enum nfs_param { Opt_vers, Opt_wsize, Opt_write, + Opt_fasc, }; =20 enum { @@ -194,6 +195,7 @@ static const struct fs_parameter_spec nfs_fs_parameters= [] =3D { fsparam_string("vers", Opt_vers), fsparam_enum ("write", Opt_write, nfs_param_enums_write), fsparam_u32 ("wsize", Opt_wsize), + fsparam_flag ("fasc", Opt_fasc), {} }; =20 @@ -861,6 +863,9 @@ static int nfs_fs_context_parse_param(struct fs_context= *fc, case Opt_sloppy: ctx->sloppy =3D true; break; + case Opt_fasc: + ctx->flags |=3D NFS_MOUNT_FASC; + break; } =20 return 0; diff --git a/fs/nfs/super.c b/fs/nfs/super.c index 30e53e93049e..e8d0ffd04b16 100644 --- a/fs/nfs/super.c +++ b/fs/nfs/super.c @@ -444,6 +444,7 @@ static void nfs_show_mount_options(struct seq_file *m, = struct nfs_server *nfss, { NFS_MOUNT_NORDIRPLUS, ",nordirplus", "" }, { NFS_MOUNT_UNSHARED, ",nosharecache", "" }, { NFS_MOUNT_NORESVPORT, ",noresvport", "" }, + { NFS_MOUNT_FASC, ",fasc", "" }, { 0, NULL, NULL } }; const struct proc_nfs_info *nfs_infop; diff --git a/include/linux/nfs_fs_sb.h b/include/linux/nfs_fs_sb.h index ea2f7e6b1b0b..332ceb11be6c 100644 --- a/include/linux/nfs_fs_sb.h +++ b/include/linux/nfs_fs_sb.h @@ -153,6 +153,7 @@ struct nfs_server { #define NFS_MOUNT_WRITE_EAGER 0x01000000 #define NFS_MOUNT_WRITE_WAIT 0x02000000 #define NFS_MOUNT_TRUNK_DISCOVERY 0x04000000 +#define NFS_MOUNT_FASC 0x08000000 =20 unsigned int fattr_valid; /* Valid attributes */ unsigned int caps; /* server capabilities */ --=20 2.39.2