From nobody Sat Feb 7 20:47:50 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD38C77B7E for ; Thu, 1 Jun 2023 21:31:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232388AbjFAVbX (ORCPT ); Thu, 1 Jun 2023 17:31:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229651AbjFAVbU (ORCPT ); Thu, 1 Jun 2023 17:31:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B8BE184 for ; Thu, 1 Jun 2023 14:31:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9DA26649F3 for ; Thu, 1 Jun 2023 21:31:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DD57C433D2; Thu, 1 Jun 2023 21:31:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685655078; bh=Rq/YPhUrxxmon4lsDaGRDkAmNIYRrnC5b1pXLnZ3MbA=; h=From:To:Cc:Subject:Date:From; b=VDx29Is+heLSHZendXg04+AgJJOfhzDRchuOF/qJ5fqzXQshWgSpyhA8H50/huNLd pINbTUfx8y2pP0q+Eq7t1xM2QbJzMb8sxEw+NNdEolt4WXQV4GkxatzEq0TOphHQLa jKwieLVkqsEVui4bdtJQkm0vunj/GtbUkKhRMeqJqhwejXt0ukzlRLgG901gefA9YP CAEIYvrlzF6Rlt09Q4Re1gsNsgnQhlpXMvZ61u1Zk4xTSRr8pO5hsMELLKh0JqRFMc D7gFui3Uwamc6waP115/MJzbVl0PBzIGsbZExrTFPSvVJAk04PEU+g3h42Df9t6PrE eUpfOTnW2D2OA== From: Arnd Bergmann To: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Marangi Cc: Arnd Bergmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: dsa: qca8k: add CONFIG_LEDS_TRIGGERS dependency Date: Thu, 1 Jun 2023 23:31:04 +0200 Message-Id: <20230601213111.3182893-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann Without LED triggers, the driver now fails to build: drivers/net/dsa/qca/qca8k-leds.c: In function 'qca8k_parse_port_leds': drivers/net/dsa/qca/qca8k-leds.c:403:31: error: 'struct led_classdev' has n= o member named 'hw_control_is_supported' 403 | port_led->cdev.hw_control_is_supported =3D qca8k_cl= ed_hw_control_is_supported; | ^ There is a mix of 'depends on' and 'select' for LEDS_TRIGGERS, so it's not clear what we should use here, but in general using 'depends on' causes fewer problems, so use that. Fixes: e0256648c831a ("net: dsa: qca8k: implement hw_control ops") Signed-off-by: Arnd Bergmann --- drivers/net/dsa/qca/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/qca/Kconfig b/drivers/net/dsa/qca/Kconfig index 4347b42c50fd2..de9da469908bc 100644 --- a/drivers/net/dsa/qca/Kconfig +++ b/drivers/net/dsa/qca/Kconfig @@ -20,6 +20,7 @@ config NET_DSA_QCA8K_LEDS_SUPPORT bool "Qualcomm Atheros QCA8K Ethernet switch family LEDs support" depends on NET_DSA_QCA8K depends on LEDS_CLASS=3Dy || LEDS_CLASS=3DNET_DSA_QCA8K + depends on LEDS_TRIGGERS help This enabled support for LEDs present on the Qualcomm Atheros QCA8K Ethernet switch chips. --=20 2.39.2