From nobody Mon Oct 20 10:10:02 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2202FC7EE2F for ; Wed, 31 May 2023 11:51:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235594AbjEaLvQ (ORCPT ); Wed, 31 May 2023 07:51:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232018AbjEaLvO (ORCPT ); Wed, 31 May 2023 07:51:14 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C978110F for ; Wed, 31 May 2023 04:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685533835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3gAyEuwafL/hxITBiKfoUbav1sLZb6lLFuGPfJnHhTI=; b=La+VGW3XaDAx+GTIBX2pBZ6KK6y/ui2DZUH9+HZLEx6yuIoNRXvDCORistDpMi3VuahAin jqf+7LdcY0sF2vTz59r51P1sr64eWIsxzD4ZGCUQmxhl0lhbFN4tYD2bl1rJNORLLPrha3 lV+bb7JLLLoqcp71PZgMIYwkfSlju7Y= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-627-rQSyLs64O4KvHgBcbeP99w-1; Wed, 31 May 2023 07:50:31 -0400 X-MC-Unique: rQSyLs64O4KvHgBcbeP99w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0E099811E8E; Wed, 31 May 2023 11:50:31 +0000 (UTC) Received: from samus.usersys.redhat.com (unknown [10.43.17.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 728AB40CFD45; Wed, 31 May 2023 11:50:29 +0000 (UTC) From: Artem Savkov To: linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , linux-kernel@vger.kernel.org, Artem Savkov Subject: [PATCH 1/2] perf util: move symbol__new_unresolved() to util/symbol.c Date: Wed, 31 May 2023 13:50:13 +0200 Message-Id: <20230531115014.161454-2-asavkov@redhat.com> In-Reply-To: <20230531115014.161454-1-asavkov@redhat.com> References: <20230531115014.161454-1-asavkov@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Make symbol__new_unresolved() available through util/symbol.h so it can be later used from builtin-c2c. Signed-off-by: Artem Savkov --- tools/perf/ui/browsers/hists.c | 22 ---------------------- tools/perf/util/symbol.c | 22 ++++++++++++++++++++++ tools/perf/util/symbol.h | 1 + 3 files changed, 23 insertions(+), 22 deletions(-) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index 69c81759a64f9..10d2243d27504 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -2471,28 +2471,6 @@ do_annotate(struct hist_browser *browser, struct pop= up_action *act) return 0; } =20 -static struct symbol *symbol__new_unresolved(u64 addr, struct map *map) -{ - struct annotated_source *src; - struct symbol *sym; - char name[64]; - - snprintf(name, sizeof(name), "%.*" PRIx64, BITS_PER_LONG / 4, addr); - - sym =3D symbol__new(addr, ANNOTATION_DUMMY_LEN, 0, 0, name); - if (sym) { - src =3D symbol__hists(sym, 1); - if (!src) { - symbol__delete(sym); - return NULL; - } - - dso__insert_symbol(map__dso(map), sym); - } - - return sym; -} - static int add_annotate_opt(struct hist_browser *browser __maybe_unused, struct popup_action *act, char **optstr, diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index 6b9c55784b56a..297a903f72777 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c @@ -294,6 +294,28 @@ void maps__fixup_end(struct maps *maps) up_write(maps__lock(maps)); } =20 +struct symbol *symbol__new_unresolved(u64 addr, struct map *map) +{ + struct annotated_source *src; + struct symbol *sym; + char name[64]; + + snprintf(name, sizeof(name), "%.*" PRIx64, BITS_PER_LONG / 4, addr); + + sym =3D symbol__new(addr, ANNOTATION_DUMMY_LEN, 0, 0, name); + if (sym) { + src =3D symbol__hists(sym, 1); + if (!src) { + symbol__delete(sym); + return NULL; + } + + dso__insert_symbol(map__dso(map), sym); + } + + return sym; +} + struct symbol *symbol__new(u64 start, u64 len, u8 binding, u8 type, const = char *name) { size_t namelen =3D strlen(name) + 1; diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h index 7558735543c25..4d47748716627 100644 --- a/tools/perf/util/symbol.h +++ b/tools/perf/util/symbol.h @@ -176,6 +176,7 @@ void symbol__exit(void); void symbol__elf_init(void); int symbol__annotation_init(void); =20 +struct symbol *symbol__new_unresolved(u64 addr, struct map *map); struct symbol *symbol__new(u64 start, u64 len, u8 binding, u8 type, const = char *name); size_t __symbol__fprintf_symname_offs(const struct symbol *sym, const struct addr_location *al, --=20 2.40.1