From nobody Mon Feb 9 06:24:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76F5AC77B73 for ; Wed, 31 May 2023 09:55:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234845AbjEaJz2 (ORCPT ); Wed, 31 May 2023 05:55:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235664AbjEaJzR (ORCPT ); Wed, 31 May 2023 05:55:17 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C451711C for ; Wed, 31 May 2023 02:54:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685526871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YtryeNC+vu63BT9xv/2HgRKYlLCkC92odnSUBOKH9oY=; b=L1Nz+jbJG6i0Sl1jO42PkDkGI8lrj9539CBmmsDJQ4kmtQahzKX5keTq6uafXLkYEkEz2n HVxzimJSkjOrVyJ4S74GgqCBtVdzxuTu5GUjUP3ZLUJZzT2v2LwTQzEBY1jEeC9pEuyjKt +Zpv33zRVwCnbLO71EGNFqy/8HupU20= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-9UHZ_965Ms2OHvWYInGSxA-1; Wed, 31 May 2023 05:54:29 -0400 X-MC-Unique: 9UHZ_965Ms2OHvWYInGSxA-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-75b06a31daaso870508185a.2 for ; Wed, 31 May 2023 02:54:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685526869; x=1688118869; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YtryeNC+vu63BT9xv/2HgRKYlLCkC92odnSUBOKH9oY=; b=W1r78DZKgu4K774S5nsKAFAAb6Yd8WEIIRlk7iIPdtlt4/AVCyWlNQnJBcp+szeJc5 3mg9eTVu1YN8dwCisMSvux19E9t8ELBY/3GHyuk6UFAx7jIj2LUT/ZrtbF+hf4h4QcLf M63ZGZtMjN51KUuN6eLLaHWc05c8++U3r4RWN9ndAR4ER/8RuqFyhw0iKHW18dg87wlQ g2jMpcUPskLZcXdFFgKiqw+1/LHdHxsT9MpZ/gy0vqsZrYBtZNSaiRl7boEqTRKciqaP dilHCwLJ6rYAsMl7utHA3rKdSk19amxKUR+CcH7vpqCPSG3QGotU08DfpE2TdElzQxNI mtrg== X-Gm-Message-State: AC+VfDw7JMhqz8fH+9uwNIFl3gVRYUhJQDyeixtUg72pW6F9nArFk4HV oLFOQMMgEq0mudO3I+4AAEJw/jbksdzZWfPXGrBMCx1Pdfz0qOfS+ihWEXdTvwVI+Os7aKHoM1h 2AM+iFsLedxyKtCnIMejabPQ= X-Received: by 2002:a05:620a:838f:b0:75b:23a0:deaf with SMTP id pb15-20020a05620a838f00b0075b23a0deafmr5146146qkn.45.1685526868873; Wed, 31 May 2023 02:54:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ54Vas7SEd2eqeSkUPwQuTvesX+WtYItIG7EHvS790JZITHXYPZnEru66ecMM1izPQvgUK3pg== X-Received: by 2002:a05:620a:838f:b0:75b:23a0:deaf with SMTP id pb15-20020a05620a838f00b0075b23a0deafmr5146133qkn.45.1685526868593; Wed, 31 May 2023 02:54:28 -0700 (PDT) Received: from klayman.redhat.com (net-2-34-28-169.cust.vodafonedsl.it. [2.34.28.169]) by smtp.gmail.com with ESMTPSA id k25-20020a05620a139900b0074def53eca5sm4902404qki.53.2023.05.31.02.54.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 May 2023 02:54:28 -0700 (PDT) From: Marco Pagani To: Moritz Fischer , Wu Hao , Xu Yilun , Tom Rix Cc: Marco Pagani , linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org Subject: [RFC PATCH v6 2/4] fpga: add an initial KUnit suite for the FPGA Bridge Date: Wed, 31 May 2023 11:54:03 +0200 Message-Id: <20230531095405.342080-3-marpagan@redhat.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230531095405.342080-1-marpagan@redhat.com> References: <20230531095405.342080-1-marpagan@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The suite tests the basic behaviors of the FPGA Bridge and the functions that operate on a list of Bridges. Signed-off-by: Marco Pagani --- drivers/fpga/tests/fpga-bridge-test.c | 164 ++++++++++++++++++++++++++ 1 file changed, 164 insertions(+) create mode 100644 drivers/fpga/tests/fpga-bridge-test.c diff --git a/drivers/fpga/tests/fpga-bridge-test.c b/drivers/fpga/tests/fpg= a-bridge-test.c new file mode 100644 index 000000000000..52c82f76a92c --- /dev/null +++ b/drivers/fpga/tests/fpga-bridge-test.c @@ -0,0 +1,164 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * KUnit test for the FPGA Bridge + * + * Copyright (C) 2023 Red Hat, Inc. + * + * Author: Marco Pagani + */ + +#include +#include +#include +#include +#include + +struct bridge_stats { + bool enable; +}; + +struct bridge_ctx { + struct fpga_bridge *bridge; + struct platform_device *pdev; + struct bridge_stats stats; +}; + +static int op_enable_set(struct fpga_bridge *bridge, bool enable) +{ + struct bridge_stats *stats =3D bridge->priv; + + stats->enable =3D enable; + + return 0; +} + +static const struct fpga_bridge_ops fake_bridge_ops =3D { + .enable_set =3D op_enable_set +}; + +static struct bridge_ctx *register_test_bridge(struct kunit *test) +{ + struct bridge_ctx *ctx; + + ctx =3D kunit_kzalloc(test, sizeof(*ctx), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); + + ctx->pdev =3D platform_device_register_simple("bridge_pdev", PLATFORM_DEV= ID_AUTO, NULL, 0); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx->pdev); + + ctx->bridge =3D fpga_bridge_register(&ctx->pdev->dev, "Fake FPGA Bridge",= &fake_bridge_ops, + &ctx->stats); + KUNIT_ASSERT_FALSE(test, IS_ERR_OR_NULL(ctx->bridge)); + + return ctx; +} + +static void unregister_test_bridge(struct bridge_ctx *ctx) +{ + fpga_bridge_unregister(ctx->bridge); + platform_device_unregister(ctx->pdev); +} + +static void fpga_bridge_test_get(struct kunit *test) +{ + struct bridge_ctx *ctx =3D test->priv; + struct fpga_bridge *bridge; + + bridge =3D fpga_bridge_get(&ctx->pdev->dev, NULL); + KUNIT_EXPECT_PTR_EQ(test, bridge, ctx->bridge); + + bridge =3D fpga_bridge_get(&ctx->pdev->dev, NULL); + KUNIT_EXPECT_EQ(test, PTR_ERR(bridge), -EBUSY); + + fpga_bridge_put(ctx->bridge); +} + +static void fpga_bridge_test_toggle(struct kunit *test) +{ + struct bridge_ctx *ctx =3D test->priv; + int ret; + + ret =3D fpga_bridge_disable(ctx->bridge); + KUNIT_EXPECT_EQ(test, ret, 0); + KUNIT_EXPECT_FALSE(test, ctx->stats.enable); + + ret =3D fpga_bridge_enable(ctx->bridge); + KUNIT_EXPECT_EQ(test, ret, 0); + KUNIT_EXPECT_TRUE(test, ctx->stats.enable); +} + +static void fpga_bridge_test_get_put_list(struct kunit *test) +{ + struct list_head bridge_list; + struct bridge_ctx *ctx_0, *ctx_1; + int ret; + + ctx_0 =3D test->priv; + ctx_1 =3D register_test_bridge(test); + + INIT_LIST_HEAD(&bridge_list); + + /* Get bridge 0 and add it to the list */ + ret =3D fpga_bridge_get_to_list(&ctx_0->pdev->dev, NULL, &bridge_list); + KUNIT_EXPECT_EQ(test, ret, 0); + + KUNIT_EXPECT_PTR_EQ(test, ctx_0->bridge, + list_first_entry_or_null(&bridge_list, struct fpga_bridge, node)); + + /* Get bridge 1 and add it to the list */ + ret =3D fpga_bridge_get_to_list(&ctx_1->pdev->dev, NULL, &bridge_list); + KUNIT_EXPECT_EQ(test, ret, 0); + + KUNIT_EXPECT_PTR_EQ(test, ctx_1->bridge, + list_first_entry_or_null(&bridge_list, struct fpga_bridge, node)); + + /* Disable an then enable both bridges from the list */ + ret =3D fpga_bridges_disable(&bridge_list); + KUNIT_EXPECT_EQ(test, ret, 0); + + KUNIT_EXPECT_FALSE(test, ctx_0->stats.enable); + KUNIT_EXPECT_FALSE(test, ctx_1->stats.enable); + + ret =3D fpga_bridges_enable(&bridge_list); + KUNIT_EXPECT_EQ(test, ret, 0); + + KUNIT_EXPECT_TRUE(test, ctx_0->stats.enable); + KUNIT_EXPECT_TRUE(test, ctx_1->stats.enable); + + /* Put and remove both bridges from the list */ + fpga_bridges_put(&bridge_list); + + KUNIT_EXPECT_TRUE(test, list_empty(&bridge_list)); + + unregister_test_bridge(ctx_1); +} + +static int fpga_bridge_test_init(struct kunit *test) +{ + test->priv =3D register_test_bridge(test); + + return 0; +} + +static void fpga_bridge_test_exit(struct kunit *test) +{ + unregister_test_bridge(test->priv); +} + +static struct kunit_case fpga_bridge_test_cases[] =3D { + KUNIT_CASE(fpga_bridge_test_get), + KUNIT_CASE(fpga_bridge_test_toggle), + KUNIT_CASE(fpga_bridge_test_get_put_list), + {} +}; + +static struct kunit_suite fpga_bridge_suite =3D { + .name =3D "fpga_bridge", + .init =3D fpga_bridge_test_init, + .exit =3D fpga_bridge_test_exit, + .test_cases =3D fpga_bridge_test_cases, +}; + +kunit_test_suite(fpga_bridge_suite); + +MODULE_LICENSE("GPL"); --=20 2.40.1