From nobody Sun Feb 8 20:52:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E5ECC7EE23 for ; Tue, 30 May 2023 14:27:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232815AbjE3O1R (ORCPT ); Tue, 30 May 2023 10:27:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232623AbjE3O0o (ORCPT ); Tue, 30 May 2023 10:26:44 -0400 Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F631E5E; Tue, 30 May 2023 07:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1685456755; x=1716992755; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=i55kdjewwFdv2f+P5xqKlvalulEYMjxB14MY/amwhRg=; b=hmUQgCrFeU55hYBEKXeoCa8hAMVEh+fG7zN/MPWCxgn3GW4QgxIQnEvJ NStvCOJAUeaKdpN3ywKMLOczqPKVlAk5UjxaXw9hiSRSREzqHJNkrf8bs rj2JhDt7ZBbmcFnoiGNF3KD2ARBA4Be4y2rLrmNYmWaO1txEfDm1B2lJA o8DQBD6v77Dlhy5osGWvwzgHkJon9AzQKJ7nnvDLkMrmWUMCkBXYEMIO7 HMXCzQemchgBs7XalAN7/g4JkhG7Xz14LCeaGR4GmZMGicRO+aLkjkO7i 8TlM+3fpki8WBhQ5FEJ8aqT4uWVPAsKyIHkXRhQGM+h2dDKXceJ8T/+HP A==; From: Astrid Rost To: Jonathan Cameron , Lars-Peter Clausen CC: , , , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Mathieu Othacehe , Astrid Rost Subject: [PATCH v5 6/7] iio: light: vcnl4000: Add oversampling_ratio for 4040/4200 Date: Tue, 30 May 2023 16:24:04 +0200 Message-ID: <20230530142405.1679146-7-astrid.rost@axis.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230530142405.1679146-1-astrid.rost@axis.com> References: <20230530142405.1679146-1-astrid.rost@axis.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add the proximity multi pulse (PS_MPS) as oversampling_ratio. Instead of one single pulse per every defined time frame, one can program2, 4, or even 8 pulses. This leads to a longer IRED on-time for each proximity measurement value, which also results in a higher detection range. Add read/write attribute for proximity oversampling-ratio and read attribute for available oversampling-ratio. This is supported for vcnl4040 and vcnl4200. Signed-off-by: Astrid Rost --- drivers/iio/light/vcnl4000.c | 86 +++++++++++++++++++++++++++++++++++- 1 file changed, 84 insertions(+), 2 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 3ae137bcd51a..7a340c6f518f 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -61,6 +61,7 @@ =20 #define VCNL4200_AL_CONF 0x00 /* Ambient light configuration */ #define VCNL4200_PS_CONF1 0x03 /* Proximity configuration */ +#define VCNL4200_PS_CONF3 0x04 /* Proximity configuration */ #define VCNL4040_PS_THDL_LM 0x06 /* Proximity threshold low */ #define VCNL4040_PS_THDH_LM 0x07 /* Proximity threshold high */ #define VCNL4040_ALS_THDL_LM 0x02 /* Ambient light threshold low */ @@ -90,6 +91,7 @@ #define VCNL4040_PS_CONF2_PS_IT GENMASK(3, 1) /* Proximity integration tim= e */ #define VCNL4040_CONF1_PS_PERS GENMASK(5, 4) /* Proximity interrupt persis= tence setting */ #define VCNL4040_PS_CONF2_PS_INT GENMASK(9, 8) /* Proximity interrupt mode= */ +#define VCNL4040_PS_CONF3_MPS GENMASK(6, 5) /* Proximity multi pulse numb= er */ #define VCNL4040_PS_IF_AWAY BIT(8) /* Proximity event cross low threshold= */ #define VCNL4040_PS_IF_CLOSE BIT(9) /* Proximity event cross high thresho= ld */ #define VCNL4040_ALS_RISING BIT(12) /* Ambient Light cross high threshold= */ @@ -158,6 +160,7 @@ static const int vcnl4200_als_it_times[][2] =3D { =20 static const int vcnl4040_als_persistence[] =3D {1, 2, 4, 8}; static const int vcnl4040_ps_persistence[] =3D {1, 2, 3, 4}; +static const int vcnl4040_ps_oversampling_ratio[] =3D {1, 2, 4, 8}; =20 #define VCNL4000_SLEEP_DELAY_MS 2000 /* before we enter pm_runtime_suspend= */ =20 @@ -777,6 +780,56 @@ static ssize_t vcnl4040_write_ps_period(struct vcnl400= 0_data *data, int val, int return ret; } =20 +static ssize_t vcnl4040_read_ps_oversampling_ratio(struct vcnl4000_data *d= ata, int *val) +{ + int ret; + + ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF3); + if (ret < 0) + return ret; + + ret =3D FIELD_GET(VCNL4040_PS_CONF3_MPS, ret); + + if (ret >=3D ARRAY_SIZE(vcnl4040_ps_oversampling_ratio)) + return -EINVAL; + + *val =3D vcnl4040_ps_oversampling_ratio[ret]; + + return ret; +} + +static ssize_t vcnl4040_write_ps_oversampling_ratio(struct vcnl4000_data *= data, int val) +{ + unsigned int i; + int ret, reg_val =3D -1; + u16 regval; + + for (i =3D 0; i < ARRAY_SIZE(vcnl4040_ps_oversampling_ratio); i++) { + if (val =3D=3D vcnl4040_ps_oversampling_ratio[i]) { + reg_val =3D i; + break; + } + } + + if (reg_val < 0) + return -EINVAL; + + mutex_lock(&data->vcnl4000_lock); + + ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF3); + if (ret < 0) + goto out_unlock; + + regval =3D (ret & ~VCNL4040_PS_CONF3_MPS) | + FIELD_PREP(VCNL4040_PS_CONF3_MPS, reg_val); + ret =3D i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF3, + regval); + +out_unlock: + mutex_unlock(&data->vcnl4000_lock); + return ret; +} + static int vcnl4000_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec const *chan, int *val, int *val2, long mask) @@ -827,6 +880,16 @@ static int vcnl4000_read_raw(struct iio_dev *indio_dev, if (ret < 0) return ret; return IIO_VAL_INT_PLUS_MICRO; + case IIO_CHAN_INFO_OVERSAMPLING_RATIO: + switch (chan->type) { + case IIO_PROXIMITY: + ret =3D vcnl4040_read_ps_oversampling_ratio(data, val); + if (ret < 0) + return ret; + return IIO_VAL_INT; + default: + return -EINVAL; + } default: return -EINVAL; } @@ -850,6 +913,13 @@ static int vcnl4040_write_raw(struct iio_dev *indio_de= v, default: return -EINVAL; } + case IIO_CHAN_INFO_OVERSAMPLING_RATIO: + switch (chan->type) { + case IIO_PROXIMITY: + return vcnl4040_write_ps_oversampling_ratio(data, val); + default: + return -EINVAL; + } default: return -EINVAL; } @@ -878,6 +948,16 @@ static int vcnl4040_read_avail(struct iio_dev *indio_d= ev, } *type =3D IIO_VAL_INT_PLUS_MICRO; return IIO_AVAIL_LIST; + case IIO_CHAN_INFO_OVERSAMPLING_RATIO: + switch (chan->type) { + case IIO_PROXIMITY: + *vals =3D (int *)vcnl4040_ps_oversampling_ratio; + *length =3D ARRAY_SIZE(vcnl4040_ps_oversampling_ratio); + *type =3D IIO_VAL_INT; + return IIO_AVAIL_LIST; + default: + return -EINVAL; + } default: return -EINVAL; } @@ -1648,8 +1728,10 @@ static const struct iio_chan_spec vcnl4040_channels[= ] =3D { }, { .type =3D IIO_PROXIMITY, .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW) | - BIT(IIO_CHAN_INFO_INT_TIME), - .info_mask_separate_available =3D BIT(IIO_CHAN_INFO_INT_TIME), + BIT(IIO_CHAN_INFO_INT_TIME) | + BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO), + .info_mask_separate_available =3D BIT(IIO_CHAN_INFO_INT_TIME) | + BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO), .ext_info =3D vcnl4000_ext_info, .event_spec =3D vcnl4040_event_spec, .num_event_specs =3D ARRAY_SIZE(vcnl4040_event_spec), --=20 2.30.2