From nobody Sat Feb 7 23:22:47 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73220C7EE23 for ; Tue, 30 May 2023 07:56:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229761AbjE3H4j (ORCPT ); Tue, 30 May 2023 03:56:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229735AbjE3H4c (ORCPT ); Tue, 30 May 2023 03:56:32 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C922F13A for ; Tue, 30 May 2023 00:56:11 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-561eadd916fso88542057b3.1 for ; Tue, 30 May 2023 00:56:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685433371; x=1688025371; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=K7ytfWF+UN+RaMrVhdC48WtmycV9AzSbc9oaKd9zjxk=; b=hOUtLNfZE60vJA625/94v7A5IkhIJF8qwaDymhZkbTk20AZUukm+XNUXuRkmOqBxTQ emjuInDHpiaGcWk91ywLezj4ftmluptwp8vSo4w8KefDtWj+D2Ps2OOU1mbcK1i5du9q yMy3ZkSEaRjVafp68Qak+SPnUEp1k5F7V+1YHfWozVmiQcFDYWWNL39pvnJS6RdEHRkV mqqbnxM6DNQZ5I1bY2FVhqtq2EL1PeXX8affZ7fIFz9mMhdRvy2yrCUJ1bhyB4zfv9Lh jZBiWW68kOSEKWOgWGv3/UQVe5AWDzLldoYAa5pbq6d3fxUtiv4OqwznQkvfId9VTOdJ 29ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685433371; x=1688025371; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=K7ytfWF+UN+RaMrVhdC48WtmycV9AzSbc9oaKd9zjxk=; b=JcJgiprVGwl705SdpFIuzAlr0uOFVn67ZaAMqQyLzEzQADCfUUvGmgh3wnCK7WhJ2s bpSXhMYAqXtEpGra7IGT4L6TkV6FcikLtt/Hm2ovVr1o7x2bnImya20UvLqHxIZWxD8p R7E9AHtgax8hhsV9qzSyVvMN7nJ8pn0LZwRMOD2GlZFaU4PaSIjw7puUB+pbWTKLqNPE SOnnQCN6ro6rU9tAg1D4YoG1qFEUeCaIZR199w/zK6W5jR5DXr3k4oi4bYhsSh+uP6mU rDyQ9UGh+lpl2EzKavqUMECPm2nHy64k+2aLxw2VbWtVilAyBXRCPuIyQTMP+5yZBwfC XrNA== X-Gm-Message-State: AC+VfDzb2sQvTOmt52d+lmihvepfY/MGtV66Z+y2gQ54QJLeYVDqShib uUctx1JKcW7SOnxl8zsfOXotd5V8Uwbx6A== X-Google-Smtp-Source: ACHHUZ5JSMwZMnDvGVI6Ii/vsemPy+HbaWLd8oh0flzFpYKfGfN+sd93pJ/SZfyB3wUb5YMJUtNRmqnRoHcAaA== X-Received: from slicestar.c.googlers.com ([fda3:e722:ac3:cc00:4f:4b78:c0a8:20a1]) (user=davidgow job=sendgmr) by 2002:a81:ae09:0:b0:560:d237:43dc with SMTP id m9-20020a81ae09000000b00560d23743dcmr911546ywh.3.1685433371096; Tue, 30 May 2023 00:56:11 -0700 (PDT) Date: Tue, 30 May 2023 15:55:57 +0800 Mime-Version: 1.0 X-Mailer: git-send-email 2.41.0.rc0.172.g3f132b7071-goog Message-ID: <20230530075557.1558422-2-davidgow@google.com> Subject: [PATCH] kunit: Fix obsolete name in documentation headers (func->action) From: David Gow To: Brendan Higgins , Shuah Khan Cc: Benjamin Berg , Maxime Ripard , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, David Gow , Stephen Rothwell Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The kunit_add_action() and related functions named the kunit_action_t parameter 'func' in early drafts, which was later renamed to 'action' However, the doc comments were not properly updated. Fix these to avoid confusion and 'make htmldocs' warnings. Fixes: b9dce8a1ed3e ("kunit: Add kunit_add_action() to defer a call until t= est exit") Reported-by: Stephen Rothwell Closes: https://lore.kernel.org/lkml/20230530151840.16a56460@canb.auug.org.= au/ Signed-off-by: David Gow Reviewed-by: Maxime Ripard --- include/kunit/resource.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/kunit/resource.h b/include/kunit/resource.h index b64eb783b1bc..c7383e90f5c9 100644 --- a/include/kunit/resource.h +++ b/include/kunit/resource.h @@ -393,7 +393,7 @@ typedef void (kunit_action_t)(void *); /** * kunit_add_action() - Call a function when the test ends. * @test: Test case to associate the action with. - * @func: The function to run on test exit + * @action: The function to run on test exit * @ctx: Data passed into @func * * Defer the execution of a function until the test exits, either normally= or @@ -415,7 +415,7 @@ int kunit_add_action(struct kunit *test, kunit_action_t= *action, void *ctx); /** * kunit_add_action_or_reset() - Call a function when the test ends. * @test: Test case to associate the action with. - * @func: The function to run on test exit + * @action: The function to run on test exit * @ctx: Data passed into @func * * Defer the execution of a function until the test exits, either normally= or @@ -441,7 +441,7 @@ int kunit_add_action_or_reset(struct kunit *test, kunit= _action_t *action, /** * kunit_remove_action() - Cancel a matching deferred action. * @test: Test case the action is associated with. - * @func: The deferred function to cancel. + * @action: The deferred function to cancel. * @ctx: The context passed to the deferred function to trigger. * * Prevent an action deferred via kunit_add_action() from executing when t= he @@ -459,7 +459,7 @@ void kunit_remove_action(struct kunit *test, /** * kunit_release_action() - Run a matching action call immediately. * @test: Test case the action is associated with. - * @func: The deferred function to trigger. + * @action: The deferred function to trigger. * @ctx: The context passed to the deferred function to trigger. * * Execute a function deferred via kunit_add_action()) immediately, rather= than --=20 2.41.0.rc0.172.g3f132b7071-goog