From nobody Mon Feb 9 05:14:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E94CFC77B7A for ; Mon, 29 May 2023 13:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229686AbjE2NOg (ORCPT ); Mon, 29 May 2023 09:14:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229662AbjE2NOa (ORCPT ); Mon, 29 May 2023 09:14:30 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DD17DB for ; Mon, 29 May 2023 06:14:28 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-4f4b2bc1565so3484189e87.2 for ; Mon, 29 May 2023 06:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685366066; x=1687958066; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=y+V7KYFuHBlcW45OH+41zrPJ2QlzAmwJ01YvxpqIdOY=; b=heEDyz0czFX7nvZcYkoL5KM3cb/debnJIH2icfy4MLPa9ya6cNZYEF5js/pUZ/CVf2 CCjCPZrxJzV9vD2eqBKTKttlxrSDi4eQW6kPpINuDEEQeAGTvanDqQ4dEoJ6sWPhoxKK 6g2/NJ6m193P2A0ai2qCnvDSxlGm2hkkW1mE40wjnKP2/ywrAQQvJudnVk1llm6DZc2d n+SRRvQxazTsCepMJzx55ci+/3RM30mLONX4oIHTFM+HVcXBrBJjWQvGc6gpCXNtsqdF VJorsUxrlQbkn/KzutuwDXcZXrwImunrz9tGvIGRd4a+ZmI7kvjHvsGsrWtwH7hO2j4b sjZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685366066; x=1687958066; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y+V7KYFuHBlcW45OH+41zrPJ2QlzAmwJ01YvxpqIdOY=; b=Bx2enMp5ylkVGTkqTEcJNx2SGSKjeo0NwF6PxaaGHRo6p4yALNgdeyR1qim+MNNCH1 6Ru2fyK8+TFfuEozByZCvWv/DDSOVuLjvO3VgFWMZojZkwDPQlu6p1yZw7xfml3yJ/ki 62KY6qhn9MDYGzp+IlmAQ9q5aYsME+EIHW8/ZzpktZfg+Pk4FqSKMeN0SvkkA2l5u8WD qmB8n2UQUgvMTHMnYHLjjPYJ+W+CXZyCLxS1VcmGU+eR67vX0Dxta1VUsLgligLn/Fmc NJSkTOi1/K+0stfPkkD/rRLAfveyAx/bI7Aa8ALgnCiGfomf862Xc6+zOvmUpRwXd1Ma zb4A== X-Gm-Message-State: AC+VfDz/1Qxut9ucD8eQTJZLW37Of6VUlYINN8GwA2lkXcGLLC/uEA1j M1hceWUso1vsC+N4olkhwtiEER/W40lL8yv7Ufs= X-Google-Smtp-Source: ACHHUZ7j20SK7rrraFhp/LOk0x4kKeh5uRiNhFtlZWnbqmYRAVyUyrPhnb7CnwVnvH44a4GNkLwC9Q== X-Received: by 2002:ac2:5208:0:b0:4f3:a0f0:7c4a with SMTP id a8-20020ac25208000000b004f3a0f07c4amr3419633lfl.40.1685366066606; Mon, 29 May 2023 06:14:26 -0700 (PDT) Received: from [192.168.1.101] (abyj77.neoplus.adsl.tpnet.pl. [83.9.29.77]) by smtp.gmail.com with ESMTPSA id b30-20020ac25e9e000000b004eff4f67f1csm1966375lfq.304.2023.05.29.06.14.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 May 2023 06:14:26 -0700 (PDT) From: Konrad Dybcio Date: Mon, 29 May 2023 15:14:23 +0200 Subject: [PATCH 1/2] dt-bindings: clock: sm6375-gpucc: Add VDD_GX MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230529-topic-sm6375gpuccpd-v1-1-8d57c41a6066@linaro.org> References: <20230529-topic-sm6375gpuccpd-v1-0-8d57c41a6066@linaro.org> In-Reply-To: <20230529-topic-sm6375gpuccpd-v1-0-8d57c41a6066@linaro.org> To: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1685366063; l=1827; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=WQWF4JJc7yA9tWZ94p0YCyHtEC0Bk5E4nV1ZHYYfpQM=; b=zZUIuwkkxc6pabcOv6AenjuRpHNEF0ij5m1IkX94treKnyiYUsxZLrVX/P0U+/F7ckkRkoEHP 42FKRKl7G0GDNfUEGh1PV/yZuQFxMZIgi+cRoo0IfTiRHfuJrzjHCLv X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The GPUCC block on SM6375 is powered by VDD_CX and VDD_GX. If the latter rail is not online, GX_GDSC will never turn on. Describe the missing handles. Signed-off-by: Konrad Dybcio Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/clock/qcom,sm6375-gpucc.yaml | 15 +++++++++++= ++++ 1 file changed, 15 insertions(+) diff --git a/Documentation/devicetree/bindings/clock/qcom,sm6375-gpucc.yaml= b/Documentation/devicetree/bindings/clock/qcom,sm6375-gpucc.yaml index b480ead5bd69..cf4cad76f6c9 100644 --- a/Documentation/devicetree/bindings/clock/qcom,sm6375-gpucc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,sm6375-gpucc.yaml @@ -27,9 +27,21 @@ properties: - description: GPLL0 div branch source - description: SNoC DVM GFX source =20 + power-domains: + description: + A phandle and PM domain specifier for the VDD_GX power rail + maxItems: 1 + + required-opps: + description: + A phandle to an OPP node describing required VDD_GX performance poin= t. + maxItems: 1 + required: - compatible - clocks + - power-domains + - required-opps =20 allOf: - $ref: qcom,gcc.yaml# @@ -40,6 +52,7 @@ examples: - | #include #include + #include =20 soc { #address-cells =3D <2>; @@ -52,6 +65,8 @@ examples: <&gcc GCC_GPU_GPLL0_CLK_SRC>, <&gcc GCC_GPU_GPLL0_DIV_CLK_SRC>, <&gcc GCC_GPU_SNOC_DVM_GFX_CLK>; + power-domains =3D <&rpmpd SM6375_VDDGX>; + required-opps =3D <&rpmpd_opp_low_svs>; #clock-cells =3D <1>; #reset-cells =3D <1>; #power-domain-cells =3D <1>; --=20 2.40.1 From nobody Mon Feb 9 05:14:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27C8AC77B7E for ; Mon, 29 May 2023 13:14:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229725AbjE2NOj (ORCPT ); Mon, 29 May 2023 09:14:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbjE2NOb (ORCPT ); Mon, 29 May 2023 09:14:31 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B387B7 for ; Mon, 29 May 2023 06:14:30 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-4f3a99b9177so3673482e87.1 for ; Mon, 29 May 2023 06:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685366068; x=1687958068; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=x278P3+nKSRirib6kE+simYSKscVONKkDYY89zSUJwA=; b=vyonl+avaXtFvjnis6oaTqyYS0tNt8GzEjV5F5AK4Rtot4JdsLwHp6SxMccKaPEwPx phkJi5bJslMRnpya6lGi0SCAmbUIrd8VfJbyytmhuC5+7aVfJvuckrk4RDKS2jNJVxWz 7XofMe3aBUE0WueGz0YLm7zT7QlxhmmhA8Ys82+nUrUaHiZSCcp02C0+IQxaOBkg5Fmf 9hIf8KBMKpAON+soDrqQ4KYUjdpYv5h8Yd1iWZs0AJ9W3AK1XXbexXvYzzcZ/oO1cgwC g8yZdfsSn3kYBAV6UGVymVGWkabKMWfEejysAEZaNowFQMDj+U1J4Z/yITsiJasQ3q3Q RqtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685366068; x=1687958068; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x278P3+nKSRirib6kE+simYSKscVONKkDYY89zSUJwA=; b=Wu/vCTw+oSQve7DdVHDniDQOYlGRvip3mPShxKTzKXxu2UroJjZHvWdMs5aTcCdwIq c7DY5IpJE20LAh9hj/ed3rqzCwIuBmbj1FzmslggUe339Zv5+J8Db8XrPiYmYA49DcVf x7Kist5Mektr/FXTZ/gILgpbE7srn9hfC7pFjoRvBIqwTjSL1ad3fqSDvHS4Wp4NXDf/ zOrnySM8oB4b/5tktmzse5i2xz0MRqmRg6bfhyrYcUYexEkXhrfvHFbcRBCC12I7cN22 R5SGM8vtITq791UgTWaByd9Dwo73RzxNS1ahphKylNyDSjS49lYxRI0987muqxtzqmH5 kpFA== X-Gm-Message-State: AC+VfDx+pmTlvqvj2r2hKd0pJxcEunhfkOoMxzC9lJscBsJlmsjL1KBp 7cC0IVKKJ0UawpxBFAqIKZXmIl/MbUDINU0C8pc= X-Google-Smtp-Source: ACHHUZ64bJxUlWfKrTYuuifCQmsZ8flxdmFyt4wtjuoOR0e10k9HkCvTD9LJYMTgWCOhZpt78Sfn3Q== X-Received: by 2002:ac2:4425:0:b0:4f2:7cb1:65fc with SMTP id w5-20020ac24425000000b004f27cb165fcmr3352598lfl.64.1685366067830; Mon, 29 May 2023 06:14:27 -0700 (PDT) Received: from [192.168.1.101] (abyj77.neoplus.adsl.tpnet.pl. [83.9.29.77]) by smtp.gmail.com with ESMTPSA id b30-20020ac25e9e000000b004eff4f67f1csm1966375lfq.304.2023.05.29.06.14.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 May 2023 06:14:27 -0700 (PDT) From: Konrad Dybcio Date: Mon, 29 May 2023 15:14:24 +0200 Subject: [PATCH 2/2] clk: qcom: gpucc-sm6375: Enable runtime pm MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230529-topic-sm6375gpuccpd-v1-2-8d57c41a6066@linaro.org> References: <20230529-topic-sm6375gpuccpd-v1-0-8d57c41a6066@linaro.org> In-Reply-To: <20230529-topic-sm6375gpuccpd-v1-0-8d57c41a6066@linaro.org> To: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1685366063; l=1703; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=FCWtznh8qKMCk7aGI9UAflx31G2nB1pwP25Cm0GDLGM=; b=TIzzdGVj/33FhZbVZwxfJzULE98ho9j5EP0ObW6OgbnLYs/W032xyG2b6VnlD4zyfMypgxTdh 3f28AKawd+1DPldnYJmP4wKIVgSVzDq86t7OOShQ8BndH8/OWYEIDV9 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The GPUCC block on SM6375 is powered by VDD_CX and VDD_GX. If the latter rail is not online, GX_GDSC will never turn on. Enable runtime pm so that we can reference VDD_GX from the dt to ensure that. Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gpucc-sm6375.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/gpucc-sm6375.c b/drivers/clk/qcom/gpucc-sm637= 5.c index d3620344a009..2d863dc3d83b 100644 --- a/drivers/clk/qcom/gpucc-sm6375.c +++ b/drivers/clk/qcom/gpucc-sm6375.c @@ -7,6 +7,7 @@ #include #include #include +#include #include =20 #include @@ -434,15 +435,29 @@ MODULE_DEVICE_TABLE(of, gpucc_sm6375_match_table); static int gpucc_sm6375_probe(struct platform_device *pdev) { struct regmap *regmap; + int ret; + + ret =3D devm_pm_runtime_enable(&pdev->dev); + if (ret) + return ret; + + ret =3D pm_runtime_resume_and_get(&pdev->dev); + if (ret) + return ret; =20 regmap =3D qcom_cc_map(pdev, &gpucc_sm6375_desc); - if (IS_ERR(regmap)) + if (IS_ERR(regmap)) { + pm_runtime_put(&pdev->dev); return PTR_ERR(regmap); + } =20 clk_lucid_pll_configure(&gpucc_pll0, regmap, &gpucc_pll0_config); clk_lucid_pll_configure(&gpucc_pll1, regmap, &gpucc_pll1_config); =20 - return qcom_cc_really_probe(pdev, &gpucc_sm6375_desc, regmap); + ret =3D qcom_cc_really_probe(pdev, &gpucc_sm6375_desc, regmap); + pm_runtime_put(&pdev->dev); + + return ret; } =20 static struct platform_driver gpucc_sm6375_driver =3D { --=20 2.40.1