From nobody Sun Feb 8 07:07:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC750C77B7A for ; Fri, 26 May 2023 19:45:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231447AbjEZTpE (ORCPT ); Fri, 26 May 2023 15:45:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243077AbjEZTou (ORCPT ); Fri, 26 May 2023 15:44:50 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17F15BD for ; Fri, 26 May 2023 12:44:49 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-ba87bd29e9dso1512414276.3 for ; Fri, 26 May 2023 12:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685130288; x=1687722288; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=PCEuHB+EAhk+z6YgMVeylt+nnvBXz0KV/fMFiqSw75M=; b=00c8A4WdV3GcZZCBWyJI3N171+nLyljMSnaQpXe6v9LMUp01Hu3fn5FEAKGT4ivB1N P5EcKBGfI5YekKMp+h2uaJGZvCpu0i6Kwh88bNnZRTBInCk6jnIZQodHPCrq/smVsoJH MDFnTBJMiEb2bx5MKmw0kcUg00X+YbE8YdtiBuQxbvaCvgN7xTBMX/nBYdCqhIET3xX6 dtgh9TYGlzpv6vBYzN4Nr/vgLC3ztLDpjjJa1tR4fZGHw8Gk6PQkoTwi1QtXC/UVMX/j rZBw7OgFAxMuzWFVjzvrSWJn7iKPVMf7jd5bl/1TwJJSr/oxBH9eLtuSElxitNpSyJ// datQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685130288; x=1687722288; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PCEuHB+EAhk+z6YgMVeylt+nnvBXz0KV/fMFiqSw75M=; b=QFPSw2x/xMSWdZMQbN7Zg9CgHC76CO/UaIGXRanKBZKnG/MKUgQLgf64FuGJZ9vegm xDXn9ymGzFGqelMIDI+zlnSu2tZGY1Lb4M0DSBLJDQ9G58CoKbuAE6G/a1gGJMCM7cof Vt3XCholK4IZzeWm+ZdIpFXOHsSZwvKlCyq+DejH88gC2UkKMwOrcaOBii3my0DDoNIC C5cw/8eHziXKU+2vLIw9BXE/oqNrlYYBatxrxQOpoJHkvU1UxbjBxfvRbLSL1QcX+12r hlLSIWO+Rw4W2xq/ngAQFxEvdxcoNt4yX8bZUV5D7iNDMUDijAI+uVPO4kZuXjv7Y33U 3M8g== X-Gm-Message-State: AC+VfDz8L4cS7HfPeDJzyzNh4K0+0sGsxSXnTWqjG8wLNl6/WEDe0e4Q KAEkxvADT+3W9axeebA64RflsYrRp/Hf X-Google-Smtp-Source: ACHHUZ4w9+UOJ8hpR92L+iuqXV2CCmM6jGTjaatKscEYXFC++9uOkF55WjICj/Btteh9ifUfJVf9/dcy0/O/ X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:3b4e:312c:644:a642]) (user=irogers job=sendgmr) by 2002:a25:d8a:0:b0:ba8:2415:f27c with SMTP id 132-20020a250d8a000000b00ba82415f27cmr1536907ybn.3.1685130288399; Fri, 26 May 2023 12:44:48 -0700 (PDT) Date: Fri, 26 May 2023 12:44:41 -0700 In-Reply-To: <20230526194442.2355872-1-irogers@google.com> Message-Id: <20230526194442.2355872-2-irogers@google.com> Mime-Version: 1.0 References: <20230526194442.2355872-1-irogers@google.com> X-Mailer: git-send-email 2.41.0.rc0.172.g3f132b7071-goog Subject: [PATCH v3 1/2] perf evsel: evsel__group_pmu_name fixes From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Kan Liang , Sandipan Das , James Clark , Dmitrii Dolgov <9erthalion6@gmail.com>, Changbin Du , Rob Herring , Xing Zhengjun , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Previously the evsel__group_pmu_name would iterate the evsel's group, however, the list of evsels aren't yet sorted and so the loop may terminate prematurely. It is also not desirable to iterate the list of evsels during list_sort as the list may be broken. Precompute the group_pmu_name for the evsel before sorting, as part of the computation and only if necessary, iterate the whole list looking for group members so that being sorted isn't necessary. Move the group pmu name computation to parse-events.c given the closer dependency on the behavior of parse_events__sort_events_and_fix_groups. Fixes: 7abf0bccaaec ("perf evsel: Add function to compute group PMU name") Signed-off-by: Ian Rogers --- tools/perf/util/evsel.c | 31 ++++----------- tools/perf/util/evsel.h | 2 +- tools/perf/util/parse-events.c | 70 ++++++++++++++++++++++++++++------ 3 files changed, 67 insertions(+), 36 deletions(-) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 42d6dfacf191..a3c24d2e8ca3 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -291,6 +291,7 @@ void evsel__init(struct evsel *evsel, evsel->per_pkg_mask =3D NULL; evsel->collect_stat =3D false; evsel->pmu_name =3D NULL; + evsel->group_pmu_name =3D NULL; evsel->skippable =3D false; } =20 @@ -390,6 +391,11 @@ struct evsel *evsel__clone(struct evsel *orig) if (evsel->pmu_name =3D=3D NULL) goto out_err; } + if (orig->group_pmu_name) { + evsel->group_pmu_name =3D strdup(orig->group_pmu_name); + if (evsel->group_pmu_name =3D=3D NULL) + goto out_err; + } if (orig->filter) { evsel->filter =3D strdup(orig->filter); if (evsel->filter =3D=3D NULL) @@ -786,30 +792,6 @@ bool evsel__name_is(struct evsel *evsel, const char *n= ame) return !strcmp(evsel__name(evsel), name); } =20 -const char *evsel__group_pmu_name(const struct evsel *evsel) -{ - struct evsel *leader =3D evsel__leader(evsel); - struct evsel *pos; - - /* - * Software events may be in a group with other uncore PMU events. Use - * the pmu_name of the first non-software event to avoid breaking the - * software event out of the group. - * - * Aux event leaders, like intel_pt, expect a group with events from - * other PMUs, so substitute the AUX event's PMU in this case. - */ - if (evsel->core.attr.type =3D=3D PERF_TYPE_SOFTWARE || evsel__is_aux_even= t(leader)) { - /* Starting with the leader, find the first event with a named PMU. */ - for_each_group_evsel(pos, leader) { - if (pos->pmu_name) - return pos->pmu_name; - } - } - - return evsel->pmu_name ?: "cpu"; -} - const char *evsel__metric_id(const struct evsel *evsel) { if (evsel->metric_id) @@ -1491,6 +1473,7 @@ void evsel__exit(struct evsel *evsel) zfree(&evsel->group_name); zfree(&evsel->name); zfree(&evsel->pmu_name); + zfree(&evsel->group_pmu_name); zfree(&evsel->unit); zfree(&evsel->metric_id); evsel__zero_per_pkg(evsel); diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h index 429b172cc94d..6d9536ecbc7b 100644 --- a/tools/perf/util/evsel.h +++ b/tools/perf/util/evsel.h @@ -72,6 +72,7 @@ struct evsel { char *name; char *group_name; const char *pmu_name; + const char *group_pmu_name; #ifdef HAVE_LIBTRACEEVENT struct tep_event *tp_format; #endif @@ -287,7 +288,6 @@ int arch_evsel__hw_name(struct evsel *evsel, char *bf, = size_t size); int __evsel__hw_cache_type_op_res_name(u8 type, u8 op, u8 result, char *bf= , size_t size); const char *evsel__name(struct evsel *evsel); bool evsel__name_is(struct evsel *evsel, const char *name); -const char *evsel__group_pmu_name(const struct evsel *evsel); const char *evsel__metric_id(const struct evsel *evsel); =20 static inline bool evsel__is_tool(const struct evsel *evsel) diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index 47ee628a65bb..ac67bb667cd9 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c @@ -1983,6 +1983,42 @@ int parse_events_terms(struct list_head *terms, cons= t char *str) return ret; } =20 +static int evsel__compute_group_pmu_name(struct evsel *evsel, + const struct list_head *head) +{ + struct evsel *leader =3D evsel__leader(evsel); + struct evsel *pos; + const char *group_pmu_name =3D evsel->pmu_name ?: "cpu"; + + /* + * Software events may be in a group with other uncore PMU events. Use + * the pmu_name of the first non-software event to avoid breaking the + * software event out of the group. + * + * Aux event leaders, like intel_pt, expect a group with events from + * other PMUs, so substitute the AUX event's PMU in this case. + */ + if (evsel->core.attr.type =3D=3D PERF_TYPE_SOFTWARE || evsel__is_aux_even= t(leader)) { + /* + * Starting with the leader, find the first event with a named + * PMU. for_each_group_(member|evsel) isn't used as the list + * isn't yet sorted putting evsel's in the same group together. + */ + if (leader->pmu_name) { + group_pmu_name =3D leader->pmu_name; + } else if (leader->core.nr_members > 1) { + list_for_each_entry(pos, head, core.node) { + if (evsel__leader(pos) =3D=3D leader && pos->pmu_name) { + group_pmu_name =3D pos->pmu_name; + break; + } + } + } + } + evsel->group_pmu_name =3D strdup(group_pmu_name); + return evsel->group_pmu_name ? 0 : -ENOMEM; +} + __weak int arch_evlist__cmp(const struct evsel *lhs, const struct evsel *r= hs) { /* Order by insertion index. */ @@ -2002,7 +2038,11 @@ static int evlist__cmp(void *state, const struct lis= t_head *l, const struct list =20 /* * First sort by grouping/leader. Read the leader idx only if the evsel - * is part of a group, as -1 indicates no group. + * is part of a group, by default ungrouped events will be sorted + * relative to grouped events based on where the first ungrouped event + * occurs. If both events don't have a group we want to fall-through to + * the arch specific sorting, that can reorder and fix things like + * Intel's topdown events. */ if (lhs_core->leader !=3D lhs_core || lhs_core->nr_members > 1) { lhs_has_group =3D true; @@ -2018,8 +2058,8 @@ static int evlist__cmp(void *state, const struct list= _head *l, const struct list =20 /* Group by PMU if there is a group. Groups can't span PMUs. */ if (lhs_has_group && rhs_has_group) { - lhs_pmu_name =3D evsel__group_pmu_name(lhs); - rhs_pmu_name =3D evsel__group_pmu_name(rhs); + lhs_pmu_name =3D lhs->group_pmu_name; + rhs_pmu_name =3D rhs->group_pmu_name; ret =3D strcmp(lhs_pmu_name, rhs_pmu_name); if (ret) return ret; @@ -2029,13 +2069,14 @@ static int evlist__cmp(void *state, const struct li= st_head *l, const struct list return arch_evlist__cmp(lhs, rhs); } =20 -static bool parse_events__sort_events_and_fix_groups(struct list_head *lis= t) +static int parse_events__sort_events_and_fix_groups(struct list_head *list) { int idx =3D 0, unsorted_idx =3D -1; struct evsel *pos, *cur_leader =3D NULL; struct perf_evsel *cur_leaders_grp =3D NULL; bool idx_changed =3D false; int orig_num_leaders =3D 0, num_leaders =3D 0; + int ret; =20 /* * Compute index to insert ungrouped events at. Place them where the @@ -2044,6 +2085,10 @@ static bool parse_events__sort_events_and_fix_groups= (struct list_head *list) list_for_each_entry(pos, list, core.node) { const struct evsel *pos_leader =3D evsel__leader(pos); =20 + ret =3D evsel__compute_group_pmu_name(pos, list); + if (ret) + return ret; + if (pos =3D=3D pos_leader) orig_num_leaders++; =20 @@ -2068,7 +2113,7 @@ static bool parse_events__sort_events_and_fix_groups(= struct list_head *list) idx =3D 0; list_for_each_entry(pos, list, core.node) { const struct evsel *pos_leader =3D evsel__leader(pos); - const char *pos_pmu_name =3D evsel__group_pmu_name(pos); + const char *pos_pmu_name =3D pos->group_pmu_name; const char *cur_leader_pmu_name, *pos_leader_pmu_name; bool force_grouped =3D arch_evsel__must_be_in_group(pos); =20 @@ -2085,7 +2130,7 @@ static bool parse_events__sort_events_and_fix_groups(= struct list_head *list) if (!cur_leader) cur_leader =3D pos; =20 - cur_leader_pmu_name =3D evsel__group_pmu_name(cur_leader); + cur_leader_pmu_name =3D cur_leader->group_pmu_name; if ((cur_leaders_grp !=3D pos->core.leader && !force_grouped) || strcmp(cur_leader_pmu_name, pos_pmu_name)) { /* Event is for a different group/PMU than last. */ @@ -2097,7 +2142,7 @@ static bool parse_events__sort_events_and_fix_groups(= struct list_head *list) */ cur_leaders_grp =3D pos->core.leader; } - pos_leader_pmu_name =3D evsel__group_pmu_name(pos_leader); + pos_leader_pmu_name =3D pos_leader->group_pmu_name; if (strcmp(pos_leader_pmu_name, pos_pmu_name) || force_grouped) { /* * Event's PMU differs from its leader's. Groups can't @@ -2114,7 +2159,7 @@ static bool parse_events__sort_events_and_fix_groups(= struct list_head *list) num_leaders++; pos_leader->core.nr_members++; } - return idx_changed || num_leaders !=3D orig_num_leaders; + return (idx_changed || num_leaders !=3D orig_num_leaders) ? 1 : 0; } =20 int __parse_events(struct evlist *evlist, const char *str, const char *pmu= _filter, @@ -2131,7 +2176,7 @@ int __parse_events(struct evlist *evlist, const char = *str, const char *pmu_filte .pmu_filter =3D pmu_filter, .match_legacy_cache_terms =3D true, }; - int ret; + int ret, ret2; =20 ret =3D parse_events__scanner(str, &parse_state); =20 @@ -2140,8 +2185,11 @@ int __parse_events(struct evlist *evlist, const char= *str, const char *pmu_filte return -1; } =20 - if (parse_events__sort_events_and_fix_groups(&parse_state.list) && - warn_if_reordered && !parse_state.wild_card_pmus) + ret2 =3D parse_events__sort_events_and_fix_groups(&parse_state.list); + if (ret2 < 0) + return ret; + + if (ret2 && warn_if_reordered && !parse_state.wild_card_pmus) pr_warning("WARNING: events were regrouped to match PMUs\n"); =20 /* --=20 2.41.0.rc0.172.g3f132b7071-goog From nobody Sun Feb 8 07:07:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82AF0C77B73 for ; Fri, 26 May 2023 19:45:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237257AbjEZTpH (ORCPT ); Fri, 26 May 2023 15:45:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243271AbjEZTow (ORCPT ); Fri, 26 May 2023 15:44:52 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D65FB6 for ; Fri, 26 May 2023 12:44:51 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-bacfa4eefebso2442171276.0 for ; Fri, 26 May 2023 12:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685130290; x=1687722290; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=xjbMXf/jBCxB/sH0FkQPUm1SvrJy5PH1+LA+XDb0Zps=; b=CSctNJp4S2q0DHrryM39VvBZdpM8b8CWJpmP/Q8o9UqglncEroGPepL0FsNvI60yMt B6Q4rqPzGsNOOGFkhy7F/HIDdyTq37p6I+BanaCyLBpXsrEpSal/BBzV35RTPVOpKgyh cFfFLGntgqWb/3V6Q/+Y0ktWmj/SzpUY2a32i1ViTx5PWJrC62fi76ZeO94yGOgVDx24 ULDEk4zzHWt+wEgQC6s514iQ3blhMm4ao4OhHOQDcBGYgcMSpDSu43sMHA/kXnpCVbEM 7Kfxd+HNnuObRfdIWMi3VDfD6izgY79eMmOeBiVCCB0NqIpMMQHAlOGQZXqmNqJkZEfj UCtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685130290; x=1687722290; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xjbMXf/jBCxB/sH0FkQPUm1SvrJy5PH1+LA+XDb0Zps=; b=D+rWVXMx2NrU7QE1ZBGNrrQB5XR9Sj2xKtapq+JLmSIG7ziagJwhKvgpCiflcrfw5V ZSPB2wnKh7G1yTt/vMyh/Q9V3u4i8NuHSX6MBmXpfqaCoiRkC7PzbgAlehh0rjRitIq0 O8gpGt1d1cxR6zITcT5Z+ZzwH8SsR1HHtyytLsZD0yguHYClVbHWm2uV4vNNqCnlTiom obOg4sU+zUbztHo9P3PoXZd8BY83LxCyfd+Py3cXPu1p79YOt0qvQsoeGfL0M3TjPrIR KGk0o2WoLm70YduKYSi0gbLddjEkLghRSRA81O0eMCMolK0lcpjsx4r/4EcCNcKm4YZ+ liUg== X-Gm-Message-State: AC+VfDydkv4lwclJojtJqfTaolxlmkQ4uEI/R2WXDOSSeeBxvZPTzcyj b2Uj+WwZ8uEbF4escwMIzStdzLeZYdMw X-Google-Smtp-Source: ACHHUZ4pHyEoD9K2o0Xh8qppwGD7sUhniJqD+UOaHDb0zLqYmdzSraJe1E6XyX8y6Y9/+6eIJkuIvsZV7OGM X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:3b4e:312c:644:a642]) (user=irogers job=sendgmr) by 2002:a25:4296:0:b0:ba8:3e1a:3fd6 with SMTP id p144-20020a254296000000b00ba83e1a3fd6mr1107185yba.3.1685130290583; Fri, 26 May 2023 12:44:50 -0700 (PDT) Date: Fri, 26 May 2023 12:44:42 -0700 In-Reply-To: <20230526194442.2355872-1-irogers@google.com> Message-Id: <20230526194442.2355872-3-irogers@google.com> Mime-Version: 1.0 References: <20230526194442.2355872-1-irogers@google.com> X-Mailer: git-send-email 2.41.0.rc0.172.g3f132b7071-goog Subject: [PATCH v3 2/2] perf evsel: for_each_group fixes From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Kan Liang , Sandipan Das , James Clark , Dmitrii Dolgov <9erthalion6@gmail.com>, Changbin Du , Rob Herring , Xing Zhengjun , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Address/memory sanitizer was reporting issues in evsel__group_pmu_name because the for_each_group_evsel loop didn't terminate when the head was reached, the head would then be cast and accessed as an evsel leading to invalid memory accesses. Fix for_each_group_member and for_each_group_evsel to terminate at the list head. Note, evsel__group_pmu_name no longer iterates the group, but the problem is present regardless. Fixes: 717e263fc354 ("perf report: Show group description when event group = is enabled") Signed-off-by: Ian Rogers --- tools/perf/util/evsel.h | 24 ++++++++++++++++-------- tools/perf/util/evsel_fprintf.c | 1 + 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h index 6d9536ecbc7b..5e8371613565 100644 --- a/tools/perf/util/evsel.h +++ b/tools/perf/util/evsel.h @@ -459,16 +459,24 @@ static inline int evsel__group_idx(struct evsel *evse= l) } =20 /* Iterates group WITHOUT the leader. */ -#define for_each_group_member(_evsel, _leader) \ -for ((_evsel) =3D list_entry((_leader)->core.node.next, struct evsel, core= .node); \ - (_evsel) && (_evsel)->core.leader =3D=3D (&_leader->core); \ - (_evsel) =3D list_entry((_evsel)->core.node.next, struct evsel, core.= node)) +#define for_each_group_member_head(_evsel, _leader, _head) \ +for ((_evsel) =3D list_entry((_leader)->core.node.next, struct evsel, core= .node); \ + (_evsel) && &(_evsel)->core.node !=3D (_head) && \ + (_evsel)->core.leader =3D=3D &(_leader)->core; \ + (_evsel) =3D list_entry((_evsel)->core.node.next, struct evsel, core.node= )) + +#define for_each_group_member(_evsel, _leader) \ + for_each_group_member_head(_evsel, _leader, &(_leader)->evlist->core.entr= ies) =20 /* Iterates group WITH the leader. */ -#define for_each_group_evsel(_evsel, _leader) \ -for ((_evsel) =3D _leader; \ - (_evsel) && (_evsel)->core.leader =3D=3D (&_leader->core); \ - (_evsel) =3D list_entry((_evsel)->core.node.next, struct evsel, core.= node)) +#define for_each_group_evsel_head(_evsel, _leader, _head) \ +for ((_evsel) =3D _leader; \ + (_evsel) && &(_evsel)->core.node !=3D (_head) && \ + (_evsel)->core.leader =3D=3D &(_leader)->core; \ + (_evsel) =3D list_entry((_evsel)->core.node.next, struct evsel, core.node= )) + +#define for_each_group_evsel(_evsel, _leader) \ + for_each_group_evsel_head(_evsel, _leader, &(_leader)->evlist->core.entri= es) =20 static inline bool evsel__has_branch_callstack(const struct evsel *evsel) { diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprint= f.c index 79e42d66f55b..a1655fd7ed9b 100644 --- a/tools/perf/util/evsel_fprintf.c +++ b/tools/perf/util/evsel_fprintf.c @@ -2,6 +2,7 @@ #include #include #include +#include "util/evlist.h" #include "evsel.h" #include "util/evsel_fprintf.h" #include "util/event.h" --=20 2.41.0.rc0.172.g3f132b7071-goog