[PATCH 1/2] mfd: pm8008: fix module autoloading

Johan Hovold posted 2 patches 10 months, 3 weeks ago
[PATCH 1/2] mfd: pm8008: fix module autoloading
Posted by Johan Hovold 10 months, 3 weeks ago
Add the missing module device table alias to that the driver can be
autoloaded when built as a module.

Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
Cc: stable@vger.kernel.org      # 5.14
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/mfd/qcom-pm8008.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
index 837246aab4ac..29ec3901564b 100644
--- a/drivers/mfd/qcom-pm8008.c
+++ b/drivers/mfd/qcom-pm8008.c
@@ -199,6 +199,7 @@ static const struct of_device_id pm8008_match[] = {
 	{ .compatible = "qcom,pm8008", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, pm8008_match);
 
 static struct i2c_driver pm8008_mfd_driver = {
 	.driver = {
-- 
2.39.3
Re: [PATCH 1/2] mfd: pm8008: fix module autoloading
Posted by Lee Jones 10 months, 1 week ago
On Fri, 26 May 2023, Johan Hovold wrote:

> Add the missing module device table alias to that the driver can be
> autoloaded when built as a module.
> 
> Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> Cc: stable@vger.kernel.org      # 5.14
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>  drivers/mfd/qcom-pm8008.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

-- 
Lee Jones [李琼斯]
Re: [PATCH 1/2] mfd: pm8008: fix module autoloading
Posted by Johan Hovold 10 months, 1 week ago
On Thu, Jun 08, 2023 at 04:45:03PM +0100, Lee Jones wrote:
> On Fri, 26 May 2023, Johan Hovold wrote:
> 
> > Add the missing module device table alias to that the driver can be
> > autoloaded when built as a module.
> > 
> > Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> > Cc: stable@vger.kernel.org      # 5.14
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---
> >  drivers/mfd/qcom-pm8008.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Applied, thanks

Thanks, Lee. Did you forget to push these out? I was gonna see if you
merged them for 6.4 or 6.5, but I can't seem to find them in your mfd
repo.

Johan
Re: [PATCH 1/2] mfd: pm8008: fix module autoloading
Posted by Lee Jones 10 months, 1 week ago
On Fri, 09 Jun 2023, Johan Hovold wrote:

> On Thu, Jun 08, 2023 at 04:45:03PM +0100, Lee Jones wrote:
> > On Fri, 26 May 2023, Johan Hovold wrote:
> > 
> > > Add the missing module device table alias to that the driver can be
> > > autoloaded when built as a module.
> > > 
> > > Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> > > Cc: stable@vger.kernel.org      # 5.14
> > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > > ---
> > >  drivers/mfd/qcom-pm8008.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > 
> > Applied, thanks
> 
> Thanks, Lee. Did you forget to push these out? I was gonna see if you
> merged them for 6.4 or 6.5, but I can't seem to find them in your mfd
> repo.

I don't tend to push daily.  I can push them now if you like.

These were added for v6.5.

-- 
Lee Jones [李琼斯]
Re: [PATCH 1/2] mfd: pm8008: fix module autoloading
Posted by Johan Hovold 10 months, 1 week ago
On Fri, Jun 09, 2023 at 07:38:04AM +0100, Lee Jones wrote:
> On Fri, 09 Jun 2023, Johan Hovold wrote:

> > Thanks, Lee. Did you forget to push these out? I was gonna see if you
> > merged them for 6.4 or 6.5, but I can't seem to find them in your mfd
> > repo.
> 
> I don't tend to push daily.  I can push them now if you like.
> 
> These were added for v6.5.

Perfect, thanks!

Johan
Re: [PATCH 1/2] mfd: pm8008: fix module autoloading
Posted by Konrad Dybcio 10 months, 3 weeks ago

On 26.05.2023 11:16, Johan Hovold wrote:
> Add the missing module device table alias to that the driver can be
> autoloaded when built as a module.
> 
> Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> Cc: stable@vger.kernel.org      # 5.14
Looks like the commit referenced in Fixes is from 5.13-rc1, perhaps
5.13 would be more fitting here?

Konrad
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>  drivers/mfd/qcom-pm8008.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
> index 837246aab4ac..29ec3901564b 100644
> --- a/drivers/mfd/qcom-pm8008.c
> +++ b/drivers/mfd/qcom-pm8008.c
> @@ -199,6 +199,7 @@ static const struct of_device_id pm8008_match[] = {
>  	{ .compatible = "qcom,pm8008", },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, pm8008_match);
>  
>  static struct i2c_driver pm8008_mfd_driver = {
>  	.driver = {
Re: [PATCH 1/2] mfd: pm8008: fix module autoloading
Posted by Johan Hovold 10 months, 3 weeks ago
On Fri, May 26, 2023 at 11:22:27AM +0200, Konrad Dybcio wrote:
> On 26.05.2023 11:16, Johan Hovold wrote:
> > Add the missing module device table alias to that the driver can be
> > autoloaded when built as a module.
> > 
> > Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> > Cc: stable@vger.kernel.org      # 5.14

> Looks like the commit referenced in Fixes is from 5.13-rc1, perhaps
> 5.13 would be more fitting here?

No, I just double checked. This driver was not present 5.13.

Johan
Re: [PATCH 1/2] mfd: pm8008: fix module autoloading
Posted by Konrad Dybcio 10 months, 3 weeks ago

On 26.05.2023 11:25, Johan Hovold wrote:
> On Fri, May 26, 2023 at 11:22:27AM +0200, Konrad Dybcio wrote:
>> On 26.05.2023 11:16, Johan Hovold wrote:
>>> Add the missing module device table alias to that the driver can be
>>> autoloaded when built as a module.
>>>
>>> Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
>>> Cc: stable@vger.kernel.org      # 5.14
> 
>> Looks like the commit referenced in Fixes is from 5.13-rc1, perhaps
>> 5.13 would be more fitting here?
> 
> No, I just double checked. This driver was not present 5.13.
Odd, I see the same thing.

Anyway

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> 
> Johan