From nobody Sun Feb 8 02:56:30 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64AFAC7EE2D for ; Thu, 25 May 2023 16:09:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229527AbjEYQJG (ORCPT ); Thu, 25 May 2023 12:09:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231451AbjEYQJD (ORCPT ); Thu, 25 May 2023 12:09:03 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30441E59 for ; Thu, 25 May 2023 09:08:33 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-5144a9c11c7so1569631a12.2 for ; Thu, 25 May 2023 09:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685030901; x=1687622901; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=USQa14bxm9/gfk0iTFn1mMIzz0dadrwCcKOKR8DDgzQ=; b=nwOl8DG2BBTjeCysT0zw1xSgZWdheR/RWsAuvcg1DdEjdV7B2fYOPNPm8x0tlNmE/j hnfZGo7TBiqISYdVhCnYremv5C6rfiQdCVrkrWDJ2SCv4k8p4lZf6cDSNxRpC/0e6ydM oJFPM1oZ1Oz6UN5lERgMzfDltBLvgFnDYXyHDHepKLi5qCbSQGiWYcWvVapAbkVDVZM7 kkKMbwzQ+y9m3LXYiu/H5cTpU7Vt+mJm5uk1ow6Rb6h889EPpJZq8nRl+c0T4ejNoyt0 VBprecfmG7TsMhgxy8WhSbUVjg2yQx2bkgVgOv0BPZ8Bb8CMQraD72x7kL5+9TFscMhg 15Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685030901; x=1687622901; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=USQa14bxm9/gfk0iTFn1mMIzz0dadrwCcKOKR8DDgzQ=; b=BhGHuJefVLJboJ8rgmRG68LRFy/R5nk4pCDUAOWAzIL89bGtV+gUlAwKWuCJCS+nK9 QQPP857QJBUYrM/ZU8xQ0oQCdw+a4CMZtVOdr7Bi7lgmRJmsSiL2TQ1iSUIpoRcLeHU/ elZgQu/2o1KgWYg0udLdGJJn4eZA5sV6MSvOXXWSwUpzy1vIiLbBoxEYm4p8ZS0wNU+g bw0AeEIA4+OVaix2cO+/feEAUqS+EgIOUfjcr6qRNv8Vn/6JQYFOqkZWMQwK84umdGWx rG3uTzh7fJLX11+0OHwxO0TIMgMf1DYaGDdr4iUuruqF79uO7xOz04wKQ9MEOjUu8aUn Bevw== X-Gm-Message-State: AC+VfDy4iIYvCkEY34F0XIVFuS0Z8v5n4FqSxvsmAyjKAa/eMBfwDgOb kiwHpbp4+jRVP0R0eOQyNSE= X-Google-Smtp-Source: ACHHUZ6hqDma7sqnvdnFTlwYvxCGOVKRH/UBaY12+lVWEC1CRJshhvo5HN45DYQ5qq2WPMdx85JqBg== X-Received: by 2002:a17:902:e5c3:b0:1a6:8ed5:428a with SMTP id u3-20020a170902e5c300b001a68ed5428amr2528473plf.22.1685030900944; Thu, 25 May 2023 09:08:20 -0700 (PDT) Received: from ubuntu777.domain.name (36-228-81-153.dynamic-ip.hinet.net. [36.228.81.153]) by smtp.gmail.com with ESMTPSA id s3-20020a170902a50300b001ab12ccc2a7sm1611450plq.98.2023.05.25.09.08.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 May 2023 09:08:20 -0700 (PDT) From: Min-Hua Chen To: Vineet Gupta Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, Min-Hua Chen Subject: [RESEND PATCH 1/2] ARC: fix incorrect THREAD_SHIFT definition Date: Fri, 26 May 2023 00:08:11 +0800 Message-Id: <20230525160813.39408-2-minhuadotchen@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230525160813.39408-1-minhuadotchen@gmail.com> References: <20230525160813.39408-1-minhuadotchen@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Current definition of THREAD_SHIFT is (PAGE_SHIFT << THREAD_SIZE_ORDER) It should be (PAGE_SHIFT + THREAD_SIZE_ORDER) because the following equation should hold: Say PAGE_SHIFT =3D=3D 13 (as the default value in ARC) THREAD_SIZE_ORDER =3D=3D 1 (as CONFIG_16KSTACKS=3Dy) THREAD_SIZE =3D=3D (1 << THREAD_SHIFT) =3D=3D (1 << (PAGE_SHIFT + THREAD_SIZE_ORDER)) =3D=3D (1 << 14) =3D=3D 16KB Signed-off-by: Min-Hua Chen --- arch/arc/include/asm/thread_info.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arc/include/asm/thread_info.h b/arch/arc/include/asm/thre= ad_info.h index 6ba7fe417095..9f9dd021501c 100644 --- a/arch/arc/include/asm/thread_info.h +++ b/arch/arc/include/asm/thread_info.h @@ -22,7 +22,7 @@ #endif =20 #define THREAD_SIZE (PAGE_SIZE << THREAD_SIZE_ORDER) -#define THREAD_SHIFT (PAGE_SHIFT << THREAD_SIZE_ORDER) +#define THREAD_SHIFT (PAGE_SHIFT + THREAD_SIZE_ORDER) =20 #ifndef __ASSEMBLY__ =20 --=20 2.34.1 From nobody Sun Feb 8 02:56:30 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E14BC7EE29 for ; Thu, 25 May 2023 16:09:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232263AbjEYQJO (ORCPT ); Thu, 25 May 2023 12:09:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231451AbjEYQJM (ORCPT ); Thu, 25 May 2023 12:09:12 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FAC51B6 for ; Thu, 25 May 2023 09:08:42 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-51452556acdso1234326a12.2 for ; Thu, 25 May 2023 09:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685030904; x=1687622904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f10B5ZIa9ITmPIMb+u+qs6/5+yRXx2vTTGWyb6FapHI=; b=j4k12bcqw1DZL7kzBgVq5yAW/945ZHX3GZezjaJBksDYmnZ+djZe6tAJRtfc2rCNd4 LA2FPd9+VYvLe1kuYuZ2tCKzBtVSI8a/OfcOQ4S5Yt7+urECSd06+8xHd9WCUyScw392 JafNrWXyz4HToplkXg+A475yLr5ytuiAkqpf7zo4dJwWY43Mdvl29PRtiKnTyYDnPP6r tW0xlmG/yK1qquV0+z/YJTP65mIMMrHrdbkY3+Jmu3Zdx5TbFXGTraCWAOESfPciF5KH MXAzmp7+eGuqZ9YKr4gOjDMF8iVCJOo2upNhlFxxFrlDFjVzjEO9CUU1/MO89ICsJQho tqog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685030904; x=1687622904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f10B5ZIa9ITmPIMb+u+qs6/5+yRXx2vTTGWyb6FapHI=; b=Ja3Uw6t5uH/3j77dHsJpAkUxSBHG6doCWC+C04GtLb9VhpYhUf467/2F0xySkfxPwC D+cuFiB+gkF5F0TWUrx4kdJh7gPSwQ0u4gE7sOuwC73z/FO4Mr82b9lmDoWQ6n8cAPDm KjKCoLJVnAnH2M+Zy7/ztTST743I0ErcfVyFLuMEC2Xd5tV/wpAwIPUkc42NrXcMS6H2 W5l9zOUMngRVGm9+//SApFMoSKNXS26+FOQJslurz9PbdKhupRaWbWEz37hCC9UWo25A OMT/FO43EN0e28vgBN0fxkQop0gUO/Y47MPdiikuQgXsAHVuifpyWnPJ+mWyzt8MDkDw MAxg== X-Gm-Message-State: AC+VfDwOfE2axGxxpMyedvyLVQZfAdCLQxBKyjYCD+OdAmQHTsdJGmRx Fu+DEC//AOAmbQ/WicVSLxU= X-Google-Smtp-Source: ACHHUZ7BKJzUagaWoCZc5fUsRZnu5bnzIJTF9ZG7dnZ12jM5KiLtEtnsQDi59PS0Evp48sZLFX8c3A== X-Received: by 2002:a17:903:430f:b0:1ac:874d:f55e with SMTP id jz15-20020a170903430f00b001ac874df55emr2063949plb.22.1685030904226; Thu, 25 May 2023 09:08:24 -0700 (PDT) Received: from ubuntu777.domain.name (36-228-81-153.dynamic-ip.hinet.net. [36.228.81.153]) by smtp.gmail.com with ESMTPSA id s3-20020a170902a50300b001ab12ccc2a7sm1611450plq.98.2023.05.25.09.08.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 May 2023 09:08:23 -0700 (PDT) From: Min-Hua Chen To: Vineet Gupta Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, Min-Hua Chen Subject: [RESEND PATCH 2/2] ARC: rename 16KSTACKS to DEBUG_STACKS Date: Fri, 26 May 2023 00:08:12 +0800 Message-Id: <20230525160813.39408-3-minhuadotchen@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230525160813.39408-1-minhuadotchen@gmail.com> References: <20230525160813.39408-1-minhuadotchen@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename 16KSTACKS to DEBUG_STACKS. arch/arc/Kconfig.debug says that the default stack size is 8KB and it will become 16KB stack if 16KSTACKS is set. However, the stack size is based on PAGE_SIZE, and it is configurable by CONFIG_ARC_PAGE_SIZE_16K or CONFIG_ARC_PAGE_SIZE_4K. When CONFIG_16KSTACKS=3Dy: PAGE_SHIFT=3D=3D12 =3D> THREAD_SIZE =3D=3D (1 << (12 + 1)) =3D 8KB PAGE_SHIFT=3D=3D13 =3D> THREAD_SIZE =3D=3D (1 << (13 + 1)) =3D 16KB PAGE_SHIFT=3D=3D14 =3D> THREAD_SIZE =3D=3D (1 << (14 + 1)) =3D 32KB We get correct 16KB stack only when PAGE_SHIFT is 13. See arch/arc/include/uapi/asm/page.h: /* PAGE_SHIFT determines the page size */ \#if defined(CONFIG_ARC_PAGE_SIZE_16K) \#define PAGE_SHIFT 14 \#elif defined(CONFIG_ARC_PAGE_SIZE_4K) \#define PAGE_SHIFT 12 \#else \#define PAGE_SHIFT 13 \#endif See arch/arc/include/asm/thread_info.h: \#ifdef CONFIG_DEBUG_STACKS \#define THREAD_SIZE_ORDER 1 \#else \#define THREAD_SIZE_ORDER 0 \#endif \#define THREAD_SIZE (PAGE_SIZE << THREAD_SIZE_ORDER) \#define THREAD_SHIFT (PAGE_SHIFT + THREAD_SIZE_ORDER) To make CONFIG_16KSTACKS less confusing, rename it to DEBUG_STACKS (as it is defined in Kconfig.debug) and modify the Kconfig description. No functional changes intended. Signed-off-by: Min-Hua Chen --- arch/arc/Kconfig.debug | 7 ++++--- arch/arc/include/asm/thread_info.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arc/Kconfig.debug b/arch/arc/Kconfig.debug index 45add86decd5..9a1e140605c4 100644 --- a/arch/arc/Kconfig.debug +++ b/arch/arc/Kconfig.debug @@ -1,10 +1,11 @@ # SPDX-License-Identifier: GPL-2.0 =20 -config 16KSTACKS - bool "Use 16Kb for kernel stacks instead of 8Kb" +config DEBUG_STACKS + bool "Use double sized kernel stacks" help - If you say Y here the kernel will use a 16Kb stacksize for the + If you say Y here the kernel will use a double sized stack for the kernel stack attached to each process/thread. The default is 8K. + (depends on CONFIG_ARC_PAGE_SIZE_16K or CONFIG_ARC_PAGE_SIZE_4K) This increases the resident kernel footprint and will cause less threads to run on the system and also increase the pressure on the VM subsystem for higher order allocations. diff --git a/arch/arc/include/asm/thread_info.h b/arch/arc/include/asm/thre= ad_info.h index 9f9dd021501c..a7358d1225a6 100644 --- a/arch/arc/include/asm/thread_info.h +++ b/arch/arc/include/asm/thread_info.h @@ -15,7 +15,7 @@ =20 #include =20 -#ifdef CONFIG_16KSTACKS +#ifdef CONFIG_DEBUG_STACKS #define THREAD_SIZE_ORDER 1 #else #define THREAD_SIZE_ORDER 0 --=20 2.34.1