From nobody Sun Feb 8 23:35:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D643C77B7A for ; Thu, 25 May 2023 07:13:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239161AbjEYHNJ (ORCPT ); Thu, 25 May 2023 03:13:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238998AbjEYHM0 (ORCPT ); Thu, 25 May 2023 03:12:26 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0C28E4C for ; Thu, 25 May 2023 00:12:17 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-ba83fed51b0so392957276.3 for ; Thu, 25 May 2023 00:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684998736; x=1687590736; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=JINgRbKyqeD/5xjEyB2Z8M27zbkpuoQ93P6f/ale0uI=; b=OP4afWsTIYHlIiVTegNyeLRIqJ2zMqeyRsGXo/7eq4nQ5gebMPUTViLGgtu89xP43w X25NyK2bhxqAHZtrw1issc4tRmXnff5EtFVyw+kq3E99WowlEQlVAV4935YOas6Bl/Bq LhMHBUoNbwpi0bpYt5T9maZQF4yoblT3yyX+IAZdUcmpyyuKxTOzG4miAldimh5JFUIB Hiu2a09aHEQYNjXmmZv0C//qoO+ntkS8zOpyqiIypFAXIpib6mKGDVU/UHRod0EfNM7Q nOsc/DeVMBBGfIoAUK4Fbqu4C3dpZ7W1WSvi/0P4y2uIevkTZhzXlmn9TyFaWIKeHC/j G8xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684998736; x=1687590736; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JINgRbKyqeD/5xjEyB2Z8M27zbkpuoQ93P6f/ale0uI=; b=OTt4vhmOHSyKpyGoFLM2D0FjycajqHp5qBzJSUpZ5UXmCi5j7n+d2ejRTrraLHOhYL w2CZKKmEH9SnYAl5KmvousH5gCkcjQiRXKOpKVApvmDWkbP7wUpSt6tsqG9Di6k5nuMH PGfdUWNR0gWnF19l5kCkQxHv2dkylJCDMMswbd8kt6NR+BpeN7ewiT5vd7MFUMTaE0l2 ChEHutaX29dh90bcegG2DVXsFjcT8ANGHn+jV1uVfSurxhEi0cdxv8RGsCNznCuQghJp Dq2V52j2b3w+xcTG02Ky+KzxXry1CqkxCVnbqnznq3MypcIg9slrFzdSFdctvyRXMt3H NoqA== X-Gm-Message-State: AC+VfDxNjxLxip3/sKjE5Hr1tfpCeFOjoacu3KFCG9ICnnciTevgWgJ6 UvqPTjnAQFwS19fZhznA9Y3OOQBNzOaF X-Google-Smtp-Source: ACHHUZ7sbw6AbhpElOgagS6t6+PV+X3bd3rUnq9Dqsw9hU6xB469HNKeglXDNdx1ojU0xz8YM86WvVJWnJUg X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:7aa7:3d2d:76ae:8e96]) (user=irogers job=sendgmr) by 2002:a25:7456:0:b0:ba7:1499:e202 with SMTP id p83-20020a257456000000b00ba71499e202mr1646377ybc.7.1684998736756; Thu, 25 May 2023 00:12:16 -0700 (PDT) Date: Thu, 25 May 2023 00:11:25 -0700 In-Reply-To: <20230525071133.2066610-1-irogers@google.com> Message-Id: <20230525071133.2066610-9-irogers@google.com> Mime-Version: 1.0 References: <20230525071133.2066610-1-irogers@google.com> X-Mailer: git-send-email 2.40.1.698.g37aff9b760-goog Subject: [PATCH v1 08/16] perf daemon: Dynamically allocate path to perf From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , "Masami Hiramatsu (Google)" , "Steven Rostedt (Google)" , Ross Zwisler , Leo Yan , Tiezhu Yang , Yang Jihong , Andi Kleen , Kan Liang , Ravi Bangoria , Sean Christopherson , K Prateek Nayak , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Avoid a PATH_MAX array in __daemon (the .data section) by dynamically allocating the memory. Signed-off-by: Ian Rogers --- tools/perf/builtin-daemon.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-daemon.c b/tools/perf/builtin-daemon.c index 34cbe3e959aa..adb5751c3ed0 100644 --- a/tools/perf/builtin-daemon.c +++ b/tools/perf/builtin-daemon.c @@ -90,7 +90,7 @@ struct daemon { char *base; struct list_head sessions; FILE *out; - char perf[PATH_MAX]; + char *perf; int signal_fd; time_t start; }; @@ -1490,6 +1490,15 @@ static int __cmd_ping(struct daemon *daemon, struct = option parent_options[], return send_cmd(daemon, &cmd); } =20 +static char *set_perf_exe(void) +{ + char path[PATH_MAX]; + + perf_exe(path, sizeof(path)); + __daemon.perf =3D strdup(path); + return __daemon.perf; +} + int cmd_daemon(int argc, const char **argv) { struct option daemon_options[] =3D { @@ -1503,7 +1512,9 @@ int cmd_daemon(int argc, const char **argv) OPT_END() }; =20 - perf_exe(__daemon.perf, sizeof(__daemon.perf)); + if (!set_perf_exe()) + return -ENOMEM; + __daemon.out =3D stdout; =20 argc =3D parse_options(argc, argv, daemon_options, daemon_usage, --=20 2.40.1.698.g37aff9b760-goog