From nobody Mon Feb 9 06:34:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A475C7EE2E for ; Thu, 25 May 2023 07:13:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239428AbjEYHNt (ORCPT ); Thu, 25 May 2023 03:13:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231126AbjEYHMv (ORCPT ); Thu, 25 May 2023 03:12:51 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 099D310EA for ; Thu, 25 May 2023 00:12:35 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5655d99da53so6064917b3.0 for ; Thu, 25 May 2023 00:12:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684998748; x=1687590748; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=+m2pnwk7ltDlRfODCcS98B4qxXpyD/wmySMIwUeQIa0=; b=3I/660dhM9lZf9IEkWxnK7nkFcSifm+MxTnqZxo1HIHPCMgFuczZTKQKko9pimGaAR KW+h/lWcmmDUB+9Qg7oBkaoKx7ICAG0RlJufytpXp6OVeIbXCyTzUHolDfuCumgGvmdB LIs+TiP23mCsJk1FwJnI7NvdstKE0tOdKgPoDgWX2fj72g3/uk9lYvD+BF0NVW7zAfwh ryxOat6Q2JryQ6iERzMFybbEGHGN5Qsa3RdbftPt6jhgxH2bmxeTSnHUn1MFemcbjrJ9 ya4+m/9d4ZsQ2u2J6Yy911kLOaCi6VzjXq5eQ7ZVVuAiaul5sFY0NqAfbNfBgFUjqpD9 wNXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684998748; x=1687590748; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+m2pnwk7ltDlRfODCcS98B4qxXpyD/wmySMIwUeQIa0=; b=ZjYnQz5LyXICQDY2iqD9+XUccX/L2v+HkDrPeDLi0CuLtgakXTbForcCfKK0o+U8cd rfSrqs4kcu/0FRRi1usnGyBHv34CDcPFDolkxctDVzLOqDCPuY/5LAR+9ZcXRZhDrXAP A4cZ2mPM9rPsKVNOV3L3yH4OHX/t18GICtrP3bzYVVuSqLOsth7HOE2vd6F7Cjk37nfh HTxBK19poTXIbEYMh8HOD5+/HuF7MH3o/JBaGh2W9So5n5HQPIFNMkiYnlOW4iocnRQ5 XcqSN1c90S6AkVJ3v2c1+Ev9RzwOXgVVQLRS3zqJxErpNHaAObheWrXEBpH+/dEsyY+u u1OQ== X-Gm-Message-State: AC+VfDw+x/feXQ6Uv02fYzBNKhaMpx6F2iN4KgJhvU8u4Zn5xcLkWGMx 9IrF1L1URawFv5KfLWl5eDJdf1PDABdi X-Google-Smtp-Source: ACHHUZ56MPxsMx36Wz7nvFDJJuJBcGPxPIUE7ojVvrebDC27lXhEXg5YoRdSUiYt0XDG5gOoxyZPnmchi5ws X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:7aa7:3d2d:76ae:8e96]) (user=irogers job=sendgmr) by 2002:a81:ac07:0:b0:561:8c16:2b66 with SMTP id k7-20020a81ac07000000b005618c162b66mr1514887ywh.4.1684998748115; Thu, 25 May 2023 00:12:28 -0700 (PDT) Date: Thu, 25 May 2023 00:11:30 -0700 In-Reply-To: <20230525071133.2066610-1-irogers@google.com> Message-Id: <20230525071133.2066610-14-irogers@google.com> Mime-Version: 1.0 References: <20230525071133.2066610-1-irogers@google.com> X-Mailer: git-send-email 2.40.1.698.g37aff9b760-goog Subject: [PATCH v1 13/16] perf scripting-engines: Move static to local variable From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , "Masami Hiramatsu (Google)" , "Steven Rostedt (Google)" , Ross Zwisler , Leo Yan , Tiezhu Yang , Yang Jihong , Andi Kleen , Kan Liang , Ravi Bangoria , Sean Christopherson , K Prateek Nayak , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Avoid 16,384 bytes in .bss by stack allocating two bitmaps. Signed-off-by: Ian Rogers --- tools/perf/util/scripting-engines/trace-event-perl.c | 4 ++-- tools/perf/util/scripting-engines/trace-event-python.c | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/scripting-engines/trace-event-perl.c b/tools/p= erf/util/scripting-engines/trace-event-perl.c index 039d0365ad41..65b761d83a1f 100644 --- a/tools/perf/util/scripting-engines/trace-event-perl.c +++ b/tools/perf/util/scripting-engines/trace-event-perl.c @@ -67,8 +67,6 @@ INTERP my_perl; #define TRACE_EVENT_TYPE_MAX \ ((1 << (sizeof(unsigned short) * 8)) - 1) =20 -static DECLARE_BITMAP(events_defined, TRACE_EVENT_TYPE_MAX); - extern struct scripting_context *scripting_context; =20 static char *cur_field_name; @@ -353,7 +351,9 @@ static void perl_process_tracepoint(struct perf_sample = *sample, void *data =3D sample->raw_data; unsigned long long nsecs =3D sample->time; const char *comm =3D thread__comm_str(thread); + DECLARE_BITMAP(events_defined, TRACE_EVENT_TYPE_MAX); =20 + bitmap_zero(events_defined, TRACE_EVENT_TYPE_MAX); dSP; =20 if (evsel->core.attr.type !=3D PERF_TYPE_TRACEPOINT) diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools= /perf/util/scripting-engines/trace-event-python.c index 41d4f9e6a8b7..40964078f92f 100644 --- a/tools/perf/util/scripting-engines/trace-event-python.c +++ b/tools/perf/util/scripting-engines/trace-event-python.c @@ -93,8 +93,6 @@ PyMODINIT_FUNC PyInit_perf_trace_context(void); #define TRACE_EVENT_TYPE_MAX \ ((1 << (sizeof(unsigned short) * 8)) - 1) =20 -static DECLARE_BITMAP(events_defined, TRACE_EVENT_TYPE_MAX); - #define N_COMMON_FIELDS 7 =20 static char *cur_field_name; @@ -934,6 +932,9 @@ static void python_process_tracepoint(struct perf_sampl= e *sample, unsigned long long nsecs =3D sample->time; const char *comm =3D thread__comm_str(al->thread); const char *default_handler_name =3D "trace_unhandled"; + DECLARE_BITMAP(events_defined, TRACE_EVENT_TYPE_MAX); + + bitmap_zero(events_defined, TRACE_EVENT_TYPE_MAX); =20 if (!event) { snprintf(handler_name, sizeof(handler_name), --=20 2.40.1.698.g37aff9b760-goog