From nobody Mon Feb 9 16:33:14 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4228C77B7A for ; Tue, 23 May 2023 06:43:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234047AbjEWGnm (ORCPT ); Tue, 23 May 2023 02:43:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235053AbjEWGn0 (ORCPT ); Tue, 23 May 2023 02:43:26 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C544121 for ; Mon, 22 May 2023 23:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=pnZxntDIL58qq5 lLbg927fG2rOg+UQvQEoeeePBGWTw=; b=NlFQrF1SA5fOWp6H1M0fdnK32Rvv6z QOH3i+nXd8KqNcEp9jljz9WCJt8/npG4FWy+E8eTzvOuIonZ6wp4gTFVjzpEQgDu MZtEubob4BtqpMq2Z4JmjBAJCzN0UzxLWuaBF74CRoD5Yvhx/srNMhq75MnVKc0w n0OwL491ECVUY= Received: (qmail 2628252 invoked from network); 23 May 2023 08:43:22 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 23 May 2023 08:43:22 +0200 X-UD-Smtp-Session: l3s3148p1@i0URtFb8/MgujnsI From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Johan Hovold , linux-kernel@vger.kernel.org, Wolfram Sang Subject: [RFC PATCH 3/5] gnss: ubx: 'vcc' can be optional Date: Tue, 23 May 2023 08:43:08 +0200 Message-Id: <20230523064310.3005-4-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230523064310.3005-1-wsa+renesas@sang-engineering.com> References: <20230523064310.3005-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There are devices where 'vcc' is always on. The reset pin is used for silencing the chip. Make the 'vcc' regulator optional. Signed-off-by: Wolfram Sang --- drivers/gnss/ubx.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/gnss/ubx.c b/drivers/gnss/ubx.c index c8d027973b85..d5281bfae9cb 100644 --- a/drivers/gnss/ubx.c +++ b/drivers/gnss/ubx.c @@ -25,9 +25,11 @@ static int ubx_set_active(struct gnss_serial *gserial) struct ubx_data *data =3D gnss_serial_get_drvdata(gserial); int ret; =20 - ret =3D regulator_enable(data->vcc); - if (ret) - return ret; + if (data->vcc) { + ret =3D regulator_enable(data->vcc); + if (ret) + return ret; + } =20 return 0; } @@ -37,9 +39,11 @@ static int ubx_set_standby(struct gnss_serial *gserial) struct ubx_data *data =3D gnss_serial_get_drvdata(gserial); int ret; =20 - ret =3D regulator_disable(data->vcc); - if (ret) - return ret; + if (data->vcc) { + ret =3D regulator_disable(data->vcc); + if (ret) + return ret; + } =20 return 0; } @@ -99,10 +103,13 @@ static int ubx_probe(struct serdev_device *serdev) =20 data =3D gnss_serial_get_drvdata(gserial); =20 - data->vcc =3D devm_regulator_get(&serdev->dev, "vcc"); + data->vcc =3D devm_regulator_get_optional(&serdev->dev, "vcc"); if (IS_ERR(data->vcc)) { ret =3D PTR_ERR(data->vcc); - goto err_free_gserial; + if (ret =3D=3D -ENODEV) + data->vcc =3D NULL; + else + goto err_free_gserial; } =20 ret =3D devm_regulator_get_enable_optional(&serdev->dev, info->v_bckp_nam= e); --=20 2.35.1