From nobody Sun Feb 8 13:53:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C522C7EE2F for ; Tue, 23 May 2023 06:43:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235262AbjEWGn3 (ORCPT ); Tue, 23 May 2023 02:43:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232386AbjEWGnZ (ORCPT ); Tue, 23 May 2023 02:43:25 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E59611F for ; Mon, 22 May 2023 23:43:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=Z3IKHiDESnxgpp XaZi+dnogQqI5j7cdY2RUORWxIqRg=; b=mINKYsG+7CbwIeHubxfu3hxenfyL9T 1F3jEIlLAwCT0yaHAPAhR2KHZ/iJsm+tlA+SYiQIXnCWHhTmTOHpTRt2tikYLH+w HiZOltuJBpER9CL0Bh7GIwXKs7w+YaqLkA/x3fQvUg2pPQhri/gO6WTt1hGjdxfj 9gxjnN1/D2oR0= Received: (qmail 2628194 invoked from network); 23 May 2023 08:43:20 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 23 May 2023 08:43:20 +0200 X-UD-Smtp-Session: l3s3148p1@VbX5s1b86MgujnsI From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Johan Hovold , linux-kernel@vger.kernel.org, Wolfram Sang Subject: [RFC PATCH 1/5] WIP: gnss: merge MTK driver into UBX driver Date: Tue, 23 May 2023 08:43:06 +0200 Message-Id: <20230523064310.3005-2-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230523064310.3005-1-wsa+renesas@sang-engineering.com> References: <20230523064310.3005-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This is a proof-of-concept how easy it is to merge those two drivers as they are extremly similar. The differences can be abstracted away easily. Further work (renaming from 'ubx' to something more generic, removing the MTK driver, ...) is postponed until there is agrement that merging these drivers is actually wanted. I vote for it, though. I have updates to the UBX driver which do make sense for the MTK driver as well. Code saving is also a plus. We can always fork into a specific driver again if we'd ever need that. Signed-off-by: Wolfram Sang --- drivers/gnss/ubx.c | 30 +++++++++++++++++++++++++----- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/drivers/gnss/ubx.c b/drivers/gnss/ubx.c index c951be202ca2..c01e1e875727 100644 --- a/drivers/gnss/ubx.c +++ b/drivers/gnss/ubx.c @@ -63,12 +63,31 @@ static const struct gnss_serial_ops ubx_gserial_ops =3D= { .set_power =3D ubx_set_power, }; =20 +struct ubx_info { + enum gnss_type type; + char *v_bckp_name; +}; + +const struct ubx_info ubx_info_ubx =3D { + .type =3D GNSS_TYPE_UBX, + .v_bckp_name =3D "v-bckp", +}; + +const struct ubx_info ubx_info_mtk =3D { + .type =3D GNSS_TYPE_MTK, + .v_bckp_name =3D "vbackup", +}; + static int ubx_probe(struct serdev_device *serdev) { + const struct ubx_info *info =3D of_device_get_match_data(&serdev->dev); struct gnss_serial *gserial; struct ubx_data *data; int ret; =20 + if (!info) + return -ENOENT; + gserial =3D gnss_serial_allocate(serdev, sizeof(*data)); if (IS_ERR(gserial)) { ret =3D PTR_ERR(gserial); @@ -77,7 +96,7 @@ static int ubx_probe(struct serdev_device *serdev) =20 gserial->ops =3D &ubx_gserial_ops; =20 - gserial->gdev->type =3D GNSS_TYPE_UBX; + gserial->gdev->type =3D info->type; =20 data =3D gnss_serial_get_drvdata(gserial); =20 @@ -87,7 +106,7 @@ static int ubx_probe(struct serdev_device *serdev) goto err_free_gserial; } =20 - data->v_bckp =3D devm_regulator_get_optional(&serdev->dev, "v-bckp"); + data->v_bckp =3D devm_regulator_get_optional(&serdev->dev, info->v_bckp_n= ame); if (IS_ERR(data->v_bckp)) { ret =3D PTR_ERR(data->v_bckp); if (ret =3D=3D -ENODEV) @@ -130,9 +149,10 @@ static void ubx_remove(struct serdev_device *serdev) =20 #ifdef CONFIG_OF static const struct of_device_id ubx_of_match[] =3D { - { .compatible =3D "u-blox,neo-6m" }, - { .compatible =3D "u-blox,neo-8" }, - { .compatible =3D "u-blox,neo-m8" }, + { .compatible =3D "u-blox,neo-6m", .data =3D &ubx_info_ubx, }, + { .compatible =3D "u-blox,neo-8", .data =3D &ubx_info_ubx, }, + { .compatible =3D "u-blox,neo-m8", .data =3D &ubx_info_ubx, }, + { .compatible =3D "globaltop,pa6h", .data =3D &ubx_info_mtk }, {}, }; MODULE_DEVICE_TABLE(of, ubx_of_match); --=20 2.35.1 From nobody Sun Feb 8 13:53:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A14DFC77B7A for ; Tue, 23 May 2023 06:43:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229713AbjEWGni (ORCPT ); Tue, 23 May 2023 02:43:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234919AbjEWGn0 (ORCPT ); Tue, 23 May 2023 02:43:26 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E70C120 for ; Mon, 22 May 2023 23:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=A1klkeCR8HO6g0 u3qn7k1G06CKjvQIO3Yn5CDkz5w74=; b=z8DAdx0uOXztMDc9I5hjMfpyNQeQuT dxhwxSPhNwYdYNwF5GU0blz85nWa7yWBvG9ZPUri+1NeCbjAFwpu99YEpXxlQDxm 2P5q5wmmeoEmrRUa7CZzFaI/b0EOapVtOZ8MwzdnxDeCOTOf2cD19zyLVOMYURry 1f7HDspif94hU= Received: (qmail 2628223 invoked from network); 23 May 2023 08:43:21 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 23 May 2023 08:43:21 +0200 X-UD-Smtp-Session: l3s3148p1@t1MGtFb89sgujnsI From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Johan Hovold , linux-kernel@vger.kernel.org, Wolfram Sang Subject: [RFC PATCH 2/5] gnss: ubx: use new helper to remove open coded regulator handling Date: Tue, 23 May 2023 08:43:07 +0200 Message-Id: <20230523064310.3005-3-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230523064310.3005-1-wsa+renesas@sang-engineering.com> References: <20230523064310.3005-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" v_bckp shall always be enabled as long as the device exists. We now have a regulator helper for that, use it. Signed-off-by: Wolfram Sang --- drivers/gnss/ubx.c | 26 ++++---------------------- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/gnss/ubx.c b/drivers/gnss/ubx.c index c01e1e875727..c8d027973b85 100644 --- a/drivers/gnss/ubx.c +++ b/drivers/gnss/ubx.c @@ -17,7 +17,6 @@ #include "serial.h" =20 struct ubx_data { - struct regulator *v_bckp; struct regulator *vcc; }; =20 @@ -106,30 +105,16 @@ static int ubx_probe(struct serdev_device *serdev) goto err_free_gserial; } =20 - data->v_bckp =3D devm_regulator_get_optional(&serdev->dev, info->v_bckp_n= ame); - if (IS_ERR(data->v_bckp)) { - ret =3D PTR_ERR(data->v_bckp); - if (ret =3D=3D -ENODEV) - data->v_bckp =3D NULL; - else - goto err_free_gserial; - } - - if (data->v_bckp) { - ret =3D regulator_enable(data->v_bckp); - if (ret) - goto err_free_gserial; - } + ret =3D devm_regulator_get_enable_optional(&serdev->dev, info->v_bckp_nam= e); + if (ret < 0 && ret !=3D -ENODEV) + goto err_free_gserial; =20 ret =3D gnss_serial_register(gserial); if (ret) - goto err_disable_v_bckp; + goto err_free_gserial; =20 return 0; =20 -err_disable_v_bckp: - if (data->v_bckp) - regulator_disable(data->v_bckp); err_free_gserial: gnss_serial_free(gserial); =20 @@ -139,11 +124,8 @@ static int ubx_probe(struct serdev_device *serdev) static void ubx_remove(struct serdev_device *serdev) { struct gnss_serial *gserial =3D serdev_device_get_drvdata(serdev); - struct ubx_data *data =3D gnss_serial_get_drvdata(gserial); =20 gnss_serial_deregister(gserial); - if (data->v_bckp) - regulator_disable(data->v_bckp); gnss_serial_free(gserial); } =20 --=20 2.35.1 From nobody Sun Feb 8 13:53:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4228C77B7A for ; Tue, 23 May 2023 06:43:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234047AbjEWGnm (ORCPT ); Tue, 23 May 2023 02:43:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235053AbjEWGn0 (ORCPT ); Tue, 23 May 2023 02:43:26 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C544121 for ; Mon, 22 May 2023 23:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=pnZxntDIL58qq5 lLbg927fG2rOg+UQvQEoeeePBGWTw=; b=NlFQrF1SA5fOWp6H1M0fdnK32Rvv6z QOH3i+nXd8KqNcEp9jljz9WCJt8/npG4FWy+E8eTzvOuIonZ6wp4gTFVjzpEQgDu MZtEubob4BtqpMq2Z4JmjBAJCzN0UzxLWuaBF74CRoD5Yvhx/srNMhq75MnVKc0w n0OwL491ECVUY= Received: (qmail 2628252 invoked from network); 23 May 2023 08:43:22 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 23 May 2023 08:43:22 +0200 X-UD-Smtp-Session: l3s3148p1@i0URtFb8/MgujnsI From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Johan Hovold , linux-kernel@vger.kernel.org, Wolfram Sang Subject: [RFC PATCH 3/5] gnss: ubx: 'vcc' can be optional Date: Tue, 23 May 2023 08:43:08 +0200 Message-Id: <20230523064310.3005-4-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230523064310.3005-1-wsa+renesas@sang-engineering.com> References: <20230523064310.3005-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There are devices where 'vcc' is always on. The reset pin is used for silencing the chip. Make the 'vcc' regulator optional. Signed-off-by: Wolfram Sang --- drivers/gnss/ubx.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/gnss/ubx.c b/drivers/gnss/ubx.c index c8d027973b85..d5281bfae9cb 100644 --- a/drivers/gnss/ubx.c +++ b/drivers/gnss/ubx.c @@ -25,9 +25,11 @@ static int ubx_set_active(struct gnss_serial *gserial) struct ubx_data *data =3D gnss_serial_get_drvdata(gserial); int ret; =20 - ret =3D regulator_enable(data->vcc); - if (ret) - return ret; + if (data->vcc) { + ret =3D regulator_enable(data->vcc); + if (ret) + return ret; + } =20 return 0; } @@ -37,9 +39,11 @@ static int ubx_set_standby(struct gnss_serial *gserial) struct ubx_data *data =3D gnss_serial_get_drvdata(gserial); int ret; =20 - ret =3D regulator_disable(data->vcc); - if (ret) - return ret; + if (data->vcc) { + ret =3D regulator_disable(data->vcc); + if (ret) + return ret; + } =20 return 0; } @@ -99,10 +103,13 @@ static int ubx_probe(struct serdev_device *serdev) =20 data =3D gnss_serial_get_drvdata(gserial); =20 - data->vcc =3D devm_regulator_get(&serdev->dev, "vcc"); + data->vcc =3D devm_regulator_get_optional(&serdev->dev, "vcc"); if (IS_ERR(data->vcc)) { ret =3D PTR_ERR(data->vcc); - goto err_free_gserial; + if (ret =3D=3D -ENODEV) + data->vcc =3D NULL; + else + goto err_free_gserial; } =20 ret =3D devm_regulator_get_enable_optional(&serdev->dev, info->v_bckp_nam= e); --=20 2.35.1 From nobody Sun Feb 8 13:53:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C01AC77B75 for ; Tue, 23 May 2023 06:43:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235119AbjEWGno (ORCPT ); Tue, 23 May 2023 02:43:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235229AbjEWGn0 (ORCPT ); Tue, 23 May 2023 02:43:26 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96AB3130 for ; Mon, 22 May 2023 23:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=q/5GtK2jKYSsTw 9UU1qmAu6KvhIyFjfDhl1+EC7gwzU=; b=EmcpTr1H+9yVuwGiTaYLAplUwiyGAA xAyvjt24R5noeLwW9G3GR3bHJYTgNp1s3rqDMxD6StyDrK08F6AZd9k7/HV86E98 pcgzejYczVFBEC2AGCY+PMoE+HMVHfbyicz8w1/BsiTSrZ+Mc/LKifB+sJnj1QX/ A9RPf2MFGLk9c= Received: (qmail 2628284 invoked from network); 23 May 2023 08:43:22 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 23 May 2023 08:43:22 +0200 X-UD-Smtp-Session: l3s3148p1@J1sZtFb8DMkujnsI From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Johan Hovold , linux-kernel@vger.kernel.org, Wolfram Sang Subject: [RFC PATCH 4/5] gnss: ubx: add support for the reset gpio Date: Tue, 23 May 2023 08:43:09 +0200 Message-Id: <20230523064310.3005-5-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230523064310.3005-1-wsa+renesas@sang-engineering.com> References: <20230523064310.3005-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Tested with a Renesas KingFisher board. The chip correctly disappears from the I2C bus when the 'gnss0' device is not opened. Signed-off-by: Wolfram Sang --- drivers/gnss/ubx.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/gnss/ubx.c b/drivers/gnss/ubx.c index d5281bfae9cb..be393b123d9a 100644 --- a/drivers/gnss/ubx.c +++ b/drivers/gnss/ubx.c @@ -7,6 +7,7 @@ =20 #include #include +#include #include #include #include @@ -18,6 +19,7 @@ =20 struct ubx_data { struct regulator *vcc; + struct gpio_desc *reset_gpio; }; =20 static int ubx_set_active(struct gnss_serial *gserial) @@ -31,6 +33,8 @@ static int ubx_set_active(struct gnss_serial *gserial) return ret; } =20 + gpiod_set_value_cansleep(data->reset_gpio, 0); + return 0; } =20 @@ -45,6 +49,8 @@ static int ubx_set_standby(struct gnss_serial *gserial) return ret; } =20 + gpiod_set_value_cansleep(data->reset_gpio, 1); + return 0; } =20 @@ -116,6 +122,11 @@ static int ubx_probe(struct serdev_device *serdev) if (ret < 0 && ret !=3D -ENODEV) goto err_free_gserial; =20 + /* Start with reset asserted (GPIO must be active low!) */ + data->reset_gpio =3D devm_gpiod_get_optional(&serdev->dev, "reset", GPIOD= _OUT_HIGH); + if (IS_ERR(data->reset_gpio)) + return PTR_ERR(data->reset_gpio); + ret =3D gnss_serial_register(gserial); if (ret) goto err_free_gserial; --=20 2.35.1 From nobody Sun Feb 8 13:53:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B98C77B7A for ; Tue, 23 May 2023 06:43:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235140AbjEWGns (ORCPT ); Tue, 23 May 2023 02:43:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235230AbjEWGn0 (ORCPT ); Tue, 23 May 2023 02:43:26 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03FFA132 for ; Mon, 22 May 2023 23:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=WgJBO0a3r+m+5K tE0tD9/pNvayuhXV3mB7/3fne0NLw=; b=xTa4KBJ4yCn+Et/74u/NAT31G1pAkp C5YckhHdLNdWKUeNfGeFZmnO7r45T/ddjHVuRWKPnIhtRe0AdkwIGjLU+uSKa6aC So1NJAQ40sxMaBTIlXQs5K5KWtEDhMjdwEPK291H3nkbHzV2xbOnANXTzJXYYq1H JHYf6e2Wh0D24= Received: (qmail 2628313 invoked from network); 23 May 2023 08:43:23 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 23 May 2023 08:43:23 +0200 X-UD-Smtp-Session: l3s3148p1@vt8gtFb8DskujnsI From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Johan Hovold , linux-kernel@vger.kernel.org, Wolfram Sang Subject: [RFC PATCH 5/5] arm64: dts: renesas: ulcb-kf: add node for GPS Date: Tue, 23 May 2023 08:43:10 +0200 Message-Id: <20230523064310.3005-6-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230523064310.3005-1-wsa+renesas@sang-engineering.com> References: <20230523064310.3005-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add the node for the GPS receiver and remove flow control for SCIF1 which is not present. The schematics are a bit misleading. The pins are sometimes named SCIF1 but they are for HSCIF1. Signed-off-by: Wolfram Sang --- arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts= /renesas/ulcb-kf.dtsi index efc80960380f..f6705cad78e4 100644 --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi @@ -367,7 +367,7 @@ hscif0_pins: hscif0 { }; =20 scif1_pins: scif1 { - groups =3D "scif1_data_b", "scif1_ctrl"; + groups =3D "scif1_data_b"; function =3D "scif1"; }; =20 @@ -397,9 +397,14 @@ &sound_clk_pins &scif1 { pinctrl-0 =3D <&scif1_pins>; pinctrl-names =3D "default"; - uart-has-rtscts; =20 status =3D "okay"; + + gnss { + compatible =3D "u-blox,neo-m8"; + reset-gpios =3D <&gpio_exp_75 6 GPIO_ACTIVE_LOW>; + current-speed =3D <9600>; + }; }; =20 &sdhi3 { --=20 2.35.1