From nobody Sun Feb 8 09:10:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EC49C77B73 for ; Mon, 22 May 2023 19:51:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235453AbjEVTvA (ORCPT ); Mon, 22 May 2023 15:51:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235391AbjEVTur (ORCPT ); Mon, 22 May 2023 15:50:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A3D1C1 for ; Mon, 22 May 2023 12:50:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 21DA362AF9 for ; Mon, 22 May 2023 19:50:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBC0FC4339B; Mon, 22 May 2023 19:50:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684785044; bh=DHB3E3whHUuZqeuu1DX7URmHv9V7oPFeShT/zXTe+DA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LTCRW8mvE+v+Qu9tfP6jNx3wcAib4AscGGz4Yi3vX0P6du6+fNQkfijJ4gOBxUEKV ZtPnFk9Dp7WlkzMvR/pj6r+WRzYXOpj6du4PA9p1dNnC21g4h5MhBqQF18eMM/otmD a6XRLVpIfXIsOvU3jIU0timMeTB/HBUDeNhW4OxfyQKctWeMgQD52yYGU7L3NGVUgI eZOXGbIiXYSC7Bn/CxAkj1A8L7FM754F756W9iiwwRdDOUpC86ogUwrTw/a83Bb0cS zpBzW+Ge7GZOtaQTDxMdtUE0NsMQ+M5JCA7WQvAlIzIVqJGiPW7JJdtaCRUkFKyKDW 9W56i/cl8X8Iw== From: Arnd Bergmann To: Ingo Molnar , Peter Zijlstra Cc: Arnd Bergmann , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org Subject: [PATCH 4/5] sched: make task_vruntime_update() prototype visible Date: Mon, 22 May 2023 21:50:20 +0200 Message-Id: <20230522195021.3456768-5-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230522195021.3456768-1-arnd@kernel.org> References: <20230522195021.3456768-1-arnd@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann Having the prototype next to the caller but not visible to the callee causes a W=3D1 warning: kernel/sched/fair.c:11985:6: error: no previous prototype for 'task_vruntim= e_update' [-Werror=3Dmissing-prototypes] Move this to a header, as we do for all other function declarations. Signed-off-by: Arnd Bergmann Reviewed-by: Mukesh Ojha --- kernel/sched/core.c | 2 -- kernel/sched/sched.h | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 044bcdf4181a..aae6ff717c55 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -6030,8 +6030,6 @@ static inline struct task_struct *pick_task(struct rq= *rq) BUG(); /* The idle class should always have a runnable task. */ } =20 -extern void task_vruntime_update(struct rq *rq, struct task_struct *p, boo= l in_fi); - static void queue_core_balance(struct rq *rq); =20 static struct task_struct * diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 44b34836bb60..d5ac0af1eede 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -1245,6 +1245,7 @@ static inline raw_spinlock_t *__rq_lockp(struct rq *r= q) =20 bool cfs_prio_less(const struct task_struct *a, const struct task_struct *= b, bool fi); +void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi= ); =20 /* * Helpers to check if the CPU's core cookie matches with the task's cookie --=20 2.39.2