From nobody Sun Feb 8 09:12:14 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2DDFC77B7C for ; Sun, 21 May 2023 22:57:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230498AbjEUW5J (ORCPT ); Sun, 21 May 2023 18:57:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjEUW5G (ORCPT ); Sun, 21 May 2023 18:57:06 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A53B9BE for ; Sun, 21 May 2023 15:57:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=vgnEmcsn/vdxwW+Wgs9nj2+PsYmZXDs2hNecCx7a6R8=; b=WOwGfCog1wQ+I6YMalK9qZfuYC 1R7vptRIeip+Ffkd7pVoZsLhGEaDC8KEdBj9jrBgIMMQ4Mfvhx3xY3BQAZAQ9TEQ3qTL78oGO99T3 AJMfW+nXBiTwd+vgiBouEoqflMeoLA2kujnSp8pWRAZs1NyAua//Ve9Rq4BFcPGEyx42N++S5VDZV WNfozb2VveEu8fQ1wqoRIJXnKfY+sMGEHNHifo7UXwJNjvw03AfArieJ59mLrbtIENr9TfT9yd6kA JyBT1QzKBwr5PmnpvijQ1mpV9LBpv/koIv0Dy7Er0qRwyCbzszbE3dms8ZUUdawUARcGtqTI79LtE gJZgl43g==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1q0rz5-004o6u-0t; Sun, 21 May 2023 22:57:03 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Grant Likely , Mark Brown , Liam Girdwood , Shengjiu Wang , Xiubo Li , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, Jaroslav Kysela , Takashi Iwai Subject: [PATCH v2 RESEND] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM Date: Sun, 21 May 2023 15:57:02 -0700 Message-Id: <20230521225702.1608-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM, so the 2 former symbols should also depend on PPC_BESTCOMM since "select" does not follow any dependency chains. This prevents a kconfig warning and build errors: WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 Depends on [n]: SOUND [=3Dy] && !UML && SND [=3Dm] && SND_SOC [=3Dm] && S= ND_POWERPC_SOC [=3Dm] && PPC_MPC52xx [=3Dy] && PPC_BESTCOMM [=3Dn] Selected by [m]: - SND_MPC52xx_SOC_PCM030 [=3Dm] && SOUND [=3Dy] && !UML && SND [=3Dm] && = SND_SOC [=3Dm] && SND_POWERPC_SOC [=3Dm] && PPC_MPC5200_SIMPLE [=3Dy] - SND_MPC52xx_SOC_EFIKA [=3Dm] && SOUND [=3Dy] && !UML && SND [=3Dm] && S= ND_SOC [=3Dm] && SND_POWERPC_SOC [=3Dm] && PPC_EFIKA [=3Dy] ERROR: modpost: "mpc5200_audio_dma_destroy" [sound/soc/fsl/mpc5200_psc_ac97= .ko] undefined! ERROR: modpost: "mpc5200_audio_dma_create" [sound/soc/fsl/mpc5200_psc_ac97.= ko] undefined! Fixes: 40d9ec14e7e1 ("ASoC: remove BROKEN from Efika and pcm030 fabric driv= ers") Signed-off-by: Randy Dunlap Cc: Grant Likely Cc: Mark Brown Cc: Liam Girdwood Cc: Shengjiu Wang Cc: Xiubo Li Cc: alsa-devel@alsa-project.org Cc: linuxppc-dev@lists.ozlabs.org Cc: Jaroslav Kysela Cc: Takashi Iwai --- v2: use correct email address for Mark Brown. sound/soc/fsl/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97 =20 config SND_MPC52xx_SOC_PCM030 tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712" - depends on PPC_MPC5200_SIMPLE + depends on PPC_MPC5200_SIMPLE && PPC_BESTCOMM select SND_SOC_MPC5200_AC97 select SND_SOC_WM9712 help @@ -252,7 +252,7 @@ config SND_MPC52xx_SOC_PCM030 =20 config SND_MPC52xx_SOC_EFIKA tristate "SoC AC97 Audio support for bbplan Efika and STAC9766" - depends on PPC_EFIKA + depends on PPC_EFIKA && PPC_BESTCOMM select SND_SOC_MPC5200_AC97 select SND_SOC_STAC9766 help