From nobody Mon Sep 15 10:16:04 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 353A7C77B7C for ; Sun, 21 May 2023 22:52:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231527AbjEUWw1 (ORCPT ); Sun, 21 May 2023 18:52:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229999AbjEUWwZ (ORCPT ); Sun, 21 May 2023 18:52:25 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B78ABF for ; Sun, 21 May 2023 15:52:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=5ZqyIo2yPozy9BK+WevZ7XbxMmk32DVp4jnPgiud1w8=; b=RLz/unVIGHd026f+9ZJXZg3KNe 5bQPjNbNIkA0r4a64+ptkEVQDA7YiH0OO+aSfRY0NbXGY/9Osua6ieyFOHq2LhzyDWkVN8i2vUf4H p72YZcujI+E4wDAdxWuQvoXfqJ2cx9oWKJsNOWsqivsSioi1hwwdvsn0MHcmIoT5bNnfVfrxWPomh 6GWYMENY2ITT4mp38zrfu0tsy0vfHL8TKj2BHhQtvtoVfbg2qr8EBhPBvgW/tPzXujJ6J4B3uXtnU OEhVuHIhE4dy2VEPu7EP3z8J8yEU2/7w1fWzXm9ziw4M7jE+cXsn7znj2rXw3BFVxPVpuf2gU50Qa 8jxTsIBw==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1q0ruT-004nQW-1b; Sun, 21 May 2023 22:52:17 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Michael Ellerman , Christophe Leroy , Leo Li , Masahiro Yamada , Nicolas Schier , Qiang Zhao , linuxppc-dev , linux-arm-kernel@lists.infradead.org, Kumar Gala Subject: [PATCH v2 RESEND] soc/fsl/qe: fix usb.c build errors Date: Sun, 21 May 2023 15:52:16 -0700 Message-Id: <20230521225216.21795-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix build errors in soc/fsl/qe/usb.c when QUICC_ENGINE is not set. This happens when PPC_EP88XC is set, which selects CPM1 & CPM. When CPM is set, USB_FSL_QE can be set without QUICC_ENGINE being set. When USB_FSL_QE is set, QE_USB deafults to y, which causes build errors when QUICC_ENGINE is not set. Making QE_USB depend on QUICC_ENGINE prevents QE_USB from defaulting to y. Fixes these build errors: drivers/soc/fsl/qe/usb.o: in function `qe_usb_clock_set': usb.c:(.text+0x1e): undefined reference to `qe_immr' powerpc-linux-ld: usb.c:(.text+0x2a): undefined reference to `qe_immr' powerpc-linux-ld: usb.c:(.text+0xbc): undefined reference to `qe_setbrg' powerpc-linux-ld: usb.c:(.text+0xca): undefined reference to `cmxgcr_lock' powerpc-linux-ld: usb.c:(.text+0xce): undefined reference to `cmxgcr_lock' Fixes: 5e41486c408e ("powerpc/QE: add support for QE USB clocks routing") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Link: https://lore.kernel.org/all/202301101500.pillNv6R-lkp@intel.com/ Suggested-by: Michael Ellerman Cc: Christophe Leroy Cc: Leo Li Cc: Masahiro Yamada Cc: Nicolas Schier Cc: Qiang Zhao Cc: linuxppc-dev Cc: linux-arm-kernel@lists.infradead.org Cc: Kumar Gala Acked-by: Nicolas Schier --- v2: drop Anton Vorontsov ; rebase/resend drivers/soc/fsl/qe/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig --- a/drivers/soc/fsl/qe/Kconfig +++ b/drivers/soc/fsl/qe/Kconfig @@ -62,6 +62,7 @@ config QE_TDM =20 config QE_USB bool + depends on QUICC_ENGINE default y if USB_FSL_QE help QE USB Controller support