From nobody Mon Feb 9 06:08:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A16EC77B7C for ; Sun, 21 May 2023 08:36:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230113AbjEUIgK (ORCPT ); Sun, 21 May 2023 04:36:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230046AbjEUI2T (ORCPT ); Sun, 21 May 2023 04:28:19 -0400 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8B11198 for ; Sun, 21 May 2023 01:28:18 -0700 (PDT) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 78E5C3F4B8 for ; Sun, 21 May 2023 08:28:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1684657697; bh=Tv9SP0tP+8DRjLTNt8sd7O2hc074o3ygEuc+rvxGi5M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=B2np6/42mdslIvsIz/AUbtKnejLsEHxvj1UOw6KmBS/Ta48DhDz2j4JvvklOznnLT mPkeOIyWbL4B/QRQfBBsYPkGzkaaG+XgbruvhbESXtjYopzkV56ZxCPPxsAM5f+wiV hxWbuit6wu+iTb0v/Pzmeux2by3trT85gWPFAWVf2OMZrIRmdBWJHrnJeP79aczMBF WI+BtN1iKDvpC7UNpQUik5CH4hMCxKk4Tr7Njr4Ow+WVkCqiKld0aR1tQx2+lalUmv +zNbTSZTYJd3+kMXtG+kEQl9nyGXcRoLZYIzBQ7MNQMgl96ftZjJcvRLqq9S2CQS2z svf3lys3oLPFA== Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-51392d645d5so539515a12.1 for ; Sun, 21 May 2023 01:28:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684657697; x=1687249697; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tv9SP0tP+8DRjLTNt8sd7O2hc074o3ygEuc+rvxGi5M=; b=Bz/OrGpO0o4MVfUKs6oJHS+0bSzAqZtBpqeRjnKPmS4DQmE2YnK5wM2ZeHibI4izoG 1aCdD833hs9NZNYcYXTdgs591dMEupbo0r8TM5prtXJ1HtXIFbeKy3KcASmHa1Nyb3E3 xBM0oCVlL897MbQScIDz15Xfqd+p00VHPMMfDIxnHljj08a9ctXyinjpvXkNyH33GgNU VYfs2pEtfyJ1r9vf2Vq575ukCqdxqiTckJxYBZJx7aUtEg7tHToHR6PerM+9EIV9qT+7 /IUkoS0TiFzrEaslBjX4ggjss4soWCrldpJAFJ/iE/Ey7eV/kBlgeprXZ9tStq432Woo A5ew== X-Gm-Message-State: AC+VfDzbV7tH0m6I9O60H0xAHtp8u5DYQ1mbyOJkVNFfsw/zFMYCnp4X U5X2LR+wUx3o0GzjNHFkkeEUrwJmw+mry7GM6OCYnkH/t/iDWHznquuN6/ee5d2hC9TGfWOvw18 xUv7hpa5OsuRydQ7HSY3sY9eSBAfHbJuzuyieQApgyg== X-Received: by 2002:a17:907:ea8:b0:96f:d63a:9508 with SMTP id ho40-20020a1709070ea800b0096fd63a9508mr408830ejc.33.1684657697001; Sun, 21 May 2023 01:28:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5zjmpQLazlg4eQAFXZI5Rr2SSRNw/GT8/EqlXK/VXX1kP9qh5iIckYIkjPiO0SfPZjdVdQXQ== X-Received: by 2002:a17:907:ea8:b0:96f:d63a:9508 with SMTP id ho40-20020a1709070ea800b0096fd63a9508mr408823ejc.33.1684657696828; Sun, 21 May 2023 01:28:16 -0700 (PDT) Received: from righiandr-XPS-13-7390.homenet.telecomitalia.it (host-87-10-127-160.retail.telecomitalia.it. [87.10.127.160]) by smtp.gmail.com with ESMTPSA id z17-20020aa7cf91000000b004c2158e87e6sm1656646edx.97.2023.05.21.01.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 May 2023 01:28:16 -0700 (PDT) From: Andrea Righi To: Miklos Szeredi Cc: Amir Goldstein , linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/3] ovl: Kconfig: introduce CONFIG_OVERLAY_FS_DEBUG Date: Sun, 21 May 2023 10:28:11 +0200 Message-Id: <20230521082813.17025-2-andrea.righi@canonical.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230521082813.17025-1-andrea.righi@canonical.com> References: <20230521082813.17025-1-andrea.righi@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Provide a Kconfig option to enable extra debugging checks for overlayfs. Reviewed-by: Amir Goldstein Signed-off-by: Andrea Righi --- fs/overlayfs/Kconfig | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/fs/overlayfs/Kconfig b/fs/overlayfs/Kconfig index 6708e54b0e30..fec5020c3495 100644 --- a/fs/overlayfs/Kconfig +++ b/fs/overlayfs/Kconfig @@ -124,3 +124,12 @@ config OVERLAY_FS_METACOPY that doesn't support this feature will have unexpected results. =20 If unsure, say N. + +config OVERLAY_FS_DEBUG + bool "Overlayfs: turn on extra debugging checks" + default n + depends on OVERLAY_FS + help + Say Y here to enable extra debugging checks in overlayfs. + + If unsure, say N. --=20 2.39.2 From nobody Mon Feb 9 06:08:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46B8BC77B7C for ; Sun, 21 May 2023 08:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229956AbjEUIbf (ORCPT ); Sun, 21 May 2023 04:31:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230094AbjEUI2Z (ORCPT ); Sun, 21 May 2023 04:28:25 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85D8518C for ; Sun, 21 May 2023 01:28:23 -0700 (PDT) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 065263F550 for ; Sun, 21 May 2023 08:28:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1684657699; bh=S+LqOkskBby/UL6h7yv8LPihhxKribfOUChuAoSoAt4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=T5Q8t77a/6T9ukRewCiwcuVHks0h4w34yCLyZYn2GTbjfFbBa+7GAjuHlfvQ7LNkR ioDT/8xvNZjQroJPL0Qw+Smnclp1lBMGzTE+xi3EGyGE1+E4DsA7uXvPE++1Qi+3KR kFsNbcQF+TzIFCoOWuIe9BlWgep2UMxVe0HMngl8ncewIR3tua3I/hI4lee9/WZrS2 t7oNq1S5SyyFNpBY/3xx0t7/rlQSpmBrOn+modFjI7IC3RR4D6nXcvwqO+MaZJfZiD W+cA0kaNW5aP31EErn70H3aYIzghm4fqX5dwnEb9qEmqugoM1Zzp94fLSssXV3dH/G 4rL6vYz4Z7HZQ== Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-510d8e4416cso5168596a12.3 for ; Sun, 21 May 2023 01:28:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684657697; x=1687249697; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S+LqOkskBby/UL6h7yv8LPihhxKribfOUChuAoSoAt4=; b=FpagfcgdOdTiPat1Cx/Pg/kGTakrXJUJ8rcqqr/qiTBZd2UyDnC/h3ntmb9J1m8vKi GlUsRqt+VUR3sBFFmRkRVKegn7lDUnofYc5HucPQz4xhLdI6euAB8lwf/8k068S73nci dDTx/T/a10mTxOwnMIkZniFdt7+n/nvduMCQricFJZOxQ1Ty3DX8fOulcBYuv/Lgnxoi oBXR2YbjHXx1a8cSyDQrG/7+fMXnS/6d0s6yRH8WwKu8lWmtcxPKW6anNVn0sJKFHn9Y mwyNfd1nX55AzDKCH9CVTTDBLH9UEOTGgTZGjKTgP/8WrjHFfOXjV898DMtkqTSRrh0S SlbA== X-Gm-Message-State: AC+VfDyapp1AG3Zo1IRrO/roYRbB98IVj29Ue6WklH2YQoNS1C5DusSc MN8aydPowa5PKrMl1vjZWxAhD1Dhzho/h7QMiasMvB5+0fuGCeHUNtzhXGfgcXL+ddr96y8Y8yp IF67Ki8jE0aWmdwZ2m8JCrtMihYJ7Q+Vg8S33apYx2A== X-Received: by 2002:aa7:c387:0:b0:504:a359:3fa8 with SMTP id k7-20020aa7c387000000b00504a3593fa8mr6481256edq.20.1684657697758; Sun, 21 May 2023 01:28:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6jBwj7OJpshwZB8fgrxA+/8LlhWFNLMRKkaj6AcLLMw1TcvK1mWiL2PpIssPSkXCC8sWOXiw== X-Received: by 2002:aa7:c387:0:b0:504:a359:3fa8 with SMTP id k7-20020aa7c387000000b00504a3593fa8mr6481247edq.20.1684657697402; Sun, 21 May 2023 01:28:17 -0700 (PDT) Received: from righiandr-XPS-13-7390.homenet.telecomitalia.it (host-87-10-127-160.retail.telecomitalia.it. [87.10.127.160]) by smtp.gmail.com with ESMTPSA id z17-20020aa7cf91000000b004c2158e87e6sm1656646edx.97.2023.05.21.01.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 May 2023 01:28:17 -0700 (PDT) From: Andrea Righi To: Miklos Szeredi Cc: Amir Goldstein , linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/3] ovl: make consistent use of OVL_FS() Date: Sun, 21 May 2023 10:28:12 +0200 Message-Id: <20230521082813.17025-3-andrea.righi@canonical.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230521082813.17025-1-andrea.righi@canonical.com> References: <20230521082813.17025-1-andrea.righi@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Always use OVL_FS() to retrieve the corresponding struct ovl_fs from a struct super_block. Reviewed-by: Amir Goldstein Signed-off-by: Andrea Righi --- fs/overlayfs/copy_up.c | 2 +- fs/overlayfs/export.c | 10 +++++----- fs/overlayfs/inode.c | 8 ++++---- fs/overlayfs/namei.c | 2 +- fs/overlayfs/ovl_entry.h | 2 ++ fs/overlayfs/super.c | 12 ++++++------ fs/overlayfs/util.c | 18 +++++++++--------- 7 files changed, 28 insertions(+), 26 deletions(-) diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c index f658cc8ea492..60aa615820e7 100644 --- a/fs/overlayfs/copy_up.c +++ b/fs/overlayfs/copy_up.c @@ -905,7 +905,7 @@ static int ovl_do_copy_up(struct ovl_copy_up_ctx *c) static bool ovl_need_meta_copy_up(struct dentry *dentry, umode_t mode, int flags) { - struct ovl_fs *ofs =3D dentry->d_sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(dentry->d_sb); =20 if (!ofs->config.metacopy) return false; diff --git a/fs/overlayfs/export.c b/fs/overlayfs/export.c index defd4e231ad2..f5f0ef8e3ce8 100644 --- a/fs/overlayfs/export.c +++ b/fs/overlayfs/export.c @@ -182,7 +182,7 @@ static int ovl_connect_layer(struct dentry *dentry) */ static int ovl_check_encode_origin(struct dentry *dentry) { - struct ovl_fs *ofs =3D dentry->d_sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(dentry->d_sb); =20 /* Upper file handle for pure upper */ if (!ovl_dentry_lower(dentry)) @@ -434,7 +434,7 @@ static struct dentry *ovl_lookup_real_inode(struct supe= r_block *sb, struct dentry *real, const struct ovl_layer *layer) { - struct ovl_fs *ofs =3D sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(sb); struct dentry *index =3D NULL; struct dentry *this =3D NULL; struct inode *inode; @@ -655,7 +655,7 @@ static struct dentry *ovl_get_dentry(struct super_block= *sb, struct ovl_path *lowerpath, struct dentry *index) { - struct ovl_fs *ofs =3D sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(sb); const struct ovl_layer *layer =3D upper ? &ofs->layers[0] : lowerpath->la= yer; struct dentry *real =3D upper ?: (index ?: lowerpath->dentry); =20 @@ -680,7 +680,7 @@ static struct dentry *ovl_get_dentry(struct super_block= *sb, static struct dentry *ovl_upper_fh_to_d(struct super_block *sb, struct ovl_fh *fh) { - struct ovl_fs *ofs =3D sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(sb); struct dentry *dentry; struct dentry *upper; =20 @@ -700,7 +700,7 @@ static struct dentry *ovl_upper_fh_to_d(struct super_bl= ock *sb, static struct dentry *ovl_lower_fh_to_d(struct super_block *sb, struct ovl_fh *fh) { - struct ovl_fs *ofs =3D sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(sb); struct ovl_path origin =3D { }; struct ovl_path *stack =3D &origin; struct dentry *dentry =3D NULL; diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c index 541cf3717fc2..c27823f6e7aa 100644 --- a/fs/overlayfs/inode.c +++ b/fs/overlayfs/inode.c @@ -334,7 +334,7 @@ static const char *ovl_get_link(struct dentry *dentry, =20 bool ovl_is_private_xattr(struct super_block *sb, const char *name) { - struct ovl_fs *ofs =3D sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(sb); =20 if (ofs->config.userxattr) return strncmp(name, OVL_XATTR_USER_PREFIX, @@ -689,7 +689,7 @@ int ovl_set_acl(struct mnt_idmap *idmap, struct dentry = *dentry, int ovl_update_time(struct inode *inode, struct timespec64 *ts, int flags) { if (flags & S_ATIME) { - struct ovl_fs *ofs =3D inode->i_sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(inode->i_sb); struct path upperpath =3D { .mnt =3D ovl_upper_mnt(ofs), .dentry =3D ovl_upperdentry_dereference(OVL_I(inode)), @@ -952,7 +952,7 @@ static inline void ovl_lockdep_annotate_inode_mutex_key= (struct inode *inode) =20 static void ovl_next_ino(struct inode *inode) { - struct ovl_fs *ofs =3D inode->i_sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(inode->i_sb); =20 inode->i_ino =3D atomic_long_inc_return(&ofs->last_ino); if (unlikely(!inode->i_ino)) @@ -1284,7 +1284,7 @@ struct inode *ovl_get_trap_inode(struct super_block *= sb, struct dentry *dir) static bool ovl_hash_bylower(struct super_block *sb, struct dentry *upper, struct dentry *lower, bool index) { - struct ovl_fs *ofs =3D sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(sb); =20 /* No, if pure upper */ if (!lower) diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c index cfb3420b7df0..d0f196b85541 100644 --- a/fs/overlayfs/namei.c +++ b/fs/overlayfs/namei.c @@ -832,7 +832,7 @@ struct dentry *ovl_lookup(struct inode *dir, struct den= try *dentry, { struct ovl_entry *oe; const struct cred *old_cred; - struct ovl_fs *ofs =3D dentry->d_sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(dentry->d_sb); struct ovl_entry *poe =3D dentry->d_parent->d_fsdata; struct ovl_entry *roe =3D dentry->d_sb->s_root->d_fsdata; struct ovl_path *stack =3D NULL, *origin_path =3D NULL; diff --git a/fs/overlayfs/ovl_entry.h b/fs/overlayfs/ovl_entry.h index fd11fe6d6d45..b32c38fdf3c7 100644 --- a/fs/overlayfs/ovl_entry.h +++ b/fs/overlayfs/ovl_entry.h @@ -95,6 +95,8 @@ static inline struct mnt_idmap *ovl_upper_mnt_idmap(struc= t ovl_fs *ofs) return mnt_idmap(ovl_upper_mnt(ofs)); } =20 +extern struct file_system_type ovl_fs_type; + static inline struct ovl_fs *OVL_FS(struct super_block *sb) { return (struct ovl_fs *)sb->s_fs_info; diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c index f97ad8b40dbb..2ed0f498fce4 100644 --- a/fs/overlayfs/super.c +++ b/fs/overlayfs/super.c @@ -259,7 +259,7 @@ static void ovl_free_fs(struct ovl_fs *ofs) =20 static void ovl_put_super(struct super_block *sb) { - struct ovl_fs *ofs =3D sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(sb); =20 ovl_free_fs(ofs); } @@ -267,7 +267,7 @@ static void ovl_put_super(struct super_block *sb) /* Sync real dirty inodes in upper filesystem (if it exists) */ static int ovl_sync_fs(struct super_block *sb, int wait) { - struct ovl_fs *ofs =3D sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(sb); struct super_block *upper_sb; int ret; =20 @@ -315,7 +315,7 @@ static int ovl_sync_fs(struct super_block *sb, int wait) */ static int ovl_statfs(struct dentry *dentry, struct kstatfs *buf) { - struct ovl_fs *ofs =3D dentry->d_sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(dentry->d_sb); struct dentry *root_dentry =3D dentry->d_sb->s_root; struct path path; int err; @@ -364,7 +364,7 @@ static inline int ovl_xino_def(void) static int ovl_show_options(struct seq_file *m, struct dentry *dentry) { struct super_block *sb =3D dentry->d_sb; - struct ovl_fs *ofs =3D sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(sb); =20 seq_show_option(m, "lowerdir", ofs->config.lowerdir); if (ofs->config.upperdir) { @@ -396,7 +396,7 @@ static int ovl_show_options(struct seq_file *m, struct = dentry *dentry) =20 static int ovl_remount(struct super_block *sb, int *flags, char *data) { - struct ovl_fs *ofs =3D sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(sb); struct super_block *upper_sb; int ret =3D 0; =20 @@ -2083,7 +2083,7 @@ static struct dentry *ovl_mount(struct file_system_ty= pe *fs_type, int flags, return mount_nodev(fs_type, flags, raw_data, ovl_fill_super); } =20 -static struct file_system_type ovl_fs_type =3D { +struct file_system_type ovl_fs_type =3D { .owner =3D THIS_MODULE, .name =3D "overlay", .fs_flags =3D FS_USERNS_MOUNT, diff --git a/fs/overlayfs/util.c b/fs/overlayfs/util.c index 923d66d131c1..2425240ef139 100644 --- a/fs/overlayfs/util.c +++ b/fs/overlayfs/util.c @@ -18,25 +18,25 @@ =20 int ovl_want_write(struct dentry *dentry) { - struct ovl_fs *ofs =3D dentry->d_sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(dentry->d_sb); return mnt_want_write(ovl_upper_mnt(ofs)); } =20 void ovl_drop_write(struct dentry *dentry) { - struct ovl_fs *ofs =3D dentry->d_sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(dentry->d_sb); mnt_drop_write(ovl_upper_mnt(ofs)); } =20 struct dentry *ovl_workdir(struct dentry *dentry) { - struct ovl_fs *ofs =3D dentry->d_sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(dentry->d_sb); return ofs->workdir; } =20 const struct cred *ovl_override_creds(struct super_block *sb) { - struct ovl_fs *ofs =3D sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(sb); =20 return override_creds(ofs->creator_cred); } @@ -62,7 +62,7 @@ int ovl_can_decode_fh(struct super_block *sb) =20 struct dentry *ovl_indexdir(struct super_block *sb) { - struct ovl_fs *ofs =3D sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(sb); =20 return ofs->indexdir; } @@ -70,7 +70,7 @@ struct dentry *ovl_indexdir(struct super_block *sb) /* Index all files on copy up. For now only enabled for NFS export */ bool ovl_index_all(struct super_block *sb) { - struct ovl_fs *ofs =3D sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(sb); =20 return ofs->config.nfs_export && ofs->config.index; } @@ -78,7 +78,7 @@ bool ovl_index_all(struct super_block *sb) /* Verify lower origin on lookup. For now only enabled for NFS export */ bool ovl_verify_lower(struct super_block *sb) { - struct ovl_fs *ofs =3D sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(sb); =20 return ofs->config.nfs_export && ofs->config.index; } @@ -152,7 +152,7 @@ enum ovl_path_type ovl_path_type(struct dentry *dentry) =20 void ovl_path_upper(struct dentry *dentry, struct path *path) { - struct ovl_fs *ofs =3D dentry->d_sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(dentry->d_sb); =20 path->mnt =3D ovl_upper_mnt(ofs); path->dentry =3D ovl_dentry_upper(dentry); @@ -415,7 +415,7 @@ bool ovl_dentry_needs_data_copy_up(struct dentry *dentr= y, int flags) =20 bool ovl_redirect_dir(struct super_block *sb) { - struct ovl_fs *ofs =3D sb->s_fs_info; + struct ovl_fs *ofs =3D OVL_FS(sb); =20 return ofs->config.redirect_dir && !ofs->noxattr; } --=20 2.39.2 From nobody Mon Feb 9 06:08:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 214CFC7EE2D for ; Sun, 21 May 2023 08:31:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229862AbjEUIbb (ORCPT ); Sun, 21 May 2023 04:31:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230064AbjEUI2W (ORCPT ); Sun, 21 May 2023 04:28:22 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7EA8ED for ; Sun, 21 May 2023 01:28:21 -0700 (PDT) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 888BF3F4F7 for ; Sun, 21 May 2023 08:28:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1684657698; bh=JDxwondAh/OUHugni3ivKWRUI1pwMRnCsBuB/co2xpE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=TgERYlQJWvrZw7gHn3ucr5v6Nsd0NPB6uVbqs6k+qlDRmOiBwA+YCgNvgKKN2htlj Lglx3xdXLUG+JjpvwJOL2XDX88f4LQc6C12su5kUVlO8wIOkprSj39FAH1dCBu1HJS BFD+gl1ECGerPKif+P5j6wuIlTgkCsR0R8j4T+8kDxuVs3KUuF4FpMPLnehtEcRWk4 yWHy+ZV02QDXg1le5Gulw5oES5qrEbkHF8kNaxHyRKbpb65rSsQCOH4FjYe7G2fvZC LDotCl7ELbaD99OHxLBepkHJmAq1952gy9yymZNgPUMNJtofHVujJCu/Dy6u2NAbLU KQ3EZBc0ExEZQ== Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-510b714821fso3139021a12.1 for ; Sun, 21 May 2023 01:28:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684657698; x=1687249698; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JDxwondAh/OUHugni3ivKWRUI1pwMRnCsBuB/co2xpE=; b=JadZMG4DvCfDwoJQFoTGOVrR/35faz6whgBul6CeP2erxJhd1Wsn0VPzKPNbrU3LY1 MJCDdU/wu5xcQ/DKajqdagMezILqPaHYrYAmc1KLbocBj2SfBS38vlvNyrMc7dyu1aE7 g8v5Zk85oyQuPamgxte/Fneg3xuCh8Q3/9yRoXQNg6HgXtUYPm2VkjYt5pS4FoOlZd/q ouDjoR3XcSWq+sN6Liha8pRINGXLZ8y3BW8ZZSMWRifoHxk0alcHNddo1TbmuPHU1QOM k93ywdY83CdIrhOZX/Si+vUPJLaHA7N6KpTSrnqYIdcLmof/MTcHeosykQpQ19s6Oum6 0aUg== X-Gm-Message-State: AC+VfDyeWbfAOo/Rsr5BgJBrjakxTptXb2hveb/qDX72lQNuYrCn0jaY L+rp8hiN2kOwcCJEI+vNYzHFP/g5epmZWJpNhgoCZPxSZyeX3hkGwi8XQbwamW5YJnkrpJe7PMm fgrj3xS/zACFFxQgCWnZsRznP9PR6TAVkIjglD4QAZQ== X-Received: by 2002:a50:ed09:0:b0:50c:161b:9154 with SMTP id j9-20020a50ed09000000b0050c161b9154mr6988440eds.11.1684657698395; Sun, 21 May 2023 01:28:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ZOrhcJoW7hdR/JwsluZvVPpD3I9c6Xd7IgooNQQzahawcWHebG+MovffeT+18V5hGxmKYpQ== X-Received: by 2002:a50:ed09:0:b0:50c:161b:9154 with SMTP id j9-20020a50ed09000000b0050c161b9154mr6988428eds.11.1684657698143; Sun, 21 May 2023 01:28:18 -0700 (PDT) Received: from righiandr-XPS-13-7390.homenet.telecomitalia.it (host-87-10-127-160.retail.telecomitalia.it. [87.10.127.160]) by smtp.gmail.com with ESMTPSA id z17-20020aa7cf91000000b004c2158e87e6sm1656646edx.97.2023.05.21.01.28.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 May 2023 01:28:17 -0700 (PDT) From: Andrea Righi To: Miklos Szeredi Cc: Amir Goldstein , linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/3] ovl: validate superblock in OVL_FS() Date: Sun, 21 May 2023 10:28:13 +0200 Message-Id: <20230521082813.17025-4-andrea.righi@canonical.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230521082813.17025-1-andrea.righi@canonical.com> References: <20230521082813.17025-1-andrea.righi@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" When CONFIG_OVERLAY_FS_DEBUG is enabled add an explicit check to make sure that OVL_FS() is always used with a valid overlayfs superblock. Otherwise trigger a WARN_ON_ONCE(). Reviewed-by: Amir Goldstein Signed-off-by: Andrea Righi --- fs/overlayfs/ovl_entry.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/fs/overlayfs/ovl_entry.h b/fs/overlayfs/ovl_entry.h index b32c38fdf3c7..e156649d9c71 100644 --- a/fs/overlayfs/ovl_entry.h +++ b/fs/overlayfs/ovl_entry.h @@ -97,8 +97,20 @@ static inline struct mnt_idmap *ovl_upper_mnt_idmap(stru= ct ovl_fs *ofs) =20 extern struct file_system_type ovl_fs_type; =20 +static inline bool is_ovl_fs_sb(struct super_block *sb) +{ + return sb->s_type =3D=3D &ovl_fs_type; +} + +#ifdef CONFIG_OVERLAY_FS_DEBUG +#define OVL_VALIDATE_SB(__sb) WARN_ON_ONCE(!is_ovl_fs_sb(__sb)) +#else +#define OVL_VALIDATE_SB(__sb) +#endif + static inline struct ovl_fs *OVL_FS(struct super_block *sb) { + OVL_VALIDATE_SB(sb); return (struct ovl_fs *)sb->s_fs_info; } =20 --=20 2.39.2